Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Sune Vuorela

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 1:26 p.m.) Review request for Build System, KDE

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84233 --- Ship it! Ship It! - Hanspeter Niederstrasser On Aug. 23,

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
On Aug. 23, 2015, 1:36 p.m., Hanspeter Niederstrasser wrote: Ship It! Oops. My pressing Ship it doesn't actually commit. Someone with write access will have to push upstream. Thanks. - Hanspeter --- This is an automatically

Re: QIcon::fromTheme(xxx, someFallback)

2015-08-23 Thread David Faure
On Sunday 23 August 2015 10:30:13 Olivier Goffart wrote: On Friday 21. August 2015 22:30:37 David Faure wrote: I would also approve a change to Qt to add an overload of QIcon::fromTheme with only one argument without a fallback. (this would be binary compatible, and source compatible

Re: Review Request 120443: Add ctags configuration option to highlighting

2015-08-23 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120443/#review84212 --- Hi Bastian, are you still working on this? As it stands, the

Review Request 124887: Also propagate window titles for folder-only file dialogs.

2015-08-23 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124887/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84220 --- +1 seems to make sense but it's not really my area, wait a

Re: QIcon::fromTheme(xxx, someFallback)

2015-08-23 Thread Olivier Goffart
On Friday 21. August 2015 22:30:37 David Faure wrote: I would also approve a change to Qt to add an overload of QIcon::fromTheme with only one argument without a fallback. (this would be binary compatible, and source compatible unless someone took the address of QIcon::fromTheme) I

Re: Review Request 124315: Change keyboard shortcut to avoid conflict with next tab

2015-08-23 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124315/#review84210 --- Ship it! I think this patch makes sense. And Ctrl+e is

Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84222 --- +1 from me also, but could you add Harald Sitter to the

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-23 Thread Thomas Lübking
On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote: bump, we should get this fixed for 5.4 Shui, do you want to work on improving the patch and adding the testcase? Thomas Lübking wrote: -100 THE PATCH BREAKS BACKTABBING!! Btw. entirely not figured by autotests

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 9:16 p.m.) Status -- This change has been