kpackage: reasons not to use ecm_mark_nongui_executable?

2015-11-10 Thread René J . V . Bertin
Hi, I've just made the MacPorts packaging for the Package framework, and noticed that both the kpackagetool and the autotests are not defined "ecm_mark_nongui_executable". That means they're build as app bundles on OS X, which is counterproductive (and causes "make test" to fail). Is there a

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-10 Thread Martin Klapetek
> On Nov. 9, 2015, 11:18 p.m., Nick Shaforostoff wrote: > > src/declarativeimports/calendar/eventpluginsmanager.cpp, line 79 > > > > > > in order to reduce malloc/free call count (and the data() method is > >

Re: Review Request 125936: Update KProtocolManager after configuration change.

2015-11-10 Thread Andreas Cord-Landwehr
> On Nov. 6, 2015, 8:02 vorm., David Faure wrote: > > src/kcms/kio/cache.cpp, line 91 > > > > > > Isn't this done by the call to updateRunningIOSlaves just below, which > > sends the DBus signal

Re: kpackage: reasons not to use ecm_mark_nongui_executable?

2015-11-10 Thread Alex Merry
On 2015-11-10 17:39, René J.V. Bertin wrote: Hi, I've just made the MacPorts packaging for the Package framework, and noticed that both the kpackagetool and the autotests are not defined "ecm_mark_nongui_executable". That means they're build as app bundles on OS X, which is counterproductive

Review Request 126017: Provide debug output by default.

2015-11-10 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126017/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

2015-11-10 Thread Albert Astals Cid
El Tuesday 10 November 2015, a les 19:57:50, Ben Cooksley va escriure: > On Mon, Nov 9, 2015 at 8:30 PM, David Faure wrote: > > On Monday 09 November 2015 19:36:09 Ben Cooksley wrote: > >> On Mon, Nov 9, 2015 at 10:26 AM, Albert Astals Cid wrote: > >> > El Saturday

Re: kpackage: reasons not to use ecm_mark_nongui_executable?

2015-11-10 Thread René J . V . Bertin
Alex Merry wrote: > I would expect that they should be nongui. We've realised that there are > some cases where we want to be marked GUI on windows and not on OS X, > but I doubt that's the case for KPackage. Do you know if applications marked non-gui initialise the windowserver connection on

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

2015-11-10 Thread Albert Astals Cid
El Monday 09 November 2015, a les 08:30:14, David Faure va escriure: > On Monday 09 November 2015 19:36:09 Ben Cooksley wrote: > > On Mon, Nov 9, 2015 at 10:26 AM, Albert Astals Cid wrote: > > > El Saturday 07 November 2015, a les 10:36:18, David Faure va escriure: > > >> On

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 127 - Still Unstable!

2015-11-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/127/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Nov 2015 09:08:54 + Build duration: 2 min 40 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 128 - Still Unstable!

2015-11-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/128/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Nov 2015 09:24:59 + Build duration: 2 min 48 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 130 - Fixed!

2015-11-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Nov 2015 10:03:25 + Build duration: 6 min 59 sec CHANGE SET Revision

KService autotests and tests on OS X

2015-11-10 Thread René J . V . Bertin
Hi, Are the autotests and tests of the KService framework supposed to run on OS X? I tried them, and 1) most simply hang after printing an error about a missing application menu (I no longer have the exact message) 2) I discovered, some time after having attempted to run these, that a large

Re: kpackage: reasons not to use ecm_mark_nongui_executable?

2015-11-10 Thread Aleix Pol
On Wed, Nov 11, 2015 at 12:35 AM, René J. V. wrote: > Alex Merry wrote: > > >> I would expect that they should be nongui. We've realised that there are >> some cases where we want to be marked GUI on windows and not on OS X, >> but I doubt that's the case for KPackage. > > Do

Re: Review Request 119011: KInit: call setgroups(0, 0) before calling setgid()

2015-11-10 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119011/#review88231 --- This broke the ability of users to have more than one group