Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Wednesday 16 December 2015 17:42:29 šumski wrote: > On Wednesday 16 of December 2015 09:08:03 David Faure wrote: > > Fixed, it was an oversight when converting the lib into a KF5 framework. > > But this is a BiC change... One that is generally allowed (not like removing a virtual method and

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89750 --- Hey, when my patch will be reviewed? - Artur Puzio On Gru

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/ --- (Updated Dec. 19, 2015, 4:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote: > > In general I don't like commented code. Why keep it? > > David, do you think we should keep it? > > > > Artur, have you made sure the tests still pass? It doesn't say so in the > > testing field. > > Artur Puzio wrote: >

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote: > > In general I don't like commented code. Why keep it? > > David, do you think we should keep it? > > > > Artur, have you made sure the tests still pass? It doesn't say so in the > > testing field. Sorry I have forgotten to

Review Request 126423: KPluginSelector::addPlugins: do not assert if 'config' parameter is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126423/ --- Review request for KDE Frameworks. Bugs: 352471

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > I really think this should be handled/mapped > > by the OS X native systray thing. But I guess > >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:07 p.m., Martin Klapetek wrote: > > > is it to be expected (in kstatusnotifieritemtest.cpp) that > > > tray->iconPixmap() returns a null QIcon immediately after calling > > > tray->setIconByName() > > > > I believe so, it's "either-or", either you set the icon by name

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/#review89737 --- src/kdeui/kpushbutton.cpp (line 256)

Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 19, 2015, 10:56 a.m.) Review request for KDE Software on

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: [Kde-pim] kdesrc-build setup for kdepim

În ziua de Sunday 13 December 2015, la 12:55:54, Daniel Vrátil a scris: > On Saturday, December 12, 2015 11:00:39 PM CET Alex Merry wrote: > > The recent splitting of kdepimlibs has caused a clean run of > > kdesrc-build to fail on lots of pim modules. This seems to be a > > combination of