Re: Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93147 --- +1 makes sense. - Aleix Pol Gonzalez On March 3, 2016,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 291 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 04 Mar 2016 01:18:13 + Build duration: 2 min 19 sec CHANGE SET

Re: Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/ --- (Updated March 4, 2016, 12:21 a.m.) Status -- This change has been

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/ --- (Updated March 4, 2016, 12:21 a.m.) Status -- This change has been

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- (Updated March 4, 2016, 12:20 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 298 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/298/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 04 Mar 2016 01:24:37 + Build duration: 2 min 30 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 297 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/297/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 04 Mar 2016 00:20:36 + Build duration: 2 min 30 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 297 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/297/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 04 Mar 2016 00:20:36 + Build duration: 2 min 30 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 291 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 04 Mar 2016 01:18:13 + Build duration: 3 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 298 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/298/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 04 Mar 2016 01:24:37 + Build duration: 3 min 2 sec CHANGE

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127261: Fix dead lock when program use kauth exits.

> On March 3, 2016, 7:05 a.m., Martin Gräßlin wrote: > > nice work! I had run into it in the past and didn't succeed investigating > > it. https://bugreports.qt.io/browse/QTBUG-51648 As pointed out by Thiago on irc, this should be considered as a bug in Qt. Not sure if we want to commit it.

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127261: Fix dead lock when program use kauth exits.

> On March 3, 2016, 8:05 a.m., Martin Gräßlin wrote: > > nice work! I had run into it in the past and didn't succeed investigating > > it. > > Xuetian Weng wrote: > https://bugreports.qt.io/browse/QTBUG-51648 > > As pointed out by Thiago on irc, this should be considered as a bug

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 3, 2016, 11:26 след обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 425 > > > > > > I assume this is the dealbreaker for the failing apps. > > This entire "restore position"

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93143 --- src/kstatusnotifieritem.cpp (line 933)

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93084 --- Fix it, then Ship it! src/ioslaves/http/http.cpp (line

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/ --- (Updated March 3, 2016, 12:16 p.m.) Review request for KDE Frameworks.

Review Request 127267: [KPeople] Set a name for the database connection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127267/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople

Re: Review Request 127265: Fix windows build of Ki18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/#review93104 --- src/kcatalog.cpp (line 150)

Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 127267: [KPeople] Set a name for the database connection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127267/#review93105 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 3,

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated March 3, 2016, 12:40 p.m.) Review request for KDE Frameworks

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/ --- (Updated March 3, 2016, 1:28 p.m.) Status -- This change has been

Review Request 127265: Fix windows build of Ki18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/ --- Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs.

Review Request 127266: Fix build with MinGW on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127266/ --- Review request for KDE Frameworks and kdewin. Repository: khtml

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93120 --- src/ioslaves/http/http.cpp (line 5442)

Re: Review Request 127265: Fix windows build of Ki18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/ --- (Updated March 3, 2016, 5:49 p.m.) Review request for KDE Frameworks,

Re: Review Request 127265: Fix windows build of Ki18n

> On March 3, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 150 > > > > > > Wouldn't it be the same to define it like this? > > ``` > > #if defined(__USE_GNU_GETTEXT) > >

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93117 --- Fix it, then Ship it!

Re: Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/#review93118 --- Ship it! Ship It! - Marco Martin On March 3, 2016,

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

> On March 3, 2016, 6:32 p.m., Aleix Pol Gonzalez wrote: > > Is it being tested from QtQuick as well? Internally this is using QtQuick. - David --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- (Updated March 3, 2016, 6:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 127265: Fix windows build of Ki18n

> On März 3, 2016, 4:51 nachm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 150 > > > > > > Wouldn't it be the same to define it like this? > > ``` > > #if defined(__USE_GNU_GETTEXT) > >

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93111 --- src/declarativeimports/core/iconitem.h (line 42)

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93110 --- src/declarativeimports/core/iconitem.h (line 69)

Re: Review Request 127268: Docs for IconItem

> On March 3, 2016, 6:06 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/core/iconitem.h, line 42 > > > > > > Needs to start with `/**` for doxygen to pick up. thanks. Weirdly it seems my subconcious

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93113 --- src/declarativeimports/core/iconitem.h (line 48)

Re: Review Request 127268: Docs for IconItem

> On March 3, 2016, 6:08 p.m., David Rosca wrote: > > src/declarativeimports/core/iconitem.h, line 69 > > > > > > There is no animation on resize. Oh, it seems so. I'm sure it used to so that it didn't do a big

Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/#review93116 --- Ship it! Is it being tested from QtQuick as well? -

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On March 3, 2016, 8:43 p.m., Andreas Hartmetz wrote: > > > > Andreas Hartmetz wrote: > OK, this looks good now overall. The comment about the indexOf() is of > course about the whole truncating at space thing, not the particular line. The idea of this line and the conditional behind it

Re: Review Request 127265: Fix windows build of Ki18n

> On March 3, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 150 > > > > > > Wouldn't it be the same to define it like this? > > ``` > > #if defined(__USE_GNU_GETTEXT) > >

Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93126 --- Looks good, +1 - Martin Klapetek On March 3, 2016, 9:34

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93128 --- Ping - Anthony Fieroni On Фев. 29, 2016, 7:18 преди обяд,

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On March 3, 2016, 7:43 p.m., Andreas Hartmetz wrote: > > > > Andreas Hartmetz wrote: > OK, this looks good now overall. The comment about the indexOf() is of > course about the whole truncating at space thing, not the particular line. > > Krzysztof Nowicki wrote: > The idea of this

Re: Review Request 127240: [Applet] Don't crash on remove panel

> On March 3, 2016, 8:56 p.m., Anthony Fieroni wrote: > > Ping. Don't want it? well, it doesn't compile, which means you haven't tested it. I'm not merging something completely untested. - David --- This is an automatically generated

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated March 3, 2016, 10:01 p.m.) Review request for KDE Frameworks

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Feb. 29, 2016, 7:59 p.m., Martin Klapetek wrote: > > This works in 50% of cases for me. I'm not sure if Quassel and Konversation > > are doing something special wrt to restoring position but this doesn't fix > > it. > > Anthony Fieroni wrote: > Can you show simple video? Placement

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 8:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made above.

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made above.

Re: Review Request 127240: [Applet] Don't crash on remove panel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127240/ --- (Updated Март 3, 2016, 11:52 след обяд) Review request for KDE

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. Ah, interestingly I've never received the replies you made above. Must have ended in some @kde.org

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping Does not work for Quassel and Konversation, I'd like to know why before I approve your patch. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 3, 2016, 10:57 след обяд, Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made