Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-26 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated March 26, 2016, 12:31 p.m.) Review request for KDE Frameworks,

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review94011 --- Ship it! Looks good to me, although this could all be a

Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127497/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2016-03-26 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated March 26, 2016, 2:45 p.m.) Status -- This change has been

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127497/#review94022 --- This issue was just fixed by Kare, see kwrite-devel mailing

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Anthony Fieroni
> On Март 26, 2016, 2:55 след обяд, Dominik Haumann wrote: > > This issue was just fixed by Kare, see kwrite-devel mailing list and commit > > https://quickgit.kde.org/?p=ktexteditor.git=commit=f7f330b21aa394a62ac95ea9bee075f372ff6d9c > > > > A bug was introduced in clazy commits,

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127497/ --- (Updated Март 26, 2016, 3:19 след обяд) Status -- This change has

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Dominik Haumann
> On March 26, 2016, 12:55 p.m., Dominik Haumann wrote: > > This issue was just fixed by Kare, see kwrite-devel mailing list and commit > > https://quickgit.kde.org/?p=ktexteditor.git=commit=f7f330b21aa394a62ac95ea9bee075f372ff6d9c > > > > A bug was introduced in clazy commits, unfortunately,

Re: Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

2016-03-26 Thread Anthony Fieroni
> On Март 26, 2016, 2:55 след обяд, Dominik Haumann wrote: > > This issue was just fixed by Kare, see kwrite-devel mailing list and commit > > https://quickgit.kde.org/?p=ktexteditor.git=commit=f7f330b21aa394a62ac95ea9bee075f372ff6d9c > > > > A bug was introduced in clazy commits,

Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127501/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-26 Thread R.Harish Navnit
> On March 26, 2016, 3:23 p.m., David Faure wrote: > > Looks good to me, although this could all be a single perl script instead > > of a bash script calling perl so many times ;) But that's unrelated to this > > commit. > > > > Also in its current form, it should be a .sh rather than a .pl

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-26 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127501/#review94033 --- Ow. That's a pretty bad problem. I suggest a less intrusive