Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94948 --- could you also have a look at it with heaptrack? it should

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94956 --- Nice! > can i use karchive in this framework? KIconThemes

Re: Review Request 127770: Increase maximum string length in KSycoca database

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127770/#review94946 --- src/sycoca/ksycocautils.cpp (line 29)

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 11:52 a.m.) Review request for KDE Frameworks

Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- Review request for KDE Frameworks and Plasma. Repository: kiconthemes

Re: Review Request 127765: RFC: Cache global config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127765/#review94947 --- just minor style review, I think that this is cool but needs

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 11:53 a.m.) Review request for KDE Frameworks

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94957 --- src/kiconloader.cpp (lines 843 - 845)

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 2:39 p.m.) Review request for KDE Frameworks

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 2:01 p.m., Kai Uwe Broulik wrote: > > src/kiconloader.cpp, line 67 > > > > > > global statics in library are bad Or use Q_GLOBAL_STATIC - Aleix

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 825 > > > > > > maybe return contents? > > Marco Martin wrote: > contents of what? `return contents;` > On April

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 12:19 p.m., Emmanuel Pescosta wrote: > > src/kiconloader.cpp, lines 843-845 > > > > > > Missing in the SVG path. > > > > IMHO it would be nicer if you put the SVG stuff into a new

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94964 --- I like the idea, but I think it needs polishing still. Some

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. I have to get back to the first version of the patch with

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94961 --- +1 on the idea and rest of the code, just a minor nitpick

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > I like the idea, but I think it needs polishing still. > > > > Some kind of assessment about the performance impact would be very > > appreciated. Also could we get a test? It's an important feature... What impact will it have

Re: Review Request 127763: Reduce memory usage footprint

> On April 28, 2016, 11:22 a.m., Milian Wolff wrote: > > could you also have a look at it with heaptrack? it should instantly give > > you a total number of allocations after finish, which should already give > > us an indication whether this brings lots to the table. Your callgrind > >

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 12:58 p.m.) Review request for KDE Frameworks

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 12:59 p.m.) Review request for KDE Frameworks

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 2:38 p.m.) Review request for KDE Frameworks

Re: Review Request 127763: Reduce memory usage footprint

> On April 28, 2016, 9:22 a.m., Milian Wolff wrote: > > could you also have a look at it with heaptrack? it should instantly give > > you a total number of allocations after finish, which should already give > > us an indication whether this brings lots to the table. Your callgrind > >

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first

Re: solving 'KSycoca database corruption!'

On Thu, Apr 28, 2016 at 10:01 AM, Jos van den Oever wrote: > Hi all, Hi Jos, > > A few days back dvratil reported errors in the KDE PIM unit tests. The tests > were writing > > QWARN : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca > database

Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127784/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Re: Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated April 28, 2016, 10:43 p.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 20:49:08 + Build duration: 21 min CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127784/#review94998 --- Ship it! Ship It! - Chusslove Illich On Април 28,

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get > > a tick at *every* cell... Oops, I'll fix, thanks. - Martin --- This is an automatically

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94997 --- Ship it! Ship It! - Albert Astals Cid On April 28,

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 40 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 15:40:38 + Build duration: 6 min 7 sec CHANGE SET Revision 4a94cb0b6f76025b3d8cde92e7d0a26852842abf

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 44 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 15:47:59 + Build duration: 1 min 22 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127774: Load protocol info as a simple config.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127774/#review94978 --- Ship it! Ship It! - Milian Wolff On April 27, 2016,

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 40 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 15:54:24 + Build duration: 18 min CHANGE SET No changes

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:25 p.m.) Review request for KDE Frameworks

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:05 p.m.) Review request for KDE Frameworks

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:56 p.m.) Review request for KDE Frameworks

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 17:55:12 + Build duration: 4 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 17:55:12 + Build duration: 4 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127784/ --- (Updated April 28, 2016, 10:53 p.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 18 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 22:56:14 + Build duration: 4 min 58 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127763: Reduce memory usage footprint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/ --- (Updated April 28, 2016, 10:50 p.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 22:56:24 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94987 --- You broke the zoomed out view, ie. in the year/decade

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

> On April 28, 2016, 8:02 a.m., Olivier Churlaud wrote: > > Any other feedback? What should I do? I suppose I need to find the time to test this out on the actual api.kde.org machine. can I run it on the old KDE4 kdelibs KDE/4.14 branch? - Allen

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95002 --- I think I disagree with the idea of overwriting KAboutData

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review94943 --- Any other feedback? What should I do? - Olivier Churlaud

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

> On April 28, 2016, 10:02 a.m., Olivier Churlaud wrote: > > Any other feedback? What should I do? > > Allen Winter wrote: > I suppose I need to find the time to test this out on the actual > api.kde.org machine. can I run it on the old KDE4 kdelibs KDE/4.14 branch? Sadly enough it won't