Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

2016-06-25 Thread Pino Toscano
> On May 23, 2016, 11:20 a.m., David Faure wrote: > > Please note that: > > * the Q_BYTE_ORDER change was reverted, since it made the wallet storage > > incompatible with previous releases. This needs further analysis in order > > to improve the code while retaining compat. > > * kwallet is

Re: Review Request 128238: Add KNewPasswordWidget

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128238/#review96852 --- Ping? - Elvis Angelaccio On June 18, 2016, 5:18 p.m.,

Re: Review Request 128254: Update knewpasswordwidgtet test app

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128254/ --- (Updated June 25, 2016, 9:32 a.m.) Status -- This change has been

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96850 --- Cool, thanks Andreas! - Kevin Funk On June 24, 2016, 8:17

Re: Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128023/#review96851 --- Ping? - Elvis Angelaccio On May 26, 2016, 11:35 a.m.,

Re: Review Request 128191: Let KCapacityBar be usable in Qt Designer

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128191/ --- (Updated June 25, 2016, 9:10 a.m.) Status -- This change has been

Re: Adding Python bindings for some frameworks in the next release

2016-06-25 Thread David Faure
On dimanche 19 juin 2016 21:29:37 CEST Stephen Kelly wrote: > Hi, > > I would like to add the python bindings previously discussed to the next > release of KF5. This means adding the four most recent commits from > > https://github.com/steveire/extra-cmake-modules/commits/python-bindings > >

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

2016-06-25 Thread David Faure
> On May 18, 2016, 2:16 p.m., Martin Klapetek wrote: > > A better approach I think would be to have a simple checkbox, store > > that in a config and then have KNotification/NotifyByAudio simply > > do nothing if that config/value is present. > > > > Or even have

Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- Review request for KDE Frameworks, KDE Usability and David Faure.

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96859 --- Nice feature, but please only start the calculation when

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96862 --- First of all: I love the feature as such, as it makes the

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Elvis Angelaccio
> On June 25, 2016, 11:35 a.m., Christoph Feck wrote: > > I wished it was for the KIO overwrite dialog ;) > > > > Anyway, reading the file three times without the user asking for the > > checksums is a recipe for disk cache draining. > > > > I suggest to compute all checksums in parallel,

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96858 --- I wished it was for the KIO overwrite dialog ;) Anyway,

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Elvis Angelaccio
> On June 25, 2016, 12:52 p.m., Thomas Pfeiffer wrote: > > First of all: I love the feature as such, as it makes the whole checksum > > comparison story actually usable for average users (although they'd still > > have to be told how to do it because they'd probably not get the idea that > >

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 25, 2016, 2:52 p.m.) Review request for KDE Frameworks,