Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

2016-08-25 Thread Heiko Tietze
> On Aug. 25, 2016, 1:59 a.m., Christoph Feck wrote: > > Ping? Can someone please review? It already missed the tr deadline for > > 5.26, but maybe we can get this into 5.27. As far as I understand the change it will show tofu'ed characters in their intended appearance (the example is

Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

2016-08-25 Thread Christoph Feck
> On Aug. 25, 2016, 1:59 a.m., Christoph Feck wrote: > > Ping? Can someone please review? It already missed the tr deadline for > > 5.26, but maybe we can get this into 5.27. > > Heiko Tietze wrote: > As far as I understand the change it will show tofu'ed characters in > their intended

Re: Review Request 128232: The default level for logging categories should be Info rather than Warning.

2016-08-25 Thread David Edmundson
> On July 14, 2016, 1:11 p.m., David Edmundson wrote: > > modules/ECMQtDeclareLoggingCategory.cmake, line 72 > > > > > > This is new in Qt5.5 > > > > It seems frameworks currently still tries to build

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 252 - Unstable!

2016-08-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/252/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 25 Aug 2016 09:39:57 + Build duration: 9 min 45 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 155 - Fixed!

2016-08-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/155/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 25 Aug 2016 11:30:13 + Build duration: 13 min CHANGE SET

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98633 --- Ship it! Ship It! - Marco Martin On Aug. 25, 2016,

Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 155 - Fixed!

2016-08-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/155/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 25 Aug 2016 11:30:13 + Build duration: 13 min CHANGE SET

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
> On Aug. 25, 2016, 2:11 p.m., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 241 > > > > > > I think always emitting is error prone. You can emitting twice even 3 > > times. > > Same

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
> On Aug. 25, 2016, 2:11 p.m., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 241 > > > > > > I think always emitting is error prone. You can emitting twice even 3 > > times. > > Same

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98639 --- src/plasma/private/applet_p.cpp (line 241)

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98646 --- Looks good to me. +1 - Anthony Fieroni On Авг. 25, 2016,

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 4:49 p.m.) Status -- This change has been

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 4:49 p.m.) Status -- This change has been

Review Request 128759: Show shortcut for New Folder action

2016-08-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128759/ --- Review request for KDE Frameworks and David Faure. Bugs: 366075

Re: Review Request 128759: Show shortcut for New Folder action

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128759/#review98652 --- src/filewidgets/knewfilemenu.cpp (line 671)

Re: Review Request 128759: Show shortcut for New Folder action

2016-08-25 Thread Elvis Angelaccio
> On Aug. 25, 2016, 5:21 p.m., Anthony Fieroni wrote: > > src/filewidgets/knewfilemenu.cpp, line 671 > > > > > > I have a stupid question, but where (i can't see) action is added to > > collection i.e. case

Re: Review Request 128759: Show shortcut for New Folder action

2016-08-25 Thread Anthony Fieroni
> On Авг. 25, 2016, 8:21 след обяд, Anthony Fieroni wrote: > > src/filewidgets/knewfilemenu.cpp, line 671 > > > > > > I have a stupid question, but where (i can't see) action is added to > > collection i.e.

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/ --- (Updated Aug. 25, 2016, 3:11 p.m.) Review request for KDE Frameworks and

Review Request 128764: Load QtQuick rendering settings from a config file and set default QQuickWindow settings.

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128764/ --- Review request for KDE Frameworks. Repository: kdeclarative

Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128765/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128582: Remove unused KF5 dependencies

2016-08-25 Thread Alexander Potashev
> On Авг. 25, 2016, 10:02 п.п., Andreas Sturmlechner wrote: > > lddtree /usr/lib64/libKF5KrossUi.so is listing all these three dependencies > > still in use. Oops... You're right: kross/src/ui/actioncollectionview.cpp uses 1. KComboBox from KCompletion, 2. KMessageBox from KWidgetsAddons, 3.

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 157 - Unstable!

2016-08-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/157/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 25 Aug 2016 21:00:41 + Build duration: 5 min 34 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 158 - Fixed!

2016-08-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/158/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 25 Aug 2016 21:42:11 + Build duration: 4 min 41 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 158 - Fixed!

2016-08-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/158/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 25 Aug 2016 21:42:11 + Build duration: 4 min 41 sec CHANGE SET Revision

Re: Review Request 128582: Remove unused KF5 dependencies

2016-08-25 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98658 --- lddtree /usr/lib64/libKF5KrossUi.so is listing all these

Re: Review Request 128759: Show shortcut for New Folder action

2016-08-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128759/#review98665 --- src/filewidgets/knewfilemenu.h (line 144)

Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/ --- Review request for KDE Frameworks and Plasma. Repository: