This revision was automatically updated to reflect the committed changes.
Closed by commit R39:acc3aec084d2: Added getter for word-count configuration
value (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4696?vs=11568=11734
jsalatas added a comment.
In https://phabricator.kde.org/D4699#89179, @dhaumann wrote:
> Looks reasonable to me as well... I don't see any negative side effects, so
should be fine from my side.
> @cullmann Can you confirm?
Let's wait for a second opinion before committing this
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/569/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Feb 2017 02:26:42 +
Build duration: 18 min
CHANGE SET
Revision
ltoscano added a reviewer: kfunk.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4733
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, kfunk
Cc: #frameworks, #documentation
dhaumann added a comment.
I think in general a good idea.
Some comments:
- Could you update the patch with the mentioned issues?
- Could you also provide two test cases (under MIT license) that demonstrate
MIPS and GNU Assembler highlighting? That would be very helpful for our
cullmann added a comment.
Don't we need to honor "m_reloading" to avoid to do this on document reloads?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4699
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas,
jsalatas added a comment.
In https://phabricator.kde.org/D4699#89262, @cullmann wrote:
> Don't we need to honor "m_reloading" to avoid to do this on document
reloads?
`KTextEditor::DocumentPrivate::documentReload()` is keeping
m_fileTypeSetByUser to a local variable (`byUser`)
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R238 KDocTools
BRANCH
categorized-logging
REVISION DETAIL
https://phabricator.kde.org/D4733
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, kfunk
Cc:
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Indeed the getter case is missing, please commit. (Can you commit yourself,
or should I take care of this?)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
jsalatas added a comment.
In https://phabricator.kde.org/D4696#89174, @dhaumann wrote:
> Indeed the getter case is missing, please commit. (Can you commit yourself,
or should I take care of this?)
Yes I can commit. Will do it later
Thanks!
REPOSITORY
R39 KTextEditor
dhaumann added subscribers: cullmann, dhaumann.
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me as well... I don't see any negative side effects, so
should be fine from my side.
@cullmann Can you confirm?
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
when adding extra actions to the drop menu,
even if the menu was already shown, the cancel action should be the
last anyways for
mart added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4739
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, #frameworks, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:13054c047311: Fix disabling the spinner animation when
Busy indicator has no opacity (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
Generally good to go. Just one major gripe about Label, and making sure our
installed items and qmldir are in sync.
INLINE COMMENTS
> CMakeLists.txt:11
> +
> +#install the componenbts as a QQC2 Style, as style for applications (mainly
> for Plasma Mobile)
>
dfaure added inline comments.
INLINE COMMENTS
> dropjob.h:38
> class DropJobPrivate;
> +class DropMenu;
>
still here?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4739
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4729
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
mart updated this revision to Diff 11682.
mart added a comment.
- adress comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4739?vs=11674=11682
BRANCH
phab/cancelisLast
REVISION DETAIL
https://phabricator.kde.org/D4739
AFFECTED FILES
dfaure added a comment.
I like the encapsulation into a different class.
INLINE COMMENTS
> dropjob.cpp:63
> +public:
> +DropMenu(QWidget *parent = 0);
> +~DropMenu();
nullptr
> dropjob.cpp:167
> +
> +void DropMenu::addExtraActions(QList appActions, QList
> pluginActions)
> +{
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:786e5525a00c: Import remote ioslave from plasma-workspace
(authored by elvisangelaccio).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4690?vs=11620=11696#toc
REPOSITORY
R241 KIO
CHANGES
20 matches
Mail list logo
