D4847: KAuth integration in document saving
anthonyfieroni added inline comments. INLINE COMMENTS > katetextbuffer.cpp:791 > */ > -QSaveFile saveFile(filename); > -saveFile.setDirectWriteFallback(true); > +QFileDevice *saveFile = new QSaveFile(filename); > +static_cast(saveFile)->setDirectWriteFallback(true); use QScopedPointer, remove manual delete > katetextbuffer.cpp:886 > #else > fsync(saveFile.handle()); > #endif Should be -> instead of . REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
Review Request 129985: [kio-extras] Thumbs for audio files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- Review request for KDE Frameworks, David Faure and Elvis Angelaccio. Repository: kio-extras Description --- ^^ Diffs - thumbnail/CMakeLists.txt da6e4233 thumbnail/audiothumbs.cpp PRE-CREATION thumbnail/audiothumbs.desktop PRE-CREATION thumbnail/audiothumbs.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni
D4847: KAuth integration in document saving
martinkostolny updated this revision to Diff 12177. martinkostolny added a comment. Good point, thanks! I now the helper is really light-weight. Helper is now only moving a temporary file and setting permissions/owner. I've also added a unit test. It directly calls the action method instead of calling KAuth action. It's not nice but I think it's safe and it works. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4847?vs=12084=12177 REVISION DETAIL https://phabricator.kde.org/D4847 AFFECTED FILES autotests/src/katetextbuffertest.cpp autotests/src/katetextbuffertest.h src/CMakeLists.txt src/buffer/katesecuretextbuffer.cpp src/buffer/katesecuretextbuffer.h src/buffer/katetextbuffer.cpp src/buffer/katetextbuffer.h src/buffer/org.kde.ktexteditor.katetextbuffer.actions To: martinkostolny, dhaumann, #ktexteditor Cc: cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
D4937: Add KFileWidget::setSelectedUrl()
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilewidget.h:150 > */ > void setSelection(const QString ); > This function only works correctly for URLs, as filenames can contain ':'s. However, for those setSelectedUrl is the right function, so I'd mark this function as deprecated REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4937 To: dfaure, fvogt Cc: fvogt, #frameworks
Re: QFileDialog and KDE file dialogs
On samedi 4 mars 2017 12:03:08 CET Frank Schäfer wrote: > Hi, > > I'm trying to track down a bug which occurs when using > QFileDialog::getSaveFileName in a Qt5-application. > With option QFileDialog::DontUseNativeDialog a different dialog > displayed, so a native file dialog seems to be used. > I've checked the source code of QFileDialog::getSaveFileName and it > calls the file dialog which is hooked into > _qt_filedialog_save_filename_hook. > For KDE4, this seems to be KDialog::getSaveFileName(), but I wasn't able > to find out if and where this hook is used in KDE5. The hook is gone in Qt5 (or at least unused). > Does KDE5 provide a native file dialog at all ? Yes. > If yes, can anybody point me to the right direction ? plasma-integration.git provides a "platform theme" plugin which brings in the KDE file dialog, cf src/platformtheme/kdeplatformfiledialoghelper.cpp > Which dialog is used if KDE4 and KDE5 libraries are installed ? There is no KDE5 ;) If you have KF5 and plasma-integration installed, then you'll get the Qt5/KF5 based file dialog. Otherwise you'll get the builtin Qt dialog. No way will you ever get a kdelibs4/qt4-based dialog in a Qt5 application, that would require loading both versions of Qt at the same time, which is impossible ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
QFileDialog and KDE file dialogs
Hi, I'm trying to track down a bug which occurs when using QFileDialog::getSaveFileName in a Qt5-application. With option QFileDialog::DontUseNativeDialog a different dialog displayed, so a native file dialog seems to be used. I've checked the source code of QFileDialog::getSaveFileName and it calls the file dialog which is hooked into _qt_filedialog_save_filename_hook. For KDE4, this seems to be KDialog::getSaveFileName(), but I wasn't able to find out if and where this hook is used in KDE5. Does KDE5 provide a native file dialog at all ? If yes, can anybody point me to the right direction ? Which dialog is used if KDE4 and KDE5 libraries are installed ? Regards, Frank
D4937: Add KFileWidget::setSelectedUrl()
dfaure created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It turns out that setSelection() cannot take both relative paths (filenames) and absolute URLs as input. "a:b" can be both, and URLs for files called "a#b" were handled wrongly. CCBUG: 376365 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4937 AFFECTED FILES src/filewidgets/kfilewidget.cpp src/filewidgets/kfilewidget.h To: dfaure Cc: #frameworks
Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126894/ --- (Updated March 4, 2017, 12:05 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit fb4ad46b0dbacba5a9f184049643f6b29a3dd9e8 by David Faure on behalf of Milian Wolff to branch master. Repository: kio Description --- With this change it is now possible to list multiple paths as defined via the command line. While at it, I refactored the code to clean it up: - rely on QEventLoopLocker to quit the application once all jobs have finished - use a lambda to count the listed entries - don't append to a KIO::UDSEntryList to cound the listed entries Diffs - tests/listjobtest.cpp 702b09950734894a9f82746d58071225419b4e3f Diff: https://git.reviewboard.kde.org/r/126894/diff/ Testing --- Thanks, Milian Wolff
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 259 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/259/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Mar 2017 18:08:32 + Build duration: 5 min 35 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5476/8010 (68%)CONDITIONAL 2993/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1449/1555 (93%)CONDITIONAL 893/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 (58%)CONDITIONAL 770/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2796 (73%)CONDITIONAL 1245/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 247 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/247/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Mar 2017 18:07:44 + Build duration: 5 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5492/8011 (69%)CONDITIONAL 2989/6232 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 (94%)CONDITIONAL 892/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1767/3046 (58%)CONDITIONAL 767/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2797 (73%)CONDITIONAL 1245/2108 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 247 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/247/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Mar 2017 18:07:44 + Build duration: 5 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5492/8011 (69%)CONDITIONAL 2989/6232 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 (94%)CONDITIONAL 892/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1767/3046 (58%)CONDITIONAL 767/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2797 (73%)CONDITIONAL 1245/2108 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
D4847: KAuth integration in document saving
cullmann added a comment. Hi, I think this is a great thing to have! My biggest complaint ATM is: I would not move the saving code out to the helper binary, instead, it should stay in the place it is and we could just save to a tmpfile and tell the helper to move that file over the destination. With that, the with higher privileges running application is simpler (e.g. no need for filterdev which might execute complex compression libs) and we would avoid to store the complete file once more in memory. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
D4932: Cookies KCM: disable "delete" button when there is no current item
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4932 To: dfaure, lesliezhai Cc: #frameworks
D4932: Cookies KCM: disable "delete" button when there is no current item
dfaure added a comment. I'm curious to find out whether the clang static analyzer still complains or realizes this is fine now :) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4932 To: dfaure, lesliezhai Cc: #frameworks
D4932: Cookies KCM: disable "delete" button when there is no current item
lesliezhai accepted this revision. lesliezhai added a comment. This revision is now accepted and ready to land. Hi David, Looks good to me! Regards, Leslie Zhai REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4932 To: dfaure, lesliezhai Cc: #frameworks
D4630: Only register APPLE_* options if(APPLE)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D4630 To: apol, #frameworks, dfaure Cc: #build_system
D4932: Cookies KCM: disable "delete" button when there is no current item
dfaure created this revision. Restricted Application added a project: Frameworks. TEST PLAN kcmshell5 cookies REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4932 AFFECTED FILES src/kcms/kio/kcookiesmanagement.cpp To: dfaure, lesliezhai Cc: #frameworks
D4931: Small cleanups
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4931 To: apol, #frameworks, #plasma, davidedmundson Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
