D5556: build: Remove KService dependency

2017-04-26 Thread Ben Cooksley
bcooksley reopened this revision. bcooksley added a comment. This revision is now accepted and ready to land. Reopening as the commit has been removed via force push per T5958 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck,

D5587: Improvements

2017-04-26 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5587 To: apol, #frameworks, leinir

D5556: build: Remove KService dependency

2017-04-26 Thread Palo Kisa
palokisa added a comment. What's happening here? :) REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: bcooksley, #frameworks

D5556: build: Remove KService dependency

2017-04-26 Thread Ben Cooksley
bcooksley added a comment. There was a mistake made when committing this which Luigi and Aleix wanted to fix. The patch itself is fine and does not require any changes - one of them should re-land this patch soon. REPOSITORY R268 KGlobalAccel REVISION DETAIL

D5573: Don't accept hover events in the DragArea

2017-04-26 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. The FV side does rely on onDragMove firing, which is understand it still does regardless, so +1. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

2017-04-26 Thread Eike Hein
hein added a dependent revision: D5594: Configurable icon size. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 405 - Fixed!

2017-04-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/405/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 405 - Fixed!

2017-04-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/405/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 10 min CHANGE SET Revision

D5597: Raise default for 'Panel' icons to 48

2017-04-26 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5597 To: hein, #plasma, mart, broulik Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

2017-04-26 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 403 - Unstable!

2017-04-26 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/403/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 4 min 47 sec CHANGE SET Revision

D5597: Raise default for 'Panel' icons to 48

2017-04-26 Thread Eike Hein
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This KCM setting is now used again and this makes it match the default used by the Task Manager applet in vertical panels. REPOSITORY

D5556: build: Remove KService dependency

2017-04-26 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R268:000dac708604: build: Remove KService dependency (authored by palokisa, committed by ltoscano). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE

D5597: Raise default for 'Panel' icons to 48

2017-04-26 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R266:3e3eaaa82169: Raise default for 'Panel' icons to 48 (authored by hein). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5597?vs=13824=13826 REVISION DETAIL

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

2017-04-26 Thread Eike Hein
hein added a dependent revision: D5595: Configurable icon size. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed,

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

2017-04-26 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f48901b05fd: Introduce units.iconSizeHints.* to provide user-configurable icon size hints (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5556: build: Remove KService dependency

2017-04-26 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5556#104741, @palokisa wrote: > What's happening here? :) Palo, can you please share your email (here, if you don't mind it being public, or to me on IRC (tosky) or to mail email address luigi dot toscano attheserver

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

2017-04-26 Thread Eike Hein
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In effect this is meant to resurrect the "Panel" icon size setting from the Icons -> Advanced KCM in System Settings, for use as a

D5587: Improvements

2017-04-26 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R304:ceecc1c47568: Improvements (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5587?vs=13797=13832 REVISION DETAIL

D5417: add an extractor using qtmultimedia

2017-04-26 Thread Matthieu Gallien
mgallien updated this revision to Diff 13840. mgallien added a comment. fix several issues when testing on Windows with DirectShow Qt backend REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5417?vs=13367=13840 REVISION DETAIL

D5603: Install Plasma Components 3 so they can be used

2017-04-26 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY PlasmaComponents 3 exists both as a theme for QQC2 but also to be used directly like the current Plasma

Re: Continuous Integration on Windows

2017-04-26 Thread Matthieu Gallien
Hello, On vendredi 14 avril 2017 07:54:25 CEST Matthieu Gallien wrote: > Hello, > > On jeudi 13 avril 2017 19:31:37 CEST Kevin Funk wrote: > > On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote: > > > Hello, > > > > > > I am trying to use KFileMetaData on Windows with mingw-5.3 32

D5603: Install Plasma Components 3 so they can be used

2017-04-26 Thread Marco Martin
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:45 > > -DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components.3) > +DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components/3)

D5605: Allow multiple categories with the same name

2017-04-26 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the category name was intended as a kind of unique id, this isn't true anymore, so multiple categories can have the

D5605: Allow multiple categories with the same name

2017-04-26 Thread Marco Martin
mart added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D4975: Prevent misdetection of EOF on Linux

2017-04-26 Thread Peter Wu
Lekensteyn added a comment. (FWIW, I ran a patched kpty 5.32.0-1 version for a while and didn't have the hang issue until I recently upgraded to an unpatched 5.33.0-1. Haven't had a moment so far to dig deeper into the issue though.) REPOSITORY R291 KPty REVISION DETAIL

D5603: Install Plasma Components 3 so they can be used

2017-04-26 Thread David Edmundson
davidedmundson updated this revision to Diff 13849. davidedmundson added a comment. Much simpler change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5603?vs=13839=13849 BRANCH master REVISION DETAIL

D5603: Install Plasma Components 3 so they can be used

2017-04-26 Thread David Edmundson
davidedmundson added a comment. Did not know about that little feature. That's much tidier. Then the only thing that's wrong is that we don't install the qmldir file, which is what sent me on this wild chase this morning. (interestingly my desktop did have that file, I guess it was