Re: How do you find the git repository for a given differential?

Mark Gaiser ha scritto: > Hi, > > For instance, take this differential [1]. > Now i found the repository (plasma-integration in that specific case), > but i always [2] have trouble finding the repository. It doesn't seem > to be stated anywhere in a differential. It is, if the submitter use

D5656: Adds method to force the reloading of a document

cullmann added a comment. You can add the function as non-virtual one. Then call the right one of the d pointer, like we do for other new introduced view stuff: KTextEditor::Cursor View::maxScrollPosition() const { return d->maxScrollPositionInternal(); } Its bit

How do you find the git repository for a given differential?

Hi, For instance, take this differential [1]. Now i found the repository (plasma-integration in that specific case), but i always [2] have trouble finding the repository. It doesn't seem to be stated anywhere in a differential. How do you folks find the right repository for a given differential?

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > This patch broke the MSVC build

D5747: add pid to plasma window management protocol

hein added a dependent revision: D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,

Re: How do you find the git repository for a given differential?

On Sun, May 7, 2017 at 2:56 PM, Luigi Toscano wrote: > Mark Gaiser ha scritto: >> Hi, >> >> For instance, take this differential [1]. >> Now i found the repository (plasma-integration in that specific case), >> but i always [2] have trouble finding the repository. It

D5741: Fix test when compiling from a tarball

apol created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Otherwise it doesn't work when falling back to the project name. TEST PLAN Ran the test locally with and without .git

D5741: Fix test when compiling from a tarball

apol added a reviewer: sitter. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 0.1% of the partition size is a rather arbitrary value, no? It could go from > something very tiny to something really big... > > On my 470GB partition this would lead

D5639: Internal cache for provider data on initialisation

leinir updated this revision to Diff 14243. leinir added a comment. Static var naming change, for consistency and whatnot REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14236=14243 REVISION DETAIL https://phabricator.kde.org/D5639 AFFECTED

D5639: Internal cache for provider data on initialisation

leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:58 > The uppercase first letter on variable name is unusual. > > I personally use a s_ prefix for static vars. Hmm. Right, there is no established way of naming them in KNS already, so while i am not personally so keen

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir updated this revision to Diff 14244. leinir added a comment. Work some numbers a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14242=14244 REVISION DETAIL https://phabricator.kde.org/D5638 AFFECTED FILES

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 239 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/239/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 18:36:36 + Build duration: 5 min 56 sec CHANGE SET No changes

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 272 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/272/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 18:46:47 + Build duration: 3 min 20 sec CHANGE SET No changes

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:29:33 + Build duration: 53 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:29:33 + Build duration: 53 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 240 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:25:21 + Build duration: 3 min 38 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 240 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 07 May 2017 21:25:21 + Build duration: 3 min 38 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > This patch broke the MSVC build

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks

D5745: recreate plasmashellsurf on exposed, destoy on hidden

mart updated this revision to Diff 14247. mart added a comment. - don't return false REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14246=14247 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745

D5747: add pid to plasma window management protocol

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also extend the autotests/client/test_wayland_windowmanagement.cpp INLINE COMMENTS > plasmawindowmanagement.h:385 > + * @returns The process id this window

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 50 bytes? isn't that a bit small? :) Yes, yes it is ;) > dfaure wrote in httpworker.cpp:57 > the uppercase first letter is weird, for a variable. Good point, yes. Not

D5745: recreate plasmashellsurf on exposed, destoy on hidden

davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:1123 > if (event->type() == QEvent::Expose) { > -// FIXME TODO: We can remove this once we depend on Qt 5.6.1+. > -// See: https://bugreports.qt.io/browse/QTBUG-26978 > -

D5741: Fix test when compiling from a tarball

This revision was automatically updated to reflect the committed changes. Closed by commit R240:94056e2e4629: Fix test when compiling from a tarball (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5741?vs=14229=14248 REVISION

D5747: add pid to plasma window management protocol

sebas created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch adds a pid event to the plasma window management protocol. It allows the compositor to tell allow

D5747: add pid to plasma window management protocol

davidedmundson added inline comments. INLINE COMMENTS > plasma-window-management.xml:267 > + > + > + uint is a native type: https://wayland.freedesktop.org/docs/html/ch04.html#sect-Protocol-Wire-Format you don't need to do an implicit cast REPOSITORY R127 KWayland REVISION

D5741: Fix test when compiling from a tarball

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system

D5739: Improve some error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f72a417aecd0: Improve some error messages (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5739?vs=14226=14230 REVISION DETAIL

D5639: Internal cache for provider data on initialisation

leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:206 > This connect (and the following) could be done outside of the if/else, so > avoid being repeated, no? > Or is there a risk that load() will emit those signals immediately?

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir updated this revision to Diff 14235. leinir marked an inline comment as done. leinir added a comment. Some style fixes, and set a reasonable maximum size for the cache REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14146=14235 REVISION

D5745: recreate plasmashellsurf on exposed, destoy on hidden

mart updated this revision to Diff 14246. mart added a comment. - check null region REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14241=14246 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745

D5639: Internal cache for provider data on initialisation

leinir updated this revision to Diff 14236. leinir marked an inline comment as done. leinir added a comment. Simplify the xmlloader cache logic a touch REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14080=14236 REVISION DETAIL

D5745: recreate plasmashellsurf on exposed, destoy on hidden

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY every time the window gets shown the wayland surfaces get created, when hidden, they get destroyed showevent is too

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

dfaure added a comment. 5 is 50kB. You wrote 50 megs which would be 5000 or 50*1024*1024. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > httpworker.cpp:41 > +QStorageInfo storageInfo(cacheLocation); > +cache.setMaximumCacheSize(qMin(50, (int)(storageInfo.bytesTotal() / >

D5739: Improve some error messages

apol created this revision. Restricted Application added a project: Frameworks. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5739 AFFECTED FILES src/attica/atticaprovider.cpp src/core/engine.cpp To: apol, #frameworks, whiting, leinir

D5739: Improve some error messages

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5739 To: apol, #frameworks, whiting, leinir

D5639: Internal cache for provider data on initialisation

dfaure added a comment. Looks simpler indeed. INLINE COMMENTS > engine.cpp:58 > +typedef QHash EngineProviderLoaderHash; > +Q_GLOBAL_STATIC(QThreadStorage, > EngineProviderLoaders) > + The uppercase first letter on variable name is unusual. I personally use a s_

D5639: Internal cache for provider data on initialisation

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5639 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir added a comment. In https://phabricator.kde.org/D5638#107645, @dfaure wrote: > 5 is 50kB. > You wrote 50 megs which would be 5000 or 50*1024*1024. Yes, i certainly did. I should remember to drink less caffeine sometimes. REPOSITORY R304 KNewStuff REVISION

D5747: add pid to plasma window management protocol

hein added a dependent revision: D5755: Expose PlasmaWindow::pid through WaylandTasksModel.. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 552 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/552/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 02:14:07 + Build duration: 20 min CHANGE SET Revision

Jenkins-kde-ci: kactivities-stats master kf5-qt5 » Linux,gcc - Build # 572 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities-stats%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/572/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 02:53:02 + Build duration: 4.4 sec CHANGE SET No changes

Jenkins-kde-ci: kactivities-stats master stable-kf5-qt5 » Linux,gcc - Build # 566 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/566/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 May 2017 03:06:54 + Build duration: 4.9 sec CHANGE SET No changes