KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 8 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 01:02:28 + Build duration: 3 min 9 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowsystemplatformwaylandtestFailed: TestSuite.kwindowsystem-netrootinfotestwm Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report75% (3/4)88% (42/48)88% (42/48)75% (6796/9070)54% (3810/7089)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (14/14)100% (14/14)98% (2932/3004)52% (1616/3115)src88% (14/16)88% (14/16)54% (776/1435)44% (314/712)src.platforms.wayland0% (0/2)0% (0/2)0% (0/89)0% (0/2)src.platforms.xcb88% (14/16)88% (14/16)68% (3088/4542)58% (1880/3260) build.log Description: Binary data
KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/7/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 00:48:32 + Build duration: 2 min 51 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowsystemplatformwaylandtestFailed: TestSuite.kwindowsystem-netrootinfotestwm Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report75% (3/4)88% (42/48)88% (42/48)75% (6796/9070)54% (3810/7089)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (14/14)100% (14/14)98% (2932/3004)52% (1616/3115)src88% (14/16)88% (14/16)54% (776/1435)44% (314/712)src.platforms.wayland0% (0/2)0% (0/2)0% (0/89)0% (0/2)src.platforms.xcb88% (14/16)88% (14/16)68% (3088/4542)58% (1880/3260) build.log Description: Binary data
D6054: Use explicit flag values or explicit constructor instead of nullptr
kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has been done with a trick based on pointer types. Which these days of nullptr existing and compilers pushing to use that sadly fired back and, instead of allowing convenient code with commonly understood literal "0" values, resulted in quite some code using "nullptr" to indicate a QFLags-based type value with no flags set, which can be puzzling for humans reading the code. To improve the code again, instead of "nullptr" are used: - enum item representing the 0=no-flag-set value, if existing - explicit default constructor REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 AFFECTED FILES autotests/kstartupinfo_unittest.cpp autotests/kwindowinfox11test.cpp autotests/kwindowsystemx11test.cpp autotests/netwininfotestwm.cpp src/kstartupinfo.cpp src/kwindowinfo.cpp src/kwindowinfo.h src/kwindowsystem.h src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/netwm.cpp src/platforms/xcb/netwm.h To: kossebau, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/7/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 00:33:27 + Build duration: 8 min 20 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katesyntaxtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report81% (22/27)88% (290/330)88% (290/330)68% (33451/49515)51% (16876/32993)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.src100% (47/47)100% (47/47)93% (4252/4561)49% (1997/4066)autotests.src.vimode100% (16/16)100% (16/16)99% (5525/5569)54% (897/1658)src.buffer88% (15/17)88% (15/17)91% (1696/1869)76% (1294/1694)src.completion100% (16/16)100% (16/16)56% (1748/3102)43% (1192/2798)src.completion.expandingtree100% (5/5)100% (5/5)40% (184/464)22% (79/354)src.dialogs0% (0/4)0% (0/4)0% (0/875)0% (0/258)src.document100% (4/4)100% (4/4)58% (1859/3225)47% (1517/3238)src.export0% (0/4)0% (0/4)0% (0/125)0% (0/152)src.include.ktexteditor93% (13/14)93% (13/14)82% (202/245)63% (145/230)src.inputmode100% (8/8)100% (8/8)53% (172/325)45% (40/89)src.mode83% (5/6)83% (5/6)39% (165/427)37% (99/265)src.printing0% (0/4)0% (0/4)0% (0/885)0% (0/294)src.render100% (9/9)100% (9/9)75% (912/1217)67% (624/932)src.schema22% (2/9)22% (2/9)1% (21/1538)1% (7/697)src.script100% (14/14)100% (14/14)66% (700/1055)53% (295/556)src.search100% (7/7)100% (7/7)74% (1043/1418)63% (588/929)src.spellcheck71% (5/7)71% (5/7)28% (375/1336)25% (207/820)src.swapfile50% (1/2)50% (1/2)33%
KDE CI: Frameworks kdeclarative kf5-qt5 XenialQt5.7 - Build # 10 - Fixed!
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks kdeclarative kf5-qt5 XenialQt5.7 Date of build: Thu, 01 Jun 2017 00:14:35 + Build duration: 1 min 37 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)76% (19/25)76% (19/25)58% (740/1269)37% (319/864)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (7/7)100% (7/7)83% (402/484)40% (192/484)src.kdeclarative75% (3/4)75% (3/4)48% (150/312)36% (60/166)src.kdeclarative.private100% (5/5)100% (5/5)41% (24/58)19% (6/32)src.qmlcontrols.kquickcontrolsaddons100% (2/2)100% (2/2)55% (79/144)46% (36/78)src.quickaddons29% (2/7)29% (2/7)31% (85/271)24% (25/104) build.log Description: Binary data
D6053: Use explicit flag values or explicit constructor instead of nullptr
kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has been done with a trick based on pointer types. Which these days of nullptr existing and compilers pushing to use that sadly fired back and, instead of allowing convenient code with commonly understood literal "0" values, resulted in quite some code using "nullptr" to indicate a QFLags-based type value with no flags set, which can be puzzling for humans reading the code. To improve the code again, instead of "nullptr" are used: - enum item representing the 0=no-flag-set value, if existing - explicit constructor REPOSITORY R236 KWidgetsAddons BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6053 AFFECTED FILES src/kassistantdialog.h src/keditlistwidget.cpp src/kfontrequester.cpp src/kpagedialog.h src/kpagewidgetmodel.cpp src/kpassworddialog.h src/kruler.h src/kseparator.h To: kossebau, #frameworks, cfeck
D6041: Port a bunch of classes away from Plasma::Package
apol added a comment. Yes sure. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6047: WIP: Support XDG v6
davidedmundson updated this revision to Diff 15020. davidedmundson added a comment. Arc didn't work, I think it was too big. Manually uploading the patch did. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15013=15020 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6049: Extend unittests to test stable sort.
adridg added reviewers: whiting, Frameworks. adridg added a comment. (also, this repo has a .reviewboardrc but no .arcconfig) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6049 To: adridg, whiting, #frameworks Cc: #frameworks
D6049: Extend unittests to test stable sort.
adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - Helper function constructs a permutation of the list of menu-items that need to be sorted, then sorts and tests. - Test ten permutations of the list of items (not all of them, since it's a stable sort some permutations must produce a different sorted output, so no std::next_permutation here). Fix stable sorting of menu items. In the case i1 installed, but in section Main, and i2 uninstalled, this lambda returned False, meaning that i1 was not less than i2. Change comparison to always sort installed before uninstalled. TEST PLAN Revert the change to src/kmoretools/kmoretools_p.h to see the sorting test fail; restore the change for the fix. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6049 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp src/kmoretools/kmoretools_p.h To: adridg Cc: #frameworks
D6041: Port a bunch of classes away from Plasma::Package
davidedmundson added a comment. Can we wait till after the next release is tagged as that's super soon and this isn't that important. We've had major bugs porting stuff in this area before. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol updated this revision to Diff 15015. apol marked an inline comment as done. apol added a comment. Address Marco's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15003=15015 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/package.cpp src/plasma/package.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.h:105 > despite the warning in the header, this ended up being an exported symbol, so > binary compatibility rules apply here too. > Plasma::Package appletPackage() const; has to stay, eventually deprecated and > a new KPackage::Package appletPackage() const; added. Okay, will fix in a next patch. Please note nobody is using these methods and we could possibly scrap altogether the storing of appletPackage and coronaPackage. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
KDE CI: Frameworks kdeclarative kf5-qt5 XenialQt5.7 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks kdeclarative kf5-qt5 XenialQt5.7 Date of build: Wed, 31 May 2017 10:40:28 + Build duration: 1 min 33 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.quickviewsharedengine Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)76% (19/25)76% (19/25)47% (596/1269)26% (223/864)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (7/7)100% (7/7)68% (328/484)25% (123/484)src.kdeclarative75% (3/4)75% (3/4)45% (140/312)34% (57/166)src.kdeclarative.private100% (5/5)100% (5/5)24% (14/58)6% (2/32)src.qmlcontrols.kquickcontrolsaddons100% (2/2)100% (2/2)55% (79/144)46% (36/78)src.quickaddons29% (2/7)29% (2/7)13% (35/271)5% (5/104) build.log Description: Binary data
D6047: WIP: Support XDG v6
davidedmundson abandoned this revision. davidedmundson added a comment. Flipping phabricator... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6047: WIP: Support XDG v6
davidedmundson created this revision. davidedmundson added projects: Plasma on Wayland, Frameworks. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REVISION SUMMARY To move forward faster I thought we could start reviewing the davidedmundson/xdgv6 branch for the top level whilst I continue the Popup stuff in a new branch. Commits are made by both me and Marco. He did pings + min/max sizes I did most most the rest. The main clever part that's not just boring boiler plate is how we handle the structure change A surface now has an XDGSurface which then has a an Xdg TopLevel or a Xdg Popup We need to fit this into the public API which assumes a surface has a Surface or a Popup. The old Surface is similar to the new TopLevel. The shoehorning works by relying on the fact that a surface without a role is pretty useless. Clients create the surface implicitly with the toplevel or implicitly with the popup. The server only announced it has a new "XdgSurface" when it gets a new zxdg_surface_get_toplevel. Don't write comments about popup code not being implemented... TEST PLAN Current test still passes. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/test_xdg_shell_v6.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6045: Set main window as parent of stand-alone popup menus
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Stand-alone popup menus are elements that are children of the top-level element. Their initial parent is nullptr, but if we are inside a QMainWindow we can use that as the parent. This ensures proper placement of the menus on wayland (where parents are required in order to have a transient parent window). We also drop an old comment which claims popup menus should not have parent. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D6045 AFFECTED FILES autotests/kxmlgui_unittest.cpp autotests/kxmlgui_unittest.h src/kxmlguibuilder.cpp To: elvisangelaccio, dfaure Cc: #frameworks
D5801: Split XDGTest to allow testing both V5 and V6
davidedmundson abandoned this revision. davidedmundson added a comment. I was hoping to put anything that affected v5 in a separate commits, with v6 separate, but that didn't really happen. Will include with the other stuff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5801 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pluginloader.h:208 > + **/ > +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const > QString ); > + wow, phab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;) > appletquickitem.h:105 > > -Plasma::Package appletPackage() const; > -void setAppletPackage(const Plasma::Package ); > +KPackage::Package appletPackage() const; > +void setAppletPackage(const KPackage::Package ); despite the warning in the header, this ended up being an exported symbol, so binary compatibility rules apply here too. Plasma::Package appletPackage() const; has to stay, eventually deprecated and a new KPackage::Package appletPackage() const; added. > wallpaperinterface.h:26 > > -#include > +#include > +#include why plasma_export.h? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
KDE CI: Frameworks kdeclarative kf5-qt5 XenialQt5.7 - Build # 8 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks kdeclarative kf5-qt5 XenialQt5.7 Date of build: Wed, 31 May 2017 09:08:53 + Build duration: 2 min 5 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.quickviewsharedengine Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)76% (19/25)76% (19/25)47% (596/1269)26% (223/864)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (7/7)100% (7/7)68% (328/484)25% (123/484)src.kdeclarative75% (3/4)75% (3/4)45% (140/312)34% (57/166)src.kdeclarative.private100% (5/5)100% (5/5)24% (14/58)6% (2/32)src.qmlcontrols.kquickcontrolsaddons100% (2/2)100% (2/2)55% (79/144)46% (36/78)src.quickaddons29% (2/7)29% (2/7)13% (35/271)5% (5/104) build.log Description: Binary data
D6017: Don't leak MimeData object
This revision was automatically updated to reflect the committed changes. Closed by commit R296:695f24fb522a: Don't leak MimeData object (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6017?vs=14959=15008 REVISION DETAIL https://phabricator.kde.org/D6017 AFFECTED FILES src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h To: davidedmundson, #plasma, mart, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
hein accepted this revision. hein added a comment. Sounds good REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart, hein Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
davidedmundson added a comment. > So you're cleaning up the leak the next time the getter is accessed? No? If it's accessed again m_data is not null so we don't get in that branch The main cleanup is implicitly in the DeclarativeDropEvent destructor REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
hein added a comment. So you're cleaning up the leak the next time the getter is accessed? What if this never happens? REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6017: Don't leak MimeData object
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6017 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
