D6418: [XDGV6] manage every ping sent
davidedmundson added a comment. > for how i did the kwin part, it must be who called it with discardTimer (this to allow kwin to receive 2 timeouts before deciding to kill the window) Ok, I see how it's meant to work but I don't understand why it's done like that. From what I see Kwayland can call "emit q->pingTimeout ; q->discardTimer() " and your kwin code will still wait for 2 timeouts, Otherwise it creates different behaviour depending on whether we do or don't receive a pong, and we make it very vulnerable to leak (for example if ShellClient instance is deleted with a ping open) - > most of it is in private, just its creation is mostly identical in the implementation of ping in the subclasses Yes, and I'm saying that bit could be shared as a method and called from the subclasses. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6418 To: mart, #plasma, davidedmundson, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6418: [XDGV6] manage every ping sent
mart added a comment. In https://phabricator.kde.org/D6418#120218, @davidedmundson wrote: > who deletes the qtimer if it times out? > > can this timer stuff be shared by moving it into XdgShellInterface::Private ? for how i did the kwin part, it must be who called it with discardTimer (this to allow kwin to receive 2 timeouts before deciding to kill the window) most of it is in private, just its creation is mostly identical in the implementation of ping in the subclasses REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6418 To: mart, #plasma, davidedmundson, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6418: [XDGV6] manage every ping sent
davidedmundson added a comment. who deletes the qtimer if it times out? can this timer stuff be shared by moving it into XdgShellInterface::Private ? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6418 To: mart, #plasma, davidedmundson, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6418: [XDGV6] manage every ping sent
mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if more ping arrives before a pong, store each of its serial and manage them one by one a new signal, pingTimeout emitted until explicitly stopped TEST PLAN tests still pass, kwin modified to use it on window close and window focus gain works correctly. What is not tested: apps not answering to pings as usually the connection thread will still be running, so something to actually query the gui thread will be needed REPOSITORY R127 KWayland BRANCH mart/xdgv6ping REVISION DETAIL https://phabricator.kde.org/D6418 AFFECTED FILES autotests/client/test_xdg_shell.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v6_interface.cpp To: mart, #plasma, davidedmundson, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 15 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/15/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 28 Jun 2017 12:29:55 + Build duration: 1 min 45 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.plasma-packagestructuretest build.log Description: Binary data
D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5
This revision was automatically updated to reflect the committed changes. Closed by commit R249:c0445f0c536b: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6338?vs=15738=15940#toc REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6338?vs=15738=15940 REVISION DETAIL https://phabricator.kde.org/D6338 AFFECTED FILES src/CMakeLists.txt src/klocalizedstring.h To: kossebau, #frameworks, ilic
D6339: Remove custom doxygen config files
This revision was automatically updated to reflect the committed changes. Closed by commit R249:f9bd662f22d8: Remove custom doxygen config files (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6339?vs=15739=15939 REVISION DETAIL https://phabricator.kde.org/D6339 AFFECTED FILES doxygen.cfg doxygen.css To: kossebau, #frameworks, ilic
D5208: Allow loading i18n catalogs from arbitrary locations
ilic added inline comments. INLINE COMMENTS > davidedmundson wrote in klocalizedstringtest.cpp:59 > Pretty sure it's fine. kactivities and kjs use them with no issue. Well, since no-one else complained either, guess it's ok. Easy to fix later if someone does complain. > ilic wrote in kcatalog.cpp:124 > Only read access is needed here, user QHash::value instead of > QHash::operator[]. Also the lock should be removed, now that only read access is used. > ilic wrote in kcatalog.cpp:151 > Also only read access needed. Also the lock should be removed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5208 To: davidedmundson, #frameworks, ilic Cc: ilic
D6339: Remove custom doxygen config files
ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH removecustomdoxygencfg REVISION DETAIL https://phabricator.kde.org/D6339 To: kossebau, #frameworks, ilic
D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5
ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH standardizedoxygenppmacro REVISION DETAIL https://phabricator.kde.org/D6338 To: kossebau, #frameworks, ilic
