cordlandwehr accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6976
To: vkrause, cordlandwehr
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R868:ee7c296202da: Make ECM a dependency for all frameworks
(authored by vkrause).
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
CHANGES SINCE LAST UPDATE
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is useful for cross-compilation, where we only need the QtCore-only
parsetrigrams build tool on the host and avoids having to pull in a full
graphics stack for the host build in Yocto.
vkrause updated this revision to Diff 17388.
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6992?vs=17387=17388
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6992
AFFECTED FILES
CMakeLists.txt
src/config-kcrash.h.cmake
src/kcrash.cpp
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 30 Jul 2017 13:43:24 +
Build duration:
1 min 1 sec and counting
JUnit Tests
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6992
AFFECTED FILES
src/kcrash.cpp
To: vkrause, #frameworks
bshah added a comment.
Also, you will need to make similar change on kinit.cpp in kinit.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah
Cc: bshah
bshah requested changes to this revision.
bshah added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcrash.cpp:272
> return "WIN_DISPLAY";
> +#else
> +return "WAYLAND_DISPLAY";
That sounds wrong.. possibly you have to check if HAVE_WAYLAND is true..
brauch added a comment.
With enough dedication, probably yes ...
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7010
To: brauch, cfeck
Cc: aacid, #frameworks
apol requested changes to this revision.
apol added a subscriber: aacid.
apol added a comment.
This revision now requires changes to proceed.
@aacid concern also applies here. I'm fine with the change as long as it's
coherent.
REPOSITORY
R237 KConfig
REVISION DETAIL
brauch created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
By changing the full text, the sizeHint() of the widget changes. If the
aacid added a comment.
I would really prefer if the option-ability of Widgets was enabled by a
setting or something, we really want to avoid people not having widgets
installed and getting a subpar build unless they really really ask for it
REPOSITORY
R246 Sonnet
REVISION DETAIL
aacid added a comment.
do we have autotests for this? Can they be added?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7010
To: brauch, cfeck
Cc: aacid, #frameworks
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6994
To: vkrause, #frameworks, apol
apol added inline comments.
INLINE COMMENTS
> check.cmake.in:79
> message(WARNING "${name}[${lang}] output was
> \"${stripped_output}\", but expected
> \"${exp_output_${catalog_name}_${lang}}\"")
> -set(fail ON)
> +set(fail ON PARENT_SCOPE)
>
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Exporting the executables will make the cmake config file check for their
presence when used, which isn't really necessary, and is actually a problem
for cross-compilation, where the helper
vkrause added a comment.
I agree on this needing runtime rather than compile-time selection code. I
disagree on this not happening in reality though, the KF5 Yocto recipes assume
there is no X11, which is why I ran into this in the first place :)
REPOSITORY
R285 KCrash
REVISION DETAIL
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/
---
(Updated July 30, 2017, 5:32 p.m.)
Status
--
This change has been
graesslin added a comment.
But then the root problem of not having an ifdef branch as fallback is also
not fixed.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah, graesslin
Cc: graesslin, bshah
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/14/
Project:
Frameworks bluez-qt kf5-qt5 XenialQt5.7
Date of build:
Sun, 30 Jul 2017 16:34:10 +
Build duration:
7 min 43 sec and counting
JUnit Tests
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/35/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 30 Jul 2017 17:03:58 +
Build duration:
4 min 39 sec and counting
JUnit
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Sorry to say, but the approach is wrong in general. The problem is that the
platform is runtime selected and not compile time. This patch fixes a very
special case which
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/15/
Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 30 Jul 2017 16:34:10 +
Build duration:
2 min 22 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/40/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sun, 30 Jul 2017 17:03:58 +
Build duration:
7 min 30 sec and counting
JUnit Tests
lueck added inline comments.
INLINE COMMENTS
> template.docbook:20
>
>
>
needs update to new license
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D6972
To: ltoscano
Cc: lueck, #frameworks, #documentation, skadinna
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/42/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 31 Jul 2017 02:48:58 +
Build duration:
8 min 8 sec and counting
JUnit
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Now we can use lineedit password outside kpassworddialog.
It's useful in kdepim for example.
TEST PLAN
I added autotest and test apps.
wbauer added inline comments.
INLINE COMMENTS
> apol wrote in check.cmake.in:79
> It should also change the other `set(fail)` calls.
>
> Or am I missing something?
The other `set(fail)` calls *are* at the top-level and not inside a function.
So, no, it doesn't make sense there.
The function
29 matches
Mail list logo
