Re: KGlobalAccel regression in latest frameworks release

I've tagged v5.38.1 and released a tar with the change reverted. I've not reverted it in master branch so it will need to be fixed or reverted before 5.39.0 Jonthan

D5034: Add support for x-gvfs style options in fstab

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D7774 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dhaumann, dfaure Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, progwolff,

D7815: Don't list tab names twice

davidedmundson updated this revision to Diff 19521. davidedmundson added a comment. update REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7815?vs=19520=19521 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7815 AFFECTED

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/106/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Thu, 14 Sep 2017 12:51:21 + Build duration: 5 min 2 sec and counting

D7815: Don't list tab names twice

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7815 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D7815: Don't list tab names twice

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7141ad172165: Don't list tab names twice (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7815?vs=19521=19524

D7815: Don't list tab names twice

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The name (with a correct role) is already exported as a tab By having the static text internally we get the

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

davidedmundson added a comment. See second line attached: F3910924: Spectacle.G18840.png F3910925: Spectacle.i18840.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/110/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 14 Sep 2017 12:51:21 + Build duration: 5 min 26 sec and counting

D7699: Add support for custom search paths for application-specific syntax and theme definitions

zrax added a comment. Is anything else needed for this? I'm assuming installing the indexer would go as a separate review and that nobody is waiting for me to add that here... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate,

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten added a subscriber: heikobecker. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7823 To: marten, #frameworks, #build_system Cc: heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY These modules are used in a number of places within Frameworks, Plasma and dependencies: FindGLIB2: plasma-desktop/applets/kimpanel/cmake/FindGLIB2.cmake

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/71/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 15 Sep 2017 03:04:40 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/77/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 15 Sep 2017 03:03:55 + Build duration: 51 sec and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/107/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Fri, 15 Sep 2017 03:05:10 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/111/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 15 Sep 2017 03:05:10 + Build duration: 9 min 28 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/81/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 15 Sep 2017 03:03:55 + Build duration: 2 min 18 sec and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/25/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 15 Sep 2017 03:05:10 + Build duration: 51 min and counting

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This draws a line underneath a Plasma checkbox label when it has keyboard focus. This is needed as when an item

D7792: Fixing incorrectly capitalized regexps

dhaumann closed this revision. dhaumann added a comment. Committed with https://cgit.kde.org/syntax-highlighting.git/commit/?id=212e6db4bbbaec14bb56a8b608f5cf0b7e2b0f4b REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7792 To: gregsteuck,

D7827: Syntax indexer: Catch invalid a-Z/A-Z ranges in regexps

dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Motivated by incorrect regular expressions of the form [a-zA-z] or [a-Z], this patch extends the highlighting indexer to check for this

D6233: KKeyServer: fix handling of KeypadModifier.

dfaure added a comment. Thanks for the reports. These shortcuts get converted correctly (https://commits.kde.org/kwindowsystem/af6d5ab12b2d99b39a73ed8df903368470ded55b), so the problem must be in the shift handling in xcbKeyPressEventToQt(). REPOSITORY R278 KWindowSystem REVISION DETAIL

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/29/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 14 Sep 2017 20:52:56 + Build duration: 4 min 5 sec and counting JUnit

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/30/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Thu, 14 Sep 2017 20:52:56 + Build duration: 8 min 57 sec and counting JUnit

D7828: createKMessageBox tries to focus a default button when available

emateli created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH createKMessageBox-btn-focus REVISION DETAIL https://phabricator.kde.org/D7828 AFFECTED FILES

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cfeck added a comment. In other words, your suggestion is not to add it to ecm, but to move it from attic/modules to find-modules. That raises the question, how one is supposed to use the attic modules, without copying them manually. REPOSITORY R240 Extra CMake Modules REVISION

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten added a comment. It's the same source really - the only differences between those in kdelibs4support and ecm/attic are that the former uses endif(same_as_if) and the latter uses endif(). Nothing else within Frameworks, Plasma or applications uses anything from ecm/attic directly.

D7828: createKMessageBox tries to focus a default button when available

emateli edited the summary of this revision. emateli edited the test plan for this revision. emateli added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks Cc: #frameworks

D6233: KKeyServer: fix handling of KeypadModifier.

dfaure added a comment. Alt+Shift+right bug fixed in https://phabricator.kde.org/D7829 Meta+Shift+Print is another issue, I get KGlobalAccelImpl::grabKey: keyQt (0x 100011e ) failed to resolve to x11 keycode and KGlobalAccelImpl::x11KeyPress: keyQt= "130a"

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

dfaure created this revision. REVISION SUMMARY When keysym1 (i.e. with shift) is 0, then we must use keysym0 (the version without shift) in any case. TEST PLAN Adding a global shortcut with Alt+Shift+Right works now. Previously it would decode it at "Alt+" at keypress time. BRANCH

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

broulik added a comment. Doesn't fix Meta+Shift+PrintScr for me REVISION DETAIL https://phabricator.kde.org/D7829 To: dfaure, graesslin, jriddell, martinkostolny, broulik Cc: #frameworks

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. This should come with an autotest REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks Cc: aacid, #frameworks