D7810: Add missing icon sizes

2017-10-30 Thread Eike Hein 
hein added inline comments.

INLINE COMMENTS

> index.theme:297
>  MinSize=32
> -MaxSize=48
> +MaxSize=32
>  

Hmm why lower this one:

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D7810

To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: hein, ngraham, cfeck, #frameworks

D7810: Add missing icon sizes

2017-10-30 Thread Jens Reuterberg 
jensreuterberg added a subscriber: andreask.
jensreuterberg added a comment.


  Well the issue is that they are not "scalable" - I mean the goal should 
rather be to make them functionable on all sizes but being SVG's means that 
they may become misaligned when rendered. (Ie if you make an icon made for one 
size slightly bigger or smaller it will risk suddenly becoming blurry).
  
  If @andreask thinks its ok as a risk I am all for it - we should keep in mind 
though to ensure that all icons have wide breadth of sizes and if possible have 
a follow up on all icons used and which ones are "just resized" and which are 
done in the correct sizes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D7810

To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: andreask, hein, ngraham, cfeck, #frameworks

D8546: Add Aztec code generator

2017-10-30 Thread Luca Beltrame 
lbeltrame added reviewers: Frameworks, svuorela.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D8546

To: vkrause, #frameworks, svuorela
Cc: #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-30 Thread Renato Oliveira Filho 
renatoo added a comment.


  Guys,  is that ready? Do you need any other change/fix?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.9 - Build # 1 - Failure!

2017-10-30 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kjobwidgets kf5-qt5 AndroidQt5.9
 Date of build:
Mon, 30 Oct 2017 13:20:06 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 17.87 KB...] > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 9548cdc901d918f9fac4c906bce2fad03ee7e9ea (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 9548cdc901d918f9fac4c906bce2fad03ee7e9eaCommit message: "Create new repository for Liquidshell. Ref T7328"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks kjobwidgets kf5-qt5 AndroidQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 37dcf7d42c9aca3fff54c6b600ebf79204e78df9 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 37dcf7d42c9aca3fff54c6b600ebf79204e78df9Commit message: "Akonadi master no longer depends on networkmanager-qt"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kjobwidgets kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kjobwidgets --branchGroup kf5-qt5 --environment production --platform AndroidQt5.9 --installTo /home/user/install-prefix/Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kjobwidgets kf5-qt5 AndroidQt5.9] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kjobwidgets --branchGroup kf5-qt5 --platform AndroidQt5.9 --installTo /home/user/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix/;/opt/Qt/5.9.1/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks kjobwidgets kf5-qt5 AndroidQt5.9"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET=-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could not set up the appstream test. appstreamcli is missing.CMake Error at

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent added a comment.


  it depends against https://phabricator.kde.org/D8348 too

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  Michal, I don't know how familiar you are with the Samba codebase, but it 
looks like another user has a proposal for fixing the issue in 
https://bugzilla.samba.org/show_bug.cgi?id=13050. Are you able to test that and 
submit a patch to them?
  
  IMHO we should commit this though. It might be a long time before any such 
patch is accepted and makes into a released version.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D8387

To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter, graesslin, z3ntu

KDE CI: Frameworks kcompletion kf5-qt5 AndroidQt5.9 - Build # 1 - Successful!

2017-10-30 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20AndroidQt5.9/1/
 Project:
Frameworks kcompletion kf5-qt5 AndroidQt5.9
 Date of build:
Mon, 30 Oct 2017 13:20:08 +
 Build duration:
1 min 27 sec and counting

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

2017-10-30 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, 
#frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent added a comment.


  it depends against https://phabricator.kde.org/D8332.diff too

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent added a comment.


  depend against https://phabricator.kde.org/D8366 too...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

2017-10-30 Thread Michal Malý 
madcatx added a comment.


  What is the status on upstreaming this? Is there anything else you need from 
me to finish this off?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D8387

To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter, graesslin, z3ntu

D8348: Add a section for removable devices

2017-10-30 Thread Laurent Montel 
mlaurent added a dependent revision: D8367: Hidding place groups implementation 
in KFilePlacesModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

2017-10-30 Thread Laurent Montel 
mlaurent added a dependent revision: D8367: Hidding place groups implementation 
in KFilePlacesModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8366

To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-30 Thread Renato Oliveira Filho 
renatoo added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesmodel.cpp:476
> Either reorder the enum or change for a different (more explicit not relying 
> on enum storage) comparison operator to have the "right" order. By right 
> order I assume the goal was to align with Dolphin which does: Places / 
> Recently Saved / Search For / Devices.
> 
> Currently we have a different order:  Places / Search For / Recently Saved / 
> Devices.

Are you fine If I set values for enums? Something like:

  enum GroupType
  {
  PlacesType = 100,
  RecentlySavedType = 200,
  SearchForType = 300,
  DevicesType = 400,
  RemovableDeviceType = 500,
  NetworkType = 600
  };

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-30 Thread Kevin Ottens 
ervin added a comment.


  Looks fine code wise now, just a couple more tweaks to make those sections 
look closer to what Dolphin got.

INLINE COMMENTS

> kfileplacesmodel.cpp:476
> +[](KFilePlacesItem *itemA, KFilePlacesItem *itemB) {
> +   return (itemA->groupType() < itemB->groupType());
> +});

Either reorder the enum or change for a different (more explicit not relying on 
enum storage) comparison operator to have the "right" order. By right order I 
assume the goal was to align with Dolphin which does: Places / Recently Saved / 
Search For / Devices.

Currently we have a different order:  Places / Search For / Recently Saved / 
Devices.

> kfileplacesview.cpp:458
> +{
> +return QApplication::fontMetrics().height();
> +}

With again the goal to get closer to Dolphin's rendering, its section headers 
are higher. The text size you use is correct during drawing but they happen to 
have much more white space before and a bit more after giving it some more 
breath.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent updated this revision to Diff 21572.
mlaurent added a comment.


  We can't use qAsConst as it's a qt5.8 macro.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=21290=21572

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-30 Thread Laurent Montel 
mlaurent edited the summary of this revision.
mlaurent added dependencies: D8366: Factoring out lists of url data within 
KFilePlacesModelTest, D8348: Add a section for removable devices, D8332: Added 
baloo urls into places model.

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks

D8332: Added baloo urls into places model

2017-10-30 Thread Laurent Montel 
mlaurent added a dependent revision: D8367: Hidding place groups implementation 
in KFilePlacesModel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham
Cc: usta, mlaurent, dvratil, ngraham, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Albert Astals Cid 
aacid resigned from this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  This change is much less invasive than before, i'm not giving a +1 since i 
don't immediately understand why this fixes things and since i don't have time 
to investigate it, i'm removing my -1

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Emirald Mateli 
emateli retitled this revision from "fix createKMessageBox focus button 
inconsistency" to "fix createKMessageBox focus widget inconsistency".

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus button inconsistency

2017-10-30 Thread Emirald Mateli 
emateli retitled this revision from "createKMessageBox tries to focus a default 
button when available" to "fix createKMessageBox focus button inconsistency".
emateli edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Nathaniel Graham 
ngraham set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D8098: Strip down and re-write the tags KIO slave.

2017-10-30 Thread James Smith 
smithjd updated this revision to Diff 21590.
smithjd added a comment.


  - Fix generating previews copies the file to tmp.
  - Fix tag navigation display labels in Dolphin.
  - Stricter url validation.
  
  1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the 
tags KIO slave. #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  This revision reverts the preview fix. There is an open bug 
(https://bugs.kde.org/show_bug.cgi?id=194181) about dolphin/KIO leaving around 
temp files.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8098?vs=20362=21590

BRANCH
  master-nestedTags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8098

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/tags/kio_tags.h
  src/kioslaves/tags/tags.protocol

To: smithjd, #frameworks, vhanda, #dolphin, ngraham
Cc: nicolasfella, ngraham

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks @aacid. Any remaining objections to landing this?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D8098: Strip down and re-write the tags KIO slave.

2017-10-30 Thread James Smith 
smithjd updated this revision to Diff 21599.
smithjd added a comment.


  - Create a full url instead of only a path.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8098?vs=21590=21599

BRANCH
  master-nestedTags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D8098

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/tags/kio_tags.h
  src/kioslaves/tags/tags.protocol

To: smithjd, #frameworks, vhanda, #dolphin, ngraham
Cc: nicolasfella, ngraham

D8527: Display "Downloaded From" by default, if file supports it

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  Do any Dolphin people object? If not, I'll land this in a few days (sooner if 
I get some more thumbs up :) ).

REPOSITORY
  R824 Baloo Widgets

BRANCH
  origin_url_386261

REVISION DETAIL
  https://phabricator.kde.org/D8527

To: ngraham, #dolphin, #frameworks, broulik, dfaure, markg, vhanda
Cc: vhanda, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D8528: Consider DjVu files to be documents

2017-10-30 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2e80367435cc: Consider DjVu files to be documents 
(authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8528?vs=21461=21597#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8528?vs=21461=21597

REVISION DETAIL
  https://phabricator.kde.org/D8528

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: ngraham, vhanda, #frameworks, rkflx
Cc: rkflx, #frameworks

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

2017-10-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/36/
 Project:
Frameworks baloo kf5-qt5 XenialQt5.7
 Date of build:
Tue, 31 Oct 2017 02:26:30 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(12/12)77%
(111/144)77%
(111/144)73%
(5039/6932)50%
(2613/5194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(42/42)89%
(16/18)autotests.integration100%
(3/3)100%
(3/3)95%
(242/255)64%
(140/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(40/40)57%
(25/44)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(736/736)53%
(390/740)autotests.unit.file100%
(11/11)100%
(11/11)97%
(788/809)51%
(438/864)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(315/326)52%
(156/302)src.codecs100%
(5/5)100%
(5/5)87%
(120/138)76%
(32/42)src.engine97%
(38/39)97%
(38/39)79%
(1607/2038)58%
(796/1379)src.file39%
(17/44)39%
(17/44)45%
(678/1506)38%
(374/980)src.file.extractor100%
(2/2)100%
(2/2)69%
(20/29)58%
(7/12)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(22/22)61%
(11/18)src.lib55%
(6/11)55%
(6/11)43%
(429/991)40%
(228/575)

Re: Frameworks release schedule?

2017-10-30 Thread Albert Astals Cid 
El dijous, 26 d’octubre de 2017, a les 11:52:39 CET, laurent Montel va 
escriure:
> Le jeudi 26 octobre 2017, 01:19:02 CEST Valorie Zimmerman a écrit :
> > On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter  wrote:
> > > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel  wrote:
> > >> Hi,
> > >> I send this email to kde-frameworks-devel
> > >> 
> > >> It's the correct ML for having an answer about it
> > >> 
> > >> Regards.
> > 
> > Hi Laurent, I thought that frameworks-devel was being deprecated but I
> > guess I'm out of the loop. So thanks.
> 
> Hi,
> for me it's kde-devel which is deprecated as you can see David is not in
> kde- devel. It's for that I added kfd :)

That's his decision.

Don't bullshit saying kde-devel is a deprecated list.

Cheers,
  Albert


> 
> Regards
> 
> > >> Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit :
> > >>> Hello folks, with my Kubuntu release manager hat on, I was filling in
> > >>> the calendar for the next 6 months. For Frameworks, this page:
> > >>> https://community.kde.org/Schedules/Frameworks is now on a provisional
> > >>> schedule - 5.40 (expected) Sat November 4th, 2017 for tagging,
> > >>> (expected) Sat November 11th, 2017.
> > >>> 
> > >>> Is the schedule for the next 6 months still undecided, or has the wiki
> > >>> page just not been filled in yet?
> > > 
> > > "... and so on. Until further notice: tagging happens the first
> > > saturday of every month, and the public release is one week later."
> > > 
> > > That generally holds true unless something causes or needs an
> > > extraordinary delay (which in the past has never been more than a
> > > couple of days).
> > > 
> > > HS
> > 
> > Thanks Harald!
> > 
> > Valorie

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

2017-10-30 Thread Albert Astals Cid 
El dissabte, 28 d’octubre de 2017, a les 19:14:26 CET, David Faure va 
escriure:
> On dimanche 24 septembre 2017 23:16:27 CEST Albert Astals Cid wrote:
> > El diumenge, 24 de setembre de 2017, a les 14:55:37 CEST, Milian Wolff va
> > 
> > escriure:
> > > Hey all,
> > > 
> > > I'm trying to get set a sane tabstop order for the record page of
> > > hotspot.
> > 
> > BTW I could not fint any "hotspot" in https://cgit.kde.org/
> 
> It's at https://github.com/KDAB/hotspot

Ah, not a KDE project.

Sadly my todo list for KDE projects is too long to find time to help non-KDE 
projects :)

Cheers,
  Albert

D8348: Add a section for removable devices

2017-10-30 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21584.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21296=21584

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-30 Thread Renato Oliveira Filho 
renatoo marked 3 inline comments as done.
renatoo added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesmodel.cpp:476
> Either reorder the enum or change for a different (more explicit not relying 
> on enum storage) comparison operator to have the "right" order. By right 
> order I assume the goal was to align with Dolphin which does: Places / 
> Recently Saved / Search For / Devices.
> 
> Currently we have a different order:  Places / Search For / Recently Saved / 
> Devices.

Fixed enum order and set values for it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8332: Added baloo urls into places model

2017-10-30 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21583.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8332?vs=21227=21583

REVISION DETAIL
  https://phabricator.kde.org/D8332

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesview.cpp

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham
Cc: usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'shared' section

2017-10-30 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21585.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8434?vs=21297=21585

REVISION DETAIL
  https://phabricator.kde.org/D8434

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-30 Thread Renato Oliveira Filho 
renatoo updated this revision to Diff 21582.
renatoo added a comment.


  Updated visuals to match dolphin

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=21226=21582

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8434: Created 'shared' section

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  +1 for the idea! Needs more screenshots. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks