Hallo,
I'm packaging krunner 5.39.0 for GNU Guix [1]. GNU Guix builds all
software in an isolated environment (a container), which includes only
the packages and tools specified explicitly.
When running the tests, dbusrunnertest faills, with this notable warning
and the error show below:
dfaure added inline comments.
INLINE COMMENTS
> kio_tags.cpp:64
> +QString tag;
> +tag = url.path().section(QLatin1Char('?'), 0, 0);
> +while (tag.startsWith(QDir::separator()))
- merge with previous line
- can path() really contain '?' ? I thought that wasn't possible (? delimits
dfaure requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfella, ngraham
dfaure added a comment.
Thanks for the fix and autotest !
INLINE COMMENTS
> kautosavefiletest.cpp:83
> {
> -// TODO
> +QUrl normalFile = QUrl::fromLocalFile(QStringLiteral("/tmp/test
> directory/tîst me.txt"));
> +
Should use QDir::tempPath() for portability.
REPOSITORY
R244
rjvbb set the repository for this revision to R39 KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8544
To: rjvbb, #frameworks
Cc: cullmann, kde-frameworks-devel, kevinapavew, demsking, head7, kfunk, sars,
dhaumann
rjvbb updated this revision to Diff 21724.
rjvbb added a comment.
This simpler version also seems to do the trick for me (read: I haven't been
able to get "it" to crash).
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8544?vs=21519=21724
REVISION DETAIL
amantia added a dependent revision: D8493: Make Folder View screen aware.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks,
ngraham added a comment.
@dvratil and @ervin, any more concerns?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
ngraham accepted this revision.
ngraham added a comment.
Lovely. Looks good to me, too!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff
Cc: elvisangelaccio, mwolff, mlaurent, #frameworks
renatoo added a dependent revision: D8434: Created 'remote' section.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
renatoo edited the summary of this revision.
renatoo added dependencies: D8332: Added baloo urls into places model, D8348:
Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff
Cc:
renatoo added a dependent revision: D8434: Created 'remote' section.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
ngraham added a comment.
Can you add "Depends on D" for each other patch that this requires?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff
Cc: elvisangelaccio, mwolff, mlaurent, #frameworks
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm, but please wait a bit, maybe someone else wants to chime in?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin,
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If https://phabricator.kde.org/D7424 goes in, we'll have to update the
default colors in KConfigWidgets. This does that.
Depends on
ngraham added reviewers: Frameworks, broulik, VDG.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D8592
To: ngraham, #frameworks, broulik, #vdg
Cc: #frameworks
renatoo updated this revision to Diff 21697.
renatoo added a comment.
Added more test cases
Renamed enum to match group name
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21694=21697
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED
mwolff added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:784
> +// insert a new network url
> +m_places->addPlace(QStringLiteral("My Shared"), QUrl(
> QStringLiteral("ftp://192.168.1.1/ftp;)), QString(), QString(),
> QModelIndex());
> +
please add URLs for the
renatoo updated this revision to Diff 21694.
renatoo added a comment.
Created unit test for remote ulrs
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21693=21694
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
volkov added a comment.
Could you try to test it without + 5 and with the following change applied?
https://phabricator.kde.org/D8590 ?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7787
To: wojnilowicz, #frameworks
Cc: volkov, cfeck, tbaumgart, #kmymoney
wojnilowicz resigned from this revision.
wojnilowicz added a comment.
I resign because I don't maintain KPageListView.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8590
To: volkov, cfeck, wojnilowicz
Cc: #frameworks
ngraham added a comment.
+1 on Remote.
We really need to remove the duplicated Places test that's the header for the
whole widget, though.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, mwolff,
renatoo added a comment.
In https://phabricator.kde.org/D8434#162786, @mwolff wrote:
> Well, but if we use `Network` for `remote://` already, then the group
should also have this label, no? I don't see an issue with this, really. On the
contrary - maybe we could in the future remove the
volkov added a reviewer: wojnilowicz.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8590
To: volkov, cfeck, wojnilowicz
Cc: #frameworks
renatoo retitled this revision from "Created 'shared' section" to "Created
'remote' section".
renatoo edited the summary of this revision.
renatoo edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham,
renatoo updated this revision to Diff 21693.
renatoo added a comment.
Renamed section from 'sared' to 'remote'
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21649=21693
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
volkov added a reviewer: cfeck.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8590
To: volkov, cfeck
Cc: #frameworks
mwolff added a comment.
But thinking 5s more about it, I personally would say that using "Remote" for
the category would be OK for now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, mwolff,
mwolff added a comment.
Well, but if we use `Network` for `remote://` already, then the group should
also have this label, no? I don't see an issue with this, really. On the
contrary - maybe we could in the future remove the `remote://` link and let the
category header react to a click,
volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
In particular its font can be changed by Breeze style that
modifies bold fonts to regular when it polishes list views.
REPOSITORY
R236
renatoo added a comment.
In https://phabricator.kde.org/D8434#162727, @mwolff wrote:
> lgtm overall. but I wonder about the naming choice. "Shared" is confusing,
to me personally at least. Why not call it "Remote" or "Network"? The reasoning
is that "shared" for me is only LAN/WLAN
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8434#162727, @mwolff wrote:
> lgtm overall. but I wonder about the naming choice. "Shared" is confusing,
to me personally at least. Why not call it "Remote" or "Network"? The reasoning
is that "shared" for me is only
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot, progwolff,
lesliezhai,
mwolff added a comment.
lgtm overall. but I wonder about the naming choice. "Shared" is confusing, to
me personally at least. Why not call it "Remote" or "Network"? The reasoning is
that "shared" for me is only LAN/WLAN shared stuff, while "remote://" allows
arbitrary remote links. I use it
amantia updated this revision to Diff 21682.
amantia added a comment.
Add signals instead of a new virtual method (that is not BIC). This also
makes us not rely on screen name, but only on plasma-internal screen id.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
amantia added a comment.
@broulik Very good point, luckily I reworked it.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot,
broulik added a comment.
This class is exported, you cannot add a new virtual to it.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks,
amantia updated this revision to Diff 21679.
amantia added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Fix API docs text
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
dhaumann added inline comments.
INLINE COMMENTS
> ervin wrote in corona.h:223
> "if there is no such screen" I guess?
And it is @return and not @returns.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil,
39 matches
Mail list logo
