KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 02:20:36 + Build duration: 5 min 43 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 02:20:36 + Build duration: 3 min 9 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON
ngraham added a comment. We have a report in the wild that this broke compiling KWin with CMake 3.10.x for someone on Gentoo: https://bugs.kde.org/show_bug.cgi?id=387983 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: ngraham, #frameworks
D9387: Add cross compile support for kconfig_compiler and kconf_update.
apol added a comment. Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with kconfigcompiler though, at the moment it's not. Here's the android scripts for reference. https://cgit.kde.org/sysadmin/ci-tooling.git/tree/system-images/android/sdk REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9387 To: habacker, dfaure, ltoscano, bcooksley, apol Cc: apol, #frameworks
D9387: Add cross compile support for kconfig_compiler and kconf_update.
bcooksley added a reviewer: apol. bcooksley added a subscriber: apol. bcooksley added a comment. I believe @apol was doing things along these lines for his Android work. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9387 To: habacker, dfaure, ltoscano, bcooksley, apol Cc: apol, #frameworks
D7706: Use runtime install prefix instead of compile time install prefix.
bcooksley added a comment. This is also a duplicate as mentioned on the other reviews? REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure, ltoscano, bcooksley Cc: dfaure, #frameworks
D7708: Use runtime install prefix instead of compile time install prefix.
bcooksley added a comment. This is a duplicate of https://phabricator.kde.org/D7706 and https://phabricator.kde.org/D9384 no? REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano, bcooksley Cc: #frameworks
D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.
bcooksley added a comment. From my understanding of this on Linux/FreeBSD the install destinations for these binaries are different. On Windows you should have one install prefix per application and you can't mix Qt versions in an application. So i'm not seeing how we end up with a clash here? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To: habacker, dfaure, ltoscano, bcooksley Cc: bcooksley, dfaure, aacid, #frameworks
D9384: Use runtime install prefix instead of compile time install prefix.
bcooksley added a comment. I'll leave this to someone with more experience with the kdeinit codebase to approve, but agree that this does need to be made relocatable. This patch will probably fix a whole pile of tests on CI. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks
D9383: Use correct service executable path for installing kwalletd dbus service on Win32
bcooksley requested changes to this revision. bcooksley added a comment. This revision now requires changes to proceed. Rather than writing the content of the file out from CMakeLists it should probably be a template as well, even if it's a second file. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D9383 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.
cgiboudeaux added a comment. This will have effects on the non-kio users : https://lxr.kde.org/search?_string=kio_http_cache_cleaner REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure, ltoscano, bcooksley Cc: cgiboudeaux, #frameworks
D9387: Add cross compile support for kconfig_compiler and kconf_update.
habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Cross compiling client packages which require kconfig_compiler or kconf_update want want the native tool, not the cross compiled variant. The native tool is provided by a dedicated cmake variable. TEST PLAN cross-compiled client package REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D9387 AFFECTED FILES KF5ConfigConfig.cmake.in src/kconf_update/CMakeLists.txt src/kconfig_compiler/CMakeLists.txt To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D9386: Mingw32 compile fix
habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add missing method Solid::NetworkingPrivate::serviceOwnerChanged(). TEST PLAN cross compiled REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9386 AFFECTED FILES src/solid/networking_p.h src/solid/networking_win.cpp To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D9384: Use runtime install prefix instead of compile time install prefix.
habacker edited the summary of this revision. habacker edited the test plan for this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks
D9384: Use runtime install prefix instead of compile time install prefix.
habacker added reviewers: ltoscano, bcooksley, dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks
D9384: Use runtime install prefix instead of compile time install prefix.
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9384 AFFECTED FILES src/kdeinit/kinit_win.cpp To: habacker Cc: #frameworks
D9383: Use correct service executable path for installing kwalletd dbus service on Win32
habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Windows service executables are installed in the same directory as normal executables and therefore need to be specified without any path component, which is not provided with the original template. TEST PLAN cross compiled and tested by inspecting the resulting file REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9383 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.
habacker added reviewers: ltoscano, bcooksley. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.
habacker added reviewers: ltoscano, bcooksley. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To: habacker, dfaure, ltoscano, bcooksley Cc: bcooksley, dfaure, aacid, #frameworks
D7706: Use runtime install prefix instead of compile time install prefix.
habacker added reviewers: ltoscano, bcooksley. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure, ltoscano, bcooksley Cc: dfaure, #frameworks
D7708: Use runtime install prefix instead of compile time install prefix.
habacker added a reviewer: bcooksley. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano, bcooksley Cc: #frameworks
D7708: Use runtime install prefix instead of compile time install prefix.
habacker added a reviewer: ltoscano. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano Cc: #frameworks
D9381: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compiled kwallet REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9381 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: habacker, dfaure Cc: #frameworks
D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.
habacker added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To: habacker, dfaure Cc: bcooksley, dfaure, aacid, #frameworks
D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.
habacker added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure Cc: #frameworks
Debug category file installation
Hello,
thanks to kdebugsettings and category files, now it is possible to easily
enable/disable debugging at runtime. However, there are a few shortcomings to
this approach, which emerged when I tried to package KF5 5.41 for openSUSE:
1. There should be a macro in ECM to unify the installation of those files
2. The .categories files are not configuration data and should be installed
below SHARE_INSTALL_PREFIX instead
3. In case of library upgrades (say, in KF6 times), those files would conflict
in their current location (this wouldn't affect applications, however)
For 1, a solution would be to either extend ECMQtDeclareLoggingCategory to
generate the category files, and install them, or have a separate macro to
collect and install separately the category files (useful for projects with
multiple ones like KDevelop, where they are defined for each lib/plugin
subdirectory). 2. and 3. Would be solved by having either a subdirectory
("kf5"? But I understand Plasma and Applications use the same mechanism, so
probably something else would be needed) to SHARE_INSTALL_PREFIX.
Opinions?
signature.asc
Description: This is a digitally signed message part.
D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)
cgilles added a comment. What's about this very important entry to improve Solid support under MacOS ? It will be integrated officially soon ? Gilles Caulier REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: kfunk, anthonyfieroni, cgilles, kde-mac
D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()
nicolasfella added a comment. Now it does. Awesome! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks
D9377: Highlighting indexer: Enable errors
This revision was automatically updated to reflect the committed changes. Closed by commit R216:f521183c4cc2: Highlighting indexer: Enable errors (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9377?vs=24027=24028 REVISION DETAIL https://phabricator.kde.org/D9377 AFFECTED FILES data/syntax/rmarkdown.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9377: Highlighting indexer: Enable errors
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH EnableErrors (branched from master) REVISION DETAIL https://phabricator.kde.org/D9377 To: dhaumann, vkrause Cc: #frameworks
D9377: Highlighting indexer: Enable errors
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Erros include: - missing contexts - duplicate contexts - missing itemDatas - missing keyword lists - duplicate keyowrd lists Warnings include: - unused contexts - unused itemDatas - unused keyword lists TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH EnableErrors (branched from master) REVISION DETAIL https://phabricator.kde.org/D9377 AFFECTED FILES data/syntax/rmarkdown.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9374: Highlighting indexer: report unused itemDatas and missing itemDatas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:412f5a7e705c: Highlighting indexer: report unused itemDatas and missing itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9374?vs=24020=24025 REVISION DETAIL https://phabricator.kde.org/D9374 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6b9c12981391: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9375?vs=24021=24026 REVISION DETAIL https://phabricator.kde.org/D9375 AFFECTED FILES data/syntax/lilypond.xml data/syntax/metafont.xml data/syntax/rhtml.xml To: dhaumann, vkrause Cc: #frameworks
D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9cdf1bee0dd3: Prolog, RelaxNG, RMarkDown: Fix highlighting issues (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9376?vs=24023=24024#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9376?vs=24023=24024 REVISION DETAIL https://phabricator.kde.org/D9376 AFFECTED FILES data/syntax/prolog.xml data/syntax/relaxng.xml data/syntax/rmarkdown.xml To: dhaumann, vkrause Cc: #frameworks
D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixMoreXmlFiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D9375 To: dhaumann, vkrause Cc: #frameworks
D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixRemaining (branched from master) REVISION DETAIL https://phabricator.kde.org/D9376 To: dhaumann, vkrause Cc: #frameworks
D9374: Highlighting indexer: report unused itemDatas and missing itemDatas
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixMoreHls (branched from master) REVISION DETAIL https://phabricator.kde.org/D9374 To: dhaumann, vkrause Cc: #frameworks
D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixRemaining (branched from master) REVISION DETAIL https://phabricator.kde.org/D9376 AFFECTED FILES data/syntax/prolog.xml data/syntax/relaxng.xml data/syntax/rmarkdown.xml To: dhaumann, vkrause Cc: #frameworks
D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixMoreXmlFiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D9375 AFFECTED FILES data/syntax/lilypond.xml data/syntax/metafont.xml data/syntax/rhtml.xml To: dhaumann, vkrause Cc: #frameworks
D9374: Highlighting indexer: report unused itemDatas and missing itemDatas
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With this patch, all issues are revealed, and not only missing itemDatas. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixMoreHls (branched from master) REVISION DETAIL https://phabricator.kde.org/D9374 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9373: Haml: Fix invalid and unused itemDatas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:91ca8ca39f66: Haml: Fix invalid and unused itemDatas (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9373?vs=24017=24018 REVISION DETAIL https://phabricator.kde.org/D9373 AFFECTED FILES data/syntax/haml.xml To: dhaumann, vkrause Cc: #frameworks
D9373: Haml: Fix invalid and unused itemDatas
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixHaml (branched from master) REVISION DETAIL https://phabricator.kde.org/D9373 To: dhaumann, vkrause Cc: #frameworks
D9373: Haml: Fix invalid and unused itemDatas
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixHaml (branched from master) REVISION DETAIL https://phabricator.kde.org/D9373 AFFECTED FILES data/syntax/haml.xml To: dhaumann, vkrause Cc: #frameworks
D9372: ObjectiveC++: Remove duplicate comment contexts
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b80748a58293: ObjectiveC++: Remove duplicate comment contexts (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9372?vs=24014=24015 REVISION DETAIL https://phabricator.kde.org/D9372 AFFECTED FILES data/syntax/objectivecpp.xml To: dhaumann, vkrause Cc: #frameworks
D9372: ObjectiveC++: Remove duplicate comment contexts
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH RemoveDuplicateCommentContexts (branched from master) REVISION DETAIL https://phabricator.kde.org/D9372 To: dhaumann, vkrause Cc: #frameworks
D9372: ObjectiveC++: Remove duplicate comment contexts
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The context "Commentar 1" was the same as "SingleLineComment". The context "Commentar 2" was the same as "MultiLineComment". This patch cleans this up and removes the Commentar contexts in favor of the others. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH RemoveDuplicateCommentContexts (branched from master) REVISION DETAIL https://phabricator.kde.org/D9372 AFFECTED FILES data/syntax/objectivecpp.xml To: dhaumann, vkrause Cc: #frameworks
D9371: Diff, ObjectiveC++: Cleanups and fix highlighting files
This revision was automatically updated to reflect the committed changes. Closed by commit R216:da6d5a7cc33a: Diff, ObjectiveC++: Cleanups and fix highlighting files (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9371?vs=24012=24013 REVISION DETAIL https://phabricator.kde.org/D9371 AFFECTED FILES data/syntax/diff.xml data/syntax/objectivecpp.xml To: dhaumann, vkrause Cc: #frameworks
D9371: Diff, ObjectiveC++: Cleanups and fix highlighting files
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixDiff (branched from master) REVISION DETAIL https://phabricator.kde.org/D9371 To: dhaumann, vkrause Cc: #frameworks
D9371: Diff, ObjectiveC++: Cleanups and fix highlighting files
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixDiff (branched from master) REVISION DETAIL https://phabricator.kde.org/D9371 AFFECTED FILES data/syntax/diff.xml data/syntax/objectivecpp.xml To: dhaumann, vkrause Cc: #frameworks
D9370: Stata highlighting: Remove unused itemData and fix non-existing attribute
This revision was automatically updated to reflect the committed changes. Closed by commit R216:00cbdc0fdc7d: Stata highlighting: Remove unused itemData and fix non-existing attribute (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9370?vs=24009=24010 REVISION DETAIL https://phabricator.kde.org/D9370 AFFECTED FILES data/syntax/stata.xml To: dhaumann, vkrause Cc: #frameworks
D9370: Stata highlighting: Remove unused itemData and fix non-existing attribute
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixStata (branched from master) REVISION DETAIL https://phabricator.kde.org/D9370 To: dhaumann, vkrause Cc: #frameworks
D9370: Stata highlighting: Remove unused itemData and fix non-existing attribute
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixStata (branched from master) REVISION DETAIL https://phabricator.kde.org/D9370 AFFECTED FILES data/syntax/stata.xml To: dhaumann, vkrause Cc: #frameworks
D9369: XML (Debug): Fix incorrect DetectChar rule
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b58763275dfd: XML (Debug): Fix incorrect DetectChar rule (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9369?vs=24007=24008 REVISION DETAIL https://phabricator.kde.org/D9369 AFFECTED FILES data/syntax/xmldebug.xml To: dhaumann, vkrause Cc: #frameworks
D9369: XML (Debug): Fix incorrect DetectChar rule
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixXmlDebug (branched from master) REVISION DETAIL https://phabricator.kde.org/D9369 To: dhaumann, vkrause Cc: #frameworks
D9369: XML (Debug): Fix incorrect DetectChar rule
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The fix is to simply remove the parts of the char that were ignored anyways. Whether this is the correct patch is up for discussion - but since noone complained for years, this is possibly not a big issue anyways. And: the XML (Debug) file does not have any extension nor mimetype, so we can safely say essentially noone is using this... Fixes: checkSingleChars: xmldebug.xml" line 130 'char' must contain exactly one char: "\"(\\s+|$)" checkSingleChars: xmldebug.xml" line 135 'char' must contain exactly one char: "'(\\s+|$)" checkSingleChars: xmldebug.xml" line 374 'char' must contain exactly one char: "\"(\\s+|$)" checkSingleChars: xmldebug.xml" line 379 'char' must contain exactly one char: "'(\\s+|$)" checkSingleChars: xmldebug.xml" line 416 'char' must contain exactly one char: "\"(\\s+|$)" checkSingleChars: xmldebug.xml" line 421 'char' must contain exactly one char: "'(\\s+|$)" checkSingleChars: xmldebug.xml" line 468 'char' must contain exactly one char: "\"(\\s+|$)" checkSingleChars: xmldebug.xml" line 473 'char' must contain exactly one char: "'(\\s+|$)" TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH FixXmlDebug (branched from master) REVISION DETAIL https://phabricator.kde.org/D9369 AFFECTED FILES data/syntax/xmldebug.xml To: dhaumann, vkrause Cc: #frameworks
D9361: Highlighting Indexer: Support cross-hl context checking
This revision was automatically updated to reflect the committed changes. Closed by commit R216:ec49a95d0959: Highlighting Indexer: Support cross-hl context checking (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9361?vs=24003=24004 REVISION DETAIL https://phabricator.kde.org/D9361 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause, cullmann Cc: #frameworks
D9361: Highlighting Indexer: Support cross-hl context checking
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH FixIncludeRulesCheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D9361 To: dhaumann, vkrause, cullmann Cc: #frameworks
D9361: Highlighting Indexer: Support cross-hl context checking
dhaumann updated this revision to Diff 24003. dhaumann added a comment. Cleanups - ContextChecker::check(): use 'success' bool correctly (was unused before) - remove m_ for member variables in the Language helper class - turn firstContext into a bool and immediately add the first context to the usedContextList REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9361?vs=23989=24003 BRANCH FixIncludeRulesCheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D9361 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause, cullmann Cc: #frameworks
D8519: do not make the context menu a Window
This revision was automatically updated to reflect the committed changes. Closed by commit R289:f2f65dee2962: do not make the context menu a Window (authored by mkoller). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8519?vs=21431=23999 REVISION DETAIL https://phabricator.kde.org/D8519 AFFECTED FILES src/kstatusnotifieritem.cpp To: mkoller, davidedmundson, graesslin Cc: #frameworks
D8519: do not make the context menu a Window
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8519 To: mkoller, davidedmundson, graesslin Cc: #frameworks
D8519: do not make the context menu a Window
mkoller added a comment. Ping! Anything wrong with this 2 liner patch ? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8519 To: mkoller, davidedmundson, graesslin Cc: #frameworks
D9361: Highlighting Indexer: Support cross-hl context checking
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH FixIncludeRulesCheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D9361 To: dhaumann, vkrause, cullmann Cc: #frameworks
