dhaumann accepted this revision.
dhaumann added a comment.
Good enough :)
INLINE COMMENTS
> highlighter.cpp:487
> +QStringList suggestions = d->spellchecker->suggest(word);
> +if (max != -1 && suggestions.count() > max) {
> +suggestions = suggestions.mid(0, max);
I am not a
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
InvalidFallthroughContext (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9493
To: dhaumann, vkrause, cullmann
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d84035c61eac: Highlighting indexer: Warn about empty
attributes (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0f2335f3edc0: Fix compilation (authored by safaalfulaij).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7660?vs=24349=24361
REVISION DETAIL
dhaumann added inline comments.
INLINE COMMENTS
> dfaure wrote in highlighter.h:134
> The -1 special value is documented here, but yeah, special values are bad.
>
> In practice SpellCheckDecorator calls this with the default value anyway.
>
> And I guess any GUI will always want to limit this,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Sun, 24 Dec 2017 20:13:22 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/69/
Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 24 Dec 2017 20:13:22 +
Build duration:
41 min and counting
JUnit
bcooksley added a comment.
Can the compile fix please be committed?
Otherwise we need to revert the entire patch to ensure Frameworks remains
buildable.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein,
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:79ca6ce4ec6a: Highlighting indexer: Warn about context
switch fallthroughContext=#stay (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/25/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Sun, 24 Dec 2017 20:13:22 +
Build duration:
7 min 33 sec and counting
JUnit Tests
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
CheckEmptyAttribute (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9494
To: dhaumann, vkrause
Cc: #frameworks
dfaure added inline comments.
INLINE COMMENTS
> highlighter.h:134
> * @param max at most this many suggestions will be returned. If this is
> *-1, as many suggestions as the spell backend supports will
> *be returned.
The -1 special value is documented
dfaure added a comment.
Please don't set LD_LIBRARY_PATH, it prevents running stuff from the builddir
when hacking (I just added a note about that to
https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/29/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 25 Dec 2017 03:42:08 +
Build duration:
14 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/49/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 25 Dec 2017 03:42:08 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/50/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 25 Dec 2017 03:42:08 +
Build duration:
21 min and counting
JUnit Tests
Name: (root)
16 matches
Mail list logo