D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

2017-12-24 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. Good enough :) INLINE COMMENTS > highlighter.cpp:487 > +QStringList suggestions = d->spellchecker->suggest(word); > +if (max != -1 && suggestions.count() > max) { > +suggestions = suggestions.mid(0, max); I am not a

D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"

2017-12-24 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH InvalidFallthroughContext (branched from master) REVISION DETAIL https://phabricator.kde.org/D9493 To: dhaumann, vkrause, cullmann Cc: #frameworks

D9494: Highlighting indexer: Warn about empty attributes

2017-12-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:d84035c61eac: Highlighting indexer: Warn about empty attributes (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7660: Fix a regression caused by changing backspace key behavior

2017-12-24 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0f2335f3edc0: Fix compilation (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=24349=24361 REVISION DETAIL

D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

2017-12-24 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > dfaure wrote in highlighter.h:134 > The -1 special value is documented here, but yeah, special values are bad. > > In practice SpellCheckDecorator calls this with the default value anyway. > > And I guess any GUI will always want to limit this,

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 24 - Unstable!

2017-12-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Dec 2017 20:13:22 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 69 - Still unstable!

2017-12-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/69/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 24 Dec 2017 20:13:22 + Build duration: 41 min and counting JUnit

D7660: Fix a regression caused by changing backspace key behavior

2017-12-24 Thread Ben Cooksley
bcooksley added a comment. Can the compile fix please be committed? Otherwise we need to revert the entire patch to ensure Frameworks remains buildable. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein,

D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"

2017-12-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:79ca6ce4ec6a: Highlighting indexer: Warn about context switch fallthroughContext=#stay (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 25 - Unstable!

2017-12-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sun, 24 Dec 2017 20:13:22 + Build duration: 7 min 33 sec and counting JUnit Tests

D9494: Highlighting indexer: Warn about empty attributes

2017-12-24 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH CheckEmptyAttribute (branched from master) REVISION DETAIL https://phabricator.kde.org/D9494 To: dhaumann, vkrause Cc: #frameworks

D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

2017-12-24 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > highlighter.h:134 > * @param max at most this many suggestions will be returned. If this is > *-1, as many suggestions as the spell backend supports will > *be returned. The -1 special value is documented

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

2017-12-24 Thread David Faure
dfaure added a comment. Please don't set LD_LIBRARY_PATH, it prevents running stuff from the builddir when hacking (I just added a note about that to https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

2017-12-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 25 Dec 2017 03:42:08 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

2017-12-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Dec 2017 03:42:08 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 50 - Still Unstable!

2017-12-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/50/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 25 Dec 2017 03:42:08 + Build duration: 21 min and counting JUnit Tests Name: (root)