D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Hi!!, Code updated. Please let me know any changes are there yet to be done Regards. VM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the groundwork for resolving it? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the groundwork for resolving it? No, it's more a change similar to proposed fix for that bug (don't set a stylename in KFontRequester). This patch implements the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 24488. simgunz marked 8 inline comments as done. simgunz added a comment. - Avoid cast by using member var to proxyModel - Initialize m_proxyModel to null pointer - Add access method to m_proxyModel, use it to avoid cast - Remove unuseful returns,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. I found some time to implement the suggestions given by @dfaure and I removed all the static_cast. I haven't implemented any UI change for now. I think that if there are not problems we can land it as it is now, and then improve the UI in a second moment (in few

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24493. velurimithun added a comment. - Make necessary changes according to comments in https://phabricator.kde.org/D9420 Use QLatin1Char for char REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun marked 4 inline comments as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added a comment. I'm not sure it's Qt bug, it change behavior and now it doing in *right* way. So i'm patch to be merged +1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D9569: Fix wildcard matching for modelines

dhaumann added a reviewer: nalvarez. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9569 To: dhaumann, cullmann, kfunk, mwolff, nalvarez Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9569: Fix wildcard matching for modelines

brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. Heh. Fix looks obviously correct to me (good find), and tests are always nice. REPOSITORY R39 KTextEditor BRANCH TestModelines (branched from master) REVISION DETAIL

D9569: Fix wildcard matching for modelines

This revision was automatically updated to reflect the committed changes. Closed by commit R39:eff6bd61e2d7: Fix wildcard matching for modelines (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9569?vs=24503=24505 REVISION DETAIL

Re: Required Compiler for KDE Frameworks

El dissabte, 30 de desembre de 2017, a les 23:41:01 CET, Dominik Haumann va escriure: > Hi, > > on https://community.kde.org/Frameworks/Policies, it says: > > The following minimal compiler versions are supported > by KDE Frameworks: > > - GCC 4.6 > - Clang 3.1 > - VS2012 (MSVC11) >

Required Compiler for KDE Frameworks

Hi, on https://community.kde.org/Frameworks/Policies, it says: The following minimal compiler versions are supported by KDE Frameworks: - GCC 4.6 - Clang 3.1 - VS2012 (MSVC11) Is this list really up-do-date? Afaik, we even require VS2015 these days. What about the others? Also: Can

Re: Required Compiler for KDE Frameworks

On Sun, Dec 31, 2017 at 11:41 AM, Dominik Haumann wrote: > Hi, > > on https://community.kde.org/Frameworks/Policies, it says: > > The following minimal compiler versions are supported > by KDE Frameworks: > > - GCC 4.6 > - Clang 3.1 > - VS2012 (MSVC11) > > Is this list

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added inline comments. INLINE COMMENTS > kprocesstest.cpp:47 > p.setProcessChannelMode(QProcess::MergedChannels); > -p.start(gargv[0], QStringList() << QString::number(how) << > QStringLiteral("--nocrashhandler")); > +p.start(QString::fromLatin1(gargv[0]), QStringList() <<