Re: Possible regression in kio with data loss

On Tue, Feb 6, 2018 at 4:17 PM, Jaime wrote: > Hi all, this is becoming urgent if next release is this weekend. > It still happens to me (with kio just compiled from master) > If it is then add the KIO master (aka, David Faure) in cc :) As i just did. > > > 2018-02-05 8:18

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 3 min 23 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 8 min 16 sec and counting JUnit Tests

D10024: Add supportedSchemes feature

mwolff added a comment. I've committed this now. If someone tells me how to add KIOSK support, I can add that later on as needed REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/97/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 17 min and counting JUnit Tests Name: (root)

D10257: KUrlMimeData: fix handling of PreferLocalUrls

mwolff added inline comments. INLINE COMMENTS > kurlmimedata.cpp:67 > +QList uris; > +const QByteArray ba = > mimeData->data(QString::fromLatin1(s_kdeUriListMime)); > +// Code from qmimedata.cpp future cleanup: remove all the `QString::fromLatin1(s_...)` in this file with a call

D10335: balooctl monitor: Exit w/o valid dbus interface

alexeymin added a comment. `quit()` and `exit(0)` do the same thing - they all stop event loop, caused by `QCoreApplication::exec()`. And I don't understand how does timer help? What is happening without singleshot timer? INLINE COMMENTS > monitorcommand.cpp:55 > +m_out <<

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 9 min 20 sec and counting JUnit Tests

D10024: Add supportedSchemes feature

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6ab218dba91f: Add supportedSchemes feature (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10024?vs=25891=26632#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10045: remote: don't create entries with empty names

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4d153df7359c: remote: dont create entries with empty names (authored by mwolff). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10045?vs=26203=26633 REVISION DETAIL

D9207: Don't load KDE platform module in kglobalaccel5

mart added a comment. can this be resurrected? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/117/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 21 min and counting JUnit Tests Name: (root)

D9207: Don't load KDE platform module in kglobalaccel5

hein added a comment. Well, the maintainer spoke out against it, so not much I can do. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,

D10106: Relocate the Baloo database to the XDG cache location.

michaelh added a reviewer: Baloo. michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10106 To: smithjd, #baloo Cc: ltoscano, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, alexeymin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/116/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 22 min and counting JUnit Tests Name: (root)

D10325: RFC: [KFileWidget] Hide places frame and header

mart accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

broulik added a comment. > Would it be possible to show it as if it were locked? That would solve all the issues with it, right? I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly what I do here: void DolphinDockWidget::setLocked(bool lock) {

D7864: Basic support for PHP and Python fenced code blocks in Markdown

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Fine with me. The approach doesn't scale though, so maybe we need to look into better support for this kind of syntax nesting if we want this for many more languages here (similar

D10355: Use the new KPackage::fileUrl() method to load mainscripts.

malteveerman added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10355 To: malteveerman, #frameworks Cc: #frameworks, michaelh, ngraham

D10355: Use the new KPackage::fileUrl() method to load mainscripts.

malteveerman created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. malteveerman requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D10355

D10355: Use the new KPackage::fileUrl() method to load mainscripts.

malteveerman edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10355 To: malteveerman Cc: #frameworks, michaelh, ngraham

D10343: Create containment on specified screen

hoffmannrobert created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. hoffmannrobert requested review of this revision. REVISION SUMMARY Add methods used by Plasma::Containment *ShellCorona::addPanel(const QString )

D10339: Drop obsolete version checks

This revision was automatically updated to reflect the committed changes. Closed by commit R306:faf16778ea6b: Drop obsolete version checks (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10339?vs=26646=26660 REVISION DETAIL

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

kossebau added a comment. Makes sense to me to have a shorter version for the common case of just one registered plugin. Less boilerplate :) Please add a note in the API dox that this macro is for the case of just one plugin class, and link to K_PLUGIN_FACTORY_WITH_JSON for the case

D10343: Create containment on specified screen

hoffmannrobert edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

jtamate marked 2 inline comments as done. jtamate added a comment. So, good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks, dfaure Cc: fvogt, ngraham, michaelh

Re: Possible regression in kio with data loss

Hi all, this is becoming urgent if next release is this weekend. It still happens to me (with kio just compiled from master) 2018-02-05 8:18 GMT+01:00 Jaime : > > > 2018-02-04 23:42 GMT+01:00 Albert Astals Cid : > >> El dissabte, 20 de gener de 2018, a les

D10325: [KFileWidget] Hide places frame and header

apol added inline comments. INLINE COMMENTS > kfilewidget.cpp:1351 > placesDock = new QDockWidget(i18nc("@title:window", "Places"), q); > -placesDock->setFeatures(QDockWidget::DockWidgetClosable); > +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures); > +

D10343: Create containment on specified screen

hoffmannrobert edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham

D10339: Drop obsolete version checks

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D10339 To: heikobecker, #frameworks, apol Cc: michaelh, ngraham

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. In https://phabricator.kde.org/D9207#201848, @hein wrote: > Well, the maintainer spoke out against it, so not much I can do. Please be aware that I am no longer the maintainer of kglobalaccel. Nevertheless I recommend against it as the risk of breakage

D10124: Faster simplejob start

broulik added a comment. So, good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10124: Faster simplejob start

jtamate added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff, dfaure Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D9207: Don't load KDE platform module in kglobalaccel5

hein abandoned this revision. hein added a comment. As mentioned, I'm OK with abandoning it. I think the change is hygienic, but it's also a micro-optimization. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/98/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 44 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/118/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/117/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 29 min and counting JUnit Tests Name: (root)

D10335: balooctl monitor: Exit w/o valid dbus interface

michaelh added a comment. This is the second time I could "resolve" a problem by throwing in a oneshot timer, see also https://phabricator.kde.org/D9590. I have the feeling something else is wrong here and regard this more as a workaround than a solution. Please comment. REPOSITORY

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:05:18 + Build duration: 3 min 19 sec and counting JUnit Tests Name:

D10335: balooctl monitor: Exit w/o valid dbus interface

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Exit the application instead of just stopping the event loop TEST PLAN $ balooctl monitor || echo

D10205: fileindexerconfig: Introduce canBeSearched()

This revision was automatically updated to reflect the committed changes. Closed by commit R293:114874660e65: fileindexerconfig: Introduce canBeSearched() (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10205?vs=26264=26630 REVISION

D10325: [KFileWidget] Hide places frame and header

broulik updated this revision to Diff 26642. broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and header" to "[KFileWidget] Hide places frame and header". broulik edited the test plan for this revision. broulik added a comment. - Add custom widget for added spacing,

D10325: [KFileWidget] Hide places frame and header

markg added a comment. In https://phabricator.kde.org/D10325#201884, @broulik wrote: > > Would it be possible to show it as if it were locked? That would solve all the issues with it, right? > > I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly

D8351: API dox: add note about calling setApplicationDomain after QApp creation

kossebau added a comment. In https://phabricator.kde.org/D8351#161562, @ilic wrote: > Well... it's a tough situation. It is not by design that `i18n` calls should in any way depend on creation of `QApplication`, and also any library may place an `i18n` call before the main program

D10339: Drop obsolete version checks

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Frameworks already require Qt 5.7.0. REPOSITORY R306 KParts BRANCH master REVISION DETAIL

D8351: API dox: add note about calling setApplicationDomain after QApp creation

ilic added a comment. Yes, I guess in the end it's the simplest way to look at it. One thing though: I'd add at least another sentence claryfing that unlike an i18n* call, a ki18n* can happen at any time, and only its toString method should be called after Q*App instance creation

D10340: Clean up old, unreachable code

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Nepomuk is never searched for, so the removed code wasn't used in a long time. Furthermore Nepomuk

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

markg created this revision. markg added reviewers: dfaure, mwolff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY This allows the compiler to generate: - Move constructor

D8351: API dox: add note about calling setApplicationDomain after QApp creation

kossebau added a comment. In https://phabricator.kde.org/D8351#201926, @ilic wrote: > Yes, I guess in the end it's the simplest way to look at it. > > One thing though: I'd add at least another sentence claryfing that unlike an i18n* call, a ki18n* can happen at any time, and only