D10662: indexerconfig: Describe some functions

lbeltrame added inline comments. INLINE COMMENTS > fileindexerconfig.h:25 > +#include > +#include > I just noticed this. Can you do the #include changes as part of a separate commit? REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL

D10662: indexerconfig: Describe some functions

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks OK to me with some changes (for readability). INLINE COMMENTS > fileindexerconfig.h:50 > /** > - * The folders to search for files to analyze. Cached and cleaned up. >

D10662: indexerconfig: Describe some functions

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > lbeltrame wrote in fileindexerconfig.h:50 > I'd put "index and analyze". Seems nitpicky, but reflects what Baloo does > (index first, extraction later). To be really nitpicky it is index > analyze >

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27762. michaelh marked an inline comment as done. michaelh added a comment. - Refine descriptions more - Apply coding style to includes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27673=27762 BRANCH

D10662: indexerconfig: Describe some functions

michaelh marked an inline comment as done. REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo, lbeltrame Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella,

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27764. michaelh added a comment. - Revert includes coding style REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27762=27764 BRANCH publicdescriptions (branched from master) REVISION DETAIL

D10744: Use correct directory to lookup trigrams in windows build dir

vonreth added reviewers: mlaurent, dfaure, leinir. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D10744 To: vonreth, mlaurent, dfaure, leinir Cc: #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. For what it's worth, LGTM . REPOSITORY R293 Baloo BRANCH expose_canbesearched (branched from master) REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo,

D10743: Don't explicitly add install prefix to plugin search path

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10743 AFFECTED FILES

D10744: Use correct directory to lookup trigrams in windows build dir

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REVISION SUMMARY Properly lookup system installed dictionaries Don't look for hunspell dictionaries in

D10744: Use correct directory to lookup trigrams in windows build dir

vonreth updated this revision to Diff 2. vonreth added a comment. Build fix REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10744?vs=27776=2 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10744 AFFECTED FILES

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. Thanks for review. > Can't we reuse this same code from kcoreaddons? Maybe kcoreaddons can offer a macro that does this? As hinted in the commit message, plan is to have some ECM macro instead, but only for 5.45 in a month, to not hurry macro signature

D10739: Remove deprecated cmake code

vonreth added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:20 > Then this also needs to go? Or just set it if the variable is defined? That's how I understood the code, to allow to define a prebuild exe REPOSITORY R246 Sonnet REVISION DETAIL

D10739: Remove deprecated cmake code

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10739 AFFECTED FILES

D10719: Highlighting for OpenSCAD

julianstirling updated this revision to Diff 27770. julianstirling added a comment. Added the test file as requested and updated the license to MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10719?vs=27698=27770 REVISION DETAIL

D10739: Remove deprecated cmake code

vonreth added reviewers: kfunk, dfaure, vkrause, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D10739 To: vonreth, kfunk, dfaure, vkrause, mlaurent Cc: #frameworks, michaelh

D10739: Remove deprecated cmake code

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:20 > add_executable(KF5::parsetrigrams IMPORTED GLOBAL) > set_target_properties(KF5::parsetrigrams PROPERTIES IMPORTED_LOCATION > ${PARSETRIGRAMS_EXECUTABLE}) > else() Then this also needs to go? Or just set it if the

D10741: Use Locale::name() instead of Locale::bcp47Name()

vonreth created this revision. vonreth added reviewers: dfaure, mlaurent, kfunk, vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REVISION SUMMARY bcp47Name() is encoded like "en-US"

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY This summary will change when the doubts are resolved (if they can be resolved!). Implement the first

D10722: other preload microoptimizations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:79fb4ebfa77f: other preload microoptimizations (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D10722: other preload microoptimizations

mart updated this revision to Diff 27796. mart added a comment. - check for function REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27795=27796 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722

D10722: other preload microoptimizations

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in svgitem.cpp:50 > > when the component is complete, in many cases i guessthe properties would > > all be already set? > > We know for definitely they will be already set. > > I don't understand what problem you think this is

D10722: other preload microoptimizations

mart updated this revision to Diff 27795. mart added a comment. - Revert most of it - only leave the forcelayout part REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27707=27795 BRANCH arcpatch-D10722 REVISION DETAIL

D10722: other preload microoptimizations

broulik accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10722 To: mart, #plasma, davidedmundson, broulik Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Feb 2018 16:24:01 + Build duration: 7 min 21 sec and counting

D10722: other preload microoptimizations

mart updated this revision to Diff 27797. mart added a comment. - fix typo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27796=27797 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722 AFFECTED

D10722: other preload microoptimizations

mart updated this revision to Diff 27798. mart added a comment. - err forgot typeof REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27797=27798 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau created this revision. kossebau added reviewers: Build System, Frameworks. Restricted Application added projects: Frameworks, Build System. kossebau requested review of this revision. REVISION SUMMARY This macro should help with setting up all the boilerplate CMake code needed to

D10749: [RFC] Add ECMSetupQtPluginMacroNames

kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: michaelh

D10722: other preload microoptimizations

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mart wrote in svgitem.cpp:50 > when the component is complete, in many cases i guessthe properties would all > be already set? (could add a

D10748: drop the setting of c++0x

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11086bb7913f: drop the setting of c++0x (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10748?vs=27790=27793 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/68/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 16:24:01 + Build duration: 6 min 31 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/71/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 16:24:01 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/72/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 17:42:37 + Build duration: 6 min 15 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 17:42:37 + Build duration: 6 min 10 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Feb 2018 17:42:37 + Build duration: 6 min 55 sec and counting

D10365: New icon for Elisa music player

mgallien added a comment. In D10365#206602 , @mgallien wrote: > In D10365#205750 , @andreask wrote: > > > can we get it now to master? > > > > @paullesur is hopefully interested in other icon's

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

kossebau added a comment. @apol So +1 on this for pushing? (sorry for possibly confusing you with all the many related review requests :) ) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10759: Use QLocale instead of QLocale::system

aacid created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. aacid requested review of this revision. REVISION SUMMARY That makes it work if someone called QLocale::setDefault like kxmlgui does

D10758: Use QLocale instead of QLocale::system

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. REVISION SUMMARY That makes it work if someone called QLocale::setDefault like kxmlgui does when setting an

D10757: Set QLocale too when we have a custom app language

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. TEST PLAN See https://bugs.kde.org/show_bug.cgi?id=390623 REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL

D10724: Help automoc to find metadata JSON files referenced in the code

This revision was automatically updated to reflect the committed changes. Closed by commit R244:7d642aec3a89: Help automoc to find metadata JSON files referenced in the code (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 22:14:49 + Build duration: 6 min 57 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/37/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Feb 2018 22:14:49 + Build duration: 5 min 11 sec and counting JUnit

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 04:20:05 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/48/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 22:14:48 + Build duration: 3 min 40 sec and counting JUnit Tests

D10758: Use QLocale instead of QLocale::system

lueck added a comment. using D10757 , D10758 , and D10759 the bug reported in https://bugs.kde.org/show_bug.cgi?id=390623 is fixed for me, thanks a lot REPOSITORY R249 KI18n

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio planned changes to this revision. dmitrio added a comment. It seems that the proposed patch in its current state does not fully prevent possible problems with move operation (did not catch any problems while testing, but looking at the code again I don't think that all is good with

D10662: indexerconfig: Describe some functions

This revision was automatically updated to reflect the committed changes. Closed by commit R293:70162de9741e: indexerconfig: Describe some functions (authored by michaelh). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10662?vs=27764=27791#toc REPOSITORY R293 Baloo CHANGES SINCE

D10747: Implement zwp_linux_dmabuf_v1

mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. +1 on my machine opengl apps seems to work well on wayland (after the first revision in which they were flipped upside down, now they are ok) would need a final ship it by someone more

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/35/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 14:53:00 + Build duration: 5 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 14:53:00 + Build duration: 6 min 7 sec and counting JUnit Tests Name:

D10747: Implement zwp_linux_dmabuf_v1

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > linuxdmabuf_v1_interface.h:39 > + > +namespace LinuxDmabuf > +{ Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer etc. instead.

D10671: [UDisks] Fix auto-mount regression

ngraham added a comment. Can this land? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10748: drop the setting of c++0x

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Builds here as before as well. Reducing duplicated flags in the compile commands for me from `-std=c++0x -std=c++0x -std=c++0x -std=gnu++11` to `-std=c++0x -std=c++0x

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

markg added a comment. I unfortunately have no clue how to answer your questions. INLINE COMMENTS > kcoredirlister.cpp:825-829 > +// If take remove the element from the list. > +if (take) { > +dirItem->lstItems.erase(it); > +

D10661: indexerconfig: Expose canBeSearched function

This revision was automatically updated to reflect the committed changes. Closed by commit R293:67a84fe99a03: indexerconfig: Expose canBeSearched function (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10661?vs=27667=27788 REVISION

D10722: other preload microoptimizations

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in svgitem.cpp:50 > I don't see how this makes any difference. > > Every setSomeProperty already calls scheduleImageUpdate regardless of whether > we're complete or not. > and if you don't have any properties set, then there's

D10747: Implement zwp_linux_dmabuf_v1

fredrik created this revision. fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. Restricted

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 14:23:00 + Build duration: 4 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/34/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 14:23:00 + Build duration: 3 min 55 sec and counting JUnit Tests Name:

D10719: Highlighting for OpenSCAD

ngraham added a comment. In case anyone wants a more complex test file, I'm attaching one (written by me, MIT license): F5725381: X-carriagestruder.scad REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719

D10748: drop the setting of c++0x

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY this is already done by KDEFrameworkCompilerSettings