D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

broulik created this revision. broulik added reviewers: Frameworks, hein. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY `KProtocolInfoFactory::findProtocol` clears its cache when requested an unknown protocol in the hope of

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/14/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 07 Mar 2018 05:40:48 + Build duration: 1 hr 36 min and counting JUnit Tests

D11099: Fix compilation on Android

apol added a comment. I actually hit this issue this week (you can see build.kde.org failing earlier this week: https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/ I fixed it by using android-21 as the sdk version, maybe it's a more acceptable compromise?

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY I don't see why this would be silently discarded. The input

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added inline comments. INLINE COMMENTS > michaelh wrote in ktooltipwidget.cpp:142 > In addition I cannot reproduce the behaviour depicted here > > anymore. Too happy

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 162 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/162/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 17:59:00 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Mar 2018 17:59:00 + Build duration: 8 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/142/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 17:59:00 + Build duration: 7 min 1 sec and counting JUnit Tests Name:

D11067: Fix more cases of incorrect parameter to findProtocol

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c25b6745366f: Fix more cases of incorrect parameter to findProtocol (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11067?vs=28801=28855

D10446: Add KLanguageName

aacid planned changes to this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid Cc: markg, apol, #frameworks, michaelh

D10446: Add KLanguageName

aacid added a comment. In D10446#218954 , @markg wrote: > Isn't this better suited for KCoreAddons? The kf5_entry.desktop files are part of kconfigwidgets tarball, so that's why i put it here. REPOSITORY R265 KConfigWidgets REVISION

D10168: Use nullptr for passing a null pointer to crc32

This revision was automatically updated to reflect the committed changes. Closed by commit R243:61d39cae560a: Use nullptr for passing a null pointer to crc32 (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10168?vs=26154=28852 REVISION

D11099: Fix compilation on Android

vkrause created this revision. vkrause added a reviewer: Frameworks. Restricted Application added a project: Frameworks. vkrause requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D11099 AFFECTED FILES

D10776: Make it possible to generate po files in parallel

apol updated this revision to Diff 28846. apol added a comment. EQUAL REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28845=28846 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 AFFECTED FILES cmake/build-pofiles.cmake

D10776: Make it possible to generate po files in parallel

apol updated this revision to Diff 28845. apol marked 3 inline comments as done. apol added a comment. Remove debug info and spaces REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28724=28845 BRANCH master REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/62/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 14:15:14 + Build duration: 12 min and counting

D11080: Make org.kde. components include a donate URL

apol updated this revision to Diff 28835. apol added a comment. Include the app id when opening the url, to inform what's the donation trigger REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11080?vs=28775=28835 BRANCH master REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/87/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 14:15:14 + Build duration: 9 min 55 sec and counting

D11080: Make org.kde. components include a donate URL

apol added inline comments. INLINE COMMENTS > aacid wrote in kpackagetool.cpp:534 > Not sure if i'm saying crap, but should we check if it already has a donation > url and then give a warning or something else? This is for the code that turns kpackage metadata files into appdata.xml files. So

D11097: [Window Thumbnail] Allow using atlas texture

davidedmundson added a comment. Edit. Just re-read. Sorry. createTextureFromId with CanUseAtlas doesn't make any sense. It creates a QSGTexture object from an existing GL Texture, it's not creating any atlas or otherwise. It'll just no-op. So no harm done. REPOSITORY

D11097: [Window Thumbnail] Allow using atlas texture

This revision was automatically updated to reflect the committed changes. Closed by commit R242:48771a291229: [Window Thumbnail] Allow using atlas texture (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11097: [Window Thumbnail] Allow using atlas texture

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11097 To: broulik, #plasma, davidedmundson Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/61/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 13:52:57 + Build duration: 19 min and counting

D11097: [Window Thumbnail] Allow using atlas texture

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY It's not using any custom shaders anyway TEST PLAN Verified

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/86/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 13:43:57 + Build duration: 23 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/60/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 12:36:51 + Build duration: 1 hr 15 min and counting

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e5dff648f01: [Dialog] Remove now obsolete KWindowSystem::setState calls (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. @rkflx I'm looking into it now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks, michaelh

D11054: Add media status icons

ngraham accepted this revision. ngraham added a comment. Let's do it! REPOSITORY R266 Breeze Icons BRANCH mediaStatus REVISION DETAIL https://phabricator.kde.org/D11054 To: romangg, #plasma, #frameworks, #vdg, andreask, ngraham Cc: ngraham, michaelh

D11054: Add media status icons

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH mediaStatus REVISION DETAIL https://phabricator.kde.org/D11054 To: romangg, #plasma, #frameworks, #vdg, andreask Cc: michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/85/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 12:36:51 + Build duration: 6 min 33 sec and counting

D11090: Fix FadingMaterial fragment with core profile

This revision was automatically updated to reflect the committed changes. Closed by commit R242:188be131bca5: Fix FadingMaterial fragment with core profile (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11091: Support Atlas textures in FadingNode

This revision was automatically updated to reflect the committed changes. Closed by commit R242:02c419453462: Support Atlas textures in FadingNode (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11090: Fix FadingMaterial fragment with core profile

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D11090 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh

D11091: Support Atlas textures in FadingNode

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D11091 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh

D11050: Remove frames around media buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R242 Plasma Framework (Library) BRANCH reworkMediaIcons REVISION DETAIL https://phabricator.kde.org/D11050 To: romangg, #frameworks, #plasma, ngraham Cc:

D11049: Remove frame around media action icons

ngraham accepted this revision. ngraham added a comment. Looks good to me too! REPOSITORY R266 Breeze Icons BRANCH reworkMediaActions REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg, andreask, ngraham Cc: ngraham, mart, #frameworks, michaelh

D11091: Support Atlas textures in FadingNode

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY Previously IconItem would create icons in

D11090: Fix FadingMaterial fragment with core profile

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY Currently it asserts. I'm sure it worked

D11049: Remove frame around media action icons

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH reworkMediaActions REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg, andreask Cc: mart, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Mar 2018 09:41:19 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/161/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 09:41:19 + Build duration: 15 min and counting JUnit Tests Name: (root)

D10989: Check for nullptr in indexForNode

dfaure added a comment. helgrind and drd are for multithreading data races, but KDirModel can't be used in a multithreading context, so I'm not sure why you're mentioning those tools. If you do want to detect data races, please note that helgrind and drd have lots of false positives

D11067: Fix more cases of incorrect parameter to findProtocol

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11067 To: jtamate, #frameworks, dfaure Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/141/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 09:41:19 + Build duration: 7 min 0 sec and counting JUnit Tests Name:

D10989: Check for nullptr in indexForNode

jtamate added a comment. In D10989#219594 , @mpyne wrote: > I think valgrind has some flags you can use to try to generate a backtrace for where a freed block of memory was freed from, which might be useful for debugging. Thanks. The

D11067: Fix more cases of incorrect parameter to findProtocol

jtamate updated this revision to Diff 28801. jtamate retitled this revision from "Fix 3 more cases of incorrect parameter to findProtocol" to "Fix more cases of incorrect parameter to findProtocol". jtamate added a comment. David's comment done. REPOSITORY R241 KIO CHANGES SINCE LAST

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11089 To: dfaure, jtamate Cc: #frameworks, michaelh

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. I'll change https://phabricator.kde.org/D11067. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11089 To: dfaure, jtamate Cc: #frameworks, michaelh

D11089: KUrlCompletion: early return if the URL is invalid like ":/"

dfaure created this revision. dfaure added a reviewer: jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY Don't send an empty protocol to findProtocol() TEST PLAN New unittest REPOSITORY R241 KIO BRANCH master

D11067: Fix 3 more cases of incorrect parameter to findProtocol

dfaure added inline comments. INLINE COMMENTS > jtamate wrote in kurlcompletion.cpp:626 > I missed one key stroke. With this test, in a non empty current dirt, it > fails. > > void KUrlCompletionTest::testInvalidProtocol() > { > > KUrlCompletion* completionHomeCwd = new KUrlCompletion; >

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

broulik updated this revision to Diff 28797. broulik added a comment. - Slightly optimize REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11088?vs=28794=28797 REVISION DETAIL https://phabricator.kde.org/D11088 AFFECTED FILES

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY I found this was called 350 times for me when opening the file dialog since for every paint pass it would

D10989: Check for nullptr in indexForNode

dfaure added a comment. That's actually valgrind-memcheck's default behaviour. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: mpyne, michaelh

D11080: Make org.kde. components include a donate URL

aacid added inline comments. INLINE COMMENTS > kpackagetool.cpp:534 > +writer.writeStartElement(QStringLiteral("url")); > +writer.writeAttribute(QStringLiteral("type"), > QStringLiteral("donation")); > + >

D11077: [Icon Item] Remove unused variables

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8019cb369cde: [Icon Item] Remove unused variables (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11077?vs=28770=28791

Kirigami breeze icons on android

Hi, I'm having trouble making use of the breeze icons on Android using Kirigami. I added kirigami-icons.qrc to the app project and added a few icons to it, but it only picksup the icons defined on kirigami own kirigami-icons.qrc file. Although when running qmake it says : Using icons QRC file

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/84/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 08:13:29 + Build duration: 14 min and counting JUnit

D11067: Fix 3 more cases of incorrect parameter to findProtocol

jtamate added inline comments. INLINE COMMENTS > dfaure wrote in kurlcompletion.cpp:626 > I'm not 100% sure about this one because kurl() is only supposed to be called > if url.isURL(). > > Also, I tried to reproduce this assert with a unittest for kcompletion, but > it works here !? > >

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/59/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 08:13:29 + Build duration: 4 min 1 sec and counting