D11891: Fix crashes in NotifyByAudio when closing applications

rjvbb added a comment. So the difference here is that `finishNotification` isn't called if `notification == nullptr`, with the crucial difference probably being the fact that `m` isn't added multiple times to the list of reusable items? Why isn't that logic part of

D11838: Turn on line numbers by default

cullmann added a comment. I think allowing a own configuration per hosting application makes sense. But I would propose to do this "opt-in". We could add some application wide flag in the config that triggers "application local" storage, that is default off. The KTextEditor config pages

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/51/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 11:53:53 + Build duration: 5 min 54 sec and counting JUnit

D11891: Fix crashes in NotifyByAudio when closing applications

cfeck added inline comments. INLINE COMMENTS > rjvbb wrote in notifybyaudio.cpp:148-150 > Slightly better English: > > // since stopping a mediaobject means it wont't emit finished(). However, > // we can receive pending finished() signals that were already emitted after > // playback

D11753: baloodb: Add clean command

michaelh planned changes to this revision. michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:316 > What do you consider a "truly dead" symlink? > > If you really want to do it correctly, you have to walk the file system > yourself, one symlink target path

D11361: add a version containmentForScreen with activity

mart updated this revision to Diff 31200. mart added a comment. - make sure the new containment has the proper activity REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11361?vs=30915=31200 BRANCH arcpatch-D11361 REVISION DETAIL

D11452: sanitizer: Improve device listing

michaelh added a comment. - Ping * REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11902: Add highlighting for GDB command listings and gdbinit files

mwolff created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY Command listings start their non-output lines with (gdb) or > for multi-line commands. gdbinit

D11652: Don't show the background if Button.flat

mart added a comment. how does it look when the mouse is over the toolbutton? the plasma button svg also has an element for that, to look like breeze toolbuttons (look at the navigation controls for the calendar for instance REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D11902: Add highlighting for GDB command listings and gdbinit files

mwolff added reviewers: vkrause, dhaumann, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11902 To: mwolff, vkrause, dhaumann, #kate Cc: #frameworks, michaelh, ngraham

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 31208. michaelh added a comment. - Ignore symbolic links There seems to be no reliable way to map a symbolic link's target to a device id. Instead of removing it print a parseable message so users can remove it manually. REPOSITORY R293 Baloo

D10849: Add template for Plasma wallpaper with QML extension

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH addtemplatewallpaperwithqmlext REVISION DETAIL https://phabricator.kde.org/D10849 To: kossebau, mart Cc: #frameworks, michaelh, ngraham

D11891: Fix crashes in NotifyByAudio when closing applications

rjvbb requested changes to this revision. rjvbb added a comment. This revision now requires changes to proceed. (sorry, keep forgetting to set the action. Consider this a change request at least for the typo in the comment ;)) REPOSITORY R289 KNotifications REVISION DETAIL

D11891: Fix crashes in NotifyByAudio when closing applications

rjvbb added a comment. (Oops, missed that one :-/) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D11891 To: aacid, #frameworks, cullmann, rjvbb Cc: cfeck, rjvbb, mpyne, michaelh, ngraham

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a comment. Maybe I am missing something here but wouldn't this allow any application to get ptrace access? e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a new socket before kcrash writes the debugger's... now the malicious program has ptrace

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 31197. broulik added a comment. - Rebase - Address Christoph's comments (4x scale and indentation) REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=29668=31197 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. > The only reason why the symbolic line-art versions exist is because the prettier icons look bad at small sizes on low-dpi screens. Note that the physical size of the icon is the same for 1x on low dpi and 2x on high dpi so the icon will be hard to tell which

D11863: Add virt-manager icons

ndavis added a comment. In D11863#238210 , @ngraham wrote: > Looks good to me! Nice use of the Breeze icon style. @andreaska? Thank! If the other reviewer takes a long time to respond, do I still have to wait for their permission to land

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham accepted this revision as: VDG. ngraham added a comment. OK, +1 then! If we can safely implement this part of the spec without causing any unexpected visual changes, then I don't see a problem with it. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. Okay I've deployed the patch, and without applying the change specified in the "For testing..." sentence, I was unable to find any visual changes from the status quo resulting from this patch. Is that intentional? For example `QT_SCREEN_SCALE_FACTORS=3 kate` does

D11863: Add virt-manager icons

ngraham added a comment. Let's cross that bridge when we come to it! :-) REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska Cc: ngraham, andreaska, #frameworks,

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/117/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 14:38:51 + Build duration: 14 min and counting JUnit

D10849: Add template for Plasma wallpaper with QML extension

This revision was automatically updated to reflect the committed changes. Closed by commit R242:354bd71296b5: Add template for Plasma wallpaper with QML extension (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/92/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 14:38:51 + Build duration: 6 min 16 sec and counting

D11863: Add virt-manager icons

andreask accepted this revision. REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska, andreask Cc: ngraham, andreaska, #frameworks, michaelh

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. > Okay I've deployed the patch, and without applying the change specified in the "For testing..." sentence, I was unable to find any visual changes from the status quo resulting from this patch. Is that intentional? Yes, as Breeze currently does not offer any

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. @ngraham, in the initial description @broulik forced a @2x folder via symlink to test. Otherwise no change will be observed. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg

D6313: Support Icon Scale from Icon naming specification 0.13

davidedmundson added a comment. RE: QT_SCALE_FACTOR vs QT_SCREEN_SCALE_FACTORS See: https://paste.kde.org/p0y4ze6dg REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 177 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/177/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 17:11:21 + Build duration: 10 min and counting JUnit Tests Name:

D10568: Handle privilege operation confirmation prompts in SlaveBase

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0e45fcffd182: Handle privilege operation confirmation prompts in SlaveBase (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10568?vs=31156=31225

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#232555 , @mwolff wrote: > WTF :D Your desktop CPU has clearly a better performance than my mobile CPU, no? Is AMD really so much worse here? How can that be - I don't get it :D > > Anyhow, I give up trying

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. Thanks David! HiDPI turns out to be complicated... ;-) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

ngraham set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D11768 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10245 To: ngraham, #frameworks, #dolphin Cc: zzag, alexeymin, markg, spoorun, rkflx, michaelh,

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8b34864135f8: Remove handling of privilege operation confirmation prompts from KIO::Job (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr updated this revision to Diff 31227. chinmoyr added a comment. Rebased on D10568 Merged D10437 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10818?vs=28537=31227 BRANCH

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added a comment. In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without duplicating the icon files? REPOSITORY R302 KIconThemes REVISION DETAIL

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr added inline comments. INLINE COMMENTS > slavebase.cpp:129 > int m_privilegeOperationStatus; > +QSet m_tempAuths; > @dfaure where should I place this variable? Just before "m_confirmationAsked"? REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D11888: Handle adjacent special characters correctly

michaelh added inline comments. INLINE COMMENTS > bruns wrote in advancedqueryparser.cpp:55 > Why choose a different wording here? Also, the important aspect here is the > "end", which commits the current token to the list. Because of opening and closing parentheses, but you're right 'end' is

D11811: avoid Asan runtime error: shift exponent -1 is negative

mwolff added a comment. maybe instead make it explicit what the old code did instead? i.e. check what you get from GCC for "1 << -1" and then use that when i == 0 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11811 To: jtamate, #kate, #frameworks Cc: mwolff,

D11487: optimization of TextLineData::attribute

mwolff added a comment. Ah, I knew it :D I suspected missing compiler optimizations from the start... But tricky indeed for you to see! But the real question would now be: what time does it take *without* this patch for you? probably it won't be more than a minute anymore. Still, this

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 198 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/198/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 17:11:21 + Build duration: 16 min and counting JUnit Tests Name: (root)

D11907: advancedqueryparsertest: Add optimization test

michaelh created this revision. michaelh added reviewers: Baloo, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH advancedqueryparsertest (branched

D11907: advancedqueryparsertest: Add optimization test

michaelh added a comment. @bruns: This is mainly to confirm I understood D11826 correctly. The tests pass with or without your patch. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 199 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/199/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 17:27:42 + Build duration: 5 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/49/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 17:30:51 + Build duration: 16 min and counting JUnit Tests Name: (root)

D10437: Update file ioslave's temporary authorization list

chinmoyr closed this revision. chinmoyr added a comment. Merged with D10818 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt Cc: markg, anthonyfieroni, michaelh, ngraham

D7909: Add syntax support for Crystal Programming Language

mwolff added subscribers: cullmann, mwolff. mwolff accepted this revision as: mwolff. mwolff added a comment. we got a test file, and it seems to work for a user of the Crystal language, so +1 from my side. @dhaumann, @cullmann ? REPOSITORY R40 Kate REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/48/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 17:11:21 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 178 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/178/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 17:26:21 + Build duration: 10 min and counting JUnit Tests Name:

D11822: Make the word/char count a global preference

mwolff added subscribers: cullmann, dhaumann, mwolff. mwolff accepted this revision as: mwolff. mwolff added a comment. This revision is now accepted and ready to land. I'm not using that feature, but code-wise this lgtm - but please wait for @dhaumann or @cullmann to give their +1 too

D11685: Implement single click on line number to select line of text

mwolff added a comment. the "also" in your commit message: can you split this commit into two parts, or is the feature addition also fixing the bug? Put differently: Could you first fix the bug, then add the feature, in separate commits? INLINE COMMENTS > kateviewhelpers.cpp:2018 >

D11891: Fix crashes in NotifyByAudio when closing applications

aacid added a comment. In D11891#238999 , @rjvbb wrote: > So the difference here is that `finishNotification` isn't called if `notification == nullptr`, with the crucial difference probably being the fact that `m` isn't added multiple times to

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 31244. croick added a comment. - check for peer PID to restrict socket connection to DrKonqi - add ifdefs to deactivate code for non-linuxes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=30980=31244 BRANCH

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:279 > + */ > +QPixmap loadIcon(const QString , KIconLoader::Group group, qreal > scale, int size = 0, > + int state = KIconLoader::DefaultState, const > QStringList = QStringList(), loadIcon("test",

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. In D11236#239055 , @sitter wrote: > Maybe I am missing something here but wouldn't this allow any application to get ptrace access? > > e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a

D11891: Fix crashes in NotifyByAudio when closing applications

aacid added inline comments. INLINE COMMENTS > rjvbb wrote in notifybyaudio.cpp:148-150 > Slightly better English: > > // since stopping a mediaobject means it wont't emit finished(). However, > // we can receive pending finished() signals that were already emitted after > // playback

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. In D6313#239212 , @cfeck wrote: > In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without

D11891: Fix crashes in NotifyByAudio when closing applications

rjvbb added a comment. This is about better and more concise English. The queued connection is the indirect explanation why the patch is necessary, and thus comes after the direct explanation (the fact that there may be pending signals). Think of it as a courtesy to people who want to get

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/93/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 03:20:29 + Build duration: 8 min 31 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/118/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 03:20:29 + Build duration: 11 min and counting JUnit

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr updated this revision to Diff 31249. chinmoyr added a comment. Rearranged member vars REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10818?vs=31227=31249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10818 AFFECTED FILES

D10818: Store PolicyKit action which the slave is authorized to perform

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ec4df175be47: Store PolicyKit action which the slave is authorized to perform (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11010: Add MSG_SLAVE_STATUS_V2 to slave interface

This revision was automatically updated to reflect the committed changes. Closed by commit R241:004cb9da1913: Add MSG_SLAVE_STATUS_V2 to slave interface (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11010?vs=28540=31251 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 200 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/200/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 03:46:05 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 179 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/179/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 03:46:05 + Build duration: 23 min and counting JUnit Tests Name:

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now or in near future. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10638 To: chinmoyr, #frameworks Cc: michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/50/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 03:46:05 + Build duration: 24 min and counting JUnit Tests Name: (root)

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 201 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/201/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 03:59:22 + Build duration: 12 min and counting JUnit Tests Name: (root)

D10636: Add support for revoking temporary authorization in KAuth

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10636 To: chinmoyr, #frameworks Cc: fvogt, dfaure, michaelh, ngraham

D10820: Send slave's polkit authorization status to the host

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ea4329c36830: Send slaves polkit authorization status to the host (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10820?vs=30333=31252#toc REPOSITORY R241 KIO

D10822: Store temporary authorization status in IdleSlave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d38b373c8b76: Store temporary authorization status in IdleSlave (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10822?vs=28581=31254 REVISION

D11888: Handle adjacent special characters correctly

bruns added inline comments. INLINE COMMENTS > michaelh wrote in advancedqueryparser.cpp:69 > 1. I misunderstood your description as ':=' should become '='. > > > The lexer should not handle ">" and ">=" differently, both are (valid) > > tokens, and should be returned as such. > > That is

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 202 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/202/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 04:11:33 + Build duration: 17 min and counting JUnit Tests Name: (root)

D10824: Delete IdleSlave having temporary authorization

This revision was automatically updated to reflect the committed changes. Closed by commit R303:bbf120b78773: Delete IdleSlave having temporary authorization (authored by chinmoyr). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10824?vs=28536=31255 REVISION

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.10 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks kinit kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 04:33:21 + Build duration: 3 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.9 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kinit kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 04:33:21 + Build duration: 4 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 180 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/180/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 04:09:40 + Build duration: 28 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 203 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/203/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 04:29:12 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/51/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 04:10:40 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 181 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/181/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 04:38:45 + Build duration: 8 min 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/52/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 04:41:13 + Build duration: 9 min 7 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/52/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 04:44:06 + Build duration: 4 min 30 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 04:44:06 + Build duration: 7 min 55 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 04:44:06 + Build duration: 7 min 16 sec and counting JUnit Tests

D10141: Restore Persistence=session for the file ioslave kauth helper

chinmoyr accepted this revision. chinmoyr added a comment. This revision is now accepted and ready to land. I think it is now okay to push this diff as the issues pertaining to warning dialogs have been fixed. See T8075 . REPOSITORY R241 KIO BRANCH