D9219: WIP: Extend Scripting API

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ;=) Just missed that. Why not ;) REPOSITORY R39 KTextEditor BRANCH Scripting (branched from master) REVISION DETAIL https://phabricator.kde.org/D9219 To: dhaumann,

D9219: WIP: Extend Scripting API

dhaumann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. @cullmann ping? :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9219 To: dhaumann, cullmann, mwolff Cc: kwrite-devel,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

dhaumann added a comment. I think the setIcon() is also buggy, since if you call setIcon() and then setMessageType(), the icon is lost. So yes, I would be in favor of a better solution. If you revert the setIcon() part, do the screenshot examples all loose their icon? Or is it still

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. Sure, I'll be happy to fix those issues. The additional `setIcon()` call is to match the behavior of the Kirigami version, which always has an icon by default. I can revert that if we're okay with having it be a little bit inconsistent with the Kirigami version.

D12320: [RFC] add ability to read embedded cover files

anthonyfieroni added a comment. In D12320#260768 , @astippich wrote: > Unfortunately, found it only after I wrote all that myself :/ Sorry i don't see RFC earlier. In D12320#260768 ,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

dhaumann added a comment. Somehow my other comments were lost, here we go: - could you also update the screenshot in the doxygen documentation? - setIcon() is behavior incompatible, and in fact, the referenced bugs did not complain about icons. So why the change? In my opinion this is

D12508: Make KMessageWidget match Kirigami inlineMessage's style

dhaumann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Can we revert the setIcon() part? It changes application behavior, an in the case of Kate/KWrite, this is note wanted, see my comments. REPOSITORY R236 KWidgetsAddons

D12270: Create a public function to access the actionMenu

ngraham abandoned this revision. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12270 To: ngraham, #frameworks Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

ngraham added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Ping? Shell I take silence to mean tacit acceptance? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma,

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260761 , @anthonyfieroni wrote: > I do *same* thing in KIO-Extras https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp Yeah, I found that when I was looking into

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 260 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/260/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 May 2018 17:37:00 + Build duration: 13 min and counting JUnit Tests Name: (root)

D12320: [RFC] add ability to read embedded cover files

anthonyfieroni added a comment. I do *same* thing in KIO-Extras https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 259 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/259/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 May 2018 17:23:06 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/109/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 10 May 2018 17:29:00 + Build duration: 4 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/15/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 10 May 2018 17:27:46 + Build duration: 3 min 44 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/108/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 10 May 2018 17:23:06 + Build duration: 5 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 10 May 2018 17:23:06 + Build duration: 4 min 37 sec and counting JUnit Tests

D12696: Use the new uds implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e80c31163170: Use the new uds implementation (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12696?vs=33929=33957 REVISION DETAIL

D12371: Don't redirect smb:/ to smb:// and then to smb:///

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:2a57054a718a: Dont redirect smb:/ to smb:// and then to smb:/// (authored by jtamate). CHANGED PRIOR TO COMMIT

D12371: Don't redirect smb:/ to smb:// and then to smb:///

jtamate retitled this revision from "fix always reproducible crash" to "Don't redirect smb:/ to smb:// and then to smb:///". jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To: jtamate, dfaure, #frameworks, apol Cc:

D12320: [RFC] add ability to read embedded cover files

astippich marked 4 inline comments as done. astippich added a comment. Thanks a lot! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich,

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33955. astippich added a comment. - fix usage of qflags - use unique_ptr REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33934=33955 BRANCH cover_read REVISION DETAIL

D10937: Retouching of Screen Layout Selection OSD Icons

bruns added a comment. Two remarks regarding the rotation icons: 1. I would remove the keyboard from the icons - you will use these with a tablet, a 2-in-1, or a pivoted external display. 2. For the large versions, rotate the content pictogram/window not by ~20 degres, but ~70

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. In D10937#260688 , @pstefan wrote: > In D10937#260289 , @abetts wrote: > > > In D10937#260277 , @ngraham wrote: > > > > >

D10937: Retouching of Screen Layout Selection OSD Icons

bruns added a comment. In D10937#260688 , @pstefan wrote: > It's supposed to be a projector screen. I took the original icon metaphor to be a projector screen, so I continued with that. I think you should remove the tripod - I have not

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. In D10937#260289 , @abetts wrote: > In D10937#260277 , @ngraham wrote: > > > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts,

D12320: [RFC] add ability to read embedded cover files

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > embeddedimagedata.cpp:69 > + > +if (types == EmbeddedImageData::FrontCover) { > + >

D12647: Move the inline preview button into the menu

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Now that previews are on by default but not shown for small icons, are there any other objections to doing this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham,

D12801: search for album artist and albumartist tags in taglibextractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH album_artist REVISION DETAIL https://phabricator.kde.org/D12801 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D12800: split tests for better readability

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Nice, thanks! REPOSITORY R286 KFileMetaData BRANCH split_tests REVISION DETAIL https://phabricator.kde.org/D12800 To: astippich, mgallien, bruns Cc: bruns, kde-frameworks-devel,

D12696: Use the new uds implementation

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12801: search for album artist and albumartist tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY album artist and albumartist tags

D12800: split tests for better readability

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY create separate test functions

D12320: [RFC] add ability to read embedded cover files

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:40 > You should be using a std::unique_ptr instead of a raw pointer. You also > should take care of either forbidding copy (operator= and copy constructor) > or

D12320: [RFC] add ability to read embedded cover files

astippich retitled this revision from "{RFC] add ability to read embedded cover files" to "[RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo,

D12320: {RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33934. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - adjust to feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/107/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 10 May 2018 08:29:31 + Build duration: 29 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 258 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/258/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 10 May 2018 08:29:31 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 10 May 2018 08:29:31 + Build duration: 5 min 16 sec and counting JUnit Tests

D12696: Use the new uds implementation

jtamate updated this revision to Diff 33929. jtamate marked 8 inline comments as done and 3 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Added the documentation for insert. Removed the () from the QDataStream& operators, but must be kept for

D12538: Allow accepting by double-click in save dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c537a717363c: Allow accepting by double-click in save dialog (authored by anemeth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33914=33930 REVISION

D12538: Allow accepting by double-click in save dialog

rkflx accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D12538 (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx,