KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/23/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 24 May 2018 06:36:01 + Build duration: 11 min and counting JUnit Tests Name:

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34779. broulik added a comment. - Rename to `loadIcon` with `scale` to `loadScaledIcon` to avoid ambiguous overload REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=31197=34779 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/22/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 23 May 2018 11:28:07 + Build duration: 19 hr and counting JUnit Tests Name:

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate updated this revision to Diff 34775. jtamate marked 5 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Removed m_hash, after implementing the right checks it was slower than comparing QUrls. REPOSITORY R241 KIO CHANGES SINCE LAST

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a comment. Imho fine in principle, but: `QFileInfo` stats internally and `KDesktopFile` actually reads file contents. I don't see how you came to the conclusion this doesn't stat. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham,

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

broulik added a comment. This still has the issue of blocking if the contents is an unavailable nfs share of some sort. INLINE COMMENTS > global.cpp:377 > +// Check to see if the folder has a custom icon > +QString customIcon = iconFromDirectoryFile(url.toLocalFile()); > +

D13083: Respect custom directory icons in iconNameForURL()

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12992: New elisa icon

lshoravi added a comment. I agree in that a circle doesn't have as much personality as maybe a casette. I also agree in that the casette felt off when looking at it. How would something like an LP player with the E on top feel? I won't have time until Monday (finals coming up), but my

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34780. broulik added a comment. - Remove accidental cruft REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34779=34780 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34781. broulik added a comment. … REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34780=34781 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kiconengine.h

D11282: less expensive findByUrl in KCoreDirListerCache

jtamate added a comment. About the KCoreDirLister::Private::addNewItems method, benchmarking the current and sorted list implementation with 5000 fileItems: It only takes 1.5 msecs per iteration without filters and 1.9 msecs with a nameFilter and a mimeFilter. For reference, doing a

D11511: [KPropertiesDialog] Support X-KDE-Protocols

This revision was automatically updated to reflect the committed changes. Closed by commit R241:047f5fe92117: [KPropertiesDialog] Support X-KDE-Protocols (authored by broulik). Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12820: Add KWayland virtual desktop protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in org_kde_plasma_virtual_desktop.xml:45 > Please note that your quick way would not work. Activities are disabled in > KWin Wayland and I don't see them getting enabled again. Activities resulted > in hard freezes several times and

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 270 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/270/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 24 May 2018 10:07:36 + Build duration: 6 min 33 sec and counting JUnit Tests Name:

D13092: make sure paths in rcc are never derived from absolute paths

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the paths for rcc plasmoids are always in the form

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/120/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 24 May 2018 10:07:36 + Build duration: 6 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 24 May 2018 10:07:36 + Build duration: 29 min and counting JUnit Tests Name:

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:277 > + * @p canReturnNull. > + * @since 5.48 > + */ Next release is 5.47, but I am fine with waiting for additional feedback if this is controversial. REPOSITORY R302 KIconThemes REVISION DETAIL

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham updated this revision to Diff 34815. ngraham added a comment. Tweaks per the review process REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12986?vs=34488=34815 BRANCH clean-up-trash-kcm (branched from master) REVISION DETAIL

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham updated this revision to Diff 34818. ngraham added a comment. Don't need to set a parent for `mLimitReachedAction`, since the `QFormLayout` it's in will just re-parent it anyway REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12986?vs=34815=34818

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. This revision improves the labels per review comments, but stays with a combobox instead of radio buttons in the interest of avoiding too many code changes in this patch, since the glue code changes quite a bit when you switch controls. If folks feel strongly that

D13083: Respect custom directory icons in iconNameForURL()

ngraham updated this revision to Diff 34816. ngraham added a comment. Re-add `url.isLocalFile()` check to the higher-level `if` statement CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13083?vs=34765=34816 BRANCH custom-icons (branched from master) REVISION DETAIL

D13083: Respect custom directory icons in iconNameForURL()

ngraham marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmtrash.cpp:303 > > -mLimitReachedAction = new QComboBox(mSizeWidget); > -mLimitReachedAction->addItem(i18n("Warn Me")); > +

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmtrash.cpp:303 > There's no benefit in changing the initial parent of these. > > It's all moot as QFormLayout::addItem takes ownership Ah right, I think I wrote this before I found that out. In fact, you can omit the

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:527 > * @see resetPalette > - * @since 5.39 > + * @since 5.38 > */ Is this missing a rebase or intended? See https://cgit.kde.org/kiconthemes.git/commit/?id=b506a48214a08f56d79e7847a22b0417028a46ff REPOSITORY

D13092: make sure paths in rcc are never derived from absolute paths

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/properrccpath REVISION DETAIL https://phabricator.kde.org/D13092 To: mart, #plasma, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34829. astippich added a comment. - simplify code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=34012=34829 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D12320 AFFECTED FILES

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 24 May 2018 17:07:48 + Build duration: 49 sec and counting JUnit Tests

D13092: make sure paths in rcc are never derived from absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit R290:2fdbbf13a6d5: make sure paths in rcc are never derived from absolute paths (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13092?vs=34807=34828

D12992: New elisa icon

astippich added a comment. In D12992#266673 , @mgallien wrote: > In D12992#266288 , @alex-l wrote: > > > F5863162: image.png > > > > ^ I'm for this one

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a subscriber: eszlari. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's not a thing on flatpak

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a comment. Hmm, you're right. I guess there's no way around that if we want custom icon support here... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham,

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 25 May 2018 03:32:15 + Build duration: 1 min 53 sec and counting JUnit Tests

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH clean-up-trash-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson Cc: davidedmundson, abetts, rkflx, kfm-devel, kde-frameworks-devel,

D13092: make sure paths in rcc are never derived from absolute paths

apol added a comment. Don't we have to make sure path is relative to the package root? INLINE COMMENTS > package.cpp:554 > +//we need just the plugin name here, never the absolute path > +dir = QDir(QStringLiteral(":/") + defaultPackageRoot() + >

D13092: make sure paths in rcc are never derived from absolute paths

mart updated this revision to Diff 34807. mart added a comment. - e midRef REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13092?vs=34803=34807 BRANCH phab/properrccpath REVISION DETAIL https://phabricator.kde.org/D13092 AFFECTED FILES

D13092: make sure paths in rcc are never derived from absolute paths

mart marked an inline comment as done. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13092 To: mart, #plasma Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13092: make sure paths in rcc are never derived from absolute paths

mart added a comment. In D13092#267702 , @apol wrote: > Don't we have to make sure path is relative to the package root? at this point we already know that absolute path is correct (regarding the actual filesystem), under

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 May 2018 05:36:50 + Build duration: 1 min 37 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 25 May 2018 05:36:50 + Build duration: 1 min 39 sec and counting JUnit Tests