KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 30 May 2018 03:32:23 + Build duration: 2 min 1 sec and counting JUnit Tests

D12233: Avoid manipulation of lists with quadratic complexity

bruns added inline comments. INLINE COMMENTS > dhaumann wrote in pendingfilequeue.cpp:69 > ++it is faster. GCC generates identical code for both ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: dhaumann, ngraham,

D12233: Avoid manipulation of lists with quadratic complexity

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun

D12025: Terminate query execution early if subterm returns empty result set

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5bf021ee134d: Terminate query execution early if subterm returns empty result set (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D12047: Avoid crash when reading corrupt data from document terms db

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1d1b7e87ff1: Avoid crash when reading corrupt data from document terms db (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12047?vs=35069=35152

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 21:01:02 + Build duration: 5 min 4 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 21:01:02 + Build duration: 2 min 48 sec and

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 91 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/91/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 21:01:35 + Build duration: 2 min 7 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 90 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/90/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 20:56:42 + Build duration: 4 min 51 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 20:56:42 + Build duration: 2 min 9 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 20:56:42 + Build duration: 2 min 8 sec and

D12860: DoxygenLua: fix closing comment blocks

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b136c9fd1c49: DoxygenLua: fix closing comment blocks (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12860?vs=34096=35147

D12860: DoxygenLua: fix closing comment blocks

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Will integrate, thanks. REPOSITORY R216 Syntax Highlighting BRANCH luafix REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting,

D12689: Lua: updated for Lua5.3

dhaumann added a subscriber: cullmann. dhaumann added a comment. @vkrause @cullmann Could you please comment on the above? Should we change KTextEditor such that dynamic is automatically derived based on whether there is a dynamic rule? Indeed, I agree with @jpoelen that this is redundant.

D13067: add pgf to the latex-ish file formats (same format as tikz)

dhaumann added a comment. @jan.hajer Thanks for the patch, updates like this are very much appreciated, so please keep it coming :-) The change will be in KDE Frameworks 5.47, released early in June. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13067

D13067: add pgf to the latex-ish file formats (same format as tikz)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:770d1515db89: add pgf to the latex-ish file formats (same format as tikz) (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13067?vs=34727=35145#toc REPOSITORY R216

D13198: Android toolchain: allow to specify extra libs manually

alexeymin created this revision. alexeymin added a reviewer: apol. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: kde-buildsystem. alexeymin requested review of this revision. REVISION SUMMARY Add new variable ANDROID_EXTRA_LIBS,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#269655 , @broulik wrote: > I like yours better, I can abandon mine if you want to finish this :) I would have abandoned mine because you were first, but fine with me :) REPOSITORY R495 Purpose

D13189: [kcoredirlister] Remove as many url.toString() as possible

jtamate updated this revision to Diff 35114. jtamate marked an inline comment as done. jtamate added a comment. const added. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13189?vs=35085=35114 REVISION DETAIL https://phabricator.kde.org/D13189 AFFECTED

D13043: Properly sanitize input

This revision was automatically updated to reflect the committed changes. Closed by commit R275:958e7c9c56d9: Properly sanitize input (authored by apol). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13043?vs=34858=35111 REVISION DETAIL

D13043: Properly sanitize input

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D13043 To: apol, #frameworks, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D12047: Avoid crash when reading corrupt data from document terms db

dhaumann added inline comments. INLINE COMMENTS > documentdb.cpp:101 > +if (result.isEmpty()) { > +qDebug() << "Document Terms DB contains corrupt data for " << docId; > +} Ah, maybe this should be a qWarning()? Feel free to decide as you wish. REPOSITORY R293 Baloo BRANCH

D12047: Avoid crash when reading corrupt data from document terms db

dhaumann added a comment. Ok, then please commit. REPOSITORY R293 Baloo BRANCH b392878_avoid_docterms_decode_crash REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, #frameworks,

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/32/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 29 May 2018 12:28:31 + Build duration: 3 min 44 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 12:28:31 + Build duration: 3 min 45 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 12:28:31 + Build duration: 3 min 3 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/21/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 Date of build: Tue, 29 May 2018 12:28:31 + Build duration: 3 min 8 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 88 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/88/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 12:28:31 + Build duration: 1 min 35 sec and counting JUnit

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a comment. In D12047#269976 , @dhaumann wrote: > If the format is really such that a term must appear before any Suffix, then this patch is already better that before. > > Could it happen to have e.g.: a\0b1c1 > > If so, this

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 11:51:57 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/125/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 11:51:36 + Build duration: 7 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 11:51:57 + Build duration: 6 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 275 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/275/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 11:51:36 + Build duration: 6 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/29/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 11:51:36 + Build duration: 5 min 21 sec and counting JUnit Tests

D13190: [autotests] Fix surface destroy test

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d3a29d6babc3: [autotests] Fix surface destroy test (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13190?vs=35092=35098 REVISION DETAIL

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 11:49:01 + Build duration: 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 11:43:41 + Build duration: 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 11:28:11 + Build duration: 2 min 53 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/87/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 11:28:11 + Build duration: 1 min 6 sec and counting CONSOLE

D13191: [server] Small code cleanup in SurfaceInterface

romangg added a comment. In D13191#270177 , @davidedmundson wrote: > > function definitions in correct order. > > What's more correct about this order? In surface_interface_p.h the functions are declared in this order: void

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 11:28:11 + Build duration: 46 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/31/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 29 May 2018 11:28:11 + Build duration: 1 min 3 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/20/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 Date of build: Tue, 29 May 2018 11:28:11 + Build duration: 34 sec and counting CONSOLE

D13191: [server] Small code cleanup in SurfaceInterface

davidedmundson added a comment. > function definitions in correct order. What's more correct about this order? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13190: [autotests] Fix surface destroy test

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fixSurfaceTest REVISION DETAIL https://phabricator.kde.org/D13190 To: romangg, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13189: [kcoredirlister] Remove as many url.toString() as possible

apol added a comment. +1 makes sense INLINE COMMENTS > kcoredirlister.cpp:547 > > -QUrl url(_url); > -url = url.adjusted(QUrl::StripTrailingSlash); > -const QString urlStr = url.toString(); > +QUrl url = _url.adjusted(QUrl::StripTrailingSlash); > const? REPOSITORY

D13191: [server] Small code cleanup in SurfaceInterface

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Use lambda function to reduce code duplication and

D13190: [autotests] Fix surface destroy test

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Interfaces must be cleaned up correctly and client

D13189: [kcoredirlister] Remove as many url.toString() as possible

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Change itemsInUse, itemsCached and

D13137: Updated handles and overflow-menu-*

mart added a comment. In D13137#269807 , @ngraham wrote: > Still not totally thrilled about `overflow-menu-left` and `overflow-menu-right`, but I'm willing to give 'em a shot and see how it goes. All the other ones are fantastic IMHO. Let's

D13083: Respect custom directory icons in iconNameForURL()

dfaure added a comment. Unlike KFileItem, this function does no caching. I hope you do caching at the layer above then... To skip this for NFS/SMB shares you need code like the one in KFileItemPrivate::isSlow(). REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham,

D13145: Check if destination exists also when pasting binary data

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-image-pasting (branched from master) REVISION DETAIL https://phabricator.kde.org/D13145 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 06:12:54 + Build duration: 9 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 06:12:54 + Build duration: 9 min 13 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 06:12:54 + Build duration: 7 min 33 sec and counting JUnit Tests