jtamate updated this revision to Diff 36533.
jtamate marked an inline comment as done.
jtamate added a comment.
Removed comment and added autotest.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13674?vs=36504=36533
REVISION DETAIL
michaeleden added a reviewer: Frameworks.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
Thanks!
INLINE COMMENTS
> kfilewidgettest.cpp:226
> +
> +// When going up from file:///home/, it should become file:/// not
> file:///home/user
> +void testCdUpToRoot()
This comment should move to line 220, since it matches that specific row of
test data ;)
anthonyfieroni added a comment.
So, recursive mutex ?
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
jtamate updated this revision to Diff 36534.
jtamate added a comment.
Moved the comment.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13674?vs=36533=36534
REVISION DETAIL
https://phabricator.kde.org/D13674
AFFECTED FILES
autotests/kfilewidgettest.cpp
yurchor accepted this revision as: yurchor.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13227
To: lueck, #frameworks, #documentation, yurchor
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna
mart updated this revision to Diff 36528.
mart added a comment.
- Merge branch 'master' into mart/plasmavirtualdesktop
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12820?vs=36161=36528
BRANCH
mart/plasmavirtualdesktop
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/56/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 22 Jun 2018 14:00:14 +
Build duration:
5 min 14 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/301/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Fri, 22 Jun 2018 14:00:14 +
Build duration:
6 min 32 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/149/
Project:
Frameworks kio kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Jun 2018 07:36:37 +
Build duration:
8 min 26 sec and counting
JUnit Tests
Name: (root)
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
If u == "file:///", then
jtamate updated this revision to Diff 36504.
jtamate marked an inline comment as done.
jtamate edited the summary of this revision.
jtamate added a comment.
Your suggested code works.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13674?vs=36499=36504
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfilewidget.cpp:1543
> // tokenize() expects it because it uses
> QUrl::adjusted(QUrl::RemoveFilename)
> +// special cases, avoid transform ":///"
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
You fixed the small details I found, but the big picture is still very wrong.
Using the same KIconLoader in multiple threads cannot work and doesn't make
sense: one thread could
aacid added a comment.
Can this be auto tested?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13674
To: jtamate, dfaure, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
anthonyfieroni updated this revision to Diff 36506.
anthonyfieroni added a comment.
- Protect shared pointers as well
- DragonPlayer related icons still not shown
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36492=36506
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13495
To: davidedmundson, #kwin, mart
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfilewidget.cpp:1547
> QUrl u(url);
> -if (!u.path().isEmpty()) {
> +if (u != fileRootUrl && !u.path().isEmpty()) {
> u.setPath(u.path()
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/23/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 22 Jun 2018 10:50:13 +
Build duration:
11 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:764b16544468: Fix stupid copy paste bug in XDGShellV6
Client (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13494?vs=36050=36510
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:64ce88d4fc3d: Fix XDGV6 popup test (authored by
davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13495?vs=36051=36511
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/61/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Fri, 22 Jun 2018 10:50:13 +
Build duration:
15 min and counting
JUnit Tests
Name:
mmustac added a comment.
I would not close the bug yet. Unfortunately I am busy at the moment so I
can't tell you when I will find to take a deeper look at the main problem from
the bug:
Although we have support for the template directory now, it is still very
difficult to display your
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Leave only the last / in the url before
habacker added a comment.
ping
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D13406
To: habacker, ilic
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/33/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Jun 2018 10:50:13 +
Build duration:
14 min and counting
JUnit Tests
Name:
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I think you want QUrl::NormalizePathSegments, which would make this code
simpler (and would also handle a initial URL like /d/c/../ if it can make it to
that code path)
jtamate updated this revision to Diff 36513.
jtamate added a comment.
Using NormalizePathSegments.
There is something else going on with the trailing slashes in the file dialog.
If I'm in my home directory and I append slashes, they are removed, also in
/, but in /home/ and other
davidedmundson updated this revision to Diff 36518.
davidedmundson added a comment.
whitespace changes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36330=36518
BRANCH
davidedmundson/scalef
REVISION DETAIL
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4c47f6127462: [Properties dialog] Improve some
permissions-related strings (authored by ngraham).
REPOSITORY
R241
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/12/
Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 22 Jun 2018 12:41:04 +
Build duration:
1 min 18 sec and counting
zzag added inline comments.
INLINE COMMENTS
> outputdevice.cpp:413
>
> +
> bool OutputDevice::isValid() const
Extra new line.
> outputconfiguration_interface.cpp:73
> +static void scaleFCallback(wl_client *client, wl_resource *resource,
> + wl_resource *
ngraham added a comment.
Seems nobody objects and the 5.48 string freeze is tomorrow. Landing this
diff.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13552
To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns
anthonyfieroni updated this revision to Diff 36523.
anthonyfieroni added a comment.
tryLock(-1) to wait other thread to release
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36506=36523
REVISION DETAIL
https://phabricator.kde.org/D13627
mart added a comment.
Looking to wire it into KWin:
so, the first thing i note is that abstractclient has already integration api
with virtualdesktops with the old assumptions of numerical id and window on
either one or all desktops, which is what Client is using on X11.
A
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Holy crap, now MutexGuard doesn't even guarantee that the mutex will be
locked, and yet you proceed, without the mutex locked, creating race conditions.
Are you reading any
36 matches
Mail list logo
