D13912: Use non deprecated replace in ForwardingSlave

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY There is no contract that ensures entry

D13913: Use non deprecated fastInsert and replace in http.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY In davParsePropstats there are chances of

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/61/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 05 Jul 2018 17:29:45 + Build duration: 16 hr and counting JUnit Tests Name:

D13915: Use non deprecated fastInsert in file_unix

jtamate added a dependency: D13782: RFC: Ignore NTFS hidden flag for root volume. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13915 To: jtamate, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

jtamate added a dependent revision: D13915: Use non deprecated fastInsert in file_unix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13913: Use non deprecated fastInsert and replace in http.cpp

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13913 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin created this revision. aleksejshilin added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Dolphin and KIO default

D13627: [KIconThemes] Isolate private data from race conditions

dfaure added a comment. "global map that holds per thread iconloader instances" is called QThreadStorage. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein Cc: hein, kde-frameworks-devel,

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Since the goal is to speed up findByUrl, can you add a Q_BENCHMARK for findByUrl? I do expect it to be faster of course --- a little bit at the expense of the code which

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37240. jtamate marked 2 inline comments as done. jtamate added a comment. Incorporated Stephan code. Fill again the extra data like User/Group. I don't see any change and I don't want to break anything more. REPOSITORY R241 KIO CHANGES SINCE LAST

D13917: Use non deprecated fastInsert in renameDialog

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY The entries are local variables.

D13676: Make it possible to change directory up even with trailing slashes in the url

dfaure added a comment. Unittests would help ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13676 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13915: Use non deprecated fastInsert in file_unix

jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY The entry is local. REPOSITORY R241 KIO REVISION

D13914: Avoid compiler warnings for taglib headers

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH avoidtaglibheaderwarnings REVISION DETAIL https://phabricator.kde.org/D13914 To: kossebau, mgallien Cc: kde-frameworks-devel,

D13914: Avoid compiler warnings for taglib headers

This revision was automatically updated to reflect the committed changes. Closed by commit R286:90a9ff80ca3b: Avoid compiler warnings for taglib headers (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13914?vs=37226=37228

D12945: kcoredirlister lstItems benchmark

dfaure added a comment. It's also interesting to look at numbers for small directories (which is still the most common case, too). This code could use a run of uncrustify to match the coding style of the rest of kio, but otherwise it looks good. INLINE COMMENTS >

D13910: Use non deprecated fastInsert in remoteimpl.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY All entries are cleared before fastInsert

D13914: Avoid compiler warnings for taglib headers

kossebau created this revision. kossebau added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Declaring them as system headers (->

D13816: Make KItinerary work as a static library

vkrause added a comment. In D13816#287459 , @lepagevalleeemmanuel wrote: > > Or does anyone have an idea how to solve this more elegantly? :) > > Hi, we talked about this at Randa and QtWorldSummit last year. Sorry for stopping working on

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 37229. broulik added a comment. Also check for `DT_UNKNOWN` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36838=37229 REVISION DETAIL https://phabricator.kde.org/D13782 AFFECTED FILES

D13908: Use non deprecated fastInsert in ftp.cpp

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13908 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13909: Use non deprecated fastInsert in kfileitemtest

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13909 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13912: Use non deprecated replace in ForwardingSlave

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13912 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13910: Use non deprecated fastInsert in remoteimpl.cpp

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13910 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux added a comment. The 5.48 release is close. Don't forget to push these changes. REPOSITORY R240 Extra CMake Modules BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry, cgiboudeaux Cc:

D13918: Use non deprecated fastInsert in kio_trash

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I remember there were good reasons for not setting UDS_LOCAL_PATH in kio_trash, but by now I forgot what they were exactly :-) I expect that some code will resolve to local paths

D13916: Use non deprecated fastInsert in slaveBase

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13916 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13917: Use non deprecated fastInsert in renameDialog

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13917 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13916: Use non deprecated fastInsert in slaveBase

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Entry is local. REPOSITORY R241 KIO

D13918: Use non deprecated fastInsert in kio_trash

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY This is the last one for kio The entry

D13915: Use non deprecated fastInsert in file_unix

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13915 To: jtamate, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

bruns added inline comments. INLINE COMMENTS > jtamate wrote in file.cpp:864 > According to the man page (2+3), readlink() //does not append a null byte to > buf//. > > It will (silently) truncate the contents (to a length of bufsiz > characters), in case the buffer is too small to hold all

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/62/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 09:51:06 + Build duration: 5 min 36 sec and counting JUnit Tests

D13913: Use non deprecated fastInsert and replace in http.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:de53875a6f52: Use non deprecated fastInsert and replace in http.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13913?vs=37225=37263

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/63/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 14:48:05 + Build duration: 4 min 54 sec and counting JUnit Tests

D13635: Fixes for Java comments

This revision was automatically updated to reflect the committed changes. Closed by commit R216:8f28e0b576e1: Fixes for Java comments (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13635?vs=36400=37274#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D13926: Avoid warnings for PolkitQt5-1 headers

kossebau created this revision. kossebau added a reviewer: shumski. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Adding the include dir as SYSTEM makes the

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.10/18/ Project: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 06 Jul 2018 16:25:05 + Build duration: 13 min and counting JUnit Tests

D13880: [KMoreTools] Reduce menu hierarchy

gregormi added a comment. The spirit goes in the right direction; please proceed :-). Note, that Kate's project plugin also uses KMoreTools. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc:

D13909: Use non deprecated fastInsert in kfileitemtest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2bd52926734: Use non deprecated fastInsert in kfileitemtest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13909?vs=37219=37260 REVISION

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 102 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/102/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 15:34:50 + Build duration: 5 min 22 sec and counting

D13358: Add new class that is a model of numbers between two values

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D13358 To: davidedmundson, vkrause Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D13635: Fixes for Java comments

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I'll give the OK, but please increase kateversion to 5.0 first. INLINE COMMENTS > javadoc.xml:3 > > - extensions="" license="LGPL" author="Alfredo Luiz Foltran Fialho >

D13910: Use non deprecated fastInsert in remoteimpl.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b4708f4ce2ec: Use non deprecated fastInsert in remoteimpl.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13910?vs=37221=37261 REVISION

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/65/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 14:57:46 + Build duration: 3 min 54 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 158 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/158/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Jul 2018 15:10:37 + Build duration: 4 min 37 sec and counting JUnit Tests Name:

D13908: Use non deprecated fastInsert in ftp.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f4b6e71c6839: Use non deprecated fastInsert in ftp.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13908?vs=37218=37259 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 309 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/309/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 14:55:03 + Build duration: 4 min 42 sec and counting JUnit Tests Name:

D13918: Use non deprecated fastInsert in kio_trash

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13918 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/66/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 15:01:43 + Build duration: 4 min 12 sec and counting JUnit Tests

D13916: Use non deprecated fastInsert in slaveBase

This revision was automatically updated to reflect the committed changes. Closed by commit R241:be6075a2659f: Use non deprecated fastInsert in slaveBase (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13916?vs=37230=37270 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 311 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/311/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 15:07:25 + Build duration: 4 min 27 sec and counting JUnit Tests Name:

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

bruns added inline comments. INLINE COMMENTS > file.cpp:889 > +#if HAVE_POSIX_ACL > +targetPath = linkTarget.toLocal8Bit(); > +#endif isn't this the same as linkTargetBuffer? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13898 To: jtamate, dfaure,

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni added a comment. https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603 So the problem maybe not here as IconLoader loads icons but in icon writer @davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ? REPOSITORY R302

D13918: Use non deprecated fastInsert in kio_trash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7b1210091c55: Use non deprecated fastInsert in kio_trash (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13918?vs=37232=37265 REVISION DETAIL

D13917: Use non deprecated fastInsert in renameDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e7bd1c4b0abe: Use non deprecated fastInsert in renameDialog (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13917?vs=37231=37271 REVISION DETAIL

D13912: Use non deprecated replace in ForwardingSlave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:30a0b32d10e4: Use non deprecated replace in ForwardingSlave (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13912?vs=37224=37262 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/64/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 14:53:01 + Build duration: 4 min 40 sec and counting JUnit Tests

D13814: Speedup sort

This revision was automatically updated to reflect the committed changes. Closed by commit R318:63825de82f3a: Speedup sort (authored by jtamate). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37182=37273 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 312 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/312/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 15:11:53 + Build duration: 6 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 15:34:50 + Build duration: 6 min 22 sec and

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. Sounds good to me! It sounds like we're all in agreement? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13915: Use non deprecated fastInsert in file_unix

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7048d259529f: Use non deprecated fastInsert in file_unix (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13915?vs=37227=37264 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 308 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/308/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 14:48:05 + Build duration: 6 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 310 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/310/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Jul 2018 15:01:10 + Build duration: 4 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 157 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/157/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Jul 2018 14:48:05 + Build duration: 22 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/44/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Jul 2018 15:34:50 + Build duration: 3 min 42 sec and counting

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/45/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Jul 2018 03:17:18 + Build duration: 7 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Jul 2018 03:17:17 + Build duration: 1 min 44 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/67/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 15:07:25 + Build duration: 4 hr 57 min and counting JUnit Tests Name:

D13814: Speedup sort

jtamate added a comment. I really, really hate these things. I've been testing this patch more than one month without any problem. And now, after pushing it, I got crashes everytime I start dolphin without parameters (user home). But not if I start it in / and keep changing

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 22:59:09 + Build duration: 37 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/68/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 20:05:10 + Build duration: 6 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 06 Jul 2018 22:54:41 + Build duration: 21 sec and counting CONSOLE OUTPUT

D13829: Lua: fix multi-line string

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R216 Syntax Highlighting BRANCH lua REVISION DETAIL https://phabricator.kde.org/D13829 To: jpoelen, dhaumann, cullmann, #ktexteditor, #kate Cc:

D13884: [KMessageWidget] Update stylesheet when palette changes

dhaumann added a comment. Late to the game, but also +1 from me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37216. jtamate marked 3 inline comments as done. jtamate added a comment. Added a comment: // readlink doesn't append a null byte to linkTargetBuffer.data() Using target path to read ACL in a non broken symbolic link. Do not fill remaining data in

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:864 > This is broken (although not new). > > `buff.st_size` is the size of the target name **without** null byte. > readlink(..., .., bufferSize) thus will typically read exactly bufferSize > bytes, thus n == bufferSize >

D13908: Use non deprecated fastInsert in ftp.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use fastInsert instead of insert. All

D13909: Use non deprecated fastInsert in kfileitemtest

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use fastInsert instead of insert.