D13670: Add subseq operator to match sub-sequences

2018-07-08 Thread Michael Eden
michaeleden added a dependent revision: D13988: Use subseq matching for service 
runner.

REPOSITORY
  R309 KService

BRANCH
  feature/match-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13670

To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/73/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 09 Jul 2018 03:11:53 +
 Build duration:
8 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(405/2095)17%
(186/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)91%
(112/123)48%
(46/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)68%
(30/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
   

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 50 - Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/50/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 09 Jul 2018 03:11:53 +
 Build duration:
3 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)20%
(429/2095)19%
(209/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
 

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 08 Jul 2018 22:47:46 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)46%
(35/76)46%
(35/76)40%
(4042/10044)32%
(2013/6202)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(1343/1360)49%
(432/886)src53%
(28/53)53%
(28/53)35%
(2699/7765)30%
(1581/5191)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/274)0%
(0/67)tests0%
(0/10)0%
(0/10)0%
(0/585)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/12)

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/22/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 08 Jul 2018 22:43:49 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7105/9495)55%
(3479/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3010/3137)52%
(1266/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1378)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D13965: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R311:fd8f94d86359: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13965?vs=37333=37417

REVISION DETAIL
  https://phabricator.kde.org/D13965

AFFECTED FILES
  CMakeLists.txt

To: arojas, valir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13983: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R314:2d4d34b5ef32: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R314 KJs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13983?vs=37361=37416

REVISION DETAIL
  https://phabricator.kde.org/D13983

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13976: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R292:6e1110f1df1e: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13976?vs=37350=37415

REVISION DETAIL
  https://phabricator.kde.org/D13976

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 08 Jul 2018 22:52:24 +
 Build duration:
46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest

D13975: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R291:d962a0d04275: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R291 KPty

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13975?vs=37349=37413

REVISION DETAIL
  https://phabricator.kde.org/D13975

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13959: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:3a058181c8ef: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13959?vs=37326=37410

REVISION DETAIL
  https://phabricator.kde.org/D13959

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13964: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:4bf77fb4eb99: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13964?vs=37332=37411

REVISION DETAIL
  https://phabricator.kde.org/D13964

AFFECTED FILES
  CMakeLists.txt

To: arojas, mck182, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13963: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R288:08d6672f5928: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13963?vs=37331=37409

REVISION DETAIL
  https://phabricator.kde.org/D13963

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Jul 2018 22:47:46 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.kxmlgui_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)46%
(35/76)46%
(35/76)40%
(4044/10044)32%
(2014/6202)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(1343/1360)49%
(432/886)src53%
(28/53)53%
(28/53)35%
(2701/7765)30%
(1582/5191)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/274)0%
(0/67)tests0%
(0/10)0%
(0/10)0%
(0/585)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/12)

D13962: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:94b5c7e0dd40: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13962?vs=37330=37408

REVISION DETAIL
  https://phabricator.kde.org/D13962

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D12865: transferjob new connect syntax

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12865

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13960: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:54ed625ac551: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13960?vs=37327=37407

REVISION DETAIL
  https://phabricator.kde.org/D13960

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Jul 2018 22:43:48 +
 Build duration:
3 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7102/9495)55%
(3476/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3006/3137)52%
(1264/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)44%
(293/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3313/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D13956: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R276:0bfc8d73ab03: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13956?vs=37323=37406

REVISION DETAIL
  https://phabricator.kde.org/D13956

AFFECTED FILES
  CMakeLists.txt

To: arojas, davidedmundson, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 08 Jul 2018 22:43:48 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm

D12872: ScalableTest, add "scalable" plasma-browser-integration

2018-07-08 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yes, please. My emails to Andreas Kainz about this unittest failure (on 9 
June and 8 July -- ok that second one was yesterday) didn't get any reaction. 
Let's fix the tests, and if this is wrong someone can tell us ;)

REPOSITORY
  R266 Breeze Icons

BRANCH
  scalable_pbi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12872

To: maximilianocuria, #frameworks, dfaure, andreaska, andreask
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13955: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:55377a85a70f: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13955?vs=37322=37405

REVISION DETAIL
  https://phabricator.kde.org/D13955

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13954: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R271:4349c759a4e4: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13954?vs=37321=37403

REVISION DETAIL
  https://phabricator.kde.org/D13954

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13953: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R285:d1094af0e34c: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13953?vs=37320=37402

REVISION DETAIL
  https://phabricator.kde.org/D13953

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13952: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:432169e7acc8: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13952?vs=37319=37401

REVISION DETAIL
  https://phabricator.kde.org/D13952

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13951: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:6657decb1d4b: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13951?vs=37317=37400

REVISION DETAIL
  https://phabricator.kde.org/D13951

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13950: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R273:50c20f8c7d46: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13950?vs=37316=37399

REVISION DETAIL
  https://phabricator.kde.org/D13950

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13945: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:b08104d00a44: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13945?vs=37311=37398

REVISION DETAIL
  https://phabricator.kde.org/D13945

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13965: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D13965

To: arojas, valir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13976: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D13976

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13983: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R314 KJs

REVISION DETAIL
  https://phabricator.kde.org/D13983

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13964: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D13964

To: arojas, mck182, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13975: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R291 KPty

REVISION DETAIL
  https://phabricator.kde.org/D13975

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13956: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D13956

To: arojas, davidedmundson, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13963: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D13963

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13959: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13959

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13960: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D13960

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13955: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D13955

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13949: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:b15446a2288d: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13949?vs=37315=37397

REVISION DETAIL
  https://phabricator.kde.org/D13949

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13962: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13962

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13953: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D13953

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 08 Jul 2018 22:35:53 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

D13952: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D13952

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13954: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D13954

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/35/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 08 Jul 2018 22:35:53 +
 Build duration:
3 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6240/8332)43%
(10010/23181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2665/2741)49%
(5716/11733)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13946: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R270:b6c89b7e7b08: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13946?vs=37312=37395

REVISION DETAIL
  https://phabricator.kde.org/D13946

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/90/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Jul 2018 22:35:53 +
 Build duration:
3 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6241/8332)43%
(10019/23183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2667/2741)49%
(5725/11731)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13951: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D13951

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13945: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D13945

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13946: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D13946

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13950: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D13950

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13949: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D13949

To: arojas, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13943: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:6c2b95f4c3be: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13943?vs=37309=37394

REVISION DETAIL
  https://phabricator.kde.org/D13943

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:bb56c91ede0f: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13941?vs=37307=37393

REVISION DETAIL
  https://phabricator.kde.org/D13941

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns


D13941: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13941

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns


D13943: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13943

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13993: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R316:a4cb54ea637a: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R316 KMediaPlayer

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13993?vs=37373=37392

REVISION DETAIL
  https://phabricator.kde.org/D13993

AFFECTED FILES
  CMakeLists.txt

To: arojas, alexmerry, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13977: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R279:d9404a942334: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R279 ThreadWeaver

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13977?vs=37351=37391

REVISION DETAIL
  https://phabricator.kde.org/D13977

AFFECTED FILES
  CMakeLists.txt

To: arojas, mirko, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13993: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R316 KMediaPlayer

REVISION DETAIL
  https://phabricator.kde.org/D13993

To: arojas, alexmerry, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13977: Honor BUILD_TESTING

2018-07-08 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R279 ThreadWeaver

REVISION DETAIL
  https://phabricator.kde.org/D13977

To: arojas, mirko, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13670: Add subseq operator to match sub-sequences

2018-07-08 Thread Michael Eden
michaeleden added a comment.


  @dfaure you can land it its no problem. I'm also not in a rush to get it into 
5.48 or anything (Bug 262837 is from 2011).
  I have a few diffs in review, I think I'll apply for a dev account since I'd 
like to keep doing this stuff.

REPOSITORY
  R309 KService

BRANCH
  feature/match-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13670

To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13980: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:569b588a5ede: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13980?vs=37354=37389

REVISION DETAIL
  https://phabricator.kde.org/D13980

AFFECTED FILES
  CMakeLists.txt

To: arojas, ivan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13980: Honor BUILD_TESTING

2018-07-08 Thread Ivan Čukić
ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D13980

To: arojas, ivan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13670: Add subseq operator to match sub-sequences

2018-07-08 Thread David Faure
dfaure added a comment.


  Ah, so you don't have a developer account, which means you can't push this 
commit either, and I should do it for you?
  
  Well, you could also apply for a developer account ;)
  
https://community.kde.org/Infrastructure/Get_a_Developer_Account#Apply_for_a_KDE_Developer_account
 (I hope it's still accurate).
  
  I'm tagging 5.48 today though, is there a rush to get this in, or can it wait 
for 5.49?

REPOSITORY
  R309 KService

BRANCH
  feature/match-subseq

REVISION DETAIL
  https://phabricator.kde.org/D13670

To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13940: Add syntax highlighting support for Stan

2018-07-08 Thread Jeffrey Arnold
jeffreyarnold added a comment.


  Great! I just updated the patch.  Sorry about the first patch.  Not an 
excuse, but it got lost with the number of new untracked files created during 
the build and testing processes. Should I create another patch (different 
issue) that would update the .gitignore file to include those patterns?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13940

To: jeffreyarnold, #framework_syntax_highlighting
Cc: dhaumann, pino, kde-frameworks-devel, michaelh, ngraham, bruns


D13570: Add workaround for labels with word-wrapping

2018-07-08 Thread Elvis Angelaccio
elvisangelaccio planned changes to this revision.
elvisangelaccio added a comment.


  There is no bugreport, I'll have to file one.
  
  While working on a minimal test case I realized that 
`QBoxLayout::addStretch()` might also be involved. Needs more investigation.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13570

To: elvisangelaccio, davidedmundson, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13940: Add syntax highlighting support for Stan

2018-07-08 Thread Jeffrey Arnold
jeffreyarnold updated this revision to Diff 37388.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13940?vs=37303=37388

REVISION DETAIL
  https://phabricator.kde.org/D13940

AFFECTED FILES
  autotests/folding/highlight.stan.fold
  autotests/html/highlight.stan.html
  autotests/input/highlight.stan
  autotests/reference/highlight.stan.ref
  data/syntax/stan.xml

To: jeffreyarnold, #framework_syntax_highlighting
Cc: dhaumann, pino, kde-frameworks-devel, michaelh, ngraham, bruns


D13370: haskell.xml: add keywords family, forall, pattern

2018-07-08 Thread Li-yao Xia
xialiyao added a comment.


  Sure thing, I can add some description next time. Thanks for the reviews!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13370

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D13970: Handle empty preview lists

2018-07-08 Thread Andreas Cord-Landwehr
cordlandwehr removed reviewers: gregormi, nicolasfella, dhaumann, Frameworks.
cordlandwehr added a comment.
This revision now requires review to proceed.


  I had a crash at the respective locations while porting Artikulate to the 
QtQuick based API, since those KNS resource files do not provide previews.
  However, IMO this patch fixes an unsafe access to a list element without 
checking that it exists.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13970

To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13970: Handle empty preview lists

2018-07-08 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  In any case, this patch will not break things.

REPOSITORY
  R304 KNewStuff

BRANCH
  bugfix/allowEmptyPreviewLists

REVISION DETAIL
  https://phabricator.kde.org/D13970

To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13970: Handle empty preview lists

2018-07-08 Thread gregormi
gregormi added a comment.


  I am rather familiar with KMoreTools but not with the rest of KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13970

To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13940: Add syntax highlighting support for Stan

2018-07-08 Thread Dominik Haumann
dhaumann added a comment.


  Looks already pretty good to me, but indeed highlight.stan is missing - the 
test file for the autotest. Could you add it and update the patch?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13940

To: jeffreyarnold, #framework_syntax_highlighting
Cc: dhaumann, pino, kde-frameworks-devel, michaelh, ngraham, bruns


D13380: haskell.xml: don't highlight Prelude data constructors differently from others

2018-07-08 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:44bc7c609dad: haskell.xml: dont highlight Prelude 
data constructors differently from others (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13380?vs=35703=37385#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13380?vs=35703=37385

REVISION DETAIL
  https://phabricator.kde.org/D13380

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  data/syntax/haskell.xml

To: xialiyao, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13380: haskell.xml: don't highlight Prelude data constructors differently from others

2018-07-08 Thread Dominik Haumann
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-data-prelude

REVISION DETAIL
  https://phabricator.kde.org/D13380

To: xialiyao, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13386: haskell.xml: remove types from "prelude function" section

2018-07-08 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c78ba1bd98dc: haskell.xml: remove types from 
prelude function section (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13386?vs=35706=37384

REVISION DETAIL
  https://phabricator.kde.org/D13386

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.lhs.ref
  data/syntax/haskell.xml

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D13386: haskell.xml: remove types from "prelude function" section

2018-07-08 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Nice patches, thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-remove-nonsense

REVISION DETAIL
  https://phabricator.kde.org/D13386

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D13373: haskell.xml: highlight promoted data constructors

2018-07-08 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6db3d08c8ecb: haskell.xml: highlight promoted data 
constructors (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13373?vs=35658=37383

REVISION DETAIL
  https://phabricator.kde.org/D13373

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  data/syntax/haskell.xml

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13373: haskell.xml: highlight promoted data constructors

2018-07-08 Thread Dominik Haumann
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-promoted-types

REVISION DETAIL
  https://phabricator.kde.org/D13373

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13370: haskell.xml: add keywords family, forall, pattern

2018-07-08 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7a45d5e122ad: haskell.xml: add keywords family, forall, 
pattern (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13370?vs=35649=37382#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13370?vs=35649=37382

REVISION DETAIL
  https://phabricator.kde.org/D13370

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  data/syntax/haskell.xml

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D13370: haskell.xml: add keywords family, forall, pattern

2018-07-08 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Can you for future review requests please add some description of what the 
patch changes? That would be very helpful for reviewing.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haskell-keywords

REVISION DETAIL
  https://phabricator.kde.org/D13370

To: xialiyao, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D13970: Handle empty preview lists

2018-07-08 Thread Dominik Haumann
dhaumann added a comment.


  Which bug in which context does this fix? The information given is a bit 
'thin' ;-)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13970

To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13985: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b3cc8b84714d: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13985?vs=37364=37381

REVISION DETAIL
  https://phabricator.kde.org/D13985

AFFECTED FILES
  CMakeLists.txt

To: arojas, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13985: Honor BUILD_TESTING

2018-07-08 Thread Volker Krause
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13985

To: arojas, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 49 - Fixed!

2018-07-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/49/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 08 Jul 2018 19:00:02 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)21%
(435/2095)20%
(214/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

D13947: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:00646c782459: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13947?vs=37313=37380

REVISION DETAIL
  https://phabricator.kde.org/D13947

AFFECTED FILES
  CMakeLists.txt

To: arojas, mdawson, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 12 - Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/12/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 08 Jul 2018 19:04:27 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtestFailed: TestSuite.kconfigcore-test_kconf_update

D13987: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:5ec96d346322: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13987?vs=37367=37379

REVISION DETAIL
  https://phabricator.kde.org/D13987

AFFECTED FILES
  CMakeLists.txt

To: arojas, afiestas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13989: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R307:1599ed797389: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13989?vs=37369=37377

REVISION DETAIL
  https://phabricator.kde.org/D13989

AFFECTED FILES
  CMakeLists.txt

To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

2018-07-08 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/72/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 08 Jul 2018 19:00:02 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(406/2095)17%
(186/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
   

D13991: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R312:6239b73d5fa8: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R312 KXmlRpcClient

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13991?vs=37371=37376

REVISION DETAIL
  https://phabricator.kde.org/D13991

AFFECTED FILES
  CMakeLists.txt

To: arojas, dvratil, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 37 - Fixed!

2018-07-08 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/37/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 08 Jul 2018 19:00:02 +
 Build duration:
1 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D13947: Honor BUILD_TESTING

2018-07-08 Thread Matthew Dawson
mdawson accepted this revision.
mdawson added a comment.
This revision is now accepted and ready to land.


  LGTM, thanks!

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13947

To: arojas, mdawson, dfaure
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns


D13992: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:f03e2db94959: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13992?vs=37372=37375

REVISION DETAIL
  https://phabricator.kde.org/D13992

AFFECTED FILES
  CMakeLists.txt

To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13986: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R301:e7f4466de3b5: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R301 KEmoticons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13986?vs=37366=37374

REVISION DETAIL
  https://phabricator.kde.org/D13986

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13993: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
arojas created this revision.
arojas added reviewers: alexmerry, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Only build tests if BUILD_TESTING is on

TEST PLAN
  Builds

REPOSITORY
  R316 KMediaPlayer

REVISION DETAIL
  https://phabricator.kde.org/D13993

AFFECTED FILES
  CMakeLists.txt

To: arojas, alexmerry, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13987: Honor BUILD_TESTING

2018-07-08 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D13987

To: arojas, afiestas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13989: Honor BUILD_TESTING

2018-07-08 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D13989

To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13986: Honor BUILD_TESTING

2018-07-08 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D13986

To: arojas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13991: Honor BUILD_TESTING

2018-07-08 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R312 KXmlRpcClient

REVISION DETAIL
  https://phabricator.kde.org/D13991

To: arojas, dvratil, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D13992: Honor BUILD_TESTING

2018-07-08 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13992

To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


  1   2   >