D14154: Add

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Please change commit title "Add" by a commit title which explains what your commit will do. thanks REPOSITORY R175 PIM: KHolidays REVISION DETAIL

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 38050. tmarshall marked 8 inline comments as done. tmarshall added a comment. I've made the requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13805?vs=36954=38050 REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/82/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Thu, 19 Jul 2018 03:22:59 + Build duration: 3 min 37 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/59/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 19 Jul 2018 03:22:59 + Build duration: 2 min 36 sec and counting JUnit Tests

D14131: Add enum alias Property::Language for typo Property::Langauge

mgallien added a comment. In D14131#294528 , @aacid wrote: > Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;) I am in holidays for 3 weeks and unable

D14131: Add enum alias Property::Language for typo Property::Langauge

aacid added a comment. Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D14131 To: kossebau, mgallien Cc: aacid,

D13808: Fix KMainWindow saving incorrect widget settings

aacid added a comment. In D13808#293759 , @maxrd2 wrote: > Events from the window system seem to be handled after normal events. > http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70

D14218: Introduce a test to make sure we're not offering duplicated icons

apol edited the test plan for this revision. apol added reviewers: andreaska, mart, vkrause, Framework: Syntax Highlighting. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting Cc:

D14218: Introduce a test to make sure we're not offering duplicated icons

apol created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY At the moment we have them separate in actions, places, applications. This distinction is

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. Thanks! BTW, It's now technically acceptable for the `BUG:` keyword to go at the beginning. Sysadmins fixed the bug that was preventing this from working before. @broulik does this patch make sense to you? For me it does not break the case of the same document

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks, cfeck Cc:

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

cfeck edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a comment. Thanks for the update! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. Sorry for the delay @ngraham . I've been traveling. I'll have these changes complete by the end of today. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck,

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a comment. @tmarshall, any update on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel,

D12820: Add KWayland virtual desktop protocol

mart added a comment. classes renamed to fooUnstableV1, but i need comments, i'm not sure about the naming or how to manage the fact that's unstable.. ‎‎Most of the unstable protocols just have the protocol implementation as unstable, but already kinda commit to stability to the c++

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 38017. mart added a comment. - fix initial state on createresource - send done to new clients - desktops shouldn't be deleted when the clients go away - iget rid of setActiveDesktop - rename the virtual desktop to Unstable REPOSITORY R127 KWayland

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

muhlenpfordt created this revision. muhlenpfordt added reviewers: dfaure, broulik, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. muhlenpfordt requested review of this revision. REVISION SUMMARY Default shortcuts for

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/32/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 18 Jul 2018 09:13:38 + Build duration: 6 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/43/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 18 Jul 2018 09:14:11 + Build duration: 4 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/42/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 18 Jul 2018 09:01:51 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/31/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 18 Jul 2018 09:01:51 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/70/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Wed, 18 Jul 2018 09:07:59 + Build duration: 3 min 50 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Wed, 18 Jul 2018 09:01:51 + Build duration: 6 min 7 sec and counting JUnit Tests

D14184: Reduce unnecessary long wait times on failing signal spies

This revision was automatically updated to reflect the committed changes. Closed by commit R127:919ee2ac6afd: Reduce unnecessary long wait times on failing signal spies (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D14183: Fix selection and seat auto tests

This revision was automatically updated to reflect the committed changes. Closed by commit R127:36544d3dfbb9: Fix selection and seat auto tests (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14183?vs=37946=37998 REVISION DETAIL

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/11/ Project: Frameworks ki18n kf5-qt5 AndroidQt5.11 Date of build: Wed, 18 Jul 2018 07:29:36 + Build duration: 53 sec and counting

D14193: Don't generate files in the source directory

This revision was automatically updated to reflect the committed changes. Closed by commit R249:6342a249990a: Dont generate files in the source directory (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14193?vs=37974=37989 REVISION DETAIL

D14194: Fix the configure check for _nl_msg_cat_cntr

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7afa19b90921: Fix the configure check for _nl_msg_cat_cntr (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14194?vs=37975=37990 REVISION