D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

shubham updated this revision to Diff 39163. shubham added a comment. Re factor Remove unnecessary indentations use only !itemList.supportsMoving() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39112=39163 REVISION DETAIL

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 06 Aug 2018 03:33:59 + Build duration: 39 min and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/58/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 06 Aug 2018 03:33:59 + Build duration: 23 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Mon, 06 Aug 2018 03:33:59 + Build duration: 22 min and counting JUnit Tests

D14449: Modify device usage information

pino added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1189 > +grid->addWidget(l, curRow, 2); > +l->setText(i18nc("Device usage information","%1 used , %2 free", > KIO::convertSize(size - free), KIO::convertSize(free))); > + Also, style for i18n strings: there must

D14641: Refine wording when a folder with an invalid name could not be created

ngraham added a comment. In D14641#304077 , @markuss wrote: > If you remove the manual new-line, will everything be in a single line with a wide window or will Qt just add a line break where it fits? The window becomes really wide, yeah.

D14641: Refine wording when a folder with an invalid name could not be created

markuss added a comment. If you remove the manual new-line, will everything be in a single line with a wide window or will Qt just add a line break where it fits? I ask because with a shot name like ".." the line break looks unnatural as if the next line is a new sentence. REPOSITORY

D14643: Bump the minimum logging category to Warning

ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY Also, break the long statements when needed, trying to follow the style of the rest

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

On Sat, Aug 4, 2018 at 12:31 PM David Faure wrote: > > Any idea about this test that fails sometimes? Timing issue? The wait() > should be longer in case of slow network? > >

D14449: Modify device usage information

rkflx added a comment. In D14449#303766 , @shubham wrote: > In D14449#300327 , @ngraham wrote: > > > +1 for using the same label but putting the information on more than one line like @rkflx

D14641: Refine wording when a folder with an invalid name could not be created

ngraham retitled this revision from "Refine wording when a folder with an invalid name could not be creted" to "Refine wording when a folder with an invalid name could not be created". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14641 To: ngraham, #dolphin,

D14641: Refine wording when a folder with an invalid name could not be creted

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14641 To: ngraham, #dolphin, #frameworks, #vdg, tmarshall Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14641: Refine wording when a folder with an invalid name could not be creted

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks, VDG, tmarshall. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is follow-on for

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When a dialog has a cancel button that says,

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/40/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 05 Aug 2018 16:05:39 + Build duration: 5 hr 51 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/103/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 05 Aug 2018 20:31:47 + Build duration: 1 hr 11 min and counting JUnit Tests

D14639: Add syntax-highlighting for RDoc (R documentation)

aaronpuchert created this revision. aaronpuchert added reviewers: dhaumann, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. aaronpuchert requested review of this revision. REVISION SUMMARY The R

Re: ktextwidgets on FreeBSD

On dimanche 5 août 2018 01:41:01 CEST Ben Cooksley wrote: > On Sat, Aug 4, 2018 at 11:06 PM, David Faure wrote: > > Anyone running FreeBSD, who could to try and debug this hanging unittest > > from the ktextwidgets framework? > > > >

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 193 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/193/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 05 Aug 2018 20:31:47 + Build duration: 24 min and counting JUnit Tests Name: (root)

D14467: Auth Support: Drop privileges if target is not owned by root

dfaure added a comment. +1, the idea seems sane to me, but I'm no expert with this kind of API so I'd like someone else to check it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc:

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure added a comment. Hmm, well, for IconApplet's use case, if you never want a readonly line-edit then a major redesign is needed, switching from the lineedit to the qlabel inside of setFileNameReadOnly itself... (and using that in the code modified by this patch...). Or adding a ctor

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure added a comment. `KFilePropsPlugin::setFileNameReadOnly` checks for m_bFromTemplate for the case where the properties dialog is used by the "Create New / ..." context menu action. In that case, the source file (the template from /usr) isn't movable, but we still want to let the

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 348 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/348/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 05 Aug 2018 20:31:47 + Build duration: 6 min 12 sec and counting JUnit Tests Name:

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please re-read your diff and, indeed, revert any unnecessary changes like indentation or no-op moving of code. INLINE COMMENTS > shubham wrote in kpropertiesdialog.cpp:988 >

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. In D13869#303905 , @bruns wrote: > And thinking about it, this very likely makes your code wrong. Have you tried mounting a filesystem again after unmounting it, **using via any mean implemented via

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenametypestest.h:20 > + > +#ifndef KIO_RENAMETYPESTEST_H > +#define KIO_RENAMETYPESTEST_H Doesn't match the header filename, and anyway, feel free to

D7487: Make KCMultiDialog scrollable

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. This has caused some pain with a number of KCMs, most notably plasma-nm and kscreen, but also others too (languages, shortcuts, powerdevil, activities). See all the duplicates of

D14606: KCrash: DrKonqi cancelled = able to start...

dfaure added a comment. The crash recursion counter is increased when a SEGV happens inside the crash handler itself. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D14606 To: rjvbb, #frameworks, sitter Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303861 , @anthonyfieroni wrote: > Since you make question to new code I make for old one, did you know why Device interfaces is ever used, it's look wrong and why interfaces should be empty, after all my tests,

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb abandoned this revision. rjvbb added a comment. I'm abandoning this for now because my assumption was wrong even though my patch had the effect I intended. I'll reopen if/when I have a real fix, because there are still 2 issues here: - The inappropriate warning. This could be

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. Actually, it's even worse than that: I didn't double-check my assumptions about the use of DrKonqi's return/exit code. Looking at the code again there is actually no way that information is even obtained. The `startProcess` function simply starts DrKonqi and then

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.10/30/ Project: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 05 Aug 2018 17:59:30 + Build duration: 2 min 43 sec and counting JUnit

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

aacid added a comment. As far as i can see none of these headers get installed so should they all be renamed to _p.h ? Also if the headers don't get installed how do you use the new classes? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli,

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.9 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks attica kf5-qt5 SUSEQt5.9 Date of build: Sun, 05 Aug 2018 17:59:30 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

D14008: Use QTEST_GUILESS_MAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by heikobecker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14008?vs=37463=39143 REVISION DETAIL

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303877 , @anthonyfieroni wrote: > About loop device it should present as well > http://storaged.org/doc/udisks2-api/2.6.3/gdbus-org.freedesktop.UDisks2.Loop.html > After all you have ony hypothetical

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. Awesome! Does Dolphin need a patch to use this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. About loop device it should present as well http://storaged.org/doc/udisks2-api/2.6.3/gdbus-org.freedesktop.UDisks2.Loop.html REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, bruns Cc:

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen edited the summary of this revision. jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli retitled this revision from "Migrate D10698 from Dolphin to KIO" to "Adds a new RenameDialog to KIO with more options for batch renaming". emateli edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. Since you make question to new code I make for old one, did you why Device interfaces is ever used, it's look wrong and they should be empty, after all my tests, it's easy to see that they are never empty. REPOSITORY R245 Solid REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION

D14631: Migrate D10698 from Dolphin to KIO

emateli added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Migrate D10698 from Dolphin to KIO

emateli created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. emateli requested review of this revision. REPOSITORY R241 KIO BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

shubham added a comment. In D14610#303706 , @rkflx wrote: > In D14610#303537 , @rkflx wrote: > > > `KPropertiesDialog::setFileNameReadOnly` > > `m_bFromTemplate` > > > @shubham Any comments

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/48/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sun, 05 Aug 2018 16:05:39 + Build duration: 14 min and counting JUnit Tests Name:

D14008: Use QTEST_GUILESS_MAIN

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D14008 To: heikobecker, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

dfaure added a comment. In D14606#303654 , @rjvbb wrote: > I think there is no way at this level of interaction to determine if an application crashed after start and distinguish that from something like a "user-cancelled" return code, or is

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 75 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/75/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sun, 05 Aug 2018 16:05:39 + Build duration: 8 min 18 sec and counting JUnit Tests

D13730: Fix memory management in WaylandOutputManagement

This revision was automatically updated to reflect the committed changes. Closed by commit R127:baba76289560: Fix memory management in WaylandOutputManagement (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13730?vs=36663=39133

D13729: Isolate every test within WaylandOutputManagement

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d6a250cfb16b: Isolate every test within WaylandOutputManagement (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13729?vs=36662=39132

D13601: OutputManagement fractional scaling

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:c981d5406f80: OutputManagement fractional scaling (authored by davidedmundson). CHANGED PRIOR TO COMMIT

D12388: Output device color curves correction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:3d06279076f1: Output device color curves correction (authored by romangg, committed by davidedmundson). CHANGED PRIOR

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#303563 , @ngraham wrote: > FWIW, we got a thumbs up from someone in https://bugs.kde.org/show_bug.cgi?id=394348: A thumbs up is nice, but this does not catch the thumbs down of all the persons who are

D13869: [solid] Notify when interface to mounted fs is lost

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The change needs a proper commit message. A reference to the bug tracker is not sufficient. The commit message should (at least) include: - Description of the setup -

D14627: KCookieJar: fix wrong timezone conversion.

dfaure created this revision. dfaure added a reviewer: stefanocrocco. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY Those format strings

D14449: Modify device usage information

shubham added a comment. In D14449#300327 , @ngraham wrote: > +1 for using the same label but putting the information on more than one line like @rkflx suggests. sorry for causing trouble : ( REPOSITORY R241 KIO REVISION DETAIL

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. I'm using too. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: ngraham, bcooksley, bruns, kde-frameworks-devel, michaelh

D14449: Modify device usage information

rkflx added a comment. > This comment has been deleted. You are doing this in every other Diff, which is a bit annoying. Please first check what you wrote, then click on Send. Otherwise people will just ignore notifications. > is there any other simpler way to achieve this?

D14449: Modify device usage information

shubham added a comment. In D14449#303710 , @rkflx wrote: > - The vertical spacing between the first and the second line is too big, it should be the same as for Size:. is there any other simpler way to achieve this? INLINE COMMENTS >

D14449: Modify device usage information

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. Thanks, looking better than before now. There are still some improvements you could make: - There is a superfluous space before the comma in the second line. - I'd prefer the

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

rkflx added a comment. In D14610#303537 , @rkflx wrote: > `KPropertiesDialog::setFileNameReadOnly` > `m_bFromTemplate` @shubham Any comments on that (see my questions to @dfaure above)? INLINE COMMENTS > kpropertiesdialog.cpp:988 > +

D14449: Modify device usage information

shubham edited reviewers, added: rkflx; removed: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx, elvisangelaccio Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

shubham updated this revision to Diff 39120. shubham added a comment. F6176187: 2.png @rkflx is this okay now? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14449?vs=38784=39120 REVISION DETAIL

D14449: Modify device usage information

shubham added a comment. > Not if you set a maximum width. @rkflx eeh, skipped from my mind btw , then it is doable REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann,

D14008: Use QTEST_GUILESS_MAIN

heikobecker added a comment. Ping? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D14008 To: heikobecker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

rkflx added a comment. In D14449#303660 , @shubham wrote: > > Let me plug my suggestion again: > > > > Device capacity: ==- 24% used of 94.4 Gib > >22.5 GiB used, 71.9 GiB free > > > > if this design is

D14449: Modify device usage information

shubham added a comment. > Let me plug my suggestion again: > > Device capacity: ==- 24% used of 94.4 Gib >22.5 GiB used, 71.9 GiB free > if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good.

D14606: KCrash: DrKonqi cancelled = able to start...

rjvbb added a comment. > > if DrKonqi gives an exit code that means it was started > > It could have crashed though... Yeah, that was meant as a snarky remark - even if it crashed it was still started :) I think there is no way at this level of interaction to determine if

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

shubham updated this revision to Diff 39112. shubham added a comment. Re-use Qlabel REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39082=39112 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp