KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 27 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/27/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:52 + Build duration: 13 hr and counting

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-11 Thread Nathaniel Graham
ngraham added a comment. Are you waiting for another review before landing this? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

2018-08-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > udisksmanager.cpp:239 > +emit deviceRemoved(udi); > +emit deviceAdded(udi); > } Your code seems to work, but i don't get it - why device is added again? How predicate will work on removed device? REPOSITORY R245 So

<    1   2