D14661: Force reevaluation of Predicates if interfaces are removed

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Not pretty but if it works.. Thanks!

REPOSITORY
  R245 Solid

BRANCH
  test

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Anthony Fieroni]

anthonyfieroni added a reviewer: apol.
anthonyfieroni added a subscriber: apol.
anthonyfieroni added a comment.


  Since solid does not have a maintainer, you can wait for @apol or @broulik or 
ship it before 5.50 tagging.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D11838: Turn on line numbers by default

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R40:d7b19c5abffc: turn on line numbers and line modifications 
per default for Kate (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11838?vs=31064=39753#toc

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11838?vs=31064=39753

REVISION DETAIL
  https://phabricator.kde.org/D11838

AFFECTED FILES
  kate/main.cpp

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: kwrite-devel, kde-frameworks-devel, cullmann, aacid, acrouthamel, brauch, 
mludwig, kfunk, dhaumann, michaelh, kevinapavew, ngraham, bruns, demsking, sars

D14847: Fix crash when replacing \n around empty lines

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-replace-newline-empty-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14847

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14847: Fix crash when replacing \n around empty lines

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, 
mwolff.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  The problem is that QString("").startsWith("") returns false.
  Similarly, QString("").endsWith("") also returns false.
  However, the code previously was assuming that both cases return true.
  
  This is now fixed, and verified through unit tests.
  
  BUG: 381080
  
  This deprecates patch D6473 

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-replace-newline-empty-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14847

AFFECTED FILES
  autotests/src/searchbar_test.cpp
  autotests/src/searchbar_test.h
  src/search/kateplaintextsearch.cpp

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D6473: Crash when replacing new lines with spaces

[Dominik Haumann]

dhaumann abandoned this revision.
dhaumann added a comment.


  Fixed in D14847  in a different way.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: dhaumann, #ktexteditor, jsalatas
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14828: remove highlighting download dialog

[René J . V . Bertin]

rjvbb added a comment.


  Downloading already didn't work for me since quite a while (the operation 
never completed) but what does this mean for highlighting files I write myself 
(or someone's mom does)?
  
  > Other users who do not follow the latest development releases [...] are 
likely not the target audience for downloading highlighting files.
  
  I take a bit exception with this; users of certain distributions that aim to 
allow them to work *with* the software instead of *on* (as in applying updates) 
are being compared with a rather negative and probably sexist view of their 
mother. The opposite is true for many such users: working with stable releases 
means you have more reason to update things like highlighting files.
  
  FWIW, there was never a reason to have a download/update button in the 
"userland" configure UI; a KCM provided by the highlighting framework would 
make perfect sense (that same KCM could serve to disable/uninstall useless 
highlighting files; your mom probably doesn't need more than half the ones that 
get installed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14828

To: cullmann, dhaumann
Cc: rjvbb, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14847: Fix crash when replacing \n around empty lines

[Dominik Haumann]

dhaumann updated this revision to Diff 39737.
dhaumann added a comment.


  - Optimize by checking isEmpty()

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14847?vs=39736=39737

BRANCH
  fix-replace-newline-empty-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14847

AFFECTED FILES
  autotests/src/searchbar_test.cpp
  autotests/src/searchbar_test.h
  src/search/kateplaintextsearch.cpp

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14817: Convert manual install test to an autotest

[Luigi Toscano]

ltoscano added a comment.


  This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems 
to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 
5.9 and FreeBSD/Qt 5.10):
  
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/
  - 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/35/
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.10/
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/32/
  
  Do the logs ring any bell about the possible reason?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D13940: Add syntax highlighting support for Stan

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0a39f67256b3: Add syntax highlighting support for Stan 
(authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13940?vs=37388=39723#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13940?vs=37388=39723

REVISION DETAIL
  https://phabricator.kde.org/D13940

AFFECTED FILES
  autotests/folding/highlight.stan.fold
  autotests/html/highlight.stan.html
  autotests/input/highlight.stan
  autotests/reference/highlight.stan.ref
  data/syntax/stan.xml

To: jeffreyarnold, #framework_syntax_highlighting, cullmann
Cc: kwrite-devel, cullmann, dhaumann, pino, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

D14847: Fix crash when replacing \n around empty lines

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c90064799dfb: Fix crash when replacing \n around empty 
lines (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14847?vs=39737=39738

REVISION DETAIL
  https://phabricator.kde.org/D14847

AFFECTED FILES
  autotests/src/searchbar_test.cpp
  autotests/src/searchbar_test.h
  src/search/kateplaintextsearch.cpp

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

[Nathaniel Graham]

ngraham added a comment.


  So from in-person conversations this week, it seems like we have a few paths 
forward here:
  
  - Upstream the features we wrote into our PlasmaComponents TextField and then 
just use that. **Downsides**: lengthy process, will take forever before we can 
actually use it here.
  - Finally fix the Qt bug that prevents QQC1 and PC2 components with text from 
working properly. **Downsides**: we already tried this and accidentally made it 
worse. Seems tricky.
  - Work around the text rendering issue in the QQC1 style as well so that all 
QQC1 and PC2 components with text look fine with no other modifications. 
**Downsides**: maybe none? Am I not seeing them? @davidedmundson?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14345

To: ngraham, #plasma, mart, davidedmundson
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D6473: Crash when replacing new lines with spaces

[Dominik Haumann]

dhaumann commandeered this revision.
dhaumann edited reviewers, added: jsalatas; removed: dhaumann.
dhaumann added a comment.


  Reassign

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: dhaumann, #ktexteditor, jsalatas
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14847: Fix crash when replacing \n around empty lines

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok :P

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-replace-newline-empty-lines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14847

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D9247: Extend Scripting API to allow executing commands

[Christoph Cullmann]

cullmann accepted this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14847: Fix crash when replacing \n around empty lines

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Better test with (a.isEmpty() && b.isEmpty()) for the special case to avoid 
comparing long lines again.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14847

To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann, martinwalch, turbov.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This change relicenses the modelines.xml file to MIT license.
  Please everyone, explicitly state that you agree with the relicense change
  to MIT and accept this revision so that we can proceed.
  
  The authors are extracted from below:
  
  - Alex Turbov 
  - Christoph Cullmann 
  - Volker Krause 
  - Dominik Haumann 
  - Martin Walch 
  
  Changes to the file in syntax-highlighting.git
  ==
  
  commit 1cf26801aeeb8b8ca681a39f5f2c654769048630 

  Author: Christoph Cullmann 
  Date:   Mon Jul 24 15:25:27 2017 +0200
  
strip leading/trailing whitespaces from keywords

command: perl -pi -e 's@\s*(\S+)\s*@\1@gi' *.xml

remaining issues:

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/4dos.xml" 
line 281 keyword with leading/trailing spaces: " DATE /T "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 2896 keyword with leading/trailing spaces: " Afall, Bfall, Qfall, Qbfall, 
Tfall, Tbfall "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 2898 keyword with leading/trailing spaces: " Arise, Brise, Qrise, Qbrise, 
Trise, Tbrise "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 2903 keyword with leading/trailing spaces: " Asim_model Property in 
Element Statements "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 2987 keyword with leading/trailing spaces: " Requirements for DRACULA II "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3012 keyword with leading/trailing spaces: " Ioh1, Ioh2 "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3014 keyword with leading/trailing spaces: " Iol1, Iol2 "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3068 keyword with leading/trailing spaces: " Spike Model Data "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3195 keyword with leading/trailing spaces: " Tphz, Tplz, Tpzh, Tpzl "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3207 keyword with leading/trailing spaces: " Voh1, Voh2 "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/ample.xml" 
line 3209 keyword with leading/trailing spaces: " Vol1, Vol2 "
"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/asn1.xml" 
line 36 keyword with leading/trailing spaces: " OCTET STRING "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/coldfusion.xml"
 line 199 keyword with leading/trailing spaces: " String formatting "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 29 keyword with leading/trailing spaces: " For Input "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 30 keyword with leading/trailing spaces: " For Output "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 31 keyword with leading/trailing spaces: " For Binary "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 32 keyword with leading/trailing spaces: " For Random "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 132 keyword with leading/trailing spaces: " Byte PTR "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 133 keyword with leading/trailing spaces: " Dword PTR "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 134 keyword with leading/trailing spaces: " Qword PTR "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 135 keyword with leading/trailing spaces: " Word PTR "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 369 keyword with leading/trailing spaces: " OPTION BASE "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/freebasic.xml"
 line 370 keyword with leading/trailing spaces: " OPTION PRIVATE "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/gnuplot.xml" 
line 88 keyword with leading/trailing spaces: " data style "

"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/gnuplot.xml" 
line 89 keyword with leading/trailing spaces: " function style "
"/home/cullmann/kdesrc/frameworks/syntax-highlighting/data/syntax/php.xml" 
line 2253 keyword with leading/trailing spaces: " 

D14826: inline note interface wip #2

[Sven Brauch]

brauch created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
brauch requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14826

AFFECTED FILES
  src/document/katedocument.h
  src/include/CMakeLists.txt
  src/render/katerenderer.cpp
  src/utils/ktexteditor.cpp
  src/view/kateview.cpp
  src/view/kateview.h

To: brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14778: Disable loading of translations when using 'C' locale

[Albert Astals Cid]

aacid added a comment.


  Honestly i think that test in kformattest is wrong and that it should contain 
it's own small minitranslation so that stuff works fine and then it should be
  
QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 
milliseconds"));
  
  instead of
  
QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 
millisecond(s)"));

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14819: Get rid of deprecated QWeakPointer usage

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Replace by `QPointer`

TEST PLAN
  - Compiles, runs
  - The storage stuff compiles but isn't really tested since it relies on 
`QMetaObject::invokeMethod` but it's likely broken and unused anyway and using 
a `QPointer` in a method signature is normally not what you want to do

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14819

AFFECTED FILES
  examples/dataengines/customDataContainers/httpContainer.h
  src/declarativeimports/core/colorscope.h
  src/declarativeimports/core/serviceoperationstatus.h
  src/declarativeimports/core/svgitem.h
  src/declarativeimports/core/tooltip.h
  src/declarativeimports/core/tooltipdialog.h
  src/declarativeimports/plasmacomponents/fullscreenwindow.h
  src/declarativeimports/plasmacomponents/qmenu.h
  src/plasma/pluginloader.cpp
  src/plasma/private/datacontainer_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/storage_p.h
  src/plasma/private/storagethread.cpp
  src/plasma/private/storagethread_p.h
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.h
  src/plasmaquick/configmodel.cpp
  src/plasmaquick/configview.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14826: inline note interface wip #2

[Sven Brauch]

brauch added reviewers: michalsrb, dhaumann, cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katerenderer.cpp:765
> +// Draw inline notes
> +auto inlineNotes = m_view->inlineNotes(range->line());
> +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {

const

> katerenderer.cpp:766
> +auto inlineNotes = m_view->inlineNotes(range->line());
> +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {
> +int column = inlineNote.column();

for (const auto& inlineNote : inlineNotes) {

> katerenderer.cpp:1048-1049
> +
> +auto inlineNotes = m_view->inlineNotes(lineLayout->line());
> +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {
> +int column = inlineNote.column();

same as above

> kateview.cpp:3653-3654
> +
> +connect(provider, SIGNAL(reset()), this, SLOT(inlineNotesReset()));
> +connect(provider, SIGNAL(lineChanged(int)), this, 
> SLOT(inlineNotesLineChanged(int)));
> +

Use new syntax connect

> kateview.cpp:3666
> +
> +disconnect(provider, nullptr, this, nullptr);
> +

provider->disconnect(this);

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

[David Edmundson]

davidedmundson added a comment.


  > Upstream the features we wrote into our PlasmaComponents TextField and then 
just use that. Downsides: lengthy process, will take forever before we can 
actually use it here.
  
  Yes, but there's also no real rush from a PC POV.
  
  > Finally fix the Qt bug that prevents QQC1 and PC2 components with text from 
working properly
  > Work around the text rendering issue in the QQC1 style as well so that all 
QQC1 and PC2
  
  That's unrelated to this patch. 
  QQC1 desktop theme has that bug, 
  PC2 (despite being QQC1) does not.
  
  So I'm not sure what we actually fix?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14345

To: ngraham, #plasma, mart, davidedmundson
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: cullmann, #ktexteditor, sraizada
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann added a reviewer: sraizada.
cullmann added a comment.


  I don't think such a behavior change is wanted.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: cullmann, #ktexteditor, sraizada
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D7245: Improve reStructuredText highlighting

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Ok, then we just close this and wait for the next update.
  Thanks for the work on that!

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 52 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/52/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 14 Aug 2018 21:52:22 +
 Build duration:
41 sec and counting
   CONSOLE OUTPUT
  [...truncated 6.59 KB...] > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 467cf37fd04f7fa753d50ae43bed1092827660a7 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 467cf37fd04f7fa753d50ae43bed1092827660a7Commit message: "Indentation script for R" > git rev-list --no-walk c90064799dfb9afa7e5da20eb15856f486a171a3 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 9c4ca282d0dd255b5d72627ab4456816f6def193 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 9c4ca282d0dd255b5d72627ab4456816f6def193Commit message: "Update Clang exclusion exception information"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision e8d599830f343a3e77e0fc0ce2b134efc17bbf2e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f e8d599830f343a3e77e0fc0ce2b134efc17bbf2eCommit message: "Activate the kirigami-gallery project"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 6d5d1ce55c2ad9168c2799f6cb013eb7533e6cfa (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 6d5d1ce55c2ad9168c2799f6cb013eb7533e6cfaCommit message: "Remove kdepim-runtime dependency for messagelib, the serializers moved meanwhile"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project ktexteditor --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.10 --installTo /home/jenkins/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: 

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  In D14817#308903 , @ltoscano wrote:
  
  > This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI 
seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on 
openSUSE/Qt 5.9 and FreeBSD/Qt 5.10):
  >
  > - 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/
  
  
  14:08:13 Scanning dependencies of target po-es-docs-foobar-index-cache-bz2
  14:08:13 [  8%] Generating po/es/docs/foobar/index.cache.bz2
  14:08:13 gmake[2]: *** 
[CMakeFiles/po-es-docs-foobar-index-cache-bz2.dir/build.make:62: 
po/es/docs/foobar/index.cache.bz2] Error 1
  14:08:13 gmake[1]: *** [CMakeFiles/Makefile2:73: 
CMakeFiles/po-es-docs-foobar-index-cache-bz2.dir/all] Error 2
  14:08:13 gmake: *** [Makefile:130: all] Error 2
  reason not visible - I suggest to add VERBOSE=1 to the related make comment
  
  > - 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/35/
  
  14:11:43 Test command failed: 
C:/Craft/CI/windows-msvc2017_64-cl-debug/dev-utils/cmake/bin/cmake.exe
  14:11:43 CMake Error at C:/CI/workspace/Frameworks kdoctools kf5-qt5 
WindowsMSVCQt5.10/autotests/kdoctools-install/test.cmake:20 (message):
  14:11:43   destdir/share/man/man1/checkXML5.1 was not found
  This may be caused  by not specifing an absolute path in test.cmake e.g.
  
-set(MANPATH destdir/share/man)
-set(HTMLPATH destdir/share/doc/HTML)
+set(MANPATH ${CMAKE_INSTALL_PREFIX}/destdir/share/man)
+set(HTMLPATH ${CMAKE_INSTALL_PREFIX}/destdir/share/doc/HTML)

---test-command ${CMAKE_COMMAND}  -P 
"${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install/test.cmake
+--test-command ${CMAKE_COMMAND}  
"-DCMAKE_INSTALL_PREFIX:PATH=${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install/destdir"
 -P "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install/test.cmake"
  
  > - 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.10/
  
  #1​6 Aug 14, 2018 2:07 PM
  Finished: SUCCESS 
  no issue visible -> tests are disabled
  
  > - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/32/
  
  #3​2 Aug 14, 2018 2:07 PM
  Finished: SUCCESS 
  no issue visible -> tests are disabled

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

[David Edmundson]

davidedmundson added a comment.


  >   Placeholder text looks good with fractional scale factors (PC3 and QQC2 
ones have this, PC2 and QQC1 ones do not)
  
  No, this is where we have crossed wires.
  
  PC3, QQC2 and PC2 look good. We control the renderType.
  Only QQC1 desktop theme has the font issue.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14345

To: ngraham, #plasma, mart, davidedmundson
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

[Nathaniel Graham]

ngraham added a comment.


  Ah, I'm sorry. I'm getting my patches confused. The PC2 TextField's bug is 
that it doesn't show placeholder text properly with light themes when software 
rendering isn't being used. I'm open to other ways of fixing that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14345

To: ngraham, #plasma, mart, davidedmundson
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Sven Brauch]

brauch added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Can't we simply update our shipped schemas, and expect users with custom 
schemas to fix them?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kde-frameworks-devel, brauch, dhaumann, mwolff, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars, #frameworks

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/47/
 Project:
Frameworks kdoctools kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 Aug 2018 21:24:06 +
 Build duration:
1 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D9247: Extend Scripting API to allow executing commands

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:72c51e15659f: Extend Scripting API to allow executing 
commands (authored by dhaumann, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9247?vs=39575=39755

REVISION DETAIL
  https://phabricator.kde.org/D9247

AFFECTED FILES
  src/script/katescriptview.cpp
  src/script/katescriptview.h

To: dhaumann, cullmann, mwolff, kfunk
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

[Nathaniel Graham]

ngraham added a comment.


  To back up a bit, the issue is that we currently have no TextField with has 
the following characteristics:
  
  1. Has built-in functionality for clear and password reveal buttons, so each 
client doesn't need to re-invent the wheel (PC2 one has this, PC3, QQC1, and 
QQC2 ones do not)
  2. Placeholder text looks good with fractional scale factors (PC3 and QQC2 
ones have this, PC2 and QQC1 ones do not)
  
  My approach with this patch was to try to port the missing features to the 
PC3 TextField to solve #1, but maybe that's not the right approach? Do you have 
any suggestions for how we resolve the issue?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14345

To: ngraham, #plasma, mart, davidedmundson
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D7245: Improve reStructuredText highlighting

[Alex Turbov]

turbov added a comment.


  @cullmann,
  
  Up to you... When I'll fix it for the cases I've found (trying to write the 
`hightlighting.rst` test file) I come back w/ a new PR :)

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D12587: Indentation script for R

[Christoph Cullmann]

cullmann added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  Given it seems nobody has time to do tests, I will merge this.
  We can still remove it again but just letting rot this nice contribution in 
the phabricator won't help any R user.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12587

To: devillemereuil, #ktexteditor, #rkward
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, #frameworks

D12587: Indentation script for R

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12587

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

D14817: Convert manual install test to an autotest

[Ralf Habacker]

habacker added a comment.


  I applied a fix to use absolute pathes. Unfortunally windows builds have an 
additional issue:
  
  > 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/36/console
  
21:26:34 -- Installing: C:/CI/workspace/Frameworks kdoctools kf5-qt5 
WindowsMSVCQt5.10/build/autotests/kdoctools-install/destdir/bin/data/man/man1/checkXML5.1
...
21:26:34   C:/CI/workspace/Frameworks kdoctools kf5-qt5 
WindowsMSVCQt5.10/build/autotests/kdoctools-install/destdir/share/man/man1/checkXML5.1
  was not found
  
  -> msvc builds uses a different install dir 
  This is caused by 
https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n443

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D12587: Indentation script for R

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:467cf37fd04f: Indentation script for R (authored by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12587?vs=33259=39754

REVISION DETAIL
  https://phabricator.kde.org/D12587

AFFECTED FILES
  src/script/data/indentation/r.js

To: devillemereuil, #ktexteditor, #rkward, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 128 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/128/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:12 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 157.46 KB...]  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 198 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/198/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:42 +
 Build duration:
8 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 121.61 KB...]  cmake_policy command to set the policy and suppress this warning.  FindOpenGL found both a legacy GL library:OPENGL_gl_LIBRARY: /usr/lib64/libGL.so  and GLVND libraries for OpenGL and GLX:OPENGL_opengl_LIBRARY: /usr/lib64/libOpenGL.soOPENGL_glx_LIBRARY: /usr/lib64/libGLX.so  OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for  compatibility with CMake 3.10 and below the legacy GL library will be used.Call Stack (most recent call first):  CMakeLists.txt:103 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- Found OpenGL: /usr/lib64/libOpenGL.so   -- Found EGL: /usr/lib64/libEGL.so (found version "1.5") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * KF5Wayland (required version >= 5.49.0), Integration with the Wayland compositor * KF5DocTools (required version >= 5.49.0), Tools to generate documentation * X11, X11 libraries,  * XCB, X protocol C-language Binding,  * OpenGL, The OpenGL libraries,  * PkgConfig * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,Support for Window Thumbnail on EGL platform-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.10.1) * Qt5Quick * Qt5Gui * Qt5Sql * Qt5Qml * Qt5Svg * Qt5QuickControls2 * KF5Activities (required version >= 5.49.0) * KF5Archive (required version >= 5.49.0) * KF5Config (required version >= 5.49.0) * KF5ConfigWidgets (required version >= 5.49.0) * KF5DBusAddons (required version >= 5.49.0) * KF5Declarative (required version >= 5.49.0) * KF5GlobalAccel (required version >= 5.49.0) * KF5GuiAddons (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5IconThemes (required version >= 5.49.0) * KF5KIO (required version >= 5.49.0) * KF5Service (required version >= 5.49.0) * KF5WindowSystem (required version >= 5.49.0) * KF5Notifications (required version >= 5.49.0) * KF5Package (required version >= 5.49.0) * KF5Kirigami2 (required version >= 5.49.0) * KF5 (required version >= 5.49.0) * Qt5X11Extras * Qt5 * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Test (required version >= 5.8.0)   Required for tests * KF5CoreAddons * KF5XmlGui * Qt5Widgets-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks plasma-framework kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project plasma-framework --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target docs-plasmapkg2-plasmapkg2-1[  0%] Generating plasmapkg2.1/bin/sh: /home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/bin/meinproc5: No such file or directorymake[2]: *** [docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/build.make:62: docs/plasmapkg2/plasmapkg2.1] Error 127make[1]: *** [CMakeFiles/Makefile2:173: docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/all] Error 2make: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 48 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/48/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:46 +
 Build duration:
6 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 129.02 KB...]./plasma-wallpaper.kdevtemplate./package./package/metadata.desktop./package/contents./package/contents/config./package/contents/config/main.xml./package/contents/ui./package/contents/ui/main.qml./package/contents/ui/config.qml./README./Messages.sh../package./package/metadata.desktop./package/contents./package/contents/ui./package/contents/ui/main.qml./package/contents/ui/config.qml./package/contents/config./package/contents/config/main.xml./Messages.sh./plugin./plugin/qmldir./plugin/%{APPNAMELC}plugin.cpp./plugin/%{APPNAMELC}plugin.h./plugin/CMakeLists.txt./README./CMakeLists.txt./plasma-wallpaper-with-qml-extension.kdevtemplate[  4%] Automatic MOC for target KF5Plasma[  4%] Built target plasma-wallpaper[  4%] Generating plasmapkg2.1../src./src/%{APPNAMELC}.h./src/CMakeLists.txt./src/%{APPNAMELC}.cpp./src/package./src/package/contents./src/package/contents/ui./src/package/contents/ui/main.qml./src/package/contents/images./src/package/contents/images/pairs.svgz./src/package/metadata.desktop./CMakeLists.txt./Messages.sh./cpp-plasmoid.png./cpp-plasmoid.kdevtemplate./README../qml-plasmoid.kdevtemplate./package./package/contents./package/contents/images./package/contents/images/pairs.svgz./package/contents/ui./package/contents/ui/main.qml./package/metadata.desktop./CMakeLists.txt./qml-plasmoid.png./README./Messages.sh/bin/sh: /usr/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 FreeBSDQt5.10/build/bin/meinproc5: not foundgmake[2]: *** [docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/build.make:62: docs/plasmapkg2/plasmapkg2.1] Error 127gmake[1]: *** [CMakeFiles/Makefile2:173: docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsScanning dependencies of target qml-plasmoid-with-qml-extension[  4%] Built target plasma-wallpaper-with-qml-extension[  4%] Built target qml-plasmoid[  4%] Built target cpp-plasmoid[  5%] Generating qml-plasmoid-with-qml-extension.tar.bz2../package./package/metadata.desktop./package/contents./package/contents/ui./package/contents/ui/main.qml./plugin./plugin/%{APPNAMELC}plugin.cpp./plugin/qmldir./plugin/CMakeLists.txt./plugin/%{APPNAMELC}plugin.h./qml-plasmoid-with-qml-extension.kdevtemplate./README./Messages.sh./CMakeLists.txt[  5%] Built target qml-plasmoid-with-qml-extension[  5%] Built target plasmapkg2_autogen[  5%] Built target calendarplugin_autogen[  5%] Built target platformcomponentsplugin_autogen[  5%] Built target KF5Plasma_autogengmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 217 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/217/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:12 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 171.23 KB...]  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"C:/CI/workspace/Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"C:/CI/workspace/Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"C:/CI/workspace/Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"C:/CI/workspace/Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"C:/CI/workspace/Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks kio kf5-qt5 WindowsMSVCQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 218 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/218/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 15 Aug 2018 03:45:12 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 179.49 KB...]  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 121 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/121/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 15 Aug 2018 03:45:42 +
 Build duration:
20 min and counting
   CONSOLE OUTPUT
  [...truncated 133.93 KB...] * OpenGL, The OpenGL libraries,  * PkgConfig * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,Support for Window Thumbnail on EGL platform-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.9.6) * Qt5Quick * Qt5Gui * Qt5Sql * Qt5Qml * Qt5Svg * Qt5QuickControls2 * KF5Activities (required version >= 5.49.0) * KF5Archive (required version >= 5.49.0) * KF5Config (required version >= 5.49.0) * KF5ConfigWidgets (required version >= 5.49.0) * KF5DBusAddons (required version >= 5.49.0) * KF5Declarative (required version >= 5.49.0) * KF5GlobalAccel (required version >= 5.49.0) * KF5GuiAddons (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5IconThemes (required version >= 5.49.0) * KF5KIO (required version >= 5.49.0) * KF5Service (required version >= 5.49.0) * KF5WindowSystem (required version >= 5.49.0) * KF5Notifications (required version >= 5.49.0) * KF5Package (required version >= 5.49.0) * KF5Kirigami2 (required version >= 5.49.0) * KF5 (required version >= 5.49.0) * Qt5X11Extras * Qt5 * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Test (required version >= 5.8.0)   Required for tests * KF5CoreAddons * KF5XmlGui * Qt5Widgets-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks plasma-framework kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project plasma-framework --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Plasma_autogenScanning dependencies of target docs-plasmapkg2-plasmapkg2-1Scanning dependencies of target platformcomponentsplugin_autogenScanning dependencies of target calendarplugin_autogenScanning dependencies of target plasmapkg2_autogenScanning dependencies of target qml-plasmoid-with-qml-extension[  1%] Automatic MOC for target KF5Plasma[  1%] Automatic MOC for target calendarplugin[  2%] Automatic MOC for target platformcomponentsplugin[  2%] Generating plasmapkg2.1[  2%] Automatic MOC for target plasmapkg2/bin/sh: /home/jenkins/workspace/Dependency Build Frameworks kf5-qt5 SUSEQt5.9/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/build.make:62: docs/plasmapkg2/plasmapkg2.1] Error 127make[1]: *** [CMakeFiles/Makefile2:173: docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  3%] Generating qml-plasmoid-with-qml-extension.tar.bz2../CMakeLists.txt./package./package/metadata.desktop./package/contents./package/contents/ui./package/contents/ui/main.qml./Messages.sh./qml-plasmoid-with-qml-extension.kdevtemplate./README./plugin./plugin/%{APPNAMELC}plugin.cpp./plugin/CMakeLists.txt./plugin/%{APPNAMELC}plugin.h./plugin/qmldir[  3%] Built target plasmapkg2_autogen[  3%] Built target qml-plasmoid-with-qml-extension[  3%] Built target calendarplugin_autogen[  3%] Built target platformcomponentsplugin_autogen[  3%] Built target KF5Plasma_autogenmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 373 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/373/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:11 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 178.87 KB...]  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.CMake Error in src/ioslaves/help/CMakeLists.txt:  Imported target "KF5::DocTools" includes non-existent path"/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/build/src"  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:  * The path was deleted, renamed, or moved to another location.  * An install or uninstall procedure did not complete successfully.  * The installation package was faulty and references files it does not  provide.-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 124 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/124/
 Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:42 +
 Build duration:
19 min and counting
   CONSOLE OUTPUT
  [...truncated 116.51 KB...]-- Found KF5DocTools: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.50.0") -- Found KF5: success (found suitable version "5.50.0", minimum required is "5.49.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 DocTools missing components:  Wayland-- Found PkgConfig: C:/Craft/CI/windows-msvc2017_64-cl-debug/dev-utils/bin/pkg-config.exe (found version "0.28") -- Could NOT find XCB_XCB (missing: XCB_XCB_LIBRARY XCB_XCB_INCLUDE_DIR) (found version "")-- Could NOT find XCB_RENDER (missing: XCB_RENDER_LIBRARY XCB_RENDER_INCLUDE_DIR XCB_XCB_FOUND) (found version "")-- Could NOT find XCB_SHAPE (missing: XCB_SHAPE_LIBRARY XCB_SHAPE_INCLUDE_DIR XCB_XCB_FOUND) (found version "")-- Could NOT find XCB_XFIXES (missing: XCB_XFIXES_LIBRARY XCB_XFIXES_INCLUDE_DIR XCB_XCB_FOUND XCB_RENDER_FOUND XCB_SHAPE_FOUND) (found version "")-- Could NOT find XCB_COMPOSITE (missing: XCB_COMPOSITE_LIBRARY XCB_COMPOSITE_INCLUDE_DIR XCB_XCB_FOUND XCB_XFIXES_FOUND) (found version "")-- Could NOT find XCB_DAMAGE (missing: XCB_DAMAGE_LIBRARY XCB_DAMAGE_INCLUDE_DIR XCB_XCB_FOUND XCB_XFIXES_FOUND) (found version "")-- Could NOT find XCB (missing: XCB_LIBRARIES XCB COMPOSITE DAMAGE SHAPE XFIXES RENDER) -- Found OpenGL: opengl32   -- Could NOT find EGL (missing: EGL_LIBRARY EGL_INCLUDE_DIR) -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- The following OPTIONAL packages have been found: * KF5DocTools (required version >= 5.49.0), Tools to generate documentation * OpenGL, The OpenGL libraries,  * PkgConfig-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.10.1) * Qt5Quick * Qt5Gui * Qt5Sql * Qt5Qml * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * KF5Activities (required version >= 5.49.0) * KF5Archive (required version >= 5.49.0) * KF5Config (required version >= 5.49.0) * KF5ConfigWidgets (required version >= 5.49.0) * KF5DBusAddons (required version >= 5.49.0) * KF5Declarative (required version >= 5.49.0) * KF5GlobalAccel (required version >= 5.49.0) * KF5GuiAddons (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5IconThemes (required version >= 5.49.0) * KF5KIO (required version >= 5.49.0) * KF5Service (required version >= 5.49.0) * KF5WindowSystem (required version >= 5.49.0) * KF5Notifications (required version >= 5.49.0) * KF5Package (required version >= 5.49.0) * KF5Kirigami2 (required version >= 5.49.0) * KF5 (required version >= 5.49.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Test (required version >= 5.8.0)   Required for tests * KF5CoreAddons * KF5XmlGui * Qt5Widgets-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5Wayland (required version >= 5.49.0), Integration with the Wayland compositor * X11, X11 libraries,  * XCB, X protocol C-language Binding,  * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,Support for Window Thumbnail on EGL platform-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10] Running batch scriptC:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target docs-plasmapkg2-plasmapkg2-1[  1%] Generating plasmapkg2.1The system cannot find the path specified.jom: C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // 

D6473: Crash when replacing new lines with spaces

[Anthony Fieroni]

anthonyfieroni added a comment.


  I'm aware of that it will fix the crash but functionally still will be 
missing, but i'll give a try.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: jsalatas, #ktexteditor, dhaumann
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bffb66cb3ed8: Modelines: add byte-order-mark  small 
fixes (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14274?vs=39552=39717

REVISION DETAIL
  https://phabricator.kde.org/D14274

AFFECTED FILES
  autotests/folding/modelines.sh.fold
  autotests/html/modelines.sh.html
  autotests/input/modelines.sh
  autotests/reference/modelines.sh.ref
  data/syntax/modelines.xml

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 153 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/153/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 Aug 2018 14:55:59 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1732/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)62%
(345/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

D8964: Fix two bugs in KMessageWidget

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  I just tested again with KWrite - I think it behaves good there.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8964

To: aacid, #frameworks, dhaumann
Cc: kde-frameworks-devel, ngraham, dhaumann, anthonyfieroni, #frameworks, 
michaelh, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 97 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/97/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 14 Aug 2018 14:55:59 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1732/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)62%
(345/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Sure, I can do that, but I'd like to get feedback on the final form first :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:43396e0a9773: Optimize many syntax highlighting files and 
fix the / char of SQL (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11543?vs=31565=39719#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11543?vs=31565=39719

REVISION DETAIL
  https://phabricator.kde.org/D11543

AFFECTED FILES
  data/syntax/prolog.xml
  data/syntax/pug.xml
  data/syntax/qml.xml
  data/syntax/r.xml
  data/syntax/rest.xml
  data/syntax/rhtml.xml
  data/syntax/ruby.xml
  data/syntax/sisu.xml
  data/syntax/sql-mysql.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml
  data/syntax/tads3.xml
  data/syntax/tcl.xml
  data/syntax/template-toolkit.xml
  data/syntax/textile.xml
  data/syntax/varnishtest.xml
  data/syntax/varnishtest4.xml
  data/syntax/vhdl.xml
  data/syntax/wml.xml
  data/syntax/xmldebug.xml
  data/syntax/zsh.xml

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

Re: Upcoming reorganisation of the CI system

[Christoph Feck]

On 14.08.2018 15:03, Ben Cooksley wrote:

Currently CI jobs are all created within a flat namespace, meaning
that it is quite difficult to view the overall status of an individual
project. Additionally, it creates the issue that the main default view
can take a significant amount of time to load.

To resolve this we intend to shift everything within Folders in
Jenkins. These folders will be structured in the form of Product /
Project / 


Will we still be able to see the status of all Applications (or all 
Frameworks) without clicking hundreds of subfolders? This is useful to 
get an overview before doing releases.


Christoph Feck

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/98/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 14 Aug 2018 15:08:04 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1732/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)62%
(345/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 154 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/154/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 Aug 2018 15:08:04 +
 Build duration:
5 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1733/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)62%
(346/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 155 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/155/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 Aug 2018 15:13:22 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1731/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)61%
(344/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I needed to revert this again, as we get tests failures:
  
  
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/97/testReport/junit/(root)/TestSuite/testhighlighter_test/
  
  -# kate: 
syntax Bash 
; 
scheme 
Normal;
  -# kate: 
font-size 
14; 
background-color #FAFAFA 
;
  +# kate: syntax Bash ; scheme Normal;
  +# kate: font-size 14; background-color #FAFAFA ;

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/99/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 14 Aug 2018 15:10:44 +
 Build duration:
6 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1733/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)62%
(346/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 100 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/100/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 14 Aug 2018 15:17:15 +
 Build duration:
1 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(34/40)85%
(34/40)80%
(2485/3099)68%
(1731/2555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(599/613)61%
(344/560)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib89%
(25/28)89%
(25/28)86%
(1707/1990)74%
(1234/1665)

D14778: Disable loading of translations when using 'C' locale

[Ralf Habacker]

habacker abandoned this revision.
habacker added a comment.


  How to handle single/plural form then ?
  
  QString KFormatPrivate::formatDecimalDuration(quint64 msecs, int 
decimalPlaces) const
  {
  ...
  
//: @item:intext %1 is a whole number
//~ singular %n millisecond
//~ plural %n milliseconds
return tr("%n millisecond(s)", nullptr, msecs);
  
  According to http://doc.qt.io/qt-5/i18n-source-translation.html the recent 
string usage seems to be exactly what is required.
  
  From further inspection the solutions is to use translated reference values
  
  - QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 
millisecond(s)"));
  - QCOMPARE(format.formatDecimalDuration(10, 3), QStringLiteral("10 
millisecond(s)"));
  
  +QCOMPARE(format.formatDecimalDuration(10), 
QCoreApplication::translate("KFormat", "%n millisecond(s)", nullptr, 10));
  +QCOMPARE(format.formatDecimalDuration(10, 3), 
QCoreApplication::translate("KFormat", "%n millisecond(s)", nullptr, 10));
  
  Thanks for your feedback.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14829: Remove warning about old kiosk feature that no longer applies.

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14829

To: dfaure, davidedmundson, arichardson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14828: remove highlighting download dialog

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good. But along with this change, please change the docbook in kate.git:
  
  We have doc/katepart/configuring.docbook
  

Download Highlighting Files...
  

  Click this button to download new or updated syntax highlight 
descriptions
  from the  website.

  

  
  And we have: doc/katepart/development.docbook
  

  You can download updated or additional syntax highlight definitions 
from the  website by clicking the
  Download Highlighting Files... button in the Modes  Filetypes tab of 
the Config Dialog.


REPOSITORY
  R39 KTextEditor

BRANCH
  no-hl-download (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14828

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14828: remove highlighting download dialog

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:705f8e0419c4: remove highlighting download dialog 
(authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14828?vs=39686=39688

REVISION DETAIL
  https://phabricator.kde.org/D14828

AFFECTED FILES
  src/dialogs/filetypeconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodeconfigpage.h

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

[Sven Brauch]

brauch added a comment.


  Thanks for the feedback! I will try doing a few more things with this 
interace and then maybe discuss again with the other kate people here at 
Akademy about which one they like better.
  
  About the tracking, I don't think anything is needed on the side of the 
interface. You can see how you can potentially do it in the KDevelop patch I 
attached: create a moving cursor for the location you want the note to track, 
and then compute the note's position from the moving cursor's position as 
needed in the getter each time.
  I think this is even better than doing it in the interface itself, since it 
is more flexible with regards to how exactly the moving cursor behaves.
  
  Regarding the QVarLengthArray, performance-wise it would be better, but it 
makes the public API ugly (QVarLengthArray is a relatively internal, hacky 
class which is supposed to be only used in special cases), so I think we should 
first profile whether this is a bottleneck in any possible use case (it 
probably isn't).
  
  Currently, I'm trying out whether we can add some simple interaction ("note 
clicked") as well already, since I think that would be nice long-term. If the 
API is nice, we can fix small uglyness like the cursor navigation around notes 
at any later time IMHO.
  
  Best,
  Sven

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/35/
 Project:
Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Tue, 14 Aug 2018 14:07:08 +
 Build duration:
5 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kdoctools_install

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

[Laurent Cimon]

xciml updated this revision to Diff 39700.
xciml added a comment.


  Hi! Good idea, what about this?

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14236?vs=38102=39700

REVISION DETAIL
  https://phabricator.kde.org/D14236

AFFECTED FILES
  src/cli/kate-syntax-highlighter.cpp
  src/lib/htmlhighlighter.cpp
  src/lib/htmlhighlighter.h
  src/lib/repository.cpp
  src/lib/repository.h

To: xciml, #framework_syntax_highlighting, vkrause
Cc: pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, 
michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D7245: Improve reStructuredText highlighting

[Christoph Cullmann]

cullmann added a comment.


  Hmm, should we not commit this state at least as is?
  Or do you want to do a new request including a new state & tests?
  I would be fine with just pushing this as an intermediate step, too.

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D4234: Change algorithm for autobrace.

[Christoph Cullmann]

cullmann added a reviewer: brauch.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

To: cactus, #ktexteditor, mwolff, brauch
Cc: kde-frameworks-devel, nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, 
cullmann, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars, 
#frameworks

D12295: Supporting nested brackets for Kate autobrackets

[Christoph Cullmann]

cullmann added a subscriber: brauch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D12295: Supporting nested brackets for Kate autobrackets

[Christoph Cullmann]

cullmann added a reviewer: brauch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch
Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D6473: Crash when replacing new lines with spaces

[Dominik Haumann]

dhaumann added a comment.


  Hm, can you send  a patch that fixes this? :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: jsalatas, #ktexteditor, dhaumann
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D7245: Improve reStructuredText highlighting

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Sorry for the delay. Shall we take care of this?

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D7245: Improve reStructuredText highlighting

[Christoph Cullmann]

cullmann accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess ok - if issues arise, we have to fix them :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sql2

REVISION DETAIL
  https://phabricator.kde.org/D11470

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

D6473: Crash when replacing new lines with spaces

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  I was just about to merge this patch. But the crash still happens for me also 
with this patch - so it's still not fixed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: jsalatas, #ktexteditor, dhaumann
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, 
#frameworks

D14826: inline note interface wip #2

[Michal Srb]

michalsrb added a comment.


  Thank you for working on this. This interface would work for the 
kdev-sourceinfo use case just as well as the old one.
  
  I think the problem with the old interface that you described is valid. This 
version gives more flexibility to the `InlineNotesProvider` with regards to how 
it stores the notes internally.
  
  Do you have plan how to track the movement of the notes during edits? Maybe 
the InlineNote could also hold revision number for which it was created?

INLINE COMMENTS

> inlinenoteinterface.h:145
> + */
> +virtual QVector inlineNotes(int line) const = 0;
> +

Perhaps this could be `QVarLengthArray` of some size too?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Sorry folks for the endless period of no activity. After some talking with 
ngraham I removed the laptop metaphor for a much more general standalone 
display. Also the projection screen was swapped out.
  
  My last feedback was that the window icons were too detailed. So I made 3 
version. (Old) fully detailed, some details and no details (well, safe for the 
window buttons :)
  
  F6193072: detailed.png 
  
  F6193074: medium-detailed.png 
  
  F6193073: empty.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Kai Uwe Broulik]

broulik added a comment.


  While you're at it can't you move them to plasma-framework? Having them in 
Breeze makes it not work with other themes and also they are only shown in the 
context of Plasma anyway

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D7245: Improve reStructuredText highlighting

[Alex Turbov]

turbov marked an inline comment as done.
turbov added a comment.


  I'm using this syntax 'till nowadays from my repo... I know about some not 
covered cases in it, but have no time these days to improve it even more %)
  Most of the time I quite satisfied w/ it... and sorry for the tests :(

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D7245: Improve reStructuredText highlighting

[Alex Turbov]

turbov added a comment.


  You can just close this MR, I'll be back sometime later w/ highlighting 
example and tests...

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D6473: Crash when replacing new lines with spaces

[Anthony Fieroni]

anthonyfieroni added a comment.


  About me when line(...) is accessed it should check for nullptr as well
  
if (auto l = line(a)) {
return l->accessor();
}
  
  
https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94293a13d3c2f852$322
 because m_renderer->doc()->lines() is bigger than lines

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

To: jsalatas, #ktexteditor, dhaumann
Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, 
kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14817: Convert manual install test to an autotest

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:f0cc8b2ccb4a: Convert manual install test to an autotest 
(authored by habacker).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14817?vs=39659=39697#toc

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14817?vs=39659=39697

REVISION DETAIL
  https://phabricator.kde.org/D14817

AFFECTED FILES
  CMakeLists.txt
  KF5DocToolsConfig.cmake.in
  autotests/CMakeLists.txt
  autotests/kdoctools-install/CMakeLists.txt
  autotests/kdoctools-install/po/es/docs/foobar/index.docbook
  autotests/kdoctools-install/po/es/docs/kioslave5/fooslave/index.docbook
  autotests/kdoctools-install/po/es/docs/man-kjscmd.1.docbook
  autotests/kdoctools-install/po/fr/docs/foobar/index.docbook
  autotests/kdoctools-install/po/fr/docs/man-kjscmd.1.docbook
  autotests/kdoctools-install/test.cmake
  tests/kdoctools_install-test/po/es/docs/foobar/index.docbook
  tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook
  tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook
  tests/kdoctools_install-test/po/fr/docs/foobar/index.docbook
  tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook

To: habacker, ltoscano
Cc: kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Ralf Habacker]

habacker updated this revision to Diff 39684.
habacker edited the summary of this revision.
habacker added a comment.


  - after feedback from ecm maintainers the fix could be refactored to not be 
depending on ecm patch

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14779?vs=39560=39684

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14779

AFFECTED FILES
  autotests/kformattest.cpp

To: habacker, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14826: inline note interface wip #2

[Sven Brauch]

brauch added a comment.


  Sample patch for KDevelop's problem highlighter plus screenshot:
  F6192637: hl.png 
  F6192639: inline-problems.diff 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Dominik Haumann]

dhaumann added a comment.


  For those who are curious: This change is required since modelines.xml is a 
file that is included in many other xml files via IncludeRules. Given our 
policy of new highlighting files should be MIT licensed, this also applies to 
included definitions. That's why this relicensing  is being done for this file. 
Your support is very much appreciated here.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  relicense-modelines-mit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14824

To: dhaumann, vkrause, cullmann, martinwalch, turbov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Volker Krause]

vkrause accepted this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  relicense-modelines-mit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14824

To: dhaumann, vkrause, cullmann, martinwalch, turbov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Alex Turbov]

turbov accepted this revision.
turbov added a comment.


  I agree w/ relicense

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  relicense-modelines-mit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14824

To: dhaumann, vkrause, cullmann, martinwalch, turbov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:857a277110d5: Relicense modelines.xml to MIT license 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14824?vs=39680=39685

REVISION DETAIL
  https://phabricator.kde.org/D14824

AFFECTED FILES
  data/syntax/modelines.xml

To: dhaumann, vkrause, cullmann, martinwalch, turbov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14828: remove highlighting download dialog

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  rational:
  
  1. there is one frameworks release per month that already provides a stream 
of hl updates
  2. often new highlightings anyways need a new frameworks version
  3. one can easily update only a part of the files which leads to broken other 
highlighting that include parts of them
  4. the updates might easily break the non-downloadable indenters
  
  GUI: highlighting download dialog removed

TEST PLAN
  make
  make test

REPOSITORY
  R39 KTextEditor

BRANCH
  no-hl-download (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14828

AFFECTED FILES
  src/dialogs/filetypeconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodeconfigpage.h

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14829: Remove warning about old kiosk feature that no longer applies.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14829

To: dfaure, davidedmundson, arichardson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14826: inline note interface wip #2

[Sven Brauch]

brauch updated this revision to Diff 39692.
brauch added a comment.


  add missing files

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14826?vs=39682=39692

BRANCH
  inlinenotes

REVISION DETAIL
  https://phabricator.kde.org/D14826

AFFECTED FILES
  src/document/katedocument.h
  src/include/CMakeLists.txt
  src/include/ktexteditor/inlinenoteinterface.h
  src/render/katerenderer.cpp
  src/utils/ktexteditor.cpp
  src/view/kateview.cpp
  src/view/kateview.h

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Upcoming reorganisation of the CI system

[David Faure]

On mardi 14 août 2018 15:03:42 CEST Ben Cooksley wrote:
> Hi all,
> 
> Currently CI jobs are all created within a flat namespace, meaning
> that it is quite difficult to view the overall status of an individual
> project. Additionally, it creates the issue that the main default view
> can take a significant amount of time to load.
> 
> To resolve this we intend to shift everything within Folders in
> Jenkins. These folders will be structured in the form of Product /
> Project / 

Very nice!

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D10587: Restore KTextEditor Document Dbus bindings

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: lukedashjr; removed: cullmann.
cullmann added a comment.


  As said, I agree a fix for the unsaved documents vs. no swap files problem is 
wanted, but a single use case is not enough to bring back the dbus overhead per 
document.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10587

To: cullmann, dhaumann, gregormi, lukedashjr
Cc: kwrite-devel, kde-frameworks-devel, anthonyfieroni, #ktexteditor, #kate, 
asturmlechner, gregormi, dhaumann, cullmann, michaelh, kevinapavew, ngraham, 
bruns, demsking, head7, kfunk, sars

D10587: Restore KTextEditor Document Dbus bindings

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10587

To: cullmann, dhaumann, gregormi, lukedashjr
Cc: kwrite-devel, kde-frameworks-devel, anthonyfieroni, #ktexteditor, #kate, 
asturmlechner, gregormi, dhaumann, cullmann, michaelh, kevinapavew, ngraham, 
bruns, demsking, head7, kfunk, sars

D14826: inline note interface wip #2

[Sven Brauch]

brauch edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14824: Relicense modelines.xml to MIT license

[Dominik Haumann]

dhaumann added a comment.


  Thanks, Martin just change the kateversion number, which was changed again 
later by us again. So I will proceed now. Thanks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  relicense-modelines-mit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14824

To: dhaumann, vkrause, cullmann, martinwalch, turbov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Albert Astals Cid]

aacid added a comment.


  In D14779#308593 , @habacker wrote:
  
  > You have remembered that in this case the loader created by 
ecm_create_qm_loader(kcoreaddons_QM_LOADER kcoreaddons5_qt) must be adjusted to 
find this - not installed - fake translation by default ?
  
  
  I think that in the test we just need to call
  
bool QCoreApplication::installTranslator(QTranslator *translationFile)
  
  with the location of the fake translation and since newest location is tried 
first it should overwrite the one from the ecm loader.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks, cfeck
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns