D14826: inline note interface wip #2

anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:765 > +// Draw inline notes > +auto inlineNotes = m_view->inlineNotes(range->line()); > +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) { const > katerenderer.cpp:766 > +

D14826: inline note interface wip #2

brauch added reviewers: michalsrb, dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

brauch created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. brauch requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES

D14824: Relicense modelines.xml to MIT license

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann, martinwalch, turbov. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This change relicenses the

D14778: Disable loading of translations when using 'C' locale

aacid added a comment. Honestly i think that test in kformattest is wrong and that it should contain it's own small minitranslation so that stuff works fine and then it should be QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 milliseconds")); instead of

D14819: Get rid of deprecated QWeakPointer usage

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Replace by `QPointer` TEST PLAN - Compiles,

D14661: Force reevaluation of Predicates if interfaces are removed

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Not pretty but if it works.. Thanks! REPOSITORY R245 Solid BRANCH test REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: apol,

D14661: Force reevaluation of Predicates if interfaces are removed

anthonyfieroni added a reviewer: apol. anthonyfieroni added a subscriber: apol. anthonyfieroni added a comment. Since solid does not have a maintainer, you can wait for @apol or @broulik or ship it before 5.50 tagging. REPOSITORY R245 Solid REVISION DETAIL

<    1   2