D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

2018-08-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 51 min and counting JUnit T

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham created this revision. shubham added a reviewer: dfaure. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY F6209381: Screenshot_20180822_173758.png TES

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

2018-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 48 min and counting JUnit Te

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

2018-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 46 min and counting

KDE CI: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

2018-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 44 min and counting JUnit Test

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

2018-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks attica kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 42 min and counting JUnit Tests

D14994: [Windows Device] Show device label only if there is one

2018-08-22 Thread Kai Uwe Broulik
broulik retitled this revision from "Show device label only if there is one" to "[Windows Device] Show device label only if there is one". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14994 To: broulik, #windows, vonreth Cc: kde-frameworks-devel, michaelh, ngraham, bru

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

2018-08-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 40207. broulik added a comment. - Fix diff REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14747?vs=40205&id=40207 REVISION DETAIL https://phabricator.kde.org/D14747 AFFECTED FILES thumbnail/icoutils.h thumbna

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

2018-08-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 40205. broulik edited the test plan for this revision. broulik added a comment. - Fix build on Windows REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14747?vs=39464&id=40205 REVISION DETAIL https://phabricator.kde

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-08-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R320:30d274092c15: [Exe Thumbnailer] Improve icon selection algorithm (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=40131&id=40204 R

D14994: Show device label only if there is one

2018-08-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Windows, vonreth. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids showing `C: ()` for drives without a label TEST PLAN `solid-hardwar

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

2018-08-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14984 To: mpyne, #frameworks, #plasma, mart, davidedmundson Cc: plasma-devel, apol, davidedmundson, mart, hein

D14987: hunspell: Restore build with hunspell <=v1.5.0

2018-08-22 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R246:a18b3810a18d: hunspell: Restore build with hunspell <=v1.5.0 (authored by kfunk). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14987?vs=40190&id=40200 REVISION DE

D14991: Track state acked by XDG Client

2018-08-22 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In XDGShell we send configure requests with a serial number which a

D14990: [Icon Item] Watch KIconLoader icon change when using QIcon

2018-08-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, TheAssassin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `QIcon` is rendered through `KIconLoader` instead of e.g. `Plasma::Svg`. T

D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. Did you nuke the plasma icon cache? `~/.cache/plasma*` (We need to bump the theme version number before frameworks tagging, then this will work automatically) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pste

D14987: hunspell: Restore build with hunspell <=v1.5.0

2018-08-22 Thread Kevin Funk
kfunk added inline comments. INLINE COMMENTS > dfaure wrote in hunspelldict.cpp:130 > lst.reserve(nbWord); Note: That's just old/copied code. Unlikely to be called on recent distros anyway. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14987 To: kfu

D14987: hunspell: Restore build with hunspell <=v1.5.0

2018-08-22 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > hunspelldict.cpp:130 > +int nbWord = m_speller->suggest(&selection, > toDictEncoding(word).constData()); > +for (int i = 0; i < nbWord; ++i) { > +lst <<

D14987: hunspell: Restore build with hunspell <=v1.5.0

2018-08-22 Thread Kevin Funk
kfunk added reviewers: rjvbb, dfaure, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D14987 To: kfunk, rjvbb, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14987: hunspell: Restore build with hunspell <=v1.5.0

2018-08-22 Thread Kevin Funk
kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Commit 0a96acf251baa5c9dd042d093ab2bf8fcee10502

<    1   2