D14978: Add unit test that checks Format data

2018-08-24 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH check-full-formats (branched from master) REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-devel,

D14978: Add unit test that checks Format data

2018-08-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e4d317da92a1: Add unit test that checks Format data (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14978?vs=40349=40351

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 107 - Failure!

2018-08-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/107/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 24 Aug 2018 06:45:44 + Build duration: 16 sec and counting

D14978: Add unit test that checks Format data

2018-08-24 Thread Dominik Haumann
dhaumann updated this revision to Diff 40349. dhaumann added a comment. - Verify Definition::formats() contain all formats from 1...N REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14978?vs=40172=40349 BRANCH check-full-formats (branched

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 108 - Still Failing!

2018-08-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/108/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 24 Aug 2018 07:34:24 + Build duration: 17 sec and counting

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

2018-08-24 Thread David Faure
On dimanche 19 août 2018 18:11:32 CEST Ben Cooksley wrote: > On Sun, Aug 19, 2018 at 10:29 PM David Faure wrote: > > On lundi 13 août 2018 11:08:24 CEST Ben Cooksley wrote: > > > Hi David, > > > > > > Unfortunately it doesn't look like the fix we put in place on Saturday > > > did > > > the

D14948: Port scriptabletags to QJSEngine

2018-08-24 Thread Volker Krause
vkrause added a comment. Is this for Grantlee? Then I think https://github.com/steveire/grantlee is the right place to submit it, it's not hosted on KDE's Git. REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann,

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

2018-08-24 Thread Ben Cooksley
On Fri, Aug 24, 2018 at 7:22 PM David Faure wrote: > > On dimanche 19 août 2018 18:11:32 CEST Ben Cooksley wrote: > > On Sun, Aug 19, 2018 at 10:29 PM David Faure wrote: > > > On lundi 13 août 2018 11:08:24 CEST Ben Cooksley wrote: > > > > Hi David, > > > > > > > > Unfortunately it doesn't look

[sysadmin/ci-tooling] helpers: Copy all the files to the install directory instead.

2018-08-24 Thread Ben Cooksley
Git commit 5f53aafed393ca2efe92a81ed389023870891d6b by Ben Cooksley. Committed on 24/08/2018 at 09:52. Pushed by bcooksley into branch 'master'. Copy all the files to the install directory instead. This is some-what convoluted as Python doesn't have any methods for recursively copying into

D14948: Port scriptabletags to QJSEngine

2018-08-24 Thread Allan Sandfeld Jensen
carewolf added a comment. Yes it is for grantlee REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

Re: purpose unittests on Windows

2018-08-24 Thread Ben Cooksley
On Sun, Aug 19, 2018 at 11:55 PM Ben Cooksley wrote: > > On Sun, 19 Aug 2018, 12:19 David Faure, wrote: >> >> On lundi 13 août 2018 11:06:12 CEST Ben Cooksley wrote: >> > On Mon, Aug 13, 2018 at 1:16 AM David Faure wrote: >> > > On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote: >> > > >

D15047: Export the StorageDevices object.

2018-08-24 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > smithjd wrote in fileindexerconfig.cpp:322 > According to > https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops this > particular example will detach with or without the const intermediate. Citing from above: > To sum this up,

D11529: Balooctl: Deindex unfound files with check command.

2018-08-24 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > indexcleaner.cpp:76 > > -const auto includeFolders = m_config->includeFolders(); > -for (const QString& folder : includeFolders) { > -quint64 id = filePathToId(QFile::encodeName(folder)); > -tr.removeRecursively(id,

D14580: support for multi pages kcms

2018-08-24 Thread Marco Martin
mart updated this revision to Diff 40370. mart added a comment. - retrocompatibility hack with systemsettings REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=39310=40370 BRANCH mart/multipageKCM REVISION DETAIL

D15047: Export the StorageDevices object.

2018-08-24 Thread Stefan Brüns
bruns added a comment. In D15047#314485 , @smithjd wrote: > In D15047#314477 , @bruns wrote: > > > There is no need for this, just create a new StorageDevices where you need it. > > Creating a

D13216: Overhaul the file index scheduler.

2018-08-24 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Split this into independent changes. Add add comprehensive description to the summary - a bug reference is insufficient. INLINE COMMENTS > fileindexscheduler.cpp:98 > -

D11529: Balooctl: Deindex unfound files with check command.

2018-08-24 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh,

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > bruns wrote in fileindexscheduler.cpp:117 > Whats that supposed to do (I have an idea, but thats ugly ...) This starts a QRunnable at a negative priority (in this case the negative integer value for NewFiles) and then calls

D13216: Overhaul the file index scheduler.

2018-08-24 Thread Stefan Brüns
bruns added a comment. ... and thats the problem - this change does 3 different things. Make each one a separate revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov,

D15047: Export the StorageDevices object.

2018-08-24 Thread James Smith
smithjd added a comment. In D15047#314741 , @bruns wrote: > In D15047#314485 , @smithjd wrote: > > > In D15047#314477 , @bruns wrote: > > > > > There

D11529: Balooctl: Deindex unfound files with check command.

2018-08-24 Thread James Smith
smithjd added inline comments. INLINE COMMENTS > bruns wrote in indexcleaner.cpp:76 > Undesired detach This example will also detach with or without a const intermediate. > ...returning a copy from a method means that the copy is shared and has > negative side-effects when used with

D13816: Make KItinerary work as a static library

2018-08-24 Thread Volker Krause
vkrause abandoned this revision. vkrause added a comment. Partly integrated, partly replaced by implicit on-demand initialization to avoid the ugly explicit init() call. REPOSITORY R1003 KItinerary: Travel Reservation handling library REVISION DETAIL https://phabricator.kde.org/D13816

D15023: [server] Add selectionChanged signal

2018-08-24 Thread Roman Gilg
romangg added a dependent revision: D15061: [xwl] Generic X selections translation mechanism with Clipboard support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15023 To: romangg, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Stefan Brüns
bruns added a comment. +1, but I haven't tested it. @broulik , @cfeck - your opinion? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Christoph Feck
cfeck accepted this revision. cfeck added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > aboutkde.svg:1 > + > +https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kactivities-stats kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities-stats%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kactivities-stats kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 9 min and counting

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 8 min and counting

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 10 min and counting

KDE CI: Frameworks kauth kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kauth kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 24 min and counting

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 23 min and counting

KDE CI: Frameworks kitemviews kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kitemviews%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kitemviews kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 25 min and counting

KDE CI: Frameworks kwallet kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kwallet kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 25 min and counting

KDE CI: Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 25 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 25 min and counting

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 22 min and counting

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 24 min and counting

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 33 min and counting

KDE CI: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 33 min and counting

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kjs kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 32 min and counting

KDE CI: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 32 min and counting

KDE CI: Frameworks kemoticons kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kemoticons kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 33 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 32 min and counting

KDE CI: Frameworks kplotting kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kplotting kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 33 min and counting

KDE CI: Frameworks kitemmodels kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kitemmodels%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kitemmodels kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 32 min and counting

KDE CI: Frameworks kcompletion kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kcompletion kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 33 min and counting

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: svenmauch, aacid, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks attica kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 0 min and counting

KDE CI: Frameworks knotifications kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks knotifications kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 1 hr 59 min and counting

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 1 min and counting

KDE CI: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 10 min and counting

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 13 min and counting

KDE CI: Frameworks kjobwidgets kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kjobwidgets kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 11 min and counting

KDE CI: Frameworks karchive kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks karchive kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 12 min and counting

KDE CI: Frameworks kinit kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kinit kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 31 min and counting

KDE CI: Frameworks kded kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kded kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 29 min and counting

KDE CI: Frameworks prison kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20prison%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks prison kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 29 min and counting

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 29 min and counting

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 30 min and counting

KDE CI: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 29 min and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 31 min and counting

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-24 Thread Stefan Brüns
bruns updated this revision to Diff 40391. bruns added a comment. rebase REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14912?vs=40256=40391 REVISION DETAIL https://phabricator.kde.org/D14912 AFFECTED FILES find-modules/rules_engine.py

KDE CI: Frameworks kbookmarks kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kbookmarks kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 25 min and counting

KDE CI: Frameworks kguiaddons kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kguiaddons kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 26 min and counting

KDE CI: Frameworks kparts kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kparts kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 27 min and counting

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 27 min and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 27 min and counting

KDE CI: Frameworks kcmutils kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kcmutils kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 28 min and counting

KDE CI: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesu%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 28 min and counting

D13627: [KSharedDataCache] Assume lock before flush changes

2018-08-24 Thread Michael Pyne
mpyne added a comment. I'd say to leave the code alone if this the change isn't needed to fix a bug. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne Cc: mpyne, hein, kde-frameworks-devel,

KDE CI: Frameworks kjsembed kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kjsembed kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 29 min and counting

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 28 min and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:17 + Build duration: 2 hr 28 min and counting

D15068: Bindings: Correct handling of sources containing utf-8

2018-08-24 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Depending on the locale, python3 may try to decode the

KDE CI: Frameworks kholidays kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kholidays kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 1 hr 58 min and counting

KDE CI: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 1 hr 57 min and counting

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 17 min and counting

KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 16 min and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 19 min and counting

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 20 min and

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 20 min and counting

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 19 min and counting

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 18 min and counting

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 19 min and counting

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 18 min and counting

D14908: Bindings: Add support for scoped enums

2018-08-24 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R240:1790a6994a35: Bindings: Add support for scoped enums (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14908?vs=40250=40390 REVISION

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-24 Thread Stefan Brüns
bruns added a subscriber: arojas. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

2018-08-24 Thread James Smith
smithjd updated this revision to Diff 40393. smithjd added a comment. - Revert "Re-order and use IndexerState to prioritize the indexer thread pool." Avoid setting a priority on the runnables. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Nathaniel Graham
ngraham added a comment. Ping, is this good to go now? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14940: kformattest: Use plural suffix (s) consequently

2018-08-24 Thread Nathaniel Graham
ngraham added a comment. FWIW, "1.0 seconds" is what I've always been taught. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To: habacker, aacid Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 2 hr 6 min and counting

D15000: Display mounted file system type in properties dialog

2018-08-24 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Let's move the new "Mounted from:" code to within the conditional that determines whether or not to show "Mounted on:". We should show both or neither, not just one.

D12130: Use the more user-friendly string "File type" in the save dialogs

2018-08-24 Thread Henrik Fehlauer
rkflx resigned from this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, abetts Cc: kde-frameworks-devel, safaalfulaij, davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12545: Set focus on the filename line edit when a file is selected

2018-08-24 Thread Henrik Fehlauer
rkflx resigned from this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Nathaniel Graham
ngraham added a subscriber: svenmauch. REPOSITORY R263 KXmlGui BRANCH hidpi-konqi (branched from master) REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: svenmauch, aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

2018-08-24 Thread Nathaniel Graham
ngraham updated this revision to Diff 40389. ngraham marked an inline comment as done. ngraham added a comment. Correct file permissions REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40246=40389 BRANCH hidpi-konqi (branched from master)

KDE CI: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:15 + Build duration: 1 hr 56 min and counting

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 1 hr 56 min and counting

KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.11 - Build # 1 - Successful!

2018-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks kdnssd kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 1 hr 55 min and counting

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.11 - Build # 1 - Failure!

2018-08-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.11/1/ Project: Frameworks khtml kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 24 Aug 2018 23:34:16 + Build duration: 2 hr 16 min and counting CONSOLE OUTPUT

  1   2   >