D6513: Add support for Attica tags support

leinir updated this revision to Diff 41131. leinir marked 2 inline comments as done. leinir added a comment. Address @dfaure's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41034=41131 REVISION DETAIL

D15283: Move SMB KCM to Network Settings category

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:ace6f726eaf5: Move SMB KCM to Network Settings category (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE

D15070: Bindings: Query the install directory from python

cgiboudeaux added a comment. In D15070#318496 , @bruns wrote: > And why isn't it up to the user to set GPB_PYTHON2_SITEARCH when installing out of the usual directories? Because we don't install things out of CMAKE_PREFIX_PATH unless

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 217 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/217/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 13:21:41 + Build duration: 4 min 6 sec and counting

D15337: Fix Solarized Light and Dark color schemes

acrouthamel created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. acrouthamel requested review of this revision. REVISION SUMMARY Solarized Light contrast was low. Upon investigation it was determined much of the color

D15328: kfilewidget: convert connect syntax

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfilewidget.cpp:1225 > QObject::disconnect(m_connEditTextChanged); > m_connEditTextChanged = QMetaObject::Connection(); Me neither ... But me wonders if this should not use `{QSignalBlocker(locationEdit); ...}`

D15337: Fix Solarized Light and Dark color schemes

acrouthamel edited the summary of this revision. acrouthamel edited the test plan for this revision. acrouthamel added reviewers: Kate, KTextEditor, Framework: Syntax Highlighting. acrouthamel added a project: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL

D15258: Remove random kio output

This revision was automatically updated to reflect the committed changes. Closed by commit R241:944f9b425842: Remove random kio output (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15258?vs=40948=41160 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 215 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/215/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 12:57:31 + Build duration: 3 min 10 sec and counting

D15330: [autotests] Compare booleans to booleans

This revision was automatically updated to reflect the committed changes. Closed by commit R127:3c128a612c1f: [autotests] Compare booleans to booleans (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15330?vs=41149=41152 REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/55/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Sep 2018 13:01:46 + Build duration: 4 min 49 sec and counting JUnit Tests

D15330: [autotests] Compare booleans to booleans

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-build REVISION DETAIL https://phabricator.kde.org/D15330 To: zzag, #kwin, romangg, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

jtamate updated this revision to Diff 41150. jtamate marked an inline comment as done. jtamate added a comment. Changed to 'Anonymous' connects and disconnects. Even if the documentation say: use 0 as a wildcard, the compiler thinks it should be a nullptr kfilewidget.cpp:1222:74:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 216 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/216/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 13:15:56 + Build duration: 4 min 0 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/6/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 07 Sep 2018 08:20:10 + Build duration: 2 min 8 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/63/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Sep 2018 08:20:11 + Build duration: 1 min 44 sec and counting JUnit Tests

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/8/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 07 Sep 2018 08:40:46 + Build duration: 5 min 6 sec and counting

D6513: Add support for Attica tags support

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > leinir wrote in tagsfilterchecker.cpp:103 > Scott Meyers' book? (might need to grab a copy of that, then :) ) Yes. REPOSITORY R304 KNewStuff REVISION DETAIL

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/4/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 07 Sep 2018 07:51:55 + Build duration: 1 min 47 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.11/4/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 07 Sep 2018 07:51:55 + Build duration: 1 min 37 sec and counting CONSOLE

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/5/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 07 Sep 2018 08:00:26 + Build duration: 4 min 32 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.10 - Build # 103 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.10/103/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 08:00:26 + Build duration: 3 min 27 sec and counting JUnit Tests

D6513: Add support for Attica tags support

leinir added inline comments. INLINE COMMENTS > dfaure wrote in tagsfilterchecker.cpp:103 > Yes. Great, thank you :) Yeah, going to have to nab a copy of that for a readthrough :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol,

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 61 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/61/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Sep 2018 07:51:55 + Build duration: 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.10 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.10/102/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 07:51:56 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT

D6513: Add support for Attica tags support

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2ad3e66d81b6: Add support for Attica tags support (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41131=41133 REVISION DETAIL

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 62 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/62/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Sep 2018 08:00:26 + Build duration: 47 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.11/5/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 07 Sep 2018 08:00:25 + Build duration: 1 min 17 sec and counting

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/7/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 07 Sep 2018 08:35:31 + Build duration: 1 min 36 sec and counting

D15328: kfilewidget: convert connect syntax

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Convert from the old syntax to the new connect syntax TEST PLAN The

D15328: kfilewidget: convert connect syntax

broulik added inline comments. INLINE COMMENTS > kfilewidget.cpp:440 > +connect(d->ops, ::urlEntered, this, > +[&](const QUrl ){d->_k_urlEntered(url);}); > +connect(d->ops, ::fileHighlighted, this, Shouldn't this be using the `url` from the signal? Also, please prefer

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Note that Plasma 5.14 depends on 5.50 which is already released, so any change that requires this property can only go in once 5.14 was branched off REPOSITORY R242 Plasma Framework

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 214 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/214/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 07 Sep 2018 10:54:56 + Build duration: 2 min 21 sec and counting

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41171. acrouthamel marked an inline comment as done. acrouthamel added a comment. - Solarized Light Region Marker fix and small Dark tweak. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41170=41171

D15337: Fix Solarized Light and Dark color schemes

dhaumann added inline comments. INLINE COMMENTS > katesyntaxhighlightingrc:143 > -Operator=ff93a1a1,ff93a1a1,-,-,,--- > -Others=ff859900,ff859900,-,-,,--- > -Preprocessor=ff27ae60,ff27ae60,-,-,,--- Isn't "Others" now missing? Every color theme should define 31 colors. If this was

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41172. acrouthamel added a comment. - Fixed Light scheme Error color REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41171=41172 BRANCH fix-solarized-colors REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

acrouthamel marked 2 inline comments as done. acrouthamel added a comment. You were right again. For some reason that Others= disappeared from my ~/.config/katesyntaxhighlightingrc so I didn't notice it. Even though it was defined and displaying fine in the GUI. Weird. I also made a few

D14529: Android: Make sure Qm translations get loaded

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok then i guess :) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14529 To: apol, #frameworks, aacid Cc: svuorela, aacid,

D15337: Fix Solarized Light and Dark color schemes

dhaumann added a comment. Thanks for working on this. Looks good to me - just a minor question about the section for Solarized light. And also related: would you also create the .theme files for KSyntaxHighlighting? INLINE COMMENTS > katesyntaxhighlightingrc:104 > # Solarized

D15337: Fix Solarized Light and Dark color schemes

acrouthamel added a comment. @dhaumann, I've added these colors to KSyntaxHighlighting over here: D15340 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor,

D15337: Fix Solarized Light and Dark color schemes

dhaumann added a comment. Solarized dark still only has 28 colors, right? Can you add the missing ones? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel,

D15337: Fix Solarized Light and Dark color schemes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Can you commit yourself? REPOSITORY R39 KTextEditor BRANCH fix-solarized-colors REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate,

D15337: Fix Solarized Light and Dark color schemes

acrouthamel added a comment. Thanks, I can. I'm getting an error in Arcanist, so let me diagnose that and I'll land it. REPOSITORY R39 KTextEditor BRANCH fix-solarized-colors REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor,

D15340: Add Solarized Light and Dark themes

acrouthamel created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. acrouthamel requested review of this revision. REVISION SUMMARY This adds Solarized Light and Dark themes, with the same color scheme selected in

D15340: Add Solarized Light and Dark themes

acrouthamel edited the summary of this revision. acrouthamel added reviewers: Kate, Framework: Syntax Highlighting. acrouthamel added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate,

D15337: Fix Solarized Light and Dark color schemes

acrouthamel edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D15337: Fix Solarized Light and Dark color schemes

acrouthamel added a comment. In D15337#322043 , @dhaumann wrote: > Solarized dark still only has 28 colors, right? Can you add the missing ones? Man, I'm looking forward to this JSON system in the future. LOL. Ok, fixed again. I counted

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41181. acrouthamel added a comment. - Added three missing definitions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41177=41181 BRANCH fix-solarized-colors REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41170. acrouthamel added a comment. - Fixed section code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41168=41170 BRANCH fix-solarized-colors REVISION DETAIL https://phabricator.kde.org/D15337

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41176. acrouthamel added a comment. - Some Marker color tweaks to ensure Solarized interaction rule adherence REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41172=41176 BRANCH fix-solarized-colors

D15337: Fix Solarized Light and Dark color schemes

acrouthamel marked an inline comment as done. acrouthamel added a comment. I've fixed the section. I'm actually working on the KSyntaxHighlighting themes now, you'll see those in another patch. INLINE COMMENTS > dhaumann wrote in katesyntaxhighlightingrc:104 > Am I mistaken, or did you

D15337: Fix Solarized Light and Dark color schemes

acrouthamel updated this revision to Diff 41177. acrouthamel added a comment. - Fixed Others definition REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41176=41177 BRANCH fix-solarized-colors REVISION DETAIL

D6513: Add support for Attica tags support

ngraham added a comment. So is this enough for people to start tagging KDE4 content as such? Or is anything else still required before that capability lands? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting,

D15337: Fix Solarized Light and Dark color schemes

acrouthamel closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D15328: kfilewidget: convert connect syntax

jtamate updated this revision to Diff 41148. jtamate marked 2 inline comments as done. jtamate added a comment. Changed [&] by [this]in the lambdas. Added a lambda for KActionCollection::addAction. I didn't knew it was already possible. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D15328: kfilewidget: convert connect syntax

anthonyfieroni added inline comments. INLINE COMMENTS > kfilewidget.cpp:1225 > // the KDirOperator's view-selection in there > -QObject::disconnect(locationEdit, SIGNAL(editTextChanged(QString)), > -q, SLOT(_k_slotLocationChanged(QString))); > +

D15330: [autotests] Compare booleans to booleans

zzag created this revision. zzag added reviewers: KWin, romangg. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY Compiler errors: 17:06:23

D15328: kfilewidget: convert connect syntax

jtamate added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfilewidget.cpp:1225 > Whenever disconnect after that reset connection to QMetaObject::Connection > cause disconnect empty connection is safe, double disconnect same one - does > not. I'm sorry but I don't understand

D15328: kfilewidget: convert connect syntax

anthonyfieroni added inline comments. INLINE COMMENTS > jtamate wrote in kfilewidget.cpp:1225 > I'm sorry but I don't understand your comment. > m_connEditTextChanged is created in the constructor, line 585. > Afterwards it is disconnected and reconnected in: > setDummyHistoryEntry,

D15328: kfilewidget: convert connect syntax

jtamate marked an inline comment as done. jtamate added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfilewidget.cpp:1225 > QObject::disconnect(m_connEditTextChanged); > m_connEditTextChanged = QMetaObject::Connection(); I'm sorry, but I still don't get it. Doesn't

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 218 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/218/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 04:12:49 + Build duration: 10 min and counting JUnit

D13700: implement reading of the replaygain tags

bruns added inline comments. INLINE COMMENTS > taglibextractor.cpp:943 > +} > +result->add(Property::ReplayGainAlbumGain, > data.replayGainAlbumGain.toDouble()); > +} You should check if the value can be converted to double, and probably also if it is in a sane

D13700: implement reading of the replaygain tags

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:50 > This is used throughout the taglibextractor and should then be corrected > everywhere in a different patch imho. Can you do a followup-patch to fix this? REPOSITORY R286 KFileMetaData REVISION DETAIL