D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41456. fvogt added a comment. Avoid reallocation in slotData if removing m_offset frees enough space. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41455=41456 BRANCH master REVISION DETAIL

D15407: Fix OCS provider URL in about dialog

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D15407 To: broulik, #frameworks, leinir, alexanderschmidt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. In D15426#324284 , @bruns wrote: > For the trivial case, do the clear in `readData()`. > > For the non-trivial case: > > 1. in `readData()`, no memmoves were ever done. Currently, if you have e.g. 50 kB in m_data,

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41455. fvogt added a comment. Save m_offset bytes in slotData as well. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41427=41455 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED

D6513: Add support for Attica tags support

leinir added a comment. In D6513#324419 , @ngraham wrote: > In D6513#322167 , @leinir wrote: > > > In D6513#322078 , @ngraham wrote: > > > > > So is this

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.10 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.10/60/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 15:23:16 + Build duration: 1 min 37 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 12 Sep 2018 15:23:16 + Build duration: 58 sec and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/16/ Project: kf5-qt5 AndroidQt5.11 Date of build: Wed, 12 Sep 2018 16:46:47 + Build duration: 3 min 48 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/85/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 17:50:37 + Build duration: 5 min 6 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/8/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 14:54:36 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.9/44/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Sep 2018 15:23:16 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.11/5/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 17:05:22 + Build duration: 7 min 46 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.9 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Sep 2018 14:54:36 + Build duration: 7 min 25 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/9/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 15:23:16 + Build duration: 12 min and counting JUnit Tests Name: (root)

D15421: [server] Add surface data proxy mechanism

romangg updated this revision to Diff 41497. romangg added a comment. Remove updateProxy call on pointer button press. The compositor is instead responsible for updating it before a drag starts, what allows more freedom in how the proxy is used. CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.10 - Build # 59 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 14:54:36 + Build duration: 2 min 29 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.11/5/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 12 Sep 2018 18:36:02 + Build duration: 2 min 9 sec and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.11 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.11/23/ Project: kf5-qt5 AndroidQt5.11 Date of build: Wed, 12 Sep 2018 18:32:32 + Build duration: 36 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.11/5/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 18:40:06 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.11/6/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 19:58:39 + Build duration: 2 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.11 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.11/24/ Project: kf5-qt5 AndroidQt5.11 Date of build: Wed, 12 Sep 2018 18:36:02 + Build duration: 1 min 0 sec and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.9 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.9/50/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Sep 2018 18:36:08 + Build duration: 11 min and counting JUnit Tests Name: (root)

D12520: [PasteJob] Emit KDirNotify on paste

ngraham added a comment. Works for me, FWIW. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: ngraham, elvisangelaccio, kde-frameworks-devel, michaelh, bruns

D15464: [server] Touch drag support

romangg added a dependency: D15443: [server] Allow multiple touch interfaces per client and remove fallback code. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15464 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a dependent revision: D15464: [server] Touch drag support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15464: [server] Touch drag support

romangg added a dependent revision: D15466: Add Wayland touch drag and drop support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15464 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.11/4/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 12 Sep 2018 18:32:32 + Build duration: 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.11/4/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 18:32:32 + Build duration: 7 min 8 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 75 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 18:36:02 + Build duration: 10 min and counting JUnit Tests Name: (root)

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a comment. I believe it works like this: A seat has one global pointer, one global keyboard and one global touch "object" each. But clients can bind to them multiple times. That's why there are focus.pointers and focus.keyboards vectors although there is only one global

D15464: [server] Touch drag support

davidedmundson added inline comments. INLINE COMMENTS > datadevice_interface.cpp:102 > { > // TODO: allow touch > +const bool pointerGrab = seat->hasImplicitPointerGrab(serial) && > seat->focusedPointerSurface() == origin; done > seat_interface.cpp:1331 > Q_D(); > -const

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.9 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.9/49/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Sep 2018 18:32:32 + Build duration: 3 min 34 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 18:32:32 + Build duration: 3 min 18 sec and counting CONSOLE OUTPUT

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

davidedmundson added a comment. > has been for no apparent reason From the spec (emphasis mine) The wl_touch interface represents **a** touchscreen associated with a seat. The wl_pointer interface represents **one or more** input devices, The wl_keyboard interface

D15464: [server] Touch drag support

romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Adds functionality to do drag and drop with touch screens. TEST PLAN

KDE CI: Frameworks » kjsembed » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20WindowsMSVCQt5.11/5/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 20:00:58 + Build duration: 3 hr 59 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/20/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 20:00:55 + Build duration: 3 hr 58 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.11/6/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 20:00:59 + Build duration: 3 hr 59 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kjs » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20WindowsMSVCQt5.11/5/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 20:00:57 + Build duration: 3 hr 58 min and counting CONSOLE OUTPUT

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

ngraham added a comment. (and branching is tomorrow, per https://community.kde.org/Schedules/Plasma_5) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15321 To: Zren, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a comment. In D15443#324889 , @davidedmundson wrote: > I don't understand removing this. If I have an app that doesn't understand touch doesn't it make sense to synthesise a pointer? I didn't read the code correctly.

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

davidedmundson added a comment. Oh, I see what you're saying, I misread, sorry. That does indeed make sense. > Some undocumented fallback code has been removed as well. Platforms not supporting touch are just considered not capable instead. I don't understand removing this. If I

D6513: Add support for Attica tags support

ngraham added a comment. In D6513#324458 , @leinir wrote: > In D6513#324419 , @ngraham wrote: > > > So I see `ghns_exclude` over at store.kde.org, but it doesn't feel quite right to check that box

D15213: Provide icons for 2x scaling

cfeck added a comment. Did this fix bug 398094? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15213: Provide icons for 2x scaling

ngraham added a comment. Hah, yes it did! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

bruns added inline comments. INLINE COMMENTS > accessmanagerreply_p.cpp:433 > +newData.append(data); > +m_data = newData; > +m_offset = 0; if you swap these two lines (i.e. append to m_data), you have `m_data += data` in all three branches, and you can move it to the

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41468. fvogt added a comment. The empty "if" is kept for readability. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41456=41468 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED FILES

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt updated this revision to Diff 41476. fvogt added a comment. Remove code. Any more nits to pick? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41468=41476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 AFFECTED

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nah, I'll land this now, and bump `X-KDE-PluginInfo-Version` in `src/desktoptheme/breeze/metadata.desktop` before Frameworks 5.51 tagging. Thanks so much for your work here, Phil! I

D14971: Combine display OSD icon files and move to plasma icon theme

This revision was automatically updated to reflect the committed changes. Closed by commit R242:32e0f7867758: Combine display OSD icon files and move to plasma icon theme (authored by pstefan, committed by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/19/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Sep 2018 14:05:16 + Build duration: 2 min 33 sec and counting CONSOLE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 220 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/220/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Sep 2018 14:05:16 + Build duration: 2 min 48 sec and counting JUnit Tests Name:

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik created this revision. broulik added reviewers: Frameworks, dfaure, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Lets the view load the correctly scaled icon on demand. TEST PLAN

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

bruns added a comment. In D15426#324486 , @fvogt wrote: > In D15426#324284 , @bruns wrote: > > > For the trivial case, do the clear in `readData()`. > > > > For the non-trivial case: > > > >

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

fvogt added a comment. In D15426#324636 , @bruns wrote: > In D15426#324486 , @fvogt wrote: > > > In D15426#324284 , @bruns wrote: > > > > > For the

D15407: Fix OCS provider URL in about dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R263:229ae4f1add4: Fix OCS provider URL in about dialog (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15407?vs=41349=41463 REVISION DETAIL

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.11/8/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 12 Sep 2018 14:54:36 + Build duration: 45 sec and counting CONSOLE OUTPUT [...truncated