date:20180920

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I like the brick wall metaphor, which does a good job of communicating the 
point, while being visually distinct from the shield.
  
  Looks great to me! Let's see if any other VDG folks have opinions in the next 
day or two, and if not, I'll ship it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham

ngraham updated this revision to Diff 42018.
ngraham added a comment.


  - Address review comments and do it better

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15583?vs=41873=42018

BRANCH
  fix-hyphen-in-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15583

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham

ngraham planned changes to this revision.
ngraham added a comment.


  Actually it looks like we shouldn't even use it anyway for other reasons per 
the documentation: https://doc.qt.io/qt-5/qdir.html#separator
  
  They recommend always using `/` directly like you indicate, so I'll do that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15421: [server] Add surface data proxy mechanism

2018-09-20 Thread Roman Gilg

romangg added a dependent revision: D15627: [xwl] Drag and drop between 
Xwayland and Wayland native clients.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Anthony Fieroni

anthonyfieroni added a comment.


  LGTM +1

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15623

To: jtamate, #frameworks, sitter
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham

ngraham added a comment.


  That would only affect the speed of appearing and disappearing though, right? 
Not the total duration that is status on the screen.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15611

To: cfeck, #frameworks, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck

cfeck added a comment.


  In D15611#328845 , @ngraham wrote:
  
  > In D15611#328821 , @cfeck wrote:
  >
  > > Would KMessageWidget need the same change?
  >
  >
  > Yeah, I think so. No sense in having a user-tweakable "animation duration" 
value if we're not going to respect it.
  
  
  I was skeptical, because my impression was that KMessageWidget animations are 
intentionally slow to stay readable.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15611

To: cfeck, #frameworks, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Kai Uwe Broulik

broulik added a reviewer: sitter.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15623

To: jtamate, #frameworks, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Jaime Torres Amate

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  If the notification is deleted from the hash, when the notification::id is 
called later by finish, it could contain anything.
  Change the order, call finish with a valid notification pointer before 
removing the notification from the hash.
  
  BUG: 398695

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D15623

AFFECTED FILES
  src/notifybyaudio_canberra.cpp

To: jtamate, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

2018-09-20 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/108/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 20 Sep 2018 14:11:22 +
 Build duration:
4 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

2018-09-20 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/52/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 20 Sep 2018 14:11:22 +
 Build duration:
1 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham

ngraham closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-09-20 Thread Andres Betts

abetts added a comment.


  In D15194#328651 , @romangg wrote:
  
  > If there are more items than space available in the list a line is drawn 
already now to indicate that there are more items to come by scrolling down. 
Does this not conflict with the new line?
  
  
  Screenshot?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfecto!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan

pstefan updated this revision to Diff 41987.
pstefan added a comment.


  Add missing sizes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15618?vs=41982=41987

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15618

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons-dark/actions/32/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg
  icons/actions/32/document-new.svg

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan

pstefan added a comment.


  Oops, sorry.
  
  Should be fixed now!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, this looks perfect for the 16px size! But we'll need the same change 
for the 22, 24, and 23 px sizes too. Could you do those, too?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham

ngraham added reviewers: Breeze, VDG.
ngraham added a comment.


  Wow, that was fast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan

pstefan created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Response to bug 398850

TEST PLAN
  Works for me

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15618

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons/actions/16/document-new.svg

To: pstefan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.

  In D15611#328821 , @cfeck wrote:

  > Indeed Breeze style was already updated to return the actual configured 
duration on Qt 5.10.
  >
  > Would KMessageWidget need the same change?

  Yeah, I think so. No sense in having a user-tweakable "animation duration" 
value if we're not going to respect it.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15611

To: cfeck, #frameworks, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Anthony Fieroni

anthonyfieroni added a comment.


  In Qt 5.9 (if i remember correct) was introduced to not have trailing '/' so, 
QDir::separator should not be used, so better get folder as copy
  
for (QString folder : folders) {
if (!folder.endsWith(QLatin1Char('/')) {
folder += QLaitin1Char('/');
}
if (path.startsWith(folder)) {

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Christoph Feck

cfeck resigned from this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-20 Thread Stefan Brüns

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-20 Thread Stefan Brüns

bruns added a comment.


  Can you rebase, please?
  And upload the patch with `arc diff`, to have the full context available.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15559: Python bindings: use cmake_parse_arguments, fix documentation

2018-09-20 Thread Stefan Brüns

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b322901ca22f: Python bindings: use cmake_parse_arguments, 
fix documentation (authored by bruns).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15559?vs=41952=41980

REVISION DETAIL
  https://phabricator.kde.org/D15559

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck

cfeck added a comment.


  Indeed Breeze style was already updated to return the actual configured 
duration on Qt 5.10.
  
  Would KMessageWidget need the same change?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15611

To: cfeck, #frameworks
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck

cfeck updated this revision to Diff 41978.
cfeck retitled this revision from "[KCollapsibleGroupBox] Respect styles that 
disable widget animations" to "[KCollapsibleGroupBox] Respect style's widget 
animation duration".
cfeck edited the summary of this revision.
cfeck edited the test plan for this revision.
cfeck added a comment.


  Respect QStyle::SH_Widget_Animation_Duration starting with Qt 5.10.0

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15611?vs=41955=41978

REVISION DETAIL
  https://phabricator.kde.org/D15611

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp

To: cfeck, #frameworks
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis

ndavis added a comment.


  Regular
  F6275107: Screenshot_20180920_052849.png 

  Panic
  F6275109: Screenshot_20180920_053034.png 

  Not sure if I want to try to cause an error on my own system just to show how 
the error icon looks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis

ndavis updated this revision to Diff 41973.
ndavis added a comment.


  Fix mixed up firewall-applet and firewall-applet-panic (22px)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=41972=41973

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis

ndavis added a comment.


  Hmm. Something is preventing me from changing the name of firewall-applet to 
firewall-applet-panic (apps/22) and vice versa. I own all of the files in that 
directory (noah:users), but the file names keep being reset to their current 
state.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis

ndavis updated this revision to Diff 41972.
ndavis added a comment.


  
  
  1. Updating D11880 : Add firewall-config 
and firewall-applet icons #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Fix mixed up firewall-applet and firewall-applet-panic (22px)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=41971=41972

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis

ndavis retitled this revision from "Add firewalld icons" to "Add 
firewall-config and firewall-applet icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis

ndavis updated this revision to Diff 41971.
ndavis added a comment.


  
  
  1. Updating D11880 : Add firewall-config 
and firewall-applet icons #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Change icons to brickwall style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=31142=41971

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15615: bump required taglib version

2018-09-20 Thread Alexander Stippich

astippich created this revision.
astippich added a reviewer: mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  some of the functionality added in D12320 
 requires functions added only in TagLib 
1.11, but the required version was not adjusted.
  TagLib 1.11.1 was released on October 24, 2016

REPOSITORY
  R286 KFileMetaData

BRANCH
  bumb_taglib_version

REVISION DETAIL
  https://phabricator.kde.org/D15615

AFFECTED FILES
  CMakeLists.txt

To: astippich, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Matthieu Gallien

mgallien added a comment.


  In D15614#328722 , @astippich 
wrote:
  
  > The removal of the convertWCharsToQString function is safe, right? It was 
never exported
  
  
  It is a static function. So it is absolutely safe to remove it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15614

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15614

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich

astippich added a comment.


  The removal of the convertWCharsToQString function is safe, right? It was 
never exported

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15614

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich

astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  as pointed out in D13700 , the custom 
function is unsafe if size(wchar) == 4 bytes. Use the function provided by 
taglib for the conversion to QString.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_extractor_string_conversion

REVISION DETAIL
  https://phabricator.kde.org/D15614

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15611: [KCollapsibleGroupBox] Respect styles that disable widget animations

2018-09-20 Thread Kai Uwe Broulik

broulik added a comment.


  `SH_Widget_Animate` is deprecated in favor of `SH_Widget_Animation_Duration` 
introduced in Qt 5.10, so perhaps this needs an `ifdef`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15611

To: cfeck, #frameworks
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis

ndavis added a comment.


  https://developer.gnome.org/icon-naming-spec/
  
  > | security-high   | The icon used to indicate that the security level of a 
connection is known to be secure, using strong encryption and a valid 
certificate.
   |
  > | security-medium | The icon used to indicate that the security level of a 
connection is presumed to be secure, using strong encryption, and a certificate 
that could not be automatically verified, but which the user has chosen to 
trust.|
  > | security-low| The icon used to indicate that the security level of a 
connection is presumed to be insecure, either by using weak encryption, or by 
using a certificate that the could not be automatically verified, and which the 
user has not chosent to trust. |
  > |
  
  Based on this information, I have decided to redo the firewall-applet icons 
because the original meaning of the security-* icons does not match what I am 
reusing them for. Instead, the firewall-applet icons will look like brick walls.
  
  In D11880#328634 , @ngraham wrote:
  
  > In D11880#328630 , @ndavis wrote:
  >
  > > Panic mode in FirewallD is not worse than Error. Panic mode is enabled by 
the user. It is something that the user enables when they need to stop all 
network traffic to the system.
  >
  >
  > Oh! In that case, I would say it should look extra secure somehow. Rather 
than using the orange warning color and iconography, maybe figure out a way to 
make it look even stronger than normal. Maybe a giant lock? Just throwing out 
ideas.
  
  
  Thanks. Not sure how I could make a big lock work with the new design, but 
I'll consider putting one in the lower right corner, similar to other 16 and 22 
px breeze icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15559: Python bindings: use cmake_parse_arguments, fix documentation

2018-09-20 Thread David Faure

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This is technically not 100% source compatible, but since the callers were 
already passing "TARGET" (and others) as documented, I guess it's fine.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  python_ecm_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15559

To: bruns, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

43 matches

Mail list logo