D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Stefan Brüns]

bruns added a comment.


  There are some more common tags with identical values, i.e. AlbumArtist, 
Composer and Lyrics - any reason you kept these?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15825

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Please lower bitdepth.
  Also, can you provide the commandline or the like to generate the files? - 
probably this is also stuff for an accompanying `README` file.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15848: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removing the (typically empty) optional argument from the function
  invocation avoids confusion and allows to remove the parameter.
  
  See also D15558 

TEST PLAN
  make

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15848

AFFECTED FILES
  src/core/CMakeLists.txt
  src/gui/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15847: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removing the (typically empty) optional argument from the function
  invocation avoids confusion and allows to remove the parameter.
  
  See also D15558 

TEST PLAN
  make

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15847

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15846: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removing the (typically empty) optional argument from the function
  invocation avoids confusion and allows to remove the parameter.
  
  See also D15558 

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15846

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removing the (typically empty) optional argument from the function
  invocation avoids confusion and allows to remove the parameter.
  
  See also D15558 

TEST PLAN
  make

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15845

AFFECTED FILES
  src/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Nathaniel Graham]

ngraham added a comment.


  I think what @bruns is gently trying to indicate is that your Summary needs 
improvement. :) Remember that it becomes a part of the commit message once the 
patch lands.
  
  A Test Plan wouldn't hurt, either.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15583: [Balooctl] remove directory parent check

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2452ce28193a: [Balooctl] remove directory parent check 
(authored by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15583?vs=42152=42576

REVISION DETAIL
  https://phabricator.kde.org/D15583

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] remove directory parent check

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D15583

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15844

To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fix-removing-locations-from-include-and-exclude-lists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15844

To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[James Smith]

smithjd added a comment.


  In D15843#334024 , @bruns wrote:
  
  > Whats the use case exactly? "Some parts" is not sufficient ...
  
  
  The index cleaner for example needs to skip unmounted paths.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Stefan Brüns]

bruns added a comment.


  Whats the use case exactly? "Some parts" is not sufficient ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[Nathaniel Graham]

ngraham added reviewers: Baloo, bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

[Nathaniel Graham]

ngraham updated this revision to Diff 42574.
ngraham added a comment.


  Don't unnecessarily rename the variable

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15844?vs=42573=42574

BRANCH
  fix-removing-locations-from-include-and-exclude-lists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15844

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15844

To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, if you add a folder to Baloo's `includeFolders` or 
`excludeFolders` lists, it cannot be removed again if it has been deleted. This 
patch fixes that for both `balooctl` and also the KCM.

TEST PLAN
mkdir ~/foobar-test
balooctl config add excludeFolders ~/foobar-test
rmdir ~/foobar-test
balooctl config remove excludeFolders ~/foobar-test
  
  Without the patch, `balooctl` exits with an error, reports "Path does not 
exist", and does not remove the entry.
  
  With the patch, `balooctl` exits cleanly with no error and removes the path
  
  Works from the KCM, too.

REPOSITORY
  R293 Baloo

BRANCH
  fix-removing-locations-from-include-and-exclude-lists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15844

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

[James Smith]

smithjd created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  Parts of Baloo need some way to check if a path's volume is mounted or not.

REPOSITORY
  R293 Baloo

BRANCH
  master-pathDeviceMounted (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15843

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  None of the KDED modules provide a X-KDE-DBus-ServiceName, so there are
  a lot of warnings during session startup.
  Not providing the entry actually is no error, as:
  
  1. modules are loaded and requested using the org.kde.kded5 service
  2. org.kde.kded5 already is a singleton, so protecting against multiple
  
  instances of the module is not necessary.

TEST PLAN
  make

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15842

AFFECTED FILES
  src/kded.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos added a comment.


  F6294480: εικόνα.png 
  [plasma taskmanager that is using red as textColor even though Breeze-Dark 
theme is chosen]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --In the future dynamic coloring might be needed for
  panels in the desktop. In such case panel colors might
  be altered in order to follow the current active maximized
  window colors or another case could be when the panel
  is transparent and plasma theme colors arent providing
  the best constrast with the underlying background.
  This is a first step in order to support panels that color
  themselves independently from the plasma theme or according
  to the plasma theme but with best contrast at all cases.
  
  Usage Example:
  
  //Containment part
  PlasmaCore.ColorScope{
  
colorGroup: PlasmaCore.Theme.UserSetColorGroup
textColor: "#f1f1f1"

/*applets*/
  
  }
  
  //applet part
  
color: PlasmaCore.ColorScope.textColor //it is going to use #f1f1f1

TEST PLAN
  -check that applets are coloring themselves accordingly
  -check that previous behavior didnt break

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  extendColorScope

REVISION DETAIL
  https://phabricator.kde.org/D15839

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/plasma/theme.h

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/29/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 29 Sep 2018 19:58:08 +
 Build duration:
3 min 42 sec and counting

[sysadmin/ci-tooling] build-specs/Frameworks: Re-disable the KIO tests on Windows like we have done essentially since the inception of Windows CI.

[Ben Cooksley]

Git commit fc6d15636d8da49f351e4bccf02e877efe5d9b10 by Ben Cooksley.
Committed on 29/09/2018 at 19:57.
Pushed by bcooksley into branch 'master'.

Re-disable the KIO tests on Windows like we have done essentially since the 
inception of Windows CI.
Qt on Windows is horrendously broken when it comes to D-Bus and the Qt 
developers consider this to be Windows fault and not theirs, and thus won't fix 
this or attempt to workaround it.

Until such time that KIO on Windows ceases it's use of D-Bus it is likely that 
KIO will remain unable to cleanly exit, requiring manual intervention and 
cleanup each time.
It is likely that other applications will also be affected by this issue as 
well, so use of D-Bus in general on Windows should probably be avoided at all 
costs as that module is just not usable on Windows.

CCMAIL: kde-frameworks-devel@kde.org

R  +0-0build-specs/Frameworks/kio-WindowsMSVCQt5.11.yaml [from: 
build-specs/Frameworks/kio-WindowsMSVCQt5.10.yaml - 100% similarity]

https://commits.kde.org/sysadmin/ci-tooling/fc6d15636d8da49f351e4bccf02e877efe5d9b10

diff --git a/build-specs/Frameworks/kio-WindowsMSVCQt5.10.yaml 
b/build-specs/Frameworks/kio-WindowsMSVCQt5.11.yaml
similarity index 100%
rename from build-specs/Frameworks/kio-WindowsMSVCQt5.10.yaml
rename to build-specs/Frameworks/kio-WindowsMSVCQt5.11.yaml

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Stefan Brüns]

bruns added a comment.


  In D15833#333933 , @svuorela wrote:
  
  > What's the origin/license of these files ? How are they created ?
  
  
  The files contain just silence.
  
  @astippich - can you convert the wav file to 8bit (32bit float currently), so 
it becomes smaller. Same for aiff, probably.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Sune Vuorela]

svuorela added a comment.


  What's the origin/license of these files ? How are they created ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> apol wrote in documenturldb.cpp:44
> Shouldn't asserts help to find where the library is being misused?

You gain no information if you crash here. Not the code is wrong, but the 
processed data.

Most importantly, when somebody runs this code, compiled without DEBUG, we will 
run into more and more silent corruption.

As soon as baloo is in a state where it is selfhealing, adding logging becomes 
an option, currently it is not.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, 
ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D12336: Replace several Q_ASSERTs with proper checks

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> bruns wrote in documenturldb.cpp:44
> This may be accessed quite frequently, so we would get a lot of warnings, 
> spamming the journal, and slowing down the system.
> 
> A backtrace is useless here, as the code processes whatever it finds in the 
> database. The interesting part is how the bad data ended up in the db.
> 
> Doing the checks here avoids spreading any existing corruption.
> 
> The long term solution is to:
> 
> 1. Find the bugs leading to the DB corruption
> 2. Run lowlevel and highlevel sanity checks on existing databases
> 
> Both are on my TODO list, but this will take some time.

Shouldn't asserts help to find where the library is being misused?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, 
ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> safaalfulaij wrote in kformatprivate.cpp:168
> Well, I searched other languages and no one seems to do as Arabic does. We do 
> not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is 
> always written, "M.Byte" > "MB").
> And of course, there is no one solid naming of the units, so adding just one 
> letter will not get the right meaning. Adding another dot will make things 
> more crowded -> "M.i.Byte" (This is fine in English, but in Arabic it is 
> really ugly and means nothing.)

I uploaded a new version, but with what you describe, this will not suffice to 
fulfill your needs for IEC binary prefixes (please confirm). For the record, I 
haven't seen it anywhere in English that dots are put in between.
I guess a second map with the IEC binary prefixes is required so that one can 
translate them separately.

I'm away for the next week, so will continue to work on the patch afterwards.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich updated this revision to Diff 42563.
astippich added a comment.


  - change description for prefixes and make the IEC prefix translatable

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15829?vs=42542=42563

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15525: Fix rendering Aztec codes with an aspect ratio != 1

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:1f7e403b02dd: Fix rendering Aztec codes with an aspect 
ratio != 1 (authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15525?vs=41687=42561

REVISION DETAIL
  https://phabricator.kde.org/D15525

AFFECTED FILES
  src/lib/aztecbarcode.cpp

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15835: avoid that the main context can be #poped

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9e039a669f8f: avoid that the main context can be #poped 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15835?vs=42555=42560

REVISION DETAIL
  https://phabricator.kde.org/D15835

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15835: avoid that the main context can be #poped

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15835

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

[Christoph Cullmann]

cullmann added a comment.


  Thanks for the examples, with that I could reproduce and introduce some hard 
guard for such cases.
  Better broken highlighting then an endless hanging application.
  https://phabricator.kde.org/D15836

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15773

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15836: Endless state transition guard

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:899ce3e7bb6e: Endless state transition guard (authored by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15836?vs=42558=42559

REVISION DETAIL
  https://phabricator.kde.org/D15836

AFFECTED FILES
  src/lib/abstracthighlighter.cpp

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15835: avoid that the main context can be #poped

[Christoph Cullmann]

cullmann added reviewers: vkrause, nibags.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15835

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15836: Endless state transition guard

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15836

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D15836: Endless state transition guard

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: dhaumann, vkrause, nibags.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  This e.g. catches the "hang" people did see before the fix in 
https://phabricator.kde.org/D15773
  Its a simple good old "endless loop counter" that aborts after too many 
transitions.
  IMHO more than a few without any progress at the text offset make no sense, 
therefore the hard limit of 1024 should be reasonable

TEST PLAN
  I tried the examples attached for https://phabricator.kde.org/D15773, with my 
fix, I get just
  
  Endless state transitions, aborting highlighting of line.
  
  as debug output but no longer any hang.
  
  (but yes, the highlighting of some lines is messed up, which IMHO is ok, much 
better than a hard hang of the application

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15836

AFFECTED FILES
  src/lib/abstracthighlighter.cpp

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/24/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 29 Sep 2018 15:14:09 +
 Build duration:
3 min 12 sec and counting

D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> apol wrote in documenturldb.cpp:44
> Would it make sense to include a warning then? If it's a wrong input, we'll 
> need ways to debug it now that it won't be giving a backtrace.

This may be accessed quite frequently, so we would get a lot of warnings, 
spamming the journal, and slowing down the system.

A backtrace is useless here, as the code processes whatever it finds in the 
database. The interesting part is how the bad data ended up in the db.

Doing the checks here avoids spreading any existing corruption.

The long term solution is to:

1. Find the bugs leading to the DB corruption
2. Run lowlevel and highlevel sanity checks on existing databases

Both are on my TODO list, but this will take some time.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: apol, sitter, kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/18/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 29 Sep 2018 15:10:45 +
 Build duration:
3 min 3 sec and counting

D15835: avoid that the main context can be #poped

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  avoids that the main context can be #poped
  + ensure we abort the switching loop if we arrive at it

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15835

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/state.cpp
  src/lib/state_p.h

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:bfe6134916f3: Properly scope CMAKE_REQUIRED_LIBRARIES 
change (authored by vkrause).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15830?vs=42543=42553

REVISION DETAIL
  https://phabricator.kde.org/D15830

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12336: Replace several Q_ASSERTs with proper checks

[Aleix Pol Gonzalez]

apol added subscribers: sitter, apol.
apol added a comment.


  If it was silently corrupting the DB maybe the right solution would have been 
to integrate baloo properly with KCrash.
  Like @sitter did in https://phabricator.kde.org/D15573.

INLINE COMMENTS

> documenturldb.cpp:44
>  {
> -Q_ASSERT(docId > 0);
> -Q_ASSERT(!url.isEmpty());
> -Q_ASSERT(!url.endsWith('/'));
> +if (!docId || url.isEmpty() || url.endsWith('/')) {
> +return false;

Would it make sense to include a warning then? If it's a wrong input, we'll 
need ways to debug it now that it won't be giving a backtrace.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: apol, sitter, kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15829: make units and prefixes of formatValue translatable

[Safa Alfulaij]

safaalfulaij added a comment.


  I came into anther problem, this time with the unit selection.
  In Arabic, we don't put a dot between the prefix and the unit if we're 
talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, 
G.Byte).
  
  If ki18n was used here, all of this can be locale-specific, but unfortunately 
that's not the case. I think I understand now why there are many strings for 
all of this unit stuff.

INLINE COMMENTS

> astippich wrote in kformatprivate.cpp:168
> Overlooked that one. Must this then be something like tr("1%2%).arg(... ...)?

Well, I searched other languages and no one seems to do as Arabic does. We do 
not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is 
always written, "M.Byte" > "MB").
And of course, there is no one solid naming of the units, so adding just one 
letter will not get the right meaning. Adding another dot will make things more 
crowded -> "M.i.Byte" (This is fine in English, but in Arabic it is really ugly 
and means nothing.)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's see what happens...

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15830

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 42551.
astippich added a comment.


  - modify permissions of binary files

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15833?vs=42549=42551

BRANCH
  taglib_extractor_additional_tests

REVISION DETAIL
  https://phabricator.kde.org/D15833

AFFECTED FILES
  autotests/samplefiles/test.aif
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.wav
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Alexander Stippich]

astippich added a dependent revision: D15833: extend test coverage to all 
supported mimetypes for taglibextractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15825

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich added a dependency: D15825: move testing of common tags of test files 
to a new data-driven test for taglibextractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, bruns, svuorela.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  add new test files such that all mime types declared as
  supported by the taglibextractor are actually tested

TEST PLAN
  new tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_extractor_additional_tests

REVISION DETAIL
  https://phabricator.kde.org/D15833

AFFECTED FILES
  autotests/samplefiles/test.aif
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.wav
  autotests/samplefiles/test.wv
  autotests/taglibextractortest.cpp

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich added a comment.


  In D15829#333799 , @safaalfulaij 
wrote:
  
  > Since the joining between number and format is translatable, that's great. 
I meant that if it is kept untranslatable, problems regarding RTL will happen.
  
  
  Sorry, I don't understand clearly, will this patch (once all issues are 
fixed) solve your problem or not?

INLINE COMMENTS

> safaalfulaij wrote in kformatprivate.cpp:115
> Line 160:
> 
>   } else {
>   value /= entry->binaryFactor;
>   prefixString = QString(entry->prefixChar).toUpper();
> 
> How this is “Metric”?

The prefixes for the IEC binary prefixes (for e.g. 2^10) are made up by the SI 
prefixes plus an "i", see below. But it actually is an SI prefix, to be more 
precise.

> safaalfulaij wrote in kformatprivate.cpp:168
> And what about this? //It should never be a puzzle string by the way.//

Overlooked that one. Must this then be something like tr("1%2%).arg(... ...)?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Safa Alfulaij]

safaalfulaij added a comment.


  Since the joining between number and format is translatable, that's great. I 
meant that if it is kept untranslatable, problems regarding RTL will happen.

INLINE COMMENTS

> kformatprivate.cpp:115
>  const PrefixMapEntry map[] = {
> -{ KFormat::UnitPrefix::Yocto, 1e-24, bpow(-80), u'y' },
> -{ KFormat::UnitPrefix::Zepto, 1e-21, bpow(-70), u'z' },
> -{ KFormat::UnitPrefix::Atto,  1e-18, bpow(-60), u'a' },
> -{ KFormat::UnitPrefix::Femto, 1e-15, bpow(-50), u'f' },
> -{ KFormat::UnitPrefix::Pico,  1e-12, bpow(-40), u'p' },
> -{ KFormat::UnitPrefix::Nano,  1e-9,  bpow(-30), u'n' },
> -// Thanks to broken MSVC, we can not use u'µ', but have to use the 
> unicode codepoint
> -{ KFormat::UnitPrefix::Micro, 1e-6,  bpow(-20), QChar(0xB5) },
> -{ KFormat::UnitPrefix::Milli, 1e-3,  bpow(-10), u'm' },
> -{ KFormat::UnitPrefix::Unity, 1.0, 1.0, u'\0' },
> -{ KFormat::UnitPrefix::Kilo,  1e3,   bpow(10), u'k' },
> -{ KFormat::UnitPrefix::Mega,  1e6,   bpow(20), u'M' },
> -{ KFormat::UnitPrefix::Giga,  1e9,   bpow(30), u'G' },
> -{ KFormat::UnitPrefix::Tera,  1e12,  bpow(40), u'T' },
> -{ KFormat::UnitPrefix::Peta,  1e15,  bpow(50), u'P' },
> -{ KFormat::UnitPrefix::Exa,   1e18,  bpow(60), u'E' },
> -{ KFormat::UnitPrefix::Zetta, 1e21,  bpow(70), u'Z' },
> -{ KFormat::UnitPrefix::Yotta, 1e24,  bpow(80), u'Y' },
> +{ KFormat::UnitPrefix::Yocto, 1e-24, bpow(-80), tr("y", "Metric 
> prefix for 10^⁻24") },
> +{ KFormat::UnitPrefix::Zepto, 1e-21, bpow(-70), tr("z", "Metric 
> prefix for 10^⁻21") },

Line 160:

  } else {
  value /= entry->binaryFactor;
  prefixString = QString(entry->prefixChar).toUpper();

How this is “Metric”?

> kformatprivate.cpp:168
>  if (dialect == KFormat::IECBinaryDialect) {
>  prefixString += u'i';
>  }

And what about this? //It should never be a puzzle string by the way.//

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12336: Replace several Q_ASSERTs with proper checks

[Stefan Brüns]

bruns added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in main.cpp:217
> posOfNonNumeric < 0 or == -1 ?

Thou shall not code after bedtime ... Thx.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns updated this revision to Diff 42547.
bruns marked an inline comment as done.
bruns added a comment.


  fix "not found" condition for `word.indexOf(...)`

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15826?vs=42530=42547

BRANCH
  db_robustness2

REVISION DETAIL
  https://phabricator.kde.org/D15826

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  It's the clean thing to do anyway, and it looks like this has side-effects
  on the coverage build of the CI.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15830

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich added a comment.


  @bruns please have a look at the changes. In particular, regarding "µ" and 
windows support. I don't know if this will be able to compile on windows, or 
how to fix it for tr() function.
  @safaalfulaij please verify if this fixes the RTL issue for you

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, safaalfulaij.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  give the possibility to translate the prefix und unit strings

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.cpp:217
> +int posOfNonNumeric = word.indexOf('-', 2);
> +if ((posOfNonNumeric < -1) || ((posOfNonNumeric + 1) 
> == word.length())) {
> +stream << "Malformed property term (no data): " 
> << word <<  "\n";

posOfNonNumeric < 0 or == -1 ?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Alexander Stippich]

astippich marked 5 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Alexander Stippich]

astippich updated this revision to Diff 42541.
astippich added a comment.


  - fix after rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15714?vs=42525=42541

BRANCH
  taglib_write_unicode

REVISION DETAIL
  https://phabricator.kde.org/D15714

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15525: Fix rendering Aztec codes with an aspect ratio != 1

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15525

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15525: Fix rendering Aztec codes with an aspect ratio != 1

[Volker Krause]

vkrause added a comment.


  ping

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D15525

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun marked an inline comment as done.
arjun added a comment.


  In D15778#333555 , @bruns wrote:
  
  > The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which 
ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit 
message.
  
  
  My distro doesn't ship arc, I've manually added the tags.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham

D15778: Log wallet open failure errors

[Arjun AK]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:c7b064e5a3d5: Log wallet open failure errors (authored by 
arjun).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15778?vs=42430=42538#toc

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15778?vs=42430=42538

REVISION DETAIL
  https://phabricator.kde.org/D15778

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham