D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

[Jaime Torres Amate]

jtamate accepted this revision.
jtamate added a comment.
This revision is now accepted and ready to land.


  I am really, really sorry. I have no excuses to not have run the autotests 
(that I usually run after my first fiasco). Hopefully, after my second fiasco, 
I'll run them before creating any review request.
  
  With your patch, all the fails from this unit test are gone.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16020

To: dfaure, jtamate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15859: allow non-local file:// redirect to a M$-WebDav URL

[Martin Koller]

mkoller added a comment.


  I was talking about the code I changed, which uses QUrl, which can not parse 
the @SSL syntax.
  I tried.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15859

To: mkoller, dfaure, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15098: make push/pop part of ConfigModule API

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  arcpatch-D15098

REVISION DETAIL
  https://phabricator.kde.org/D15098

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15912: Don't silently error if damage is sent before buffer

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b4cd89ea4977: Dont silently error if damage is sent 
before buffer (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15912?vs=42820=43108

REVISION DETAIL
  https://phabricator.kde.org/D15912

AFFECTED FILES
  src/server/surface_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 62 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/62/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 08:16:32 +
 Build duration:
7 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 45 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24780/28425)53%
(9807/18331)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11685/11759)50%
(6202/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5731/6771)65%
(1504/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6930/7964)66%
(1932/2929)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

[Michal Malý]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:75ee4dfb4042: Add a specific error string for ENOTEMPTY 
return code. (authored by madcatx).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15871?vs=42807=43119

REVISION DETAIL
  https://phabricator.kde.org/D15871

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: madcatx, elvisangelaccio, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16020

To: dfaure, jtamate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate planned changes to this revision.
jtamate added a comment.


  QTest::qWaitForWindowActive fails because I use kwin Focus stealing 
prevention High, therefore the windows doesn't become active until I click on 
them in the task bar or switch to them.
  And qWaitForWindowExposed doesn't help because the window/widget needs to 
have the focus.
  
  Is creating a README file and a kwin script to disable stealing prevention 
for kio tests an acceptable solution?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: bruns, anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/89/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 08:16:32 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 45 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24779/28424)54%
(9808/18331)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11683/11758)50%
(6202/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5732/6771)65%
(1505/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6930/7964)66%
(1932/2929)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 266 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/266/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 07:43:32 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(32053/60011)38%
(16529/43906)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9067/9504)48%
(4281/8932)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8365/14347)50%
(4674/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7925)34%
(1589/4671)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(527/1025)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(719/1373)43%
  

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

[Michal Malý]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a26de31a5dfb: Distinguish between file and directory 
delete request in debug output. (authored by madcatx).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15873?vs=42646=43120

REVISION DETAIL
  https://phabricator.kde.org/D15873

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: madcatx, elvisangelaccio, broulik
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

D15328: kfilewidget: convert connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 43106.
jtamate added a comment.


  Fix a crash ,caused by a still connected signal, after running again the 
unittests.
  kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails 
for me.
  
  Don't accept this revision until kfilewidgettest works flawlessly.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15328?vs=41246=43106

REVISION DETAIL
  https://phabricator.kde.org/D15328

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: jtamate, dfaure, #frameworks
Cc: bruns, anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 421 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/421/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 07:43:32 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31986/60010)38%
(16476/43908)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9061/9504)48%
(4262/8932)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8307/14346)50%
(4641/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7925)34%
(1589/4671)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1025)37%
(316/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

D16043: Clean up unused QDebug/baloodebug.h includes

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The code does not use qDebug(), qWarning() or similar, so remove it.

TEST PLAN
  make
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  debug_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16043

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/result.cpp
  src/file/fileindexerconfig.cpp
  src/file/filtereddiriterator.cpp
  src/file/mainhub.cpp
  src/file/optimizedbytearray.h
  src/file/pendingfilequeue.cpp
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15510: Introduce HKDF

[Alexander Volkov]

volkov updated this revision to Diff 43125.
volkov added a comment.


  more reinterpret_casts

REPOSITORY
  R486 QCA Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15510?vs=43123=43125

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15510

AFFECTED FILES
  include/QtCrypto/qca_basic.h
  include/QtCrypto/qcaprovider.h
  plugins/qca-botan/qca-botan.cpp
  plugins/qca-ossl/qca-ossl.cpp
  src/qca_basic.cpp
  unittest/kdfunittest/kdfunittest.cpp

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov updated this revision to Diff 43123.
volkov added a comment.


  fixed

REPOSITORY
  R486 QCA Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15510?vs=41656=43123

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15510

AFFECTED FILES
  include/QtCrypto/qca_basic.h
  include/QtCrypto/qcaprovider.h
  plugins/qca-botan/qca-botan.cpp
  plugins/qca-ossl/qca-ossl.cpp
  src/qca_basic.cpp
  unittest/kdfunittest/kdfunittest.cpp

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D16044: [Timeline] Use categorized logging

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Set all messages in regular execution paths to Debug (off by default),
  and keep the only error message (parsing error) as Warning.

TEST PLAN
  make && ctest
  entering e.g. "Last Month" from Places no longer fills the journal (3 log
  lines per day, i.e. ~90 lines).

REPOSITORY
  R293 Baloo

BRANCH
  debug_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16044

AFFECTED FILES
  baloo.categories
  src/kioslaves/timeline/CMakeLists.txt
  src/kioslaves/timeline/timelinetools.cpp

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15510: Introduce HKDF

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> dfaure wrote in qca-botan.cpp:250
> override?

it still supports build with Qt 4 and without C++ 11

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D15510: Introduce HKDF

[Alexander Volkov]

volkov added a comment.


  BTW, should I create a review request to reformat code with astyle-kdelibs?

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: dfaure

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

[Jaime Torres Amate]

jtamate added a comment.


  Just in case, I'm subscribed now to the RSS 
https://build.kde.org/job/Frameworks/job/kio/rssFailed

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16020

To: dfaure, jtamate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:44f2852fb299: [Thumbnails] Paint larger one 
thumbnail tile only when needed (authored by broulik).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15402?vs=41382=43132

REVISION DETAIL
  https://phabricator.kde.org/D15402

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: broulik, #dolphin, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  RE:
  
  In D15999#338724 , @filipf wrote:
  
  > Would the background be grey and the icon itself black in all color 
schemes? (apropos how Inkscape shows it:)
  >
  > F6310672: image.png 
  >
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  >
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  
  The background stays the same color, no matter the color scheme used. I am 
told that it's not currently possible for the login-screen to change the color 
of the background independently of the foreground. The foreground color is the 
same color as a theme's text color. In the case of the lockscreen, that's white.
  
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  > 
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  I have never thought about that tbh. It's something to investigate, can you 
repost that thought on T9658 ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis added a comment.


  @ngraham @broulik Do you have any objections or questions about this commit?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/43/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 18:22:02 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9497)55%
(3475/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1379)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4658)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D15833: extend test coverage to all supported mimetypes for taglibextractor

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Thx!

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_extractor_additional_tests

REVISION DETAIL
  https://phabricator.kde.org/D15833

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/56/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 17:52:22 +
 Build duration:
2 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 422 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/422/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 17:48:07 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31976/60014)38%
(16478/43908)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9067/9504)48%
(4276/8932)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8307/14346)50%
(4645/9275)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7925)34%
(1588/4671)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(527/1025)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(698/1373)42%
  

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/78/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 17:52:22 +
 Build duration:
4 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

D16049: Added missing Icons to Places Panel code from KIO

[Alex Debus]

alexde created this revision.
alexde added reviewers: VDG, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The items "Hide", "Hide Entry" and "Show All Entries"  of the places panel 
did not have icons.
  Therefor I replicated the changes for the KIO code, which I already submitted 
for Dolphin .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16049

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: alexde, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/31/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 18:22:02 +
 Build duration:
6 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7106/9497)55%
(3478/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3010/3137)52%
(1265/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1379)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4658)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D15934: Add battery and bluetooth icons for other DE compatibility

[Nathaniel Graham]

ngraham added a comment.


  I have no objection to the concept, but I like to test patches before I 
approve them, and I'm still not sure how I would satisfactorily test this 
without taking up an afternoon setting up a dev environment in an XFCE-using 
distro in a VM, which unfortunately is time I just don't have at the moment.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

[Noah Davis]

ndavis added a comment.


  In D15934#339276 , @ngraham wrote:
  
  > I have no objection to the concept, but I like to test patches before I 
approve them, and I'm still not sure how I would satisfactorily test this 
without taking up an afternoon setting up a dev environment in an XFCE-using 
distro in a VM, which unfortunately is time I just don't have at the moment.
  
  
  Fair enough. If I did it and took a series of screenshots, would that be good 
enough for you?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16043: Clean up unused QDebug/baloodebug.h includes

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R293 Baloo

BRANCH
  debug_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16043

To: bruns, #baloo, #frameworks, broulik, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:aaa1edbb74c4: [mtp] Move MTP device handling from 
kioslave to kiod-module (authored by akrutzler).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15277?vs=43074=43145

REVISION DETAIL
  https://phabricator.kde.org/D15277

AFFECTED FILES
  mtp/CMakeLists.txt
  mtp/devicecache.cpp
  mtp/devicecache.h
  mtp/filecache.cpp
  mtp/filecache.h
  mtp/kio_mtp.cpp
  mtp/kio_mtp.h
  mtp/kio_mtp_helpers.cpp
  mtp/kio_mtp_helpers.h
  mtp/kiod_module/CMakeLists.txt
  mtp/kiod_module/kmtpd.cpp
  mtp/kiod_module/kmtpd.h
  mtp/kiod_module/kmtpd.json
  mtp/kiod_module/mtpdevice.cpp
  mtp/kiod_module/mtpdevice.h
  mtp/kiod_module/mtpstorage.cpp
  mtp/kiod_module/mtpstorage.h
  mtp/shared/CMakeLists.txt
  mtp/shared/kmtpdeviceinterface.cpp
  mtp/shared/kmtpdeviceinterface.h
  mtp/shared/kmtpdinterface.cpp
  mtp/shared/kmtpdinterface.h
  mtp/shared/kmtpfile.cpp
  mtp/shared/kmtpfile.h
  mtp/shared/kmtpstorageinterface.cpp
  mtp/shared/kmtpstorageinterface.h
  mtp/shared/org.kde.kmtp.daemon.xml
  mtp/shared/org.kde.kmtp.device.xml
  mtp/shared/org.kde.kmtp.storage.xml

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 268 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/268/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 20:42:27 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(32058/60022)38%
(16509/43914)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9061/9504)48%
(4267/8932)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8377/14348)50%
(4670/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3895/7931)34%
(1590/4679)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1025)37%
(316/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4317)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns updated this revision to Diff 43176.
bruns added a comment.


  make (introduction of) error message translatable

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15826?vs=42547=43176

BRANCH
  oob

REVISION DETAIL
  https://phabricator.kde.org/D15826

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 160 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/160/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 23:21:58 +
 Build duration:
7 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13180)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 161 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/161/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 23:29:32 +
 Build duration:
7 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13180)29%
(2736/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(424/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
 

D15973: Add a 'Properties' entry in the places panel context menu

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6bbb80c2f9f2: Add a Properties entry in the 
places panel context menu (authored by thsurrel).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=43071=43164

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 235 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/235/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 23:21:58 +
 Build duration:
2 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in main.cpp:211
> But still, if the term is short (namely, length < 4), we will either won't 
> have "-" (this corresponds to `posOfNonNumeric < 0`, and that's 
> `X`), or it will be the last symbol (something like `X1-` - which is 
> `posOfNonNumeric+1 == word.length()`).

but you are not allowed to access `word[2]` if `word.length() < 3`.

> poboiko wrote in main.cpp:218
> On the one hand, you're right. On the other hand, the output should be 
> consistent. Other messages here are translated.

None of the other messages is an error message, but just regular output. Hm, 
maybe `i18n("Internal Error: %1", message)`.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko added a comment.


  > Hah, looks like you pushed a commit for it last year!
  > 
  > I'm not wedded to symlink support, but if we're not going to do it, we 
should close the bug with some good reasons.
  
  Well, I remembered that I did something on that, but I totally forgot what 
exactly. That's how I've found this bug - lurking through commit log :)
  
  > Adding to all the points you already mentioned, I am also against following 
symlinks:
  > 
  > - if a symlink points inside a hierarchy already included, there is nothing 
gained
  > - if a symlink points outside, it can be included explicitly using 
includeFolders
  > 
  >   Prior to any implementation attempt I would like to see a specific use 
case for following symlinks, which is not already covered.
  
  So, it seems like it is not just about whether we should follow symlinks when 
indexing or not. There are apparently also some troubles with "Search From 
Here" in Dolphin...
  I agree - I think we should start with looking what are the possible use 
cases for symlinks, and which of them work (or not). If the situation can be 
improved cheaply (i.e. without changing DB schema :), then it would be nice

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15944

To: poboiko, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D15582: Reference product "KF5" in widget metadata, instead of "KDE"

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R298:9c34333131b8: Reference product KF5 in widget 
metadata, instead of KDE (authored by kossebau).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15582?vs=41871=43174

REVISION DETAIL
  https://phabricator.kde.org/D15582

AFFECTED FILES
  src/kde.widgets

To: kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14530: Fix crash when save a QImage to the eps format file

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  Closing this review request as the author has not reacted. D15405 
 should be serving already as more proper 
fix for the referenced bug.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D14530

To: kossebau, mlaurent, dfaure, zccrs
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15988: Add 'Mount' option to context menu of unmounted device in Places

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:57f0d33d8e9a: Add Mount option to context 
menu of unmounted device in Places (authored by thsurrel).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15988?vs=42979=43165#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15988?vs=42979=43165

REVISION DETAIL
  https://phabricator.kde.org/D15988

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 269 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/269/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 21:17:08 +
 Build duration:
5 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(32022/60026)38%
(16493/43922)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9067/9504)48%
(4277/8932)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8354/14347)50%
(4657/9279)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7936)34%
(1588/4687)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(527/1025)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4317)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(698/1373)42%

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D14530: Fix crash when save a QImage to the eps format file

[Friedrich W. H. Kossebau]

kossebau commandeered this revision.
kossebau edited reviewers, added: zccrs; removed: kossebau.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D14530

To: kossebau, mlaurent, dfaure, zccrs
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15970: Properly look for fallback themes

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15970

To: apol, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Igor Poboiko]

poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in main.cpp:211
> but you are not allowed to access `word[2]` if `word.length() < 3`.

We don't access it directly, and `indexOf` performs internal checks. For 
example, `QStringLiteral("ab").indexOf('c', 5)` seem to be perfectly valid 
code, which returns `-1`. 
On one hand, it makes sense, and I think we can rely on it. On the other - it's 
not actually stated directly in the documentation 
...

> bruns wrote in main.cpp:218
> None of the other messages is an error message, but just regular output. Hm, 
> maybe `i18n("Internal Error: %1", message)`.

OK, I think that's better

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15959: Wait for the extraction process to finish before scheduling

[Stefan Brüns]

bruns added a comment.


  This works for me:
  
 void FileIndexScheduler::scheduleIndexing()
 {
-if (m_threadPool.activeThreadCount() || m_indexerState == Suspended) {
+if (m_indexerState == Suspended) {
 return;
 }

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15959

To: poboiko, #baloo, #frameworks
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D15970: Properly look for fallback themes

[Eike Hein]

hein accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15970

To: apol, #plasma, davidedmundson, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15970: Properly look for fallback themes

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8c18054a0de3: Properly look for fallback themes (authored 
by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15970?vs=42938=43175

REVISION DETAIL
  https://phabricator.kde.org/D15970

AFFECTED FILES
  src/plasma/private/theme_p.cpp

To: apol, #plasma, davidedmundson, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns added a comment.


  In D11828#339379 , @poboiko wrote:
  
  > Looks fine to me. But do we really need to optimize it? I mean, I didn't 
see it running more than ~20 ms, and with this patch for small queries it runs 
like ~16 ms. Worst case is when user types something in KRunner, but again, the 
lag is negligible there.
  
  
  KRunner currently executes each search term 8 times, once for each of type in 
[ Audio, Video, Document, ...]. I think especially for krunner lower latency is 
important, as it does search-as-you-type.

INLINE COMMENTS

> poboiko wrote in orpostingiterator.cpp:79
> I'm not really sure, do we actually need to set it to `nullptr`? It becomes 
> inaccessible after next line

It makes debugging a little bit nicer, erase is implemented as swap, and when 
setting it the vector only contains nullptrs after size() elements.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, #frameworks, poboiko
Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 236 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/236/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 23:24:41 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15934: Add battery and bluetooth icons for other DE compatibility

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I'd be happy about that!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns added a comment.


  In D15826#339367 , @poboiko wrote:
  
  > BTW, does it also wipe tags and other user-provided metadata?
  
  
  Tags and comments are store in XAttrs, i.e. with the file.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

[James Smith]

smithjd added a comment.


  Does this run at startup? If so, this will erase the entries of files on a 
removable volume not already mounted.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15939

To: poboiko, #baloo, #frameworks, vhanda, ngraham
Cc: smithjd, bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D11529: Balooctl: Deindex unfound files with check command.

[James Smith]

smithjd abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh, broulik, bruns
Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  RE:
  
  In D15999#338724 , @filipf wrote:
  
  > Would the background be grey and the icon itself black in all color 
schemes? (apropos how Inkscape shows it:)
  >
  > F6310672: image.png 
  >
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  >
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  
  The background stays the same color, no matter the color scheme used. I am 
told that it's not currently possible for the login-screen to change the color 
of the background independently of the foreground. The foreground color is the 
same color as a theme's text color. In the case of the lockscreen, that's white.
  
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  > 
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  I have never thought about that tbh. It's something to investigate, can you 
repost that thought on T9658 ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16043: Clean up unused QDebug/baloodebug.h includes

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  debug_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16043

To: bruns, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16044: [Timeline] Use categorized logging

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  debug_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16044

To: bruns, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16043: Clean up unused QDebug/baloodebug.h includes

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5e3871aa030b: Clean up unused QDebug/baloodebug.h 
includes (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16043?vs=43121=43159

REVISION DETAIL
  https://phabricator.kde.org/D16043

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/result.cpp
  src/file/fileindexerconfig.cpp
  src/file/filtereddiriterator.cpp
  src/file/mainhub.cpp
  src/file/optimizedbytearray.h
  src/file/pendingfilequeue.cpp
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, #frameworks, broulik, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16044: [Timeline] Use categorized logging

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2530d160781d: [Timeline] Use categorized logging 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16044?vs=43127=43160

REVISION DETAIL
  https://phabricator.kde.org/D16044

AFFECTED FILES
  baloo.categories
  src/kioslaves/timeline/CMakeLists.txt
  src/kioslaves/timeline/timelinetools.cpp

To: bruns, #baloo, #frameworks, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15932: [UDisks2] Power down drive on remove if supported

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R245:867f53608d3a: [UDisks2] Power down drive on remove if 
supported (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15932?vs=42905=43162

REVISION DETAIL
  https://phabricator.kde.org/D15932

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: bruns, #frameworks, ngraham, broulik
Cc: broulik, kde-frameworks-devel, ngraham, michaelh, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/44/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 08 Oct 2018 19:43:06 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7099/9496)55%
(3472/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1259/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1378)44%
(294/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4658)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/32/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 08 Oct 2018 19:43:06 +
 Build duration:
6 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7103/9496)55%
(3478/6357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1263/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(776/1378)45%
(295/662)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4658)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Stefan Brüns]

bruns added a comment.


  In D15825#338218 , @astippich 
wrote:
  
  > In D15825#334087 , @bruns wrote:
  >
  > > There are some more common tags with identical values, i.e. AlbumArtist, 
Composer and Lyrics - any reason you kept these?
  >
  >
  > These are the tags directly supported by taglib (e.g. tag->artist() ) which 
don't require manual reading of tags. These are only the supported tags for the 
mime types tested in D15833 
  
  
  Sorry, I don't get it yet ...
  
  Is there anything preventing this to work:
  
SimpleExtractionResult result(testFilePath(fileName), mimeType);
plugin.extract();
QCOMPARE(result.properties().value(Property::AlbumArtist), 
QVariant(QStringLiteral("Album Artist")));
  
  As far as I can see, this is identical code for all tests, and supported by 
all formats.
  
  Or are these not supported by some of the four //new// formats added in 
D15833 ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15825

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Igor Poboiko]

poboiko added a comment.


  Maybe we should print also a suggestion to user, something like (maybe 
rephrase it better)
  
WARNING:
Looks like your index is corrupted.
We suggest you to run `balooctl disable && balooctl disable` to wipe it and 
rebuild from scratch
  
  so they won't have to google what to do (there's still not much can be done 
in that case)
  
  BTW, does it also wipe tags and other user-provided metadata?

INLINE COMMENTS

> bruns wrote in main.cpp:204
> See `word[0]` access directly after.
> I have fixed to many "shouldn't be" errors/crashes due to corrupt DB values 
> in the past.

OK, you're right, I guess.

> bruns wrote in main.cpp:211
> This is the exact case I have had - "X.
> The code after (`word.indexOf('-', 2)`) requires a check for length >= 3 here 
> (code correctness), semantics require >= 4.

But still, if the term is short (namely, length < 4), we will either won't have 
"-" (this corresponds to `posOfNonNumeric < 0`, and that's `X`), or it 
will be the last symbol (something like `X1-` - which is `posOfNonNumeric+1 == 
word.length()`).

> bruns wrote in main.cpp:218
> I am not really sure:
> balooctl -x is a quite low level debug tool. This is a diagnostic message 
> only printed in case of DB errors. Translated strings make search on the web 
> harder.

On the one hand, you're right. On the other hand, the output should be 
consistent. Other messages here are translated.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16049: Added missing Icons to Places Panel code from KIO

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16049

To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11828: Simplify orPostingIterator and make it faster

[Igor Poboiko]

poboiko added a comment.


  Looks fine to me. But do we really need to optimize it? I mean, I didn't see 
it running more than ~20 ms, and with this patch for small queries it runs like 
~16 ms. Worst case is when user types something in KRunner, but again, the lag 
is negligible there.

INLINE COMMENTS

> orpostingiterator.cpp:73
>  
> -// First or last element
> -if (iter->docId() == 0 && iter->next() == 0) {
> -delete iter;
> -*it = nullptr;
> -continue;
> +auto docId = iter->docId();
> +if (docId <= m_docId) {

Usage of `auto` keyword (at least for docId) somehow made it a bit harder to 
read for me. Looks like Qt Coding Conventions 
 agrees 
(it's fine for iterators, whose definition has a long-long-name and it's clear 
from the line that it's an iterator. But for ordinary `docId` I've began to 
think it's not `quint64`, but some weird class with large definition or 
something).

> orpostingiterator.cpp:79
> +delete iter;
> +*it = nullptr;
> +it = m_iterators.erase(it);

I'm not really sure, do we actually need to set it to `nullptr`? It becomes 
inaccessible after next line

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, #frameworks, poboiko
Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16049: Added missing Icons to Places Panel code from KIO

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16049

To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns