D16135: refactor tests for taglibextractor

2018-10-13 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:2d6b448b69b0: refactor tests for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43490=43525 REVISION

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Igor Poboiko
poboiko added a comment. In D16165#342156 , @astippich wrote: > I guess bugs > 352856 > 353848 > 361259 > will also be fixed by this? Yes, they should be. Thanks for the links! Added it to summary. REPOSITORY R286

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Igor Poboiko
poboiko updated this revision to Diff 43526. poboiko added a comment. Replaced `size()` by `count()`, which is more appropriate here REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43506=43526 BRANCH dont-crash-invalid-exiv (branched from

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Stefan Brüns
bruns added a comment. In D16165#342348 , @poboiko wrote: > In D16165#342156 , @astippich wrote: > > > I guess bugs > > 352856 > > 353848 > > 361259 > > will also be fixed by this? >

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-13 Thread David Faure
dfaure updated this revision to Diff 43555. dfaure added a comment. add bug number REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16183?vs=43553=43555 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16183 AFFECTED FILES src/kcrash.cpp

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-13 Thread Heiko Becker
heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. I can confirm that the crash doesn't occur anymore. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker,

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-10-13 Thread Christoph Roick
croick updated this revision to Diff 43560. croick added a comment. - Use empty body for while loop REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=43020=43560 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Stefan Brüns
bruns added a comment. In D16165#342522 , @poboiko wrote: > In D16165#342433 , @bruns wrote: > > > These three should be CCBUG: (not test file, not able to confirm fixed), while 375131 should be

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

2018-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 13 Oct 2018 15:32:25 + Build duration: 1 min 26 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 121 - Fixed!

2018-10-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/121/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Oct 2018 15:32:25 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed:

D16145: Adapt autotest to new menu structure

2018-10-13 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R304:34e50636dd7b: Adapt autotest to new menu structure (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16145?vs=43433=43541 REVISION

D16165: Don't crash on invalid exiv2 data

2018-10-13 Thread Igor Poboiko
poboiko added a comment. In D16165#342433 , @bruns wrote: > These three should be CCBUG: (not test file, not able to confirm fixed), while 375131 should be BUG: (confirmed and fixed). Wait. Those three are about the very same crash I was

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-13 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY small optimization and harmonization for all metadata

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-13 Thread David Faure
dfaure created this revision. dfaure added reviewers: heikobecker, aacid, sitter. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY For instance in kio_help. The right fix

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-13 Thread Michael Pyne
mpyne created this revision. mpyne added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY A recent commit d428fc8e6447ede81f1e1911d0b66b39265672f3

Re: KDE4 build question: turning off hidden visibility?

2018-10-13 Thread Michael Pyne
On Thu, Oct 11, 2018 at 12:25:32PM +0200, René J.V. Bertin wrote: > Hi, > > Please excuse me for a question that's not directly related to KF5 > frameworks; I don't know where else to reach an audience who might know > (remember) the answer. > > In short: how do I configure a build so it will

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-13 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. No longer needed with D15935 (or at least, the pressure is off). REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc:

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-13 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns