D8532: [WIP] Restrict file extractor with Seccomp

[Detlef Eppers]

detlefe added a comment.


  Dropping one more comment, in case someone wants to give it a try: Apparmor 
profile transitions don't work if a seccomp filter has been installed before. 
This makes it probably rather difficult to integrate DrKonqi into an Apparmor 
policy.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D8532

To: davidk, apol, ossi, #frameworks, smithjd, bruns
Cc: fvogt, mgallien, kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, 
nicolasfella, ashaposhnikov, astippich, spoorun, bruns, abrahams

D8532: [WIP] Restrict file extractor with Seccomp

[Detlef Eppers]

detlefe added a comment.


  In D8532#336584 , @fvogt wrote:
  
  > AFAICT this won't actually protect much - the open DBus socket is enough to 
execute arbitrary programs.
  >
  > The best design would be (IMO, not sure how well the current architecture 
fits) to have a fully sandboxed executable which can only communicate with 
baloo over a single socket.
  >  Over that socket it receives a (read-only) file descriptor for the to be 
dissected file and then sends the result to baloo.
  
  
  I love the proposal(!), but just in case a full sandbox is wanted here and 
large changes to (unmaintained) baloo are out of scope, maybe a combination of 
Apparmor and seccomp could offer a way out. Note that this was also proposed by 
Martin Flöser for the original kscreenlocker seccomp sandbox, but as far as I 
know never implemented.
  
  Apparmor has the advantage that access to DBus can be controlled in a very 
fine grained way, that writing a profile should be relatively straightforward 
and that users can debug (or adapt) the profile easily. The main disadvantage 
is that it is not available everywhere, as pointed out already by @davidk in 
the summary. Regarding this latter point, however, it is maybe worth pointing 
out that also a proper sandbox is not necessarily available everywhere. The 
question here is how would you do it? You need root to set it up, and there are 
in the moment two ways to get there: Unprivileged user namespaces, which are 
not available in all distributions (Arch, Debian, ...), or SUID root, which is 
risky and hard to get it right. Bubblewrap or something like that would 
introduce an additional dependency.
  
  One advantage of seccomp is that it works basically everywhere. Also I tend 
to disagree on the suggestion that it is useless. Whitelists can have 
properties of a real sandbox, but usually the role of seccomp is to reduce 
attack surface... this is why it exists, what seccomp was designed for, and why 
IMHO it makes a lot of sense for Baloo even if there is not a perfect 
solution/if Apparmor is unavailable.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D8532

To: davidk, apol, ossi, #frameworks, smithjd, bruns
Cc: fvogt, mgallien, kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, 
nicolasfella, ashaposhnikov, astippich, spoorun, bruns, abrahams

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R877:ccfb970b3206: Force ki18n to build with the libintl.so 
path (authored by sdepiets, committed by vonreth).

REPOSITORY
  R877 Craft Blueprints for KDE

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14938?vs=40023=43947

REVISION DETAIL
  https://phabricator.kde.org/D14938

AFFECTED FILES
  kde/frameworks/tier1/ki18n/0002-Keep-LibIntl-libraries-path.patch
  kde/frameworks/tier1/ki18n/ki18n.py

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a comment.


  So to recap recent discussions, here are the requested changes:
  
  - (Required) Create a version of the `go-previous` icon with this same style, 
and name it `go-previous-translucent`
  - (Required) Make the background circle more opaque and/or darker
  - (Optional, your call) experiment with making the symbols a bit smaller 
inside the background circle, per @filipf's suggestion

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Ben Cooksley]

bcooksley added a comment.


  It might be worth getting in touch with the Samba developers, as I believe 
they've worked with the people at Microsoft who look after the SMB parts of 
Windows - and they'd know best what is done in regards to discovery of shares 
these days. 
  Turning to Google though, it looks like this is simply broken in current 
versions of Windows 10 (by default at least) - 
https://answers.microsoft.com/en-us/windows/forum/windows_10-files/homegroup-removed-how-to-get-network-sharing-work/01277332-2916-4a68-853a-116696b20743

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: bcooksley, ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp

D16137: Add an option to KConfigDialog to fit page contents horizontally

[Tim __]

kadabash updated this revision to Diff 43944.
kadabash added a comment.


  Fit page content horizontally *and* vertically
  
  Vertical fitting only occurs on displays that Qt deems large enough.
  Displays that are just high enough to fit the content vertically 
  are apparently sometimes not considered large enough.

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16137?vs=43607=43944

BRANCH
  config-dialog-content-fit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16137

AFFECTED FILES
  src/kconfigdialog.cpp
  src/kconfigdialog.h

To: kadabash
Cc: ngraham, svuorela, aacid, kde-frameworks-devel, michaelh, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Shubham]

shubham added a comment.


  @bruns Apart from these, does the code seems sane to you?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> job_error.cpp:1078
> +description = xi18n("The file %1 cannot be 
> transeferred,"
> +" because the the destination's filesystem does 
> not support files that large", errorText);
> +solutions << i18n("Format the destination drive to a filesystem 
> format which supports file that large.");

double "the"
drop the "`s"

> job_error.cpp:1079
> +" because the the destination's filesystem does 
> not support files that large", errorText);
> +solutions << i18n("Format the destination drive to a filesystem 
> format which supports file that large.");
> +break;

"Format **with**"
"filesystem type" or just "filesystem"
either "a file" or better "files"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

vonreth accepted this revision.
vonreth added a comment.
This revision is now accepted and ready to land.


  its not optimal to patch this on our side but lets do it for now

REPOSITORY
  R877 Craft Blueprints for KDE

BRANCH
  ki18n_libintl_lib (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Shubham]

shubham updated this revision to Diff 43938.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=43930=43938

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Shubham]

shubham added a comment.


  @ngraham No, please recheck, the check is before the first m_totalSize > 
m_freeSpace check

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16318: [xdgshell] Add positioner constraint adjustment flag operators

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16318

To: davidedmundson, #kwin, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Nathaniel Graham]

ngraham added a comment.


  `1ul << 32) -1` needs a comment explaining what it means, for people like me 
with puny brains. :)
  
  There are //two// checks in this file that result in an `ERR_DISK_FULL` if 
there is not enough space. The FAT32 check is now before the second one, but 
not the first one, so the first one still will still look for adequate space 
before checking to see whether or not the copy is even possible due to FAT32 
file size restrictions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Shubham]

shubham updated this revision to Diff 43930.
shubham marked 5 inline comments as done.
shubham added a comment.


  File size limit check for a given file system before (m_totalSize > 
m_freeSpace) check

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=43895=43930

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> ngraham wrote in job_error.cpp:253
> Unrelated and incorrect change: `https` is correct here, so please revert.

That was my previous commit where I changed http -> https. Don't know why it 
affected my local branch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added a comment.


  It's available as an API, but it is not used to publish **shares** it seems. 
In fact, if I am reading Microsoft's arcticle 

 on smb1 correctly then ws-discovery is also not enabled by default. Finding 
other shares in the network seems simply not supported out of the box. I've 
gotten a device which has an up to date windows 10, albeit installed before the 
2017 Fall update, so it has smb1 still enabled. As expected the discovery 
service also mentioned in the article isn't started by default. Starting it 
gives me some ws-discovery chatter on the network.
  
  I've also tried to get gsoap to work but I feel somewhat defeated. It's 
sending out a probe event but gets nothing back, getting it to even build 
properly is also fairly mental because it expects symbols to be visible. It all 
feels fairly terrible. While I eventually got some Probe events multicasted, 
the windows machine then proceeded to not reply to those and instead kept 
spouting Resolve requests which AFAIK don't need handling by clients at all. 
I'm probably gonna download a development VM to stand a better chance at 
debugging this, but overall ws-discovery supports seems incredibly unreasonable 
to add at this time.
  
  I've also tried kdsoap and have it auto generate a proxy class from the 
ws-discovery wsdl, but somehow the generator didn't like the fact that the wsdl 
didn't define any bindings and decided to qAbort instead of generating 
anything...
  
  So, all in all a big fat waste of time. Assuming Windows 10 indeed doesn't 
have ws-discovery enabled by default I really really think everyone would be 
better off if we got Microsoft to either add a DNSSD discovery service OR we 
could just do something like that ourselves that the user can download. In the 
end the user would have to manually do something if they want to discover 
Windows 10 hosts it seems.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

D16318: [xdgshell] Add positioner constraint adjustment flag operators

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Used in kwin

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16318

AFFECTED FILES
  src/server/xdgshell_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15645: Add scheme selection menu with a "System" entry.

[Nathaniel Graham]

ngraham added reviewers: broulik, cfeck, elvisangelaccio.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu added a comment.


  Ping. Can someone please review ?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Nathaniel Graham]

ngraham added a comment.


  In D16299#345718 , @sitter wrote:
  
  > What I'd really like to know is if windows 10 actually has dnssd nowadays, 
and if it is enabled by default, and whether smb is published if/when dnssd is 
enabled.
  
  
  https://www.ctrl.blog/entry/windows-mdns-dnssd and 
https://stackoverflow.com/a/30769404/2934226seem to indicate that DNS-SD is 
used for discovery in Windows 10.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 170 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/170/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 19 Oct 2018 11:44:13 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13181)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1700/3506)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 443 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/443/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 19 Oct 2018 12:04:58 +
 Build duration:
6 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31928/59978)37%
(16458/43892)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9077/9516)48%
(4264/8920)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8270/14315)50%
(4633/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3885/7923)34%
(1589/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(697/1372)42%
  

D16313: Use QMenu::addSeparator

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5001954b022a: Use QMenu::addSeparator (authored by 
thsurrel).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16313?vs=43913=43914

REVISION DETAIL
  https://phabricator.kde.org/D16313

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/knewfilemenu.cpp

To: thsurrel, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16313: Use QMenu::addSeparator

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arc_addseparator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16313

To: thsurrel, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 245 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/245/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 19 Oct 2018 11:44:12 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3579/13121)19%
(1791/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)54%
(600/1113)28%
(307/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(295/2221)6%
(91/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1414/3492)30%
(792/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(574/1978)17%
(295/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D16313: Use QMenu::addSeparator

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arc_addseparator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16313

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/knewfilemenu.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16301: Remove ComponentInstaller

[Aleix Pol Gonzalez]

apol added a comment.


  FWIW my +1 is to removing it. The Appstream assessment is all right but 
fixing something nobody uses sounds like a waste of time. :P

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16301

To: broulik, #plasma, mart
Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16166: Pass the FileIndexerConfig as const to the individual indexers

[Stefan Brüns]

bruns added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16166

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

[Kai Uwe Broulik]

broulik retitled this revision from "[KFilePlacesView] Use asynchronous 
KIO::FileSystemFreeSpaceJob" to "RFC: [KFilePlacesView] Use asynchronous 
KIO::FileSystemFreeSpaceJob".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16311: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This ensure hovering a broken mount will not freeze the UI.
  I already optimized it in D11088  to 
avoid doing blocking calls for when the bar isn't shown but this patch makes it 
fully async now.
  Moreover, refresh only every 60 seconds (it's what Dolphin as well as 
Plasma's free space warning do), currently it would refresh every frame

TEST PLAN
  Capacity bar shows up for a mounted drive and updates after a while when you 
hover it again.
  It doesn't update "live" but it never did that, only happened to because it 
was querying free space like a mad man.
  
  In theory this would also enable free space bars for network shares but 
`CapacityBarRecommendedRole` is only for mounted local storage sans CD rom.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16306: [Codecs] Remove unneeded const_cast

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2e3dafe5a892: [Codecs] Remove unneeded const_cast 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16306?vs=43898=43910

REVISION DETAIL
  https://phabricator.kde.org/D16306

AFFECTED FILES
  src/codecs/postingcodec.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added a comment.


  Done some research on ws-discovery. gsoap is the only free c implementation I 
could find. There are some python, js and java implementations but they'll 
probably not help us nearly as much (unless someone wants to write a daemon or 
helper binary to bridge the language divide without much hassle). Alternative 
approach would be writing our own implementation using KDAB's kdsoap library, 
but then that'd need a maintainer which I am confident we don't have :)
  
  I have no idea how stable or lovely gsoap is to use though. It has only a 
hand full of users (as in: software using it) that is packaged in debian and 
the way gsoap is packaged is using an aggressively versioned soname in debian 
(which is often an indication of either poor soname maintenance or super lax 
API stability policy; both of which are not very good). So I am not too 
confident here.
  
  What I'd really like to know is if windows 10 actually has dnssd nowadays, 
and if it is enabled by default, and whether smb is published if/when dnssd is 
enabled.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

D16301: Remove ComponentInstaller

[Kai Uwe Broulik]

broulik added a comment.


  > Method InstallPackages
  
  Thanks for the insight. In any case, the way the code "works" right now is 
probably not what we want. It has been unused for years and is unlikely to come 
back in that form, so we can rm it. If we were to support something like this 
we need to modernize the architecture using AppStream and what not anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16301

To: broulik, #plasma, mart
Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16306: [Codecs] Remove unneeded const_cast

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  oob

REVISION DETAIL
  https://phabricator.kde.org/D16306

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 442 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/442/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 19 Oct 2018 06:57:08 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31942/59991)37%
(16453/43892)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9071/9516)48%
(4256/8920)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8280/14316)50%
(4637/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3895/7935)34%
(1591/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

D16306: [Codecs] Remove unneeded const_cast

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16306

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams