D16522: [Extractor] Do not check QFile::exists for an empty url

This revision was automatically updated to reflect the committed changes. Closed by commit R293:856fd6811881: [Extractor] Do not check QFile::exists for an empty url (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16522?vs=44475=44480

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/64/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 30 Oct 2018 03:08:35 + Build duration: 4 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/120/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 30 Oct 2018 03:08:35 + Build duration: 1 min 20 sec and counting JUnit Tests Name:

D16514: Re-add monochrome link icon as action

ngraham added a comment. Due to a bug in how Phabricator handles diffs that involve symlinks that become real files, I had to land this by hand: https://cgit.kde.org/breeze-icons.git/commit/?id=0d8d99bd9d16f9bc5e4f14c77109e43dd65094cb REPOSITORY R266 Breeze Icons REVISION DETAIL

D16514: Re-add monochrome link icon as action

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16514 To: ndavis, #vdg, #breeze, ngraham Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16522: [Extractor] Do not check QFile::exists for an empty url

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16522 To: bruns, #baloo, #frameworks, dfaure, apol, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16514: Re-add monochrome link icon as action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, that'll do! REPOSITORY R266 Breeze Icons BRANCH fix-link-action (branched from master) REVISION DETAIL https://phabricator.kde.org/D16514 To: ndavis, #vdg, #breeze, ngraham

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

bruns added a dependent revision: D16524: [Extractor] Use QDataStream serialization in place of cooked one. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16524: [Extractor] Use QDataStream serialization in place of cooked one

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need to reinvent serialization of Qt data

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The handler does not handle partial reads, and most

D16522: [Extractor] Do not check QFile::exists for an empty url

bruns created this revision. bruns added reviewers: Baloo, Frameworks, dfaure, apol. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the file has been removed from the IdTree DB, but is

D16520: proper kwalletd dbus service file for the legacy name

bruns added a comment. The old kwalletd(4) from kde-runtime newer installed a service file, as far as I can see. The `org.kde.kwalletd.service` from kwalletd5 only serves one purpose - start the old kwalletd4 as a source for the migration agent. IMHO the much better approach would be

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. > So now both kdelibs4 and kf5-kwallet will be installing org.kde.kwalletd.service and the package manager will complain. that was the case even before my patch REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,

D16520: proper kwalletd dbus service file for the legacy name

apol added a comment. In D16520#350809 , @damjang wrote: > in what way exactly? > > note that the kwallet package already did install org.kde.kwalletd.service, but also, kdelibs4 apps should be able to use kwalletd5 via the old interface

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. In D16520#350807 , @apol wrote: > Won't this break co-installability with kdelibs4? in what way exactly? note that the kwallet package already did install org.kde.kwalletd.service, but also, kdelibs4 apps

D16520: proper kwalletd dbus service file for the legacy name

apol added a comment. Won't this break co-installability with kdelibs4? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

damjang created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. damjang requested review of this revision. REVISION SUMMARY the org.kde.kwalletd legacy (kde4) name/interface is implemented by kwalletd5. this patch makes a proper dbus

D14472: Set Dialog flag for JobDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R495:b82b62e87a4e: Set Dialog flag for JobDialog (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14472?vs=38729=44468 REVISION

D16116: [KPropertiesDialog] Show a filename for the / directory

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops, missed this. However, I'm afraid it doesn't work for me, unless I'm holding it wrong: F6373382: Doesn't seem to work.png Looks

D16116: [KPropertiesDialog] Show a filename for the / directory

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Er, whoops. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16494: Take 1..n KMainWindows in kRestoreMainWindows

This revision was automatically updated to reflect the committed changes. Closed by commit R263:726684c0eb19: Take 1..n KMainWindows in kRestoreMainWindows (authored by tobiasdeiminger). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16494?vs=44383=44464

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

phily updated this revision to Diff 44457. phily added a comment. - Added JCL test program as well as fixing recommendations (no hard coded colors) - Added new highlighting of steps (vs program options) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

phily updated this revision to Diff 44454. phily added a comment. Adding test file for JCL and making removing hard coded colors. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16415?vs=44277=44454 REVISION DETAIL

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Oct 2018 17:49:53 + Build duration: 3 min 34 sec and counting JUnit Tests Name: (root)

D16500: Wait for docbookl10nhelper to be built before building our own manpages

This revision was automatically updated to reflect the committed changes. Closed by commit R238:002940d2e0c3: Wait for docbookl10nhelper to be built before building our own manpages (authored by aacid). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D16416: z/OS CLIST file syntax highlighting

phily added a comment. In D16416#349335 , @cullmann wrote: > To properly push it with you as author, what is your full name + mail address? Phil Young mainframed...@gmail.com (I'm assuming you meant email address) REPOSITORY

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/18/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 29 Oct 2018 15:52:06 + Build duration: 2 min 5 sec and counting JUnit Tests

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.9 - Build # 47 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.9/47/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 29 Oct 2018 15:47:03 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.10 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.10/59/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Oct 2018 15:47:03 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.9 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.9/46/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 29 Oct 2018 15:42:43 + Build duration: 1 min 35 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.10 - Build # 58 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Oct 2018 15:42:43 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

D14472: Set Dialog flag for JobDialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH dialog REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16514: Re-add monochrome link icon as action

ndavis added reviewers: VDG, Breeze. ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16514 To: ndavis, #vdg, #breeze Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16514: Re-add monochrome link icon as action

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some action icons were symlinks to `emblem-symbolic-link`. When the new emblem style was applied to

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350460 , @pino wrote: > In D16498#350426 , @bruns wrote: > > > In D16498#350422 , @pino wrote: > > > > > In

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/63/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 29 Oct 2018 13:19:08 + Build duration: 4 min 53 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/119/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Oct 2018 13:19:07 + Build duration: 1 min 16 sec and counting JUnit Tests Name:

D16421: Improve emblem contrast, legibility and consistency

ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg, ngraham Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks fantastic. Fabulous work. REPOSITORY R266 Breeze Icons BRANCH emblem-outlines (branched from master) REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#350426 , @bruns wrote: > In D16498#350422 , @pino wrote: > > > In D16498#350289 , @bruns wrote: > > > > > In

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350422 , @pino wrote: > In D16498#350289 , @bruns wrote: > > > In D16498#350286 , @pino wrote: > > > > > Ugh no manual

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#350289 , @bruns wrote: > In D16498#350286 , @pino wrote: > > > Ugh no manual parsing of PS files -- please use libspectre. > > > This is not Postscript parsing,

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit R286:891b3f70c8b6: [KFileMetaData] Replace QDir::separator() with / in unit tests (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH qdir_separator REVISION DETAIL https://phabricator.kde.org/D16505 To: bruns, #frameworks, #baloo, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16431: Guard data source being deleted before processing dataoffer receive event

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8fe4a2756cdb: Guard data source being deleted before processing dataoffer receive event (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D15900: Add unit test for subsurface input mask detection

This revision was automatically updated to reflect the committed changes. Closed by commit R127:55ebeda6d5b3: Add unit test for subsurface input mask detection (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15900?vs=42731=44423

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 67 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/67/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 29 Oct 2018 10:10:07 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/94/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Oct 2018 10:10:07 + Build duration: 4 min 28 sec and counting JUnit Tests Name: (root)

D15900: Add unit test for subsurface input mask detection

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. The test passes on current master. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15900 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel,

D16431: Guard data source being deleted before processing dataoffer receive event

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16431 To: davidedmundson, #kwin, romangg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. @pino - please remove your change request, if you have not read the code at all ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino Cc: pino, kde-frameworks-devel,

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16490: [KFileMetaData] Add unittest for XML extractor

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > lbeltrame wrote in xmlextractortest.cpp:38 > IIRC you shouldn't use `QDir::separator()`. See > http://agateau.com/2015/qdir-separator-considered-harmful/ Thx, fixed here and elsewhere (D16505

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

bruns created this revision. bruns added reviewers: Frameworks, Baloo, lbeltrame. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN make no functional changes REPOSITORY R286 KFileMetaData BRANCH

D16421: Improve emblem contrast, legibility and consistency

ndavis updated this revision to Diff 44410. ndavis added a comment. Add emblem-readonly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44313=44410 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16116: [KPropertiesDialog] Show a filename for the / directory

thsurrel added a comment. Ping ! Anyone from #frameworks could review this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16490: [KFileMetaData] Add unittest for XML extractor

bruns updated this revision to Diff 44409. bruns added a comment. Replace QDir::Separator with "/" REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16490?vs=44375=44409 BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16490

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350286 , @pino wrote: > Ugh no manual parsing of PS files -- please use libspectre. This is not Postscript parsing, but DSC parsing - read the specification to understand the difference! REPOSITORY

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Ugh no manual parsing of PS files -- please use libspectre. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns updated this revision to Diff 44408. bruns added a comment. Replace QDir::Separator with "/" REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16498?vs=44388=44408 BRANCH postscript_dsc REVISION DETAIL https://phabricator.kde.org/D16498

D16490: [KFileMetaData] Add unittest for XML extractor

lbeltrame added a comment. Generally looks OK to me, one note on `QDir::separator()` usage. INLINE COMMENTS > xmlextractortest.cpp:38 > +{ > +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + > QDir::separator() + fileName; > +} IIRC you shouldn't use `QDir::separator()`. See