D16643: Correct the accept flag of the event object on DragMove

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> DeclarativeDropArea.cpp:97
>  if (event->pos() == m_oldDragMovePos) {
> -event->setAccepted(false);
>  return;

Change it to accept() and try it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Nathaniel Graham]

ngraham added a comment.


  Uh-oh, now the patch doesn't apply for me anymore:
  
$ arc patch D16249
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16249.
Checking patch src/core/job_error.cpp...
error: while searching for:
case KIO::ERR_CANNOT_CREATE_SLAVE:
result = i18n("Unable to create io-slave. %1", errorText);
break;
default:
result = i18n("Unknown error code %1\n%2\nPlease send a full bug 
report at https://bugs.kde.org.;, errorCode, errorText);
break;
}


error: patch failed: src/core/job_error.cpp:245
Hunk #2 succeeded at 1068 (offset -4 lines).
Checking patch src/core/global.h...
Checking patch src/core/copyjob.cpp...
Applying patch src/core/job_error.cpp with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Applied patch src/core/global.h cleanly.
Applied patch src/core/copyjob.cpp cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Might need to be re-based on the current state of master. But you really 
should look into using `arc`; it makes all of this so much easier. Setting it 
up takes all of 5 minutes. See 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 252 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/252/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Nov 2018 01:48:24 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 178 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/178/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Nov 2018 01:48:24 +
 Build duration:
2 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5178/13179)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1698/3504)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  !Ping Reviewers
  
  Please review this. It's just a very simple patch.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid that didn't change anything for me. If the experiment to make the 
background color adapt to the theme isn't working, maybe we should revert that 
change for now and just keep it hardcoded for now.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Nathaniel Graham]

ngraham added a comment.


  Is this logic correct? Just because we found any entries, we don't use DNSSD? 
Is there ever a case where we found some entries but might find even more by 
using DNSSD?
  
  Also, I want to compliment your code. It's so nice and clean and well 
commented.

INLINE COMMENTS

> kio_smb.h:282
>  bool workaroundEEXIST(const int errNum) const;
> +void listDNNSD(UDSEntry , const QUrl , const uint 
> direntCount);
>  

Shouldn't this be `listDNSSD`?

> kio_smb_browse.cpp:459
>  
> +   listDNNSD(udsentry, url, direntCount);
> +

Shouldn't this be `listDNSSD`?

> kio_smb_browse.cpp:504
>  
> +void SMBSlave::listDNNSD(UDSEntry , const QUrl , const uint 
> direntCount)
> +{

Shouldn't this be `listDNSSD`?

> kio_smb_browse.cpp:508
> +
> +// This entire method act as fallback logic iff SMB discovery is not 
> working
> +// (for example when using a protocol version that doesn't have 
> discovery).

iff -> if

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16684: Updated with petroleum industry units

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:b2419e57eeea: Updated with petroleum industry units 
(authored by joaonetto, committed by ngraham).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44918=44991

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability_p.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham added a comment.


  Indeed it can. Great job! May it be the first of many.  :-)

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16593: [ExtractorCollection] Use only best matching extractor plugin

[Stefan Brüns]

bruns added a comment.


  Fixed ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

[Stefan Brüns]

bruns added a comment.


  AFAICS the only chance this can happen if the test is using a different 
library version, e.g. when accidentally using the lib from the system. This 
would be a test setup error and should be reported with a fail ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Do not crash if no suitable extractor is found.
  Skip the test instead.

REPOSITORY
  R286 KFileMetaData

BRANCH
  skip_missing

REVISION DETAIL
  https://phabricator.kde.org/D16716

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich updated this revision to Diff 44982.
astippich added a comment.


  - more cleanup

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16671?vs=44868=44982

BRANCH
  refactor_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D16671

AFFECTED FILES
  src/embeddedimagedata.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  In D16643#354262 , @trmdi wrote:
  
  > In D16643#354120 , @bruns wrote:
  >
  > > `m_enabled` may change between //consecutive// DragMove events, but not 
during an event.
  > >
  > > In this case, though, it does not, and is constantly true. You can verify 
this by attaching a debugger or by adding debug statements.
  > >
  > > The only wrong code part is the `setAccepted(false)`, which should be 
`setAccepted(true)` (or just `accept()`, both are equivalent).
  >
  >
  > Please see these videos, note the cursor icon:
  >
  > - If I place `setAccepted(m_enabled)` below the first if like you said: 
https://streamable.com/oj1j4 -> the cursor does not change
  > - If I place `setAccepted(m_enabled)` above the first if like I've done in 
my patch: https://streamable.com/2g58g -> the cursor changes
  
  
  You have a conceptual misunderstanding of the enabled property, see 
QQuickItem 
  
  > enabled : bool
  >  This property holds whether the item receives mouse and keyboard events. 
By default this is true.
  
  It would also be good if you stick to one issue at a time.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16471: Listen for added DBus interfaces instead of registered services

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:fa472e6a5e26: Listen for added DBus interfaces instead of 
registered services (authored by fvogt).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16471?vs=44334=44981

REVISION DETAIL
  https://phabricator.kde.org/D16471

AFFECTED FILES
  src/manager.cpp
  src/manager_p.h
  src/secretagent.cpp
  src/secretagent.h
  src/secretagent_p.h

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16471: Listen for added DBus interfaces instead of registered services

[Fabian Vogt]

fvogt retitled this revision from "[RFC] Listen for added DBus interfaces 
instead of registered services" to "Listen for added DBus interfaces instead of 
registered services".
fvogt edited the summary of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  ifadded

REVISION DETAIL
  https://phabricator.kde.org/D16471

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16471: [RFC] Listen for added DBus interfaces instead of registered services

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Seems to work, let's push this for now and we will see if there is no 
regression.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  ifadded

REVISION DETAIL
  https://phabricator.kde.org/D16471

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Wolfgang Bauer]

wbauer added a comment.


  In D16692#355070 , @ngraham wrote:
  
  > The point is, there is no reason to reference distos (which are downstream 
from us) when we fix issues here. It does not matter that many or even most 
reports came from Neon. All rolling release distros have Frameworks 5.51, so it 
certainly was not just Neon users experiencing the issue.
  
  
  IIANM, the crash should be fixed by this commit in kcrash:
  
https://cgit.kde.org/kcrash.git/commit/?id=6dbd0edec10f65ff00341ccca94a052bbd55a876
  ( see also 
https://mail.kde.org/pipermail/release-team/2018-October/011106.html )
  
  Maybe that is not included yet in KDE Neon for some reason?
  IIRC this needed a respin on release day: 
https://mail.kde.org/pipermail/release-team/2018-October/011108.html

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: wbauer, ngraham, fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, 
kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, 
Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, 
SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16564: cleanup the test for embedded image extraction

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  embedded_test

REVISION DETAIL
  https://phabricator.kde.org/D16564

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[David Edmundson]

davidedmundson marked an inline comment as done.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16701

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16701

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[David Edmundson]

davidedmundson updated this revision to Diff 44977.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16701?vs=44953=44977

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16701

AFFECTED FILES
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.h
  src/client/registry.h
  src/server/display.h
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.h

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> romangg wrote in textinput_interface.cpp:67
> wlPurpose is also an abbreviation. ;)
> 
> And in the header file it is named `purpose`. Makes more sense to me to have 
> the name without abbreviation in the API. I'll rename the function variable 
> though.

> wlPurpose is also an abbreviation. ;)

You caught me. :D

> textinput_interface_p.h:69
>  
> +virtual TextInputInterface::ContentHints convertContentHint(uint32_t 
> hint) = 0;
> +virtual TextInputInterface::ContentPurpose 
> convertContentPurpose(uint32_t purpose) = 0;

Can be const.

REPOSITORY
  R127 KWayland

BRANCH
  textInputEnums

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Nathaniel Graham]

ngraham added a comment.


  The point is, there is no reason to reference distos (which are downstream 
from us) when we fix issues here. It does not matter that many or even most 
reports came from Neon. All rolling release distros have Frameworks 5.51, so it 
certainly was not just Neon users experiencing the issue.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: ngraham, fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, 
kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, 
Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, 
SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Albert Vaca Cintora]

albertvaka added a comment.


  In D16692#355068 , @fvogt wrote:
  
  > In D16692#355067 , @albertvaka 
wrote:
  >
  > > In D16692#354990 , @fvogt 
wrote:
  > >
  > > > I'm wondering why this specifically mentions "KDE Neon" both in the 
title and in the commit message.
  > > >
  > > > Is this workaround/fix only needed on neon or is the message wrong?
  > >
  > >
  > > I think only Neon ships frameworks 5.51
  >
  >
  > Why would you think that? 5.51 got released almost a month ago.
  
  
  Of curse I don't know every distro in the planet, but we got like a gazillion 
bug reports and I would say all of them are from Neon users, so this fix was 
quite directed to them.
  
  See: https://bugs.kde.org/show_bug.cgi?id=400178
  
  You can rename it, although it has been merged already.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Fabian Vogt]

fvogt added a comment.


  In D16692#355067 , @albertvaka 
wrote:
  
  > In D16692#354990 , @fvogt wrote:
  >
  > > I'm wondering why this specifically mentions "KDE Neon" both in the title 
and in the commit message.
  > >
  > > Is this workaround/fix only needed on neon or is the message wrong?
  >
  >
  > I think only Neon ships frameworks 5.51
  
  
  Why would you think that? 5.51 got released almost a month ago.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Albert Vaca Cintora]

albertvaka added a comment.


  In D16692#354990 , @fvogt wrote:
  
  > I'm wondering why this specifically mentions "KDE Neon" both in the title 
and in the commit message.
  >
  > Is this workaround/fix only needed on neon or is the message wrong?
  
  
  I think only Neon ships frameworks 5.51

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

romangg updated this revision to Diff 44970.
romangg added a comment.


  - Rename variables, function

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16708?vs=44966=44970

BRANCH
  textInputEnums

REVISION DETAIL
  https://phabricator.kde.org/D16708

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in textinput_interface.cpp:67
> purpose_? or just keep previous name (wlPurpose)?
> 
> https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations

wlPurpose is also an abbreviation. ;)

And in the header file it is named `purpose`. Makes more sense to me to have 
the name without abbreviation in the API. I'll rename the function variable 
though.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

[Roman Gilg]

romangg abandoned this revision.
romangg added a comment.


  Mistake by me. This is done already by bitwise comparison.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16709

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

romangg added a dependent revision: D16709: [server] Support text input v0 
default content hint.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

[Roman Gilg]

romangg added a dependency: D16708: [server] Text input content hint and 
purpose per protocol version.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16709

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

[Roman Gilg]

romangg added reviewers: KWin, Frameworks.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16709

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

[Roman Gilg]

romangg created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  text-input v0 supports an additional enum value default, that combines
  auto completion, correction and capitalization.
  
  Query this value.

TEST PLAN
  Compiles

REPOSITORY
  R127 KWayland

BRANCH
  textInputDefaultHint

REVISION DETAIL
  https://phabricator.kde.org/D16709

AFFECTED FILES
  src/server/textinput_interface_v0.cpp

To: romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> textinput_interface.cpp:67
> +const auto hints = p->convertContentHints(hint);
> +const auto purp = p->convertContentPurpose(purpose);
> +if (hints != p->contentHints || purp != p->contentPurpose) {

purpose_? or just keep previous name (wlPurpose)?

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Convert content hint and purpose according to used text-input protocol 
version.
  
  This way we can use different specifiers, which enables us in the future to 
use
  the default hint of v0 and the pin purpose of v3.
  
  Also code is cleaner when using the correctly versioned specifier names 
according
  to the protocol version.

TEST PLAN
  Compiles, autotest passes.

REPOSITORY
  R127 KWayland

BRANCH
  textInputEnums

REVISION DETAIL
  https://phabricator.kde.org/D16708

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Fabian Vogt]

fvogt added a comment.


  I'm wondering why this specifically mentions "KDE Neon" both in the title and 
in the commit message.
  
  Is this workaround/fix only needed on neon or is the message wrong?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: fvogt, sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/77/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 13:13:08 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 40 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testTextInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)88%
(227/257)88%
(227/257)80%
(23094/29008)50%
(9300/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client93%
(39/42)93%
(39/42)91%
(10953/12041)47%
(5932/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client90%
(66/73)90%
(66/73)75%
(5160/6863)57%
(1355/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)80%
(6547/8158)60%
(1844/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Albert Vaca Cintora]

This revision was automatically updated to reflect the committed changes.
Closed by commit R224:560e8638e8dd: A QApplication object needs to be 
instantiated for kio-kdeconnect to work on… (authored by eduisters, committed 
by albertvaka).

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16692?vs=44954=44964

REVISION DETAIL
  https://phabricator.kde.org/D16692

AFFECTED FILES
  kio/CMakeLists.txt
  kio/kdeconnect.json
  kio/kdeconnect.protocol
  kio/kiokdeconnect.cpp

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/76/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 12:49:50 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24813/29128)52%
(9851/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11685/12056)49%
(6204/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5742/6936)64%
(1508/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6952/8190)64%
(1970/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/103/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 13:09:16 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24821/29127)53%
(9860/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11703/12057)49%
(6217/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6951/8190)64%
(1968/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/102/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 12:49:50 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24794/29127)52%
(9836/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11672/12057)49%
(6189/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5736/6934)64%
(1508/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6952/8190)64%
(1970/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 458 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/458/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 13:00:11 +
 Build duration:
5 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31986/59987)38%
(16495/43902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9105/9545)48%
(4275/8954)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8292/14288)50%
(4643/9237)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3885/7921)34%
(1587/4687)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(697/1372)42%
  

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 74 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/74/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 06 Nov 2018 12:58:50 +
 Build duration:
3 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 414.79 KB...]C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(117): error C2664: 'int MessageBoxA(HWND,LPCSTR,LPCSTR,UINT)': cannot convert argument 2 from 'QByteArray' to 'LPCSTR'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(119): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be calledjom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\src\kioslave\CMakeFiles\kioslave.dir\build.make [src\kioslave\CMakeFiles\kioslave.dir\kioslave.cpp.obj] Error 2jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [src\kioslave\CMakeFiles\kioslave.dir\all] Error 2[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.obj[ 30%] Building CXX object src/ioslaves/remote/CMakeFiles/kio_remote.dir/remoteimpl.cpp.objkio_help.cpp[ 30%] Built target ktrash5[ 30%] Built target kio_http_cache_cleaner[ 30%] Building CXX object src/ioslaves/trash/CMakeFiles/kio_trash.dir/kiotrashdebug.cpp.obj[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.objremotedirnotifymodule.cppdebug.cpp[ 30%] Building CXX object src/kiod/CMakeFiles/kiod5.dir/kiod5_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 30%] Building CXX object src/ioslaves/remote/kdedmodule/CMakeFiles/remotedirnotify.dir/remotedirnotify_autogen/mocs_compilation.cpp.objremoteimpl.cpp[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.objmocs_compilation.cpp[ 30%] Building CXX object src/ioslaves/remote/CMakeFiles/kio_remote.dir/debug.cpp.obj[ 30%] Linking CXX executable ..\..\bin\kiod5.exe[ 30%] Built target KF5KIOWidgets_autogen[ 30%] Building CXX object src/ioslaves/trash/CMakeFiles/kio_trash.dir/kio_trash_autogen/mocs_compilation.cpp.objmocs_compilation.cppC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\help\kio_help.cpp(314): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.objkiotrashdebug.cpp[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.obj[ 30%] Linking CXX shared module ..\..\..\..\bin\remotenotifier.dllmain.cppxslt_help.cpp[ 30%] Building CXX object src/ioslaves/remote/CMakeFiles/kio_remote.dir/kio_remote_autogen/mocs_compilation.cpp.objdebug.cppmocs_compilation.cpp[ 30%] Built target kiod5[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\help\kio_help.cpp(314): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data[ 30%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.objmocs_compilation.cppmocs_compilation.cppmain_ghelp.cppxslt_help.cpp   Creating library ..\..\..\..\lib\remotenotifier.lib and object ..\..\..\..\lib\remotenotifier.exp[ 31%] Linking CXX shared module ..\..\..\bin\kf5\kio\remote.dllC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(283): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(285): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(286): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(156): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(287): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\trash\kio_trash_win.cpp(326): warning C4996: 'KIO::UDSEntry::insert': was declared deprecatedC:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.11/src/core/udsentry.h(148): note: see declaration of 'KIO::UDSEntry::insert'C:\CI\workspace\Frameworks\kio\kf5-qt5 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 457 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/457/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 08:59:58 +
 Build duration:
4 hr 0 min and counting

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:12e46aa19296: [server] Put text-input (de-)activate, 
en-/disable callbacks in child classes (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16676?vs=44878=44963#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16676?vs=44878=44963

REVISION DETAIL
  https://phabricator.kde.org/D16676

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks, davidedmundson, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Roman Gilg]

romangg marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

BRANCH
  textInputActivateEnable

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks, davidedmundson, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c3179f58e248: [server] Put set surrounding text callback 
with uint in v0 class (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16675?vs=44874=44962

REVISION DETAIL
  https://phabricator.kde.org/D16675

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  textInputActivateEnable

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Vlad Zagorodniy]

zzag accepted this revision.

REPOSITORY
  R127 KWayland

BRANCH
  textInputActivateEnable

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks, davidedmundson, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Harald Sitter]

sitter added a comment.


  https://mail.kde.org/pipermail/distributions/2018-October/000298.html

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

To: mpyne, #frameworks, sitter, dfaure, broulik
Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh, 
ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in textinput_interface_v0.cpp:92
> This seems to be different.

Shouldn't make a difference, but it's an unneeded change, so I'll revert to 
`surface` again.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

[David Edmundson]

davidedmundson added a comment.


  > Could the renaming be problematic in regards to binary compatibility
  
  It's fine here.
  
  As a general rule, if the class isn't defined in an installed header you can 
do whatever.

REPOSITORY
  R127 KWayland

BRANCH
  textInputSurroundingTextCallback

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> textinput_interface_v0.cpp:92
>  emit q_func()->enabledChanged();
> -emit q_func()->requestActivate(seat, surface);
>  }

This seems to be different.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  textInputSurroundingTextCallback

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

[Vlad Zagorodniy]

zzag added a comment.


  In D16675#354181 , @romangg wrote:
  
  > Could the renaming be problematic in regards to binary compatibility? All 
are private interfaces though.
  
  
  I don't think so. Otherwise PIMPL is pointless.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Albert Vaca Cintora]

albertvaka added a comment.


  Old apps that didn't have a QApplication are broken by this version of KIO. 
Definitely a regression to me :/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

To: mpyne, #frameworks, sitter, dfaure, broulik
Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh, 
ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Let's ship this, but I still think we should see if something can be done on 
the KIO side to not break old apps.

REPOSITORY
  R224 KDE Connect

BRANCH
  kde-neon

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Harald Sitter]

sitter added a comment.


  It was fixed in that it doesn't crash anymore. Due to crash handling now 
going through kcrash you still want to have a coreapp in every slave though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

To: mpyne, #frameworks, sitter, dfaure, broulik
Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh, 
ngraham, bruns

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> registry.h:180
>  ServerSideDecorationPalette, ///Refers to 
> org_kde_kwin_server_decoration_palette_manager @since 5.42
> -RemoteAccessManager, ///< Refers to 
> org_kde_kwin_remote_access_manager interface, @since 5.45
>  PlasmaVirtualDesktopManagement, ///< Refers to 
> org_kde_plasma_virtual_desktop_management interface @since 5.47

Is it correct one?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16701

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Erik Duisters]

eduisters updated this revision to Diff 44954.
eduisters added a comment.


  Implemented requested changes
  
  Removed commented out line from CMakeLists.txt
  Reverted to using entry.insert to support older KIO versions

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16692?vs=44929=44954

BRANCH
  kde-neon

REVISION DETAIL
  https://phabricator.kde.org/D16692

AFFECTED FILES
  kio/CMakeLists.txt
  kio/kdeconnect.json
  kio/kdeconnect.protocol
  kio/kiokdeconnect.cpp

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16701

AFFECTED FILES
  src/client/plasmavirtualdesktop.h
  src/client/registry.h
  src/server/display.h
  src/server/plasmavirtualdesktop_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 73 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/73/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 06 Nov 2018 08:59:58 +
 Build duration:
4 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 545.16 KB...][ 49%] Building CXX object autotests/CMakeFiles/ksambashareprivatetest.dir/__/src/core/kiocoredebug.cpp.obj[ 49%] Building CXX object autotests/CMakeFiles/kcoredirlister_benchmark.dir/kcoredirlister_benchmark_autogen/mocs_compilation.cpp.obj[ 49%] Building CXX object autotests/CMakeFiles/urlutiltest.dir/urlutiltest.cpp.objurlutiltest.cpp[ 49%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 49%] Linking CXX executable ..\bin\deletejobtest.exe[ 49%] Linking CXX executable ..\bin\kprotocolinfotest.exemocs_compilation.cppScanning dependencies of target httpauthenticationtestmocs_compilation.cpp[ 49%] Building CXX object autotests/http/CMakeFiles/httpauthenticationtest.dir/httpauthenticationtest.cpp.obj[ 49%] Building CXX object autotests/CMakeFiles/ksambashareprivatetest.dir/ksambashareprivatetest_autogen/mocs_compilation.cpp.objhttpauthenticationtest.cppksambashare.cppkiocoredebug.cppmocs_compilation.cpp[ 49%] Building CXX object autotests/CMakeFiles/urlutiltest.dir/urlutiltest_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(438): warning C4273: 'KSambaShare::KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(128): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(450): warning C4273: 'KSambaShare::~KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(107): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(460): warning C4273: 'KSambaShare::smbConfPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(118): note: see previous definition of 'smbConfPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(467): warning C4273: 'KSambaShare::isDirectoryShared': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(52): note: see previous definition of 'isDirectoryShared'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(473): warning C4273: 'KSambaShare::isShareNameAvailable': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(71): note: see previous definition of 'isShareNameAvailable'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(479): warning C4273: 'KSambaShare::shareNames': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(81): note: see previous definition of 'shareNames'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(485): warning C4273: 'KSambaShare::sharedDirectories': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(60): note: see previous definition of 'sharedDirectories'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(491): warning C4273: 'KSambaShare::getShareByName': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(93): note: see previous definition of 'getShareByName'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(497): warning C4273: 'KSambaShare::getSharesByPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(105): note: see previous definition of 'getSharesByPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(511): warning C4273: 'KSambaShare::instance': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(43): note: see previous definition of 'instance'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(73): warning C4273: 'KSambaShare::qt_static_metacall': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'qt_static_metacall'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(94): warning C4273: 'staticMetaObject': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'public: static QMetaObject const 

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto added a comment.


  Done, can land now

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto edited the summary of this revision.

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Erik Duisters]

eduisters marked 2 inline comments as done.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara