D16643: Correct the accept flag of the event object on DragMove

2018-11-06 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > DeclarativeDropArea.cpp:97 > if (event->pos() == m_oldDragMovePos) { > -event->setAccepted(false); > return; Change it to accept() and try it. REPOSITORY R296 KDeclarative REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-06 Thread Nathaniel Graham
ngraham added a comment. Uh-oh, now the patch doesn't apply for me anymore: $ arc patch D16249 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D16249. Checking patch src/core/job_error.cpp... error: while searching

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 252 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/252/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Nov 2018 01:48:24 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 178 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/178/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Nov 2018 01:48:24 + Build duration: 2 min 54 sec and counting JUnit Tests Name:

D16643: Correct the accept flag of the event object on DragMove

2018-11-06 Thread trmdi
trmdi added a comment. !Ping Reviewers Please review this. It's just a very simple patch. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: bruns, dkorth, ngraham, kde-frameworks-devel,

D15999: Add icons with added background to system.svgz

2018-11-06 Thread Nathaniel Graham
ngraham added a comment. I'm afraid that didn't change anything for me. If the experiment to make the background color adapt to the theme isn't working, maybe we should revert that change for now and just keep it hardcoded for now. REPOSITORY R242 Plasma Framework (Library) REVISION

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-11-06 Thread Nathaniel Graham
ngraham added a comment. Is this logic correct? Just because we found any entries, we don't use DNSSD? Is there ever a case where we found some entries but might find even more by using DNSSD? Also, I want to compliment your code. It's so nice and clean and well commented. INLINE

D16684: Updated with petroleum industry units

2018-11-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R292:b2419e57eeea: Updated with petroleum industry units (authored by joaonetto, committed by ngraham). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE

D16684: Updated with petroleum industry units

2018-11-06 Thread Nathaniel Graham
ngraham added a comment. Indeed it can. Great job! May it be the first of many. :-) REPOSITORY R292 KUnitConversion BRANCH master REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-06 Thread Stefan Brüns
bruns added a comment. Fixed ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

2018-11-06 Thread Stefan Brüns
bruns added a comment. AFAICS the only chance this can happen if the test is using a different library version, e.g. when accidentally using the lib from the system. This would be a test setup error and should be reported with a fail ... REPOSITORY R286 KFileMetaData REVISION DETAIL

D16716: skip writing test if mime type is not supported by the extractor

2018-11-06 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not crash if no suitable extractor is found. Skip the

D16671: Refactor embedded image extractor for greater extensibility

2018-11-06 Thread Alexander Stippich
astippich updated this revision to Diff 44982. astippich added a comment. - more cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=44868=44982 BRANCH refactor_embedded_image REVISION DETAIL https://phabricator.kde.org/D16671

D16643: Correct the accept flag of the event object on DragMove

2018-11-06 Thread Stefan Brüns
bruns added a comment. In D16643#354262 , @trmdi wrote: > In D16643#354120 , @bruns wrote: > > > `m_enabled` may change between //consecutive// DragMove events, but not during an event. > > > >

D16471: Listen for added DBus interfaces instead of registered services

2018-11-06 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R282:fa472e6a5e26: Listen for added DBus interfaces instead of registered services (authored by fvogt). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D16471: Listen for added DBus interfaces instead of registered services

2018-11-06 Thread Fabian Vogt
fvogt retitled this revision from "[RFC] Listen for added DBus interfaces instead of registered services" to "Listen for added DBus interfaces instead of registered services". fvogt edited the summary of this revision. REPOSITORY R282 NetworkManagerQt BRANCH ifadded REVISION DETAIL

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-06 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Seems to work, let's push this for now and we will see if there is no regression. REPOSITORY R282 NetworkManagerQt BRANCH ifadded REVISION DETAIL

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Wolfgang Bauer
wbauer added a comment. In D16692#355070 , @ngraham wrote: > The point is, there is no reason to reference distos (which are downstream from us) when we fix issues here. It does not matter that many or even most reports came from Neon. All

D16564: cleanup the test for embedded image extraction

2018-11-06 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH embedded_test REVISION DETAIL https://phabricator.kde.org/D16564 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-06 Thread David Edmundson
davidedmundson marked an inline comment as done. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16701 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-06 Thread Vlad Zagorodniy
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16701 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-06 Thread David Edmundson
davidedmundson updated this revision to Diff 44977. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16701?vs=44953=44977 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16701 AFFECTED FILES

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > romangg wrote in textinput_interface.cpp:67 > wlPurpose is also an abbreviation. ;) > > And in the header file it is named `purpose`. Makes more sense to me to have > the

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Nathaniel Graham
ngraham added a comment. The point is, there is no reason to reference distos (which are downstream from us) when we fix issues here. It does not matter that many or even most reports came from Neon. All rolling release distros have Frameworks 5.51, so it certainly was not just Neon users

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Albert Vaca Cintora
albertvaka added a comment. In D16692#355068 , @fvogt wrote: > In D16692#355067 , @albertvaka wrote: > > > In D16692#354990 , @fvogt wrote: > > > > >

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Fabian Vogt
fvogt added a comment. In D16692#355067 , @albertvaka wrote: > In D16692#354990 , @fvogt wrote: > > > I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Albert Vaca Cintora
albertvaka added a comment. In D16692#354990 , @fvogt wrote: > I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message. > > Is this workaround/fix only needed on neon or is the message wrong?

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Roman Gilg
romangg updated this revision to Diff 44970. romangg added a comment. - Rename variables, function REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16708?vs=44966=44970 BRANCH textInputEnums REVISION DETAIL https://phabricator.kde.org/D16708 AFFECTED

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > zzag wrote in textinput_interface.cpp:67 > purpose_? or just keep previous name (wlPurpose)? > > https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations wlPurpose is also an abbreviation. ;) And in the header file it is

D16709: [server] Support text input v0 default content hint

2018-11-06 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. Mistake by me. This is done already by bitwise comparison. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16709 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Roman Gilg
romangg added a dependent revision: D16709: [server] Support text input v0 default content hint. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16708 To: romangg, #kwin, #frameworks Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

2018-11-06 Thread Roman Gilg
romangg added a dependency: D16708: [server] Text input content hint and purpose per protocol version. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16709 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

2018-11-06 Thread Roman Gilg
romangg added reviewers: KWin, Frameworks. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16709 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16709: [server] Support text input v0 default content hint

2018-11-06 Thread Roman Gilg
romangg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY text-input v0 supports an additional enum value default, that combines auto completion, correction and

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > textinput_interface.cpp:67 > +const auto hints = p->convertContentHints(hint); > +const auto purp = p->convertContentPurpose(purpose); > +if (hints != p->contentHints || purp != p->contentPurpose) { purpose_? or just keep previous name

D16708: [server] Text input content hint and purpose per protocol version

2018-11-06 Thread Roman Gilg
romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Convert content hint and purpose according to used text-input protocol

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Fabian Vogt
fvogt added a comment. I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message. Is this workaround/fix only needed on neon or is the message wrong? REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/77/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 13:13:08 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 6

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Albert Vaca Cintora
This revision was automatically updated to reflect the committed changes. Closed by commit R224:560e8638e8dd: A QApplication object needs to be instantiated for kio-kdeconnect to work on… (authored by eduisters, committed by albertvaka). REPOSITORY R224 KDE Connect CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/76/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Nov 2018 12:49:50 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 3

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/103/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 13:09:16 + Build duration: 3 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

2018-11-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/102/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 12:49:50 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 458 - Successful!

2018-11-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/458/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 13:00:11 + Build duration: 5 min 41 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 74 - Still Failing!

2018-11-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/74/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 06 Nov 2018 12:58:50 + Build duration: 3 min 55 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 457 - Aborted!

2018-11-06 Thread CI System
BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/457/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Nov 2018 08:59:58 + Build duration: 4 hr 0 min and counting

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:12e46aa19296: [server] Put text-input (de-)activate, en-/disable callbacks in child classes (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16676?vs=44878=44963#toc

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread Roman Gilg
romangg marked 2 inline comments as done. REPOSITORY R127 KWayland BRANCH textInputActivateEnable REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin, #frameworks, davidedmundson, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-06 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:c3179f58e248: [server] Put set surrounding text callback with uint in v0 class (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH textInputActivateEnable REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin, #frameworks, davidedmundson Cc: zzag, kde-frameworks-devel, michaelh,

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread Vlad Zagorodniy
zzag accepted this revision. REPOSITORY R127 KWayland BRANCH textInputActivateEnable REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin, #frameworks, davidedmundson, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Harald Sitter
sitter added a comment. https://mail.kde.org/pipermail/distributions/2018-October/000298.html REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh,

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > zzag wrote in textinput_interface_v0.cpp:92 > This seems to be different. Shouldn't make a difference, but it's an unneeded change, so I'll revert to `surface` again. REPOSITORY R127 KWayland REVISION DETAIL

D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-06 Thread David Edmundson
davidedmundson added a comment. > Could the renaming be problematic in regards to binary compatibility It's fine here. As a general rule, if the class isn't defined in an installed header you can do whatever. REPOSITORY R127 KWayland BRANCH textInputSurroundingTextCallback

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

2018-11-06 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > textinput_interface_v0.cpp:92 > emit q_func()->enabledChanged(); > -emit q_func()->requestActivate(seat, surface); > } This seems to be different. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16676 To:

D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-06 Thread Vlad Zagorodniy
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH textInputSurroundingTextCallback REVISION DETAIL https://phabricator.kde.org/D16675 To: romangg, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-06 Thread Vlad Zagorodniy
zzag added a comment. In D16675#354181 , @romangg wrote: > Could the renaming be problematic in regards to binary compatibility? All are private interfaces though. I don't think so. Otherwise PIMPL is pointless. REPOSITORY R127

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Albert Vaca Cintora
albertvaka added a comment. Old apps that didn't have a QApplication are broken by this version of KIO. Definitely a regression to me :/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc: sredman, albertvaka,

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Albert Vaca Cintora
albertvaka accepted this revision. albertvaka added a comment. This revision is now accepted and ready to land. Let's ship this, but I still think we should see if something can be done on the KIO side to not break old apps. REPOSITORY R224 KDE Connect BRANCH kde-neon REVISION DETAIL

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Harald Sitter
sitter added a comment. It was fixed in that it doesn't crash anymore. Due to crash handling now going through kcrash you still want to have a coreapp in every slave though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure,

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-06 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > registry.h:180 > ServerSideDecorationPalette, ///Refers to > org_kde_kwin_server_decoration_palette_manager @since 5.42 > -RemoteAccessManager, ///< Refers to > org_kde_kwin_remote_access_manager interface, @since 5.45 >

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Erik Duisters
eduisters updated this revision to Diff 44954. eduisters added a comment. Implemented requested changes Removed commented out line from CMakeLists.txt Reverted to using entry.insert to support older KIO versions REPOSITORY R224 KDE Connect CHANGES SINCE LAST UPDATE

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-06 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 73 - Still Failing!

2018-11-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/73/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 06 Nov 2018 08:59:58 + Build duration: 4 min 25 sec and counting CONSOLE OUTPUT

D16684: Updated with petroleum industry units

2018-11-06 Thread Joao Oliveira
joaonetto added a comment. Done, can land now REPOSITORY R292 KUnitConversion BRANCH master REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-06 Thread Joao Oliveira
joaonetto edited the summary of this revision. REPOSITORY R292 KUnitConversion BRANCH master REVISION DETAIL https://phabricator.kde.org/D16684 To: joaonetto, ngraham, broulik, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-06 Thread Erik Duisters
eduisters marked 2 inline comments as done. REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks, albertvaka Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, skymoore, wistak,