D8912: Added a set of Game Folder icons

andreyorst updated this revision to Diff 45220. andreyorst added a comment. - made controll buttons 1.2px instead of 1px. Now 16 and 22 px icons will have slope somewhat between proposed variants. Looks crisp enough on my setup REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D16677: Add BrightScript syntax

dlevin added a comment. @ngraham, so I have to match commit authors in syntax-highlighting Git project against that list? Curious whether all those people have rights to push patches particularly into this project. Still it feels like this is not an easy task to do that manually, so I would

D8912: Added a set of Game Folder icons

andreyorst updated this revision to Diff 45219. andreyorst added a comment. fix links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8912?vs=45202=45219 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8912 AFFECTED FILES

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

kossebau added a subscriber: aacid. kossebau added a comment. @aacid Thanks for providing your ftp server, served its purpose. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

kossebau retitled this revision from "[ftp kio-slave] Fix deletion of directory with non-latin parent path" to "[ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path". kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/124/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 09 Nov 2018 22:26:37 + Build duration: 5 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/68/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 09 Nov 2018 22:26:37 + Build duration: 4 min 57 sec and counting JUnit Tests Name: (root)

D16772: Add new icons for root

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e2270613fc25: Add new icons for root (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16772?vs=45209=45213 REVISION

D16772: Add new icons for root

ngraham added a comment. Other VDG folks in chat seem happy as well. Landing it! Nice work. REPOSITORY R266 Breeze Icons BRANCH folder-root (branched from master) REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg, ngraham Cc: ngraham, #vdg,

D16772: Add new icons for root

ngraham added a comment. Usually the time is right when someone recommends that you do so! :-) REPOSITORY R266 Breeze Icons BRANCH folder-root (branched from master) REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg, ngraham Cc: ngraham, #vdg, kde-frameworks-devel,

D16772: Add new icons for root

ndavis added a comment. In D16772#357086 , @ngraham wrote: > Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the

D16772: Add new icons for root

ndavis updated this revision to Diff 45208. ndavis added a comment. Update commit message to more accurately describe the changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16772?vs=45196=45208 BRANCH folder-root (branched from master)

D16677: Add BrightScript syntax

ngraham added a comment. In D16677#356620 , @dhaumann wrote: > Unless you have a KDE commit account you can not commit yourself. Unfortunately we cannot see on Phabricator whether you have one or not. BTW, you can check to see whether

D8912: Added a set of Game Folder icons

ndavis added a comment. In D8912#357074 , @ngraham wrote: > In D8912#357052 , @ndavis wrote: > > > F6403963: Screenshot_20181109_154449.png > > > > Ah,

D8912: Added a set of Game Folder icons

ndavis added a comment. In D8912#357072 , @bruns wrote: > Try making the buttons somewhat larger. A 1px circle ends up as light gray square. Think that's perfectly fine. If they were larger, they would completely dominate the icon and

D8912: Added a set of Game Folder icons

ngraham added a comment. In D8912#357052 , @ndavis wrote: > F6403963: Screenshot_20181109_154449.png > > Ah, that's much better. The buttons and D-pad are much easier to see. Try making the sides

D8912: Added a set of Game Folder icons

bruns added a comment. Try making the buttons somewhat larger. A 1px circle ends up as light gray square. INLINE COMMENTS > folder-games.svg:93 > + transform="translate(0,-292.76667)"> > + + width="0" Remove all these leftover rects .. REPOSITORY R266 Breeze Icons

D8912: Added a set of Game Folder icons

bruns added inline comments. INLINE COMMENTS > folder-games.svg:73 > + inkscape:cy="10.469244" > + inkscape:document-units="mm" > + inkscape:current-layer="layer1-3-5" switch the document units to px, the values are shorter then. > folder-games.svg:1 >

D8912: Added a set of Game Folder icons

ndavis added a comment. F6403963: Screenshot_20181109_154449.png Ah, that's much better. The buttons and D-pad are much easier to see. Try making the sides straight since the angle is pretty small for that size already. Kind of like this:

D8912: Added a set of Game Folder icons

andreyorst updated this revision to Diff 45202. andreyorst added a comment. Changed icons so they look crisp REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8912?vs=22644=45202 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8912

D16788: fixed game folder icons to be crisp on 1px grid

andreyorst created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. andreyorst requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D16788 AFFECTED FILES

D16677: Add BrightScript syntax

cullmann added a comment. The merge should show up here and you should get a notification mail like for any other action. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: dhaumann, cullmann,

D16677: Add BrightScript syntax

dlevin added a comment. Thanks a lot for helping me with this! One last question: how do I know that patch was finally merged, by periodically checking the github mirror git repository? https://github.com/KDE/syntax-highlighting.git REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D16772: Add new icons for root

ndavis updated this revision to Diff 45196. ndavis added a comment. Change style to `/_`. The reason for this is that `/` by itself looks kind of empty and it's easy to confuse the meaning with disabled or inactive, especially for drive-harddisk-root. REPOSITORY R266 Breeze Icons CHANGES

D16772: Add new icons for root

ndavis retitled this revision from "Add folder-root icon" to "Add new icons for root". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg,

D8912: Added a set of Game Folder icons

andreyorst added a comment. Understood. Yeh, now I see it. I have very poor eyesight, I'll fixt it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns

D16677: Add BrightScript syntax

cullmann added a comment. I can push that for you, just need to fixup my local dev setup again ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: dhaumann, cullmann, kwrite-devel,

D16677: Add BrightScript syntax

dlevin added a comment. I do not have a KDE commit account, so I guess I need your help to integrate this patch. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: dhaumann, cullmann,

D16772: Add folder-root icon

ndavis added a comment. Alternative style. If I choose this style, I will also change the style of `drive-harddisk-root`. F6403388: Screenshot_20181109_102458.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772

D8912: Added a set of Game Folder icons

ndavis added a comment. In D8912#356590 , @andreyorst wrote: > > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. > > Yeah, I'm here! I'd like to make desired changes myself. > > >

D16665: Add programmaticaly useful error signalling

leinir added a dependent revision: D16776: Better error handling in KNewStuff backend. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D15464: [server] Touch drag support

romangg updated this revision to Diff 45164. romangg added a comment. - No touch motion on drag - Add touch dnd autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15464?vs=41923=45164 BRANCH touchDrag REVISION DETAIL