D17085: Fix language load after including keywords from this language in another file

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17085 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars,

D17092: Add syntax highlighting for TypeScript & TypeScript React

nibags updated this revision to Diff 46105. nibags added a comment. - typescript.xml & typescript-react.xml: add some comments and the operator "!" after objects https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#non-null-assertion-operator REPOSITORY R216 Syntax

D17093: Rust & Yacc/Bison: improve comments

nibags updated this revision to Diff 46104. nibags added a comment. - rust.xml: fix indentation. The file uses tabs, but in one part I used spaces as indentation REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17093?vs=45993=46104 BRANCH

D16919: Re-add DBus test

hindenburg added a comment. In D16919#364934 , @bcooksley wrote: > Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. > Did you run "make tests" / "ctest" or did you use the run-tests.py

D17128: DocumentPrivate: Remove comment mark when joining lines

loh.tar added a comment. This works so far in most cases I have tried. - C/C++, // and /* */ works, but sadly not Oxygen style comments. Guess the single star is not as special marked. Could that be fixed in the highlight stuff? - Bash, # works - Ruby, # works - Python, # works

D17128: DocumentPrivate: Remove comment mark when joining lines

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...from the next line

D16919: Re-add DBus test

bcooksley added a comment. Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests? REPOSITORY R319 Konsole REVISION DETAIL

D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range"

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good, thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17123 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range"

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. loh.tar added a project: Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when cut or copy a line without

T10112: KDEInstallDirs on Mac

rjvbb created this task. rjvbb added a project: Build System. TASK DESCRIPTION (I hope this is the better place to discuss something that should be done than a WIP diff review...) There is a discrepancy under the Mac's OS (and unpatched Qt) between the install locations expected in the

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14000 To: rjvbb, #frameworks, mart Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel,

D16919: Re-add DBus test

hindenburg added a comment. In D16919#364587 , @bcooksley wrote: > When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? I used the script in

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt created this revision. fvogt added reviewers: KWin, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY If there is no socketName specified explicitly, it will use

T10112: KDEInstallDirs on Mac

rjvbb added a comment. > Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled? Sadly not without patching any code, apparently. We'll also need something like this I think: _define_relative(DATADIR DATAROOTDIR "" "read-only

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:79 > What about this comment? Well, it isn't actually required and it compiles just fine with both canberra and phonon missing. REPOSITORY R289 KNotifications REVISION DETAIL

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > DESCRIPTION "Qt-based audio library" > -# This is REQUIRED since you cannot tell CMake "either one of those > two optional ones are required" > -TYPE REQUIRED What about this comment?